ICODE-ADC/lammps
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

formatting tweak for labels, add checking item for added pair styles

Browse Source
This commit is contained in:
Axel Kohlmeyer
2018-11-24 16:47:18 -05:00
parent b76c7ddc84
commit 5af7f52370
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
doc/github-development-workflow.md
View File

@ -55,11 +55,11 @@ required changes or ask the submitter of the pull request to implement
them. Even though, all LAMMPS developers may have write access to pull them. Even though, all LAMMPS developers may have write access to pull
requests (if enabled by the submitter, which is the default), only the requests (if enabled by the submitter, which is the default), only the
submitter or the assignee of a pull request may do so. During this submitter or the assignee of a pull request may do so. During this
period the "work_in_progress" label shall be applied to the pull period the `work_in_progress` label shall be applied to the pull
request. The assignee gets to decide what happens to the pull request request. The assignee gets to decide what happens to the pull request
next, e.g. whether it should be assigned to a different developer for next, e.g. whether it should be assigned to a different developer for
additional checks and changes, or is recommended to be merged. Removing additional checks and changes, or is recommended to be merged. Removing
the "work_in_progress" label and assigning the pull request to the the `work_in_progress` label and assigning the pull request to the
developer tasked with merging signals that a pull request is ready to be developer tasked with merging signals that a pull request is ready to be
merged. merged.
@ -145,6 +145,9 @@ Here are some items to check:
compiling LAMMPS with `-DLAMMPS_BIGBIG`. compiling LAMMPS with `-DLAMMPS_BIGBIG`.
* when including both `lmptype.h` (and using defines or macros from it) * when including both `lmptype.h` (and using defines or macros from it)
and `mpi.h`, `lmptype.h` must be included first. and `mpi.h`, `lmptype.h` must be included first.
* when pair styles are added, check if settings for flags like
`single_enable`, `writedata`, `reinitflag`, `manybody_flag`
and others are correctly set and supported.
## GitHub Issues ## GitHub Issues