From 6f08e81bf81327f2f46cf8b70b88cc51fecbc89c Mon Sep 17 00:00:00 2001 From: Axel Kohlmeyer Date: Mon, 8 Feb 2021 20:19:22 -0500 Subject: [PATCH] don't access uninitialized data and avoid shadowing a class member variable --- src/KOKKOS/fix_langevin_kokkos.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/KOKKOS/fix_langevin_kokkos.cpp b/src/KOKKOS/fix_langevin_kokkos.cpp index 0dcaabb39c..054302b9c5 100644 --- a/src/KOKKOS/fix_langevin_kokkos.cpp +++ b/src/KOKKOS/fix_langevin_kokkos.cpp @@ -765,11 +765,11 @@ template KOKKOS_INLINE_FUNCTION double FixLangevinKokkos::compute_energy_item(int i) const { - double energy; + double my_energy = 0.0; if (mask[i] & groupbit) - energy = d_flangevin(i,0)*v(i,0) + d_flangevin(i,1)*v(i,1) + + my_energy = d_flangevin(i,0)*v(i,0) + d_flangevin(i,1)*v(i,1) + d_flangevin(i,2)*v(i,2); - return energy; + return my_energy; } /* ----------------------------------------------------------------------