diff --git a/src/modify.cpp b/src/modify.cpp index aac08bb31e..90399abec4 100644 --- a/src/modify.cpp +++ b/src/modify.cpp @@ -797,7 +797,7 @@ int Modify::min_reset_ref() Fix *Modify::add_fix(int narg, char **arg, int trysuffix) { - if (narg < 3) error->all(FLERR, "Illegal fix command"); + if (narg < 3) utils::missing_cmd_args(FLERR, "fix", error); // cannot define fix before box exists unless style is in exception list // don't like this way of checking for exceptions by adding fixes to list, @@ -988,7 +988,7 @@ Fix *Modify::replace_fix(const char *replaceID, int narg, char **arg, int trysuf // change ID, igroup, style of fix being replaced to match new fix // requires some error checking on arguments for new fix - if (narg < 3) error->all(FLERR, "Illegal replace_fix invocation"); + if (narg < 3) error->all(FLERR, "Not enough arguments for replace_fix invocation"); if (get_fix_by_id(arg[0])) error->all(FLERR, "Replace_fix ID {} is already in use", arg[0]); delete[] oldfix->id; @@ -1026,16 +1026,11 @@ Fix *Modify::replace_fix(const std::string &oldfix, const std::string &fixcmd, i void Modify::modify_fix(int narg, char **arg) { - if (narg < 2) error->all(FLERR, "Illegal fix_modify command"); + if (narg < 2) utils::missing_cmd_args(FLERR, "fix_modify", error); - // lookup Fix ID - - int ifix; - for (ifix = 0; ifix < nfix; ifix++) - if (strcmp(arg[0], fix[ifix]->id) == 0) break; - if (ifix == nfix) error->all(FLERR, "Could not find fix_modify ID {}", arg[0]); - - fix[ifix]->modify_params(narg - 1, &arg[1]); + auto ifix = get_fix_by_id(arg[0]); + if (!ifix) error->all(FLERR, "Could not find fix_modify ID {}", arg[0]); + ifix->modify_params(narg - 1, &arg[1]); } /* ---------------------------------------------------------------------- @@ -1226,13 +1221,11 @@ int Modify::check_rigid_list_overlap(int *select) Compute *Modify::add_compute(int narg, char **arg, int trysuffix) { - if (narg < 3) error->all(FLERR, "Illegal compute command"); + if (narg < 3) utils::missing_cmd_args(FLERR, "compute", error); // error check - for (int icompute = 0; icompute < ncompute; icompute++) - if (strcmp(arg[0], compute[icompute]->id) == 0) - error->all(FLERR, "Reuse of compute ID '{}'", arg[0]); + if (get_compute_by_id(arg[0])) error->all(FLERR, "Reuse of compute ID '{}'", arg[0]); // extend Compute list if necessary @@ -1299,16 +1292,13 @@ Compute *Modify::add_compute(const std::string &computecmd, int trysuffix) void Modify::modify_compute(int narg, char **arg) { - if (narg < 2) error->all(FLERR, "Illegal compute_modify command"); + if (narg < 2) utils::missing_cmd_args(FLERR, "compute_modify",error); // lookup Compute ID - int icompute; - for (icompute = 0; icompute < ncompute; icompute++) - if (strcmp(arg[0], compute[icompute]->id) == 0) break; - if (icompute == ncompute) error->all(FLERR, "Could not find compute_modify ID {}", arg[0]); - - compute[icompute]->modify_params(narg - 1, &arg[1]); + auto icompute = get_compute_by_id(arg[0]); + if (!icompute) error->all(FLERR, "Could not find compute_modify ID {}", arg[0]); + icompute->modify_params(narg - 1, &arg[1]); } /* ----------------------------------------------------------------------