diff --git a/src/GPU/pair_eam_alloy_gpu.cpp b/src/GPU/pair_eam_alloy_gpu.cpp index 3a8e440bdc..11af562f15 100644 --- a/src/GPU/pair_eam_alloy_gpu.cpp +++ b/src/GPU/pair_eam_alloy_gpu.cpp @@ -364,7 +364,7 @@ void PairEAMAlloyGPU::read_file(char *filename) fptr = fopen(filename,"r"); if (fptr == NULL) { char str[128]; - sprintf(str,"Cannot open EAM potential file %s",filename); + snprintf(str,128,"Cannot open EAM potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/GPU/pair_eam_fs_gpu.cpp b/src/GPU/pair_eam_fs_gpu.cpp index 51681d563b..ef8dd09e23 100644 --- a/src/GPU/pair_eam_fs_gpu.cpp +++ b/src/GPU/pair_eam_fs_gpu.cpp @@ -364,7 +364,7 @@ void PairEAMFSGPU::read_file(char *filename) fptr = force->open_potential(filename); if (fptr == NULL) { char str[128]; - sprintf(str,"Cannot open EAM potential file %s",filename); + snprintf(str,128,"Cannot open EAM potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/GRANULAR/fix_wall_gran_region.cpp b/src/GRANULAR/fix_wall_gran_region.cpp index 4a6be5f3c9..8633587ad5 100644 --- a/src/GRANULAR/fix_wall_gran_region.cpp +++ b/src/GRANULAR/fix_wall_gran_region.cpp @@ -113,16 +113,16 @@ void FixWallGranRegion::init() strcmp(region_style,region->style) != 0 || nregion != region->nregion) { char str[256]; - sprintf(str,"Region properties for region %s changed between runs, " - "resetting its motion",idregion); + snprintf(str,256,"Region properties for region %s changed between runs, " + "resetting its motion",idregion); error->warning(FLERR,str); region->reset_vel(); } if (motion_resetflag){ char str[256]; - sprintf(str,"Region properties for region %s are inconsistent " - "with restart file, resetting its motion",idregion); + snprintf(str,256,"Region properties for region %s are inconsistent " + "with restart file, resetting its motion",idregion); error->warning(FLERR,str); region->reset_vel(); } diff --git a/src/KOKKOS/pair_eam_alloy_kokkos.cpp b/src/KOKKOS/pair_eam_alloy_kokkos.cpp index fc19da1c8a..49e1313c26 100644 --- a/src/KOKKOS/pair_eam_alloy_kokkos.cpp +++ b/src/KOKKOS/pair_eam_alloy_kokkos.cpp @@ -992,7 +992,7 @@ void PairEAMAlloyKokkos::read_file(char *filename) fptr = force->open_potential(filename); if (fptr == NULL) { char str[128]; - sprintf(str,"Cannot open EAM potential file %s",filename); + snprintf(str,128,"Cannot open EAM potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/KOKKOS/pair_eam_fs_kokkos.cpp b/src/KOKKOS/pair_eam_fs_kokkos.cpp index 8f5571bf29..ee0a799826 100644 --- a/src/KOKKOS/pair_eam_fs_kokkos.cpp +++ b/src/KOKKOS/pair_eam_fs_kokkos.cpp @@ -992,7 +992,7 @@ void PairEAMFSKokkos::read_file(char *filename) fptr = force->open_potential(filename); if (fptr == NULL) { char str[128]; - sprintf(str,"Cannot open EAM potential file %s",filename); + snprintf(str,128,"Cannot open EAM potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/KOKKOS/pair_exp6_rx_kokkos.cpp b/src/KOKKOS/pair_exp6_rx_kokkos.cpp index 810173d219..f38feea5f4 100644 --- a/src/KOKKOS/pair_exp6_rx_kokkos.cpp +++ b/src/KOKKOS/pair_exp6_rx_kokkos.cpp @@ -1725,7 +1725,7 @@ void PairExp6rxKokkos::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open exp6/rx potential file %s",file); + snprintf(str,128,"Cannot open exp6/rx potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MANYBODY/fix_qeq_comb.cpp b/src/MANYBODY/fix_qeq_comb.cpp index e46da9bfe7..7146ee9d65 100644 --- a/src/MANYBODY/fix_qeq_comb.cpp +++ b/src/MANYBODY/fix_qeq_comb.cpp @@ -67,7 +67,7 @@ FixQEQComb::FixQEQComb(LAMMPS *lmp, int narg, char **arg) : Fix(lmp, narg, arg), fp = fopen(arg[iarg+1],"w"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix qeq/comb file %s",arg[iarg+1]); + snprintf(str,128,"Cannot open fix qeq/comb file %s",arg[iarg+1]); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_adp.cpp b/src/MANYBODY/pair_adp.cpp index 831f1d0efa..7b48522e84 100644 --- a/src/MANYBODY/pair_adp.cpp +++ b/src/MANYBODY/pair_adp.cpp @@ -551,7 +551,7 @@ void PairADP::read_file(char *filename) fp = force->open_potential(filename); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open ADP potential file %s",filename); + snprintf(str,128,"Cannot open ADP potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_airebo.cpp b/src/MANYBODY/pair_airebo.cpp index ac3ed36a83..067eb1634f 100644 --- a/src/MANYBODY/pair_airebo.cpp +++ b/src/MANYBODY/pair_airebo.cpp @@ -3373,9 +3373,9 @@ void PairAIREBO::read_file(char *filename) if (fp == NULL) { char str[128]; if (morseflag) - sprintf(str,"Cannot open AIREBO-M potential file %s",filename); + snprintf(str,128,"Cannot open AIREBO-M potential file %s",filename); else - sprintf(str,"Cannot open AIREBO potential file %s",filename); + snprintf(str,128,"Cannot open AIREBO potential file %s",filename); error->one(FLERR,str); } diff --git a/src/MANYBODY/pair_bop.cpp b/src/MANYBODY/pair_bop.cpp index 87a23dff99..ca0f229068 100644 --- a/src/MANYBODY/pair_bop.cpp +++ b/src/MANYBODY/pair_bop.cpp @@ -4976,7 +4976,7 @@ void PairBOP::read_table(char *filename) FILE *fp = force->open_potential(filename); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open BOP potential file %s",filename); + snprintf(str,128,"Cannot open BOP potential file %s",filename); error->one(FLERR,str); } fgets(s,MAXLINE,fp); // skip first comment line @@ -5079,7 +5079,7 @@ void PairBOP::read_table(char *filename) FILE *fp = force->open_potential(filename); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open BOP potential file %s",filename); + snprintf(str,128,"Cannot open BOP potential file %s",filename); error->one(FLERR,str); } fgets(s,MAXLINE,fp); // skip first comment line diff --git a/src/MANYBODY/pair_comb.cpp b/src/MANYBODY/pair_comb.cpp index e7b0d27b6e..85ea4812bf 100644 --- a/src/MANYBODY/pair_comb.cpp +++ b/src/MANYBODY/pair_comb.cpp @@ -597,7 +597,7 @@ void PairComb::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open COMB potential file %s",file); + snprintf(str,128,"Cannot open COMB potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_comb3.cpp b/src/MANYBODY/pair_comb3.cpp index 72360be5f0..106b83eeba 100644 --- a/src/MANYBODY/pair_comb3.cpp +++ b/src/MANYBODY/pair_comb3.cpp @@ -320,11 +320,7 @@ void PairComb3::read_lib() if (comm->me == 0) { FILE *fp = force->open_potential("lib.comb3"); - if (fp == NULL) { - char str[128]; - sprintf(str,"Cannot open COMB3 lib.comb3 file"); - error->one(FLERR,str); - } + if (fp == NULL) error->one(FLERR,"Cannot open COMB3 lib.comb3 file"); // read and store at the same time fgets(s,MAXLIB,fp); @@ -607,7 +603,7 @@ void PairComb3::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open COMB3 potential file %s",file); + snprintf(str,128,"Cannot open COMB3 potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_eam.cpp b/src/MANYBODY/pair_eam.cpp index 87bcebb111..f4b4901075 100644 --- a/src/MANYBODY/pair_eam.cpp +++ b/src/MANYBODY/pair_eam.cpp @@ -460,7 +460,7 @@ void PairEAM::read_file(char *filename) fptr = force->open_potential(filename); if (fptr == NULL) { char str[128]; - sprintf(str,"Cannot open EAM potential file %s",filename); + snprintf(str,128,"Cannot open EAM potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_eam_alloy.cpp b/src/MANYBODY/pair_eam_alloy.cpp index eed38f79e9..c004030240 100644 --- a/src/MANYBODY/pair_eam_alloy.cpp +++ b/src/MANYBODY/pair_eam_alloy.cpp @@ -127,7 +127,7 @@ void PairEAMAlloy::read_file(char *filename) fptr = force->open_potential(filename); if (fptr == NULL) { char str[128]; - sprintf(str,"Cannot open EAM potential file %s",filename); + snprintf(str,128,"Cannot open EAM potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_eam_cd.cpp b/src/MANYBODY/pair_eam_cd.cpp index 5b8b241b45..8db1b6dd9a 100644 --- a/src/MANYBODY/pair_eam_cd.cpp +++ b/src/MANYBODY/pair_eam_cd.cpp @@ -504,7 +504,7 @@ void PairEAMCD::read_h_coeff(char *filename) fptr = force->open_potential(filename); if (fptr == NULL) { char str[128]; - sprintf(str,"Cannot open EAM potential file %s", filename); + snprintf(str,128,"Cannot open EAM potential file %s", filename); error->one(FLERR,str); } diff --git a/src/MANYBODY/pair_eam_fs.cpp b/src/MANYBODY/pair_eam_fs.cpp index 2b5d530d3a..bbda84fdf1 100644 --- a/src/MANYBODY/pair_eam_fs.cpp +++ b/src/MANYBODY/pair_eam_fs.cpp @@ -127,7 +127,7 @@ void PairEAMFS::read_file(char *filename) fptr = force->open_potential(filename); if (fptr == NULL) { char str[128]; - sprintf(str,"Cannot open EAM potential file %s",filename); + snprintf(str,128,"Cannot open EAM potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_eim.cpp b/src/MANYBODY/pair_eim.cpp index 6703e159e6..b0fa1b1eef 100644 --- a/src/MANYBODY/pair_eim.cpp +++ b/src/MANYBODY/pair_eim.cpp @@ -461,7 +461,7 @@ void PairEIM::read_file(char *filename) fptr = force->open_potential(filename); if (fptr == NULL) { char str[128]; - sprintf(str,"Cannot open EIM potential file %s",filename); + snprintf(str,128,"Cannot open EIM potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_gw.cpp b/src/MANYBODY/pair_gw.cpp index 0aff4970bb..f2d3b67eb0 100644 --- a/src/MANYBODY/pair_gw.cpp +++ b/src/MANYBODY/pair_gw.cpp @@ -381,7 +381,7 @@ void PairGW::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open GW potential file %s",file); + snprintf(str,128,"Cannot open GW potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_gw_zbl.cpp b/src/MANYBODY/pair_gw_zbl.cpp index 81d4866e84..f3dd1bc04b 100644 --- a/src/MANYBODY/pair_gw_zbl.cpp +++ b/src/MANYBODY/pair_gw_zbl.cpp @@ -77,7 +77,7 @@ void PairGWZBL::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open GW potential file %s",file); + snprintf(str,128,"Cannot open GW potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_lcbop.cpp b/src/MANYBODY/pair_lcbop.cpp index 57373c4f85..88477e48f3 100644 --- a/src/MANYBODY/pair_lcbop.cpp +++ b/src/MANYBODY/pair_lcbop.cpp @@ -978,7 +978,7 @@ void PairLCBOP::read_file(char *filename) FILE *fp = force->open_potential(filename); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open LCBOP potential file %s",filename); + snprintf(str,128,"Cannot open LCBOP potential file %s",filename); error->one(FLERR,str); } diff --git a/src/MANYBODY/pair_nb3b_harmonic.cpp b/src/MANYBODY/pair_nb3b_harmonic.cpp index 01718d14cd..ce449e4890 100644 --- a/src/MANYBODY/pair_nb3b_harmonic.cpp +++ b/src/MANYBODY/pair_nb3b_harmonic.cpp @@ -299,7 +299,7 @@ void PairNb3bHarmonic::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open nb3b/harmonic potential file %s",file); + snprintf(str,128,"Cannot open nb3b/harmonic potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_polymorphic.cpp b/src/MANYBODY/pair_polymorphic.cpp index ce9af66d30..41c5892d4e 100644 --- a/src/MANYBODY/pair_polymorphic.cpp +++ b/src/MANYBODY/pair_polymorphic.cpp @@ -573,7 +573,7 @@ void PairPolymorphic::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open polymorphic potential file %s",file); + snprintf(str,128,"Cannot open polymorphic potential file %s",file); error->one(FLERR,str); } // move past comments to first data line diff --git a/src/MANYBODY/pair_sw.cpp b/src/MANYBODY/pair_sw.cpp index da470d568a..91e11b3d26 100644 --- a/src/MANYBODY/pair_sw.cpp +++ b/src/MANYBODY/pair_sw.cpp @@ -363,7 +363,7 @@ void PairSW::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open Stillinger-Weber potential file %s",file); + snprintf(str,128,"Cannot open Stillinger-Weber potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_tersoff.cpp b/src/MANYBODY/pair_tersoff.cpp index 45068e5c2e..54101aef9e 100644 --- a/src/MANYBODY/pair_tersoff.cpp +++ b/src/MANYBODY/pair_tersoff.cpp @@ -404,7 +404,7 @@ void PairTersoff::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open Tersoff potential file %s",file); + snprintf(str,128,"Cannot open Tersoff potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_tersoff_mod.cpp b/src/MANYBODY/pair_tersoff_mod.cpp index 73297fb534..e8fdecfe01 100644 --- a/src/MANYBODY/pair_tersoff_mod.cpp +++ b/src/MANYBODY/pair_tersoff_mod.cpp @@ -60,7 +60,7 @@ void PairTersoffMOD::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open Tersoff potential file %s",file); + snprintf(str,128,"Cannot open Tersoff potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_tersoff_mod_c.cpp b/src/MANYBODY/pair_tersoff_mod_c.cpp index 0d0016664a..4a5904c106 100644 --- a/src/MANYBODY/pair_tersoff_mod_c.cpp +++ b/src/MANYBODY/pair_tersoff_mod_c.cpp @@ -55,7 +55,7 @@ void PairTersoffMODC::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open Tersoff potential file %s",file); + snprintf(str,128,"Cannot open Tersoff potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_tersoff_zbl.cpp b/src/MANYBODY/pair_tersoff_zbl.cpp index 1692c88a50..353e3d2264 100644 --- a/src/MANYBODY/pair_tersoff_zbl.cpp +++ b/src/MANYBODY/pair_tersoff_zbl.cpp @@ -77,7 +77,7 @@ void PairTersoffZBL::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open Tersoff potential file %s",file); + snprintf(str,128,"Cannot open Tersoff potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MANYBODY/pair_vashishta.cpp b/src/MANYBODY/pair_vashishta.cpp index 54b184ea39..b4c3086ca8 100644 --- a/src/MANYBODY/pair_vashishta.cpp +++ b/src/MANYBODY/pair_vashishta.cpp @@ -369,7 +369,7 @@ void PairVashishta::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open Vashishta potential file %s",file); + snprintf(str,128,"Cannot open Vashishta potential file %s",file); error->one(FLERR,str); } } diff --git a/src/MEAM/pair_meam.cpp b/src/MEAM/pair_meam.cpp index 5aa13ab02e..b8f5291338 100644 --- a/src/MEAM/pair_meam.cpp +++ b/src/MEAM/pair_meam.cpp @@ -464,7 +464,7 @@ void PairMEAM::read_files(char *globalfile, char *userfile) fp = force->open_potential(globalfile); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open MEAM potential file %s",globalfile); + snprintf(str,128,"Cannot open MEAM potential file %s",globalfile); error->one(FLERR,str); } } @@ -645,7 +645,7 @@ void PairMEAM::read_files(char *globalfile, char *userfile) fp = force->open_potential(userfile); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open MEAM potential file %s",userfile); + snprintf(str,128,"Cannot open MEAM potential file %s",userfile); error->one(FLERR,str); } } @@ -694,8 +694,8 @@ void PairMEAM::read_files(char *globalfile, char *userfile) if (strcmp(params[0],keywords[which]) == 0) break; if (which == nkeywords) { char str[128]; - sprintf(str,"Keyword %s in MEAM parameter file not recognized", - params[0]); + snprintf(str,128,"Keyword %s in MEAM parameter file not recognized", + params[0]); error->all(FLERR,str); } nindex = nparams - 2; diff --git a/src/MISC/fix_ttm.cpp b/src/MISC/fix_ttm.cpp index c8f33c73b7..4e15581377 100644 --- a/src/MISC/fix_ttm.cpp +++ b/src/MISC/fix_ttm.cpp @@ -71,7 +71,7 @@ FixTTM::FixTTM(LAMMPS *lmp, int narg, char **arg) : fpr = fopen(arg[13],"r"); if (fpr == NULL) { char str[128]; - sprintf(str,"Cannot open file %s",arg[13]); + snprintf(str,128,"Cannot open file %s",arg[13]); error->one(FLERR,str); } @@ -84,7 +84,7 @@ FixTTM::FixTTM(LAMMPS *lmp, int narg, char **arg) : fp = fopen(arg[15],"w"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix ttm file %s",arg[15]); + snprintf(str,128,"Cannot open fix ttm file %s",arg[15]); error->one(FLERR,str); } } diff --git a/src/MOLECULE/angle_table.cpp b/src/MOLECULE/angle_table.cpp index 235e9b4d5b..2867865497 100644 --- a/src/MOLECULE/angle_table.cpp +++ b/src/MOLECULE/angle_table.cpp @@ -369,7 +369,7 @@ void AngleTable::read_table(Table *tb, char *file, char *keyword) FILE *fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open file %s",file); + snprintf(str,128,"Cannot open file %s",file); error->one(FLERR,str); } diff --git a/src/MOLECULE/bond_table.cpp b/src/MOLECULE/bond_table.cpp index a5c579042b..392904149d 100644 --- a/src/MOLECULE/bond_table.cpp +++ b/src/MOLECULE/bond_table.cpp @@ -298,7 +298,7 @@ void BondTable::read_table(Table *tb, char *file, char *keyword) FILE *fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open file %s",file); + snprintf(str,128,"Cannot open file %s",file); error->one(FLERR,str); } diff --git a/src/MOLECULE/fix_cmap.cpp b/src/MOLECULE/fix_cmap.cpp index b527eef020..a889a8d0db 100644 --- a/src/MOLECULE/fix_cmap.cpp +++ b/src/MOLECULE/fix_cmap.cpp @@ -644,7 +644,7 @@ void FixCMAP::read_grid_map(char *cmapfile) fp = force->open_potential(cmapfile); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix cmap file %s",cmapfile); + snprintf(str,128,"Cannot open fix cmap file %s",cmapfile); error->one(FLERR,str); } } @@ -1076,7 +1076,7 @@ void FixCMAP::read_data_section(char *keyword, int n, char *buf, if (nwords != 7) { char str[128]; - sprintf(str,"Incorrect %s format in data file",keyword); + snprintf(str,128,"Incorrect %s format in data file",keyword); error->all(FLERR,str); } diff --git a/src/POEMS/fix_poems.cpp b/src/POEMS/fix_poems.cpp index 2c2fefb250..f345d52aab 100644 --- a/src/POEMS/fix_poems.cpp +++ b/src/POEMS/fix_poems.cpp @@ -369,7 +369,7 @@ void FixPOEMS::init() if (pflag && (modify->fmask[i] & POST_FORCE) && !modify->fix[i]->rigid_flag) { char str[128]; - sprintf(str,"Fix %s alters forces after fix poems",modify->fix[i]->id); + snprintf(str,128,"Fix %s alters forces after fix poems",modify->fix[i]->id); error->warning(FLERR,str); } } @@ -961,7 +961,7 @@ void FixPOEMS::readfile(char *file) fp = fopen(file,"r"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix poems file %s",file); + snprintf(str,128,"Cannot open fix poems file %s",file); error->one(FLERR,str); } } diff --git a/src/QEQ/fix_qeq.cpp b/src/QEQ/fix_qeq.cpp index 0fe041209f..49e0a6d423 100644 --- a/src/QEQ/fix_qeq.cpp +++ b/src/QEQ/fix_qeq.cpp @@ -715,7 +715,7 @@ void FixQEq::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix qeq parameter file %s",file); + snprintf(str,128,"Cannot open fix qeq parameter file %s",file); error->one(FLERR,str); } } diff --git a/src/REAX/fix_reax_bonds.cpp b/src/REAX/fix_reax_bonds.cpp index 84e4a66e6c..5273cd1faa 100644 --- a/src/REAX/fix_reax_bonds.cpp +++ b/src/REAX/fix_reax_bonds.cpp @@ -53,7 +53,7 @@ FixReaxBonds::FixReaxBonds(LAMMPS *lmp, int narg, char **arg) : if (suffix && strcmp(suffix,".gz") == 0) { #ifdef LAMMPS_GZIP char gzip[128]; - sprintf(gzip,"gzip -6 > %s",arg[4]); + snprintf(gzip128,,"gzip -6 > %s",arg[4]); #ifdef _WIN32 fp = _popen(gzip,"wb"); #else @@ -66,7 +66,7 @@ FixReaxBonds::FixReaxBonds(LAMMPS *lmp, int narg, char **arg) : if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix reax/bonds file %s",arg[4]); + snprintf(str,128,"Cannot open fix reax/bonds file %s",arg[4]); error->one(FLERR,str); } } @@ -222,11 +222,8 @@ void FixReaxBonds::OutputReaxBonds(bigint ntimestep, FILE *fp) numbonds = nint(buf[j+2]); fprintf(fp," %d %d %d",nint(buf[j]),nint(buf[j+1]),numbonds); j += 3; - if (numbonds > nsbmax_most) { - char str[128]; - sprintf(str,"Fix reax/bonds numbonds > nsbmax_most"); - error->one(FLERR,str); - } + if (numbonds > nsbmax_most) + error->one(FLERR,"Fix reax/bonds numbonds > nsbmax_most"); // print connection table diff --git a/src/REPLICA/neb.cpp b/src/REPLICA/neb.cpp index c9aedf7401..9a4de9ca0b 100644 --- a/src/REPLICA/neb.cpp +++ b/src/REPLICA/neb.cpp @@ -549,7 +549,7 @@ void NEB::open(char *file) else { #ifdef LAMMPS_GZIP char gunzip[128]; - sprintf(gunzip,"gzip -c -d %s",file); + snprintf(gunz128,ip,"gzip -c -d %s",file); #ifdef _WIN32 fp = _popen(gunzip,"rb"); @@ -564,7 +564,7 @@ void NEB::open(char *file) if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open file %s",file); + snprintf(str,128,"Cannot open file %s",file); error->one(FLERR,str); } } diff --git a/src/REPLICA/tad.cpp b/src/REPLICA/tad.cpp index 46073952fc..da42ba6fae 100644 --- a/src/REPLICA/tad.cpp +++ b/src/REPLICA/tad.cpp @@ -712,10 +712,7 @@ void TAD::perform_neb(int ievent) args[0] = (char *) "neb"; args[1] = (char *) "all"; args[2] = (char *) "neb"; - char str[128]; - args[3] = str; - double kspring = 1.0; - sprintf(args[3],"%f",kspring); + args[3] = (char *) "1.0"; modify->add_fix(narg2,args); fix_neb = (Fix *) modify->fix[modify->nfix-1]; delete [] args; diff --git a/src/RIGID/fix_rigid.cpp b/src/RIGID/fix_rigid.cpp index c15a909ada..39c49ca1c4 100644 --- a/src/RIGID/fix_rigid.cpp +++ b/src/RIGID/fix_rigid.cpp @@ -730,7 +730,7 @@ void FixRigid::init() if (rflag && (modify->fmask[i] & POST_FORCE) && !modify->fix[i]->rigid_flag) { char str[128]; - sprintf(str,"Fix %s alters forces after fix rigid",modify->fix[i]->id); + snprintf(str,128,"Fix %s alters forces after fix rigid",modify->fix[i]->id); error->warning(FLERR,str); } } @@ -2271,7 +2271,7 @@ void FixRigid::readfile(int which, double *vec, fp = fopen(infile,"r"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix rigid infile %s",infile); + snprintf(str,128,"Cannot open fix rigid infile %s",infile); error->one(FLERR,str); } @@ -2380,11 +2380,11 @@ void FixRigid::write_restart_file(char *file) if (me) return; char outfile[128]; - sprintf(outfile,"%s.rigid",file); + snprintf(outfile,128,"%s.rigid",file); FILE *fp = fopen(outfile,"w"); if (fp == NULL) { char str[192]; - sprintf(str,"Cannot open fix rigid restart file %s",outfile); + snprintf(str,192,"Cannot open fix rigid restart file %s",outfile); error->one(FLERR,str); } diff --git a/src/RIGID/fix_rigid_small.cpp b/src/RIGID/fix_rigid_small.cpp index d5d3d36083..44e1870e0a 100644 --- a/src/RIGID/fix_rigid_small.cpp +++ b/src/RIGID/fix_rigid_small.cpp @@ -569,7 +569,7 @@ void FixRigidSmall::init() if (rflag && (modify->fmask[i] & POST_FORCE) && !modify->fix[i]->rigid_flag) { char str[128]; - sprintf(str,"Fix %s alters forces after fix rigid",modify->fix[i]->id); + snprintf(str,128,"Fix %s alters forces after fix rigid",modify->fix[i]->id); error->warning(FLERR,str); } } @@ -2482,7 +2482,7 @@ void FixRigidSmall::readfile(int which, double **array, int *inbody) fp = fopen(infile,"r"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix rigid/small infile %s",infile); + snprintf(str,128,"Cannot open fix rigid/small infile %s",infile); error->one(FLERR,str); } @@ -2597,11 +2597,11 @@ void FixRigidSmall::write_restart_file(char *file) if (me == 0) { char outfile[128]; - sprintf(outfile,"%s.rigid",file); + snprintf(outfile,128,"%s.rigid",file); fp = fopen(outfile,"w"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix rigid restart file %s",outfile); + snprintf(str,128,"Cannot open fix rigid restart file %s",outfile); error->one(FLERR,str); } diff --git a/src/SNAP/pair_snap.cpp b/src/SNAP/pair_snap.cpp index eaefb0325d..9f4c6bf5e2 100644 --- a/src/SNAP/pair_snap.cpp +++ b/src/SNAP/pair_snap.cpp @@ -1591,7 +1591,7 @@ void PairSNAP::read_files(char *coefffilename, char *paramfilename) fpcoeff = force->open_potential(coefffilename); if (fpcoeff == NULL) { char str[128]; - sprintf(str,"Cannot open SNAP coefficient file %s",coefffilename); + snprintf(str,128,"Cannot open SNAP coefficient file %s",coefffilename); error->one(FLERR,str); } } @@ -1757,7 +1757,7 @@ void PairSNAP::read_files(char *coefffilename, char *paramfilename) fpparam = force->open_potential(paramfilename); if (fpparam == NULL) { char str[128]; - sprintf(str,"Cannot open SNAP parameter file %s",paramfilename); + snprintf(str,128,"Cannot open SNAP parameter file %s",paramfilename); error->one(FLERR,str); } } diff --git a/src/USER-BOCS/fix_bocs.cpp b/src/USER-BOCS/fix_bocs.cpp index 03fc94ae58..bf11b1d6ba 100644 --- a/src/USER-BOCS/fix_bocs.cpp +++ b/src/USER-BOCS/fix_bocs.cpp @@ -207,12 +207,11 @@ FixBocs::FixBocs(LAMMPS *lmp, int narg, char **arg) : p_basis_type = 2; spline_length = read_F_table( arg[iarg+1], p_basis_type ); iarg += 2; - } else - { - char * errmsg = (char *) calloc(150,sizeof(char)); - sprintf(errmsg,"CG basis type %s is not recognized\nSupported " - "basis types: analytic linear_spline cubic_spline",arg[iarg]); - error->all(FLERR,errmsg); + } else { + char errmsg[256]; + snprintf(errmsg,256,"CG basis type %s is not recognized\nSupported " + "basis types: analytic linear_spline cubic_spline",arg[iarg]); + error->all(FLERR,errmsg); } // END NJD MRD } else if (strcmp(arg[iarg],"tchain") == 0) { if (iarg+2 > narg) error->all(FLERR,"Illegal fix bocs command"); @@ -243,9 +242,9 @@ FixBocs::FixBocs(LAMMPS *lmp, int narg, char **arg) : if (nc_pchain < 0) error->all(FLERR,"Illegal fix bocs command"); iarg += 2; } else { - char * errmsg = (char *) calloc(80,sizeof(char)); - sprintf(errmsg,"Illegal fix bocs command: unrecognized keyword %s" - ,arg[iarg]); + char errmsg[128]; + snprintf(errmsg,128,"Illegal fix bocs command: unrecognized keyword %s" + ,arg[iarg]); error->all(FLERR,errmsg); } } @@ -641,20 +640,16 @@ int FixBocs::read_F_table( char *filename, int p_basis_type ) { data[i] = (double *) calloc(n_entries,sizeof(double)); } - } - else - { - char * errmsg = (char *) calloc(50,sizeof(char)); - sprintf(errmsg,"Unable to open file: %s\n",filename); + } else { + char errmsg[128]; + snprintf(errmsg,128,"Unable to open file: %s\n",filename); error->all(FLERR,errmsg); } n_entries = 0; fpi = fopen(filename,"r"); - if (fpi) - { - while( fgets(line,199,fpi)) - { + if (fpi) { + while( fgets(line,199,fpi)) { ++n_entries; test_sscanf = sscanf(line," %f , %f ",&f1, &f2); if (test_sscanf == 2) @@ -668,11 +663,9 @@ int FixBocs::read_F_table( char *filename, int p_basis_type ) "line %d of file %s\n\tline: %s",n_entries,filename,line); } } - } - else - { - char * errmsg = (char *) calloc(50,sizeof(char)); - sprintf(errmsg,"Unable to open file: %s\n",filename); + } else { + char errmsg[128]; + snprintf(errmsg,128,"Unable to open file: %s\n",filename); error->all(FLERR,errmsg); } fclose(fpi); diff --git a/src/USER-DIFFRACTION/fix_saed_vtk.cpp b/src/USER-DIFFRACTION/fix_saed_vtk.cpp index ad9c76ac6b..882c13bc3e 100644 --- a/src/USER-DIFFRACTION/fix_saed_vtk.cpp +++ b/src/USER-DIFFRACTION/fix_saed_vtk.cpp @@ -424,12 +424,12 @@ void FixSAEDVTK::invoke_vector(bigint ntimestep) fclose(fp); char nName [128]; - sprintf(nName,"%s.%d.vtk",filename,nOutput); + snprintf(nName,128,"%s.%d.vtk",filename,nOutput); fp = fopen(nName,"w"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix saed/vtk file %s",nName); + snprintf(str,128,"Cannot open fix saed/vtk file %s",nName); error->one(FLERR,str); } } @@ -550,13 +550,13 @@ void FixSAEDVTK::options(int narg, char **arg) filename = new char[n]; strcpy(filename,arg[iarg+1]); - char nName [128]; - sprintf(nName,"%s.%d.vtk",filename,nOutput); + char nName [128]; + snprintf(nName,128,"%s.%d.vtk",filename,nOutput); fp = fopen(nName,"w"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix saed/vtk file %s",nName); + snprintf(str,128,"Cannot open fix saed/vtk file %s",nName); error->one(FLERR,str); } } diff --git a/src/USER-DPD/fix_eos_table.cpp b/src/USER-DPD/fix_eos_table.cpp index e57a3788bf..7d701f5fb8 100644 --- a/src/USER-DPD/fix_eos_table.cpp +++ b/src/USER-DPD/fix_eos_table.cpp @@ -200,7 +200,7 @@ void FixEOStable::read_table(Table *tb, Table *tb2, char *file, char *keyword) FILE *fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open file %s",file); + snprintf(str,128,"Cannot open file %s",file); error->one(FLERR,str); } diff --git a/src/USER-DPD/fix_eos_table_rx.cpp b/src/USER-DPD/fix_eos_table_rx.cpp index 181c7dccfa..779cee0e8b 100644 --- a/src/USER-DPD/fix_eos_table_rx.cpp +++ b/src/USER-DPD/fix_eos_table_rx.cpp @@ -309,7 +309,7 @@ void FixEOStableRX::read_file(char *file) fp = fopen(file,"r"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open eos table/rx potential file %s",file); + snprintf(str,128,"Cannot open eos table/rx potential file %s",file); error->one(FLERR,str); } } @@ -419,7 +419,7 @@ void FixEOStableRX::read_table(Table *tb, Table *tb2, char *file, char *keyword) FILE *fp = fopen(file,"r"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open file %s",file); + snprintf(str,128,"Cannot open file %s",file); error->one(FLERR,str); } diff --git a/src/USER-DPD/fix_rx.cpp b/src/USER-DPD/fix_rx.cpp index 1a9c43704d..97668471c8 100644 --- a/src/USER-DPD/fix_rx.cpp +++ b/src/USER-DPD/fix_rx.cpp @@ -272,7 +272,7 @@ void FixRX::post_constructor() fp = force->open_potential(kineticsFile); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open rx file %s",kineticsFile); + snprintf(str,128,"Cannot open rx file %s",kineticsFile); error->one(FLERR,str); } } @@ -859,7 +859,7 @@ void FixRX::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open rx file %s",file); + snprintf(str,128,"Cannot open rx file %s",file); error->one(FLERR,str); } } diff --git a/src/USER-DPD/pair_exp6_rx.cpp b/src/USER-DPD/pair_exp6_rx.cpp index 057c8fa119..0251f019c5 100644 --- a/src/USER-DPD/pair_exp6_rx.cpp +++ b/src/USER-DPD/pair_exp6_rx.cpp @@ -730,7 +730,7 @@ void PairExp6rx::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open exp6/rx potential file %s",file); + snprintf(str,128,"Cannot open exp6/rx potential file %s",file); error->one(FLERR,str); } } @@ -841,7 +841,7 @@ void PairExp6rx::read_file2(char *file) fp = fopen(file,"r"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open polynomial file %s",file); + snprintf(str,128,"Cannot open polynomial file %s",file); error->one(FLERR,str); } } diff --git a/src/USER-DPD/pair_multi_lucy.cpp b/src/USER-DPD/pair_multi_lucy.cpp index f911d8299e..19a4a02f0b 100644 --- a/src/USER-DPD/pair_multi_lucy.cpp +++ b/src/USER-DPD/pair_multi_lucy.cpp @@ -350,7 +350,7 @@ void PairMultiLucy::read_table(Table *tb, char *file, char *keyword) FILE *fp = fopen(file,"r"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open file %s",file); + snprintf(str,128,"Cannot open file %s",file); error->one(FLERR,str); } diff --git a/src/USER-DPD/pair_multi_lucy_rx.cpp b/src/USER-DPD/pair_multi_lucy_rx.cpp index 13c838fe01..f3ad86eb2f 100644 --- a/src/USER-DPD/pair_multi_lucy_rx.cpp +++ b/src/USER-DPD/pair_multi_lucy_rx.cpp @@ -495,7 +495,7 @@ void PairMultiLucyRX::read_table(Table *tb, char *file, char *keyword) FILE *fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open file %s",file); + snprintf(str,128,"Cannot open file %s",file); error->one(FLERR,str); } diff --git a/src/USER-INTEL/pair_eam_alloy_intel.cpp b/src/USER-INTEL/pair_eam_alloy_intel.cpp index 192b39b2e8..da8a180fff 100644 --- a/src/USER-INTEL/pair_eam_alloy_intel.cpp +++ b/src/USER-INTEL/pair_eam_alloy_intel.cpp @@ -126,7 +126,7 @@ void PairEAMAlloyIntel::read_file(char *filename) fptr = force->open_potential(filename); if (fptr == NULL) { char str[128]; - sprintf(str,"Cannot open EAM potential file %s",filename); + snprintf(str,128,"Cannot open EAM potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/USER-INTEL/pair_eam_fs_intel.cpp b/src/USER-INTEL/pair_eam_fs_intel.cpp index 61bb6e0b4d..043f77db3e 100644 --- a/src/USER-INTEL/pair_eam_fs_intel.cpp +++ b/src/USER-INTEL/pair_eam_fs_intel.cpp @@ -126,7 +126,7 @@ void PairEAMFSIntel::read_file(char *filename) fptr = force->open_potential(filename); if (fptr == NULL) { char str[128]; - sprintf(str,"Cannot open EAM potential file %s",filename); + snprintf(str,128,"Cannot open EAM potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/USER-MEAMC/pair_meamc.cpp b/src/USER-MEAMC/pair_meamc.cpp index eca1040c9c..ff2a1180b5 100644 --- a/src/USER-MEAMC/pair_meamc.cpp +++ b/src/USER-MEAMC/pair_meamc.cpp @@ -328,7 +328,7 @@ void PairMEAMC::read_files(char *globalfile, char *userfile) fp = force->open_potential(globalfile); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open MEAM potential file %s",globalfile); + snprintf(str,128,"Cannot open MEAM potential file %s",globalfile); error->one(FLERR,str); } } @@ -509,7 +509,7 @@ void PairMEAMC::read_files(char *globalfile, char *userfile) fp = force->open_potential(userfile); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open MEAM potential file %s",userfile); + snprintf(str,128,"Cannot open MEAM potential file %s",userfile); error->one(FLERR,str); } } @@ -558,8 +558,8 @@ void PairMEAMC::read_files(char *globalfile, char *userfile) if (strcmp(params[0],keywords[which]) == 0) break; if (which == nkeywords) { char str[128]; - sprintf(str,"Keyword %s in MEAM parameter file not recognized", - params[0]); + snprintf(str,128,"Keyword %s in MEAM parameter file not recognized", + params[0]); error->all(FLERR,str); } nindex = nparams - 2; diff --git a/src/USER-MISC/fix_ave_correlate_long.cpp b/src/USER-MISC/fix_ave_correlate_long.cpp index 0ce6121bf9..5c9f478a65 100644 --- a/src/USER-MISC/fix_ave_correlate_long.cpp +++ b/src/USER-MISC/fix_ave_correlate_long.cpp @@ -165,7 +165,7 @@ FixAveCorrelateLong::FixAveCorrelateLong(LAMMPS * lmp, int narg, char **arg): fp = fopen(arg[iarg+1],"w"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix ave/correlate/long file %s",arg[iarg+1]); + snprintf(str,128,"Cannot open fix ave/correlate/long file %s",arg[iarg+1]); error->one(FLERR,str); } } diff --git a/src/USER-MISC/fix_bond_react.cpp b/src/USER-MISC/fix_bond_react.cpp index ceac93178d..ae4534f825 100644 --- a/src/USER-MISC/fix_bond_react.cpp +++ b/src/USER-MISC/fix_bond_react.cpp @@ -2529,7 +2529,7 @@ void FixBondReact::open(char *file) fp = fopen(file,"r"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open superimpose file %s",file); + snprintf(str,128,"Cannot open superimpose file %s",file); error->one(FLERR,str); } } diff --git a/src/USER-MISC/fix_gle.cpp b/src/USER-MISC/fix_gle.cpp index 0b08fab4ca..01da7f87cf 100644 --- a/src/USER-MISC/fix_gle.cpp +++ b/src/USER-MISC/fix_gle.cpp @@ -232,7 +232,7 @@ FixGLE::FixGLE(LAMMPS *lmp, int narg, char **arg) : fgle = force->open_potential(fname); if (fgle == NULL) { char str[128]; - sprintf(str,"Cannot open A-matrix file %s",fname); + snprintf(str,128,"Cannot open A-matrix file %s",fname); error->one(FLERR,str); } if (screen) fprintf(screen,"Reading A-matrix from %s\n", fname); @@ -302,7 +302,7 @@ FixGLE::FixGLE(LAMMPS *lmp, int narg, char **arg) : fgle = force->open_potential(fname); if (fgle == NULL) { char str[128]; - sprintf(str,"Cannot open C-matrix file %s",fname); + snprintf(str,128,"Cannot open C-matrix file %s",fname); error->one(FLERR,str); } if (screen) diff --git a/src/USER-MISC/fix_ttm_mod.cpp b/src/USER-MISC/fix_ttm_mod.cpp index 65f8e90ec3..a423b510e5 100644 --- a/src/USER-MISC/fix_ttm_mod.cpp +++ b/src/USER-MISC/fix_ttm_mod.cpp @@ -86,7 +86,7 @@ FixTTMMod::FixTTMMod(LAMMPS *lmp, int narg, char **arg) : FILE *fpr_2 = force->open_potential(arg[4]); if (fpr_2 == NULL) { char str[128]; - sprintf(str,"Cannot open file %s",arg[4]); + snprintf(str,128,"Cannot open file %s",arg[4]); error->all(FLERR,str); } @@ -99,7 +99,7 @@ FixTTMMod::FixTTMMod(LAMMPS *lmp, int narg, char **arg) : FILE *fpr = force->open_potential(arg[8]); if (fpr == NULL) { char str[128]; - sprintf(str,"Cannot open file %s",arg[8]); + snprintf(str,128,"Cannot open file %s",arg[8]); error->all(FLERR,str); } @@ -111,7 +111,7 @@ FixTTMMod::FixTTMMod(LAMMPS *lmp, int narg, char **arg) : fp = fopen(arg[10],"w"); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open fix ttm/mod file %s",arg[10]); + snprintf(str,128,"Cannot open fix ttm/mod file %s",arg[10]); error->one(FLERR,str); } } diff --git a/src/USER-MISC/pair_agni.cpp b/src/USER-MISC/pair_agni.cpp index 998582f619..0277969d15 100644 --- a/src/USER-MISC/pair_agni.cpp +++ b/src/USER-MISC/pair_agni.cpp @@ -363,7 +363,7 @@ void PairAGNI::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open AGNI potential file %s",file); + snprintf(str,128,"Cannot open AGNI potential file %s",file); error->one(FLERR,str); } } diff --git a/src/USER-MISC/pair_edip.cpp b/src/USER-MISC/pair_edip.cpp index 4716e271d7..491268567f 100644 --- a/src/USER-MISC/pair_edip.cpp +++ b/src/USER-MISC/pair_edip.cpp @@ -877,7 +877,7 @@ void PairEDIP::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open EDIP potential file %s",file); + snprintf(str,128,"Cannot open EDIP potential file %s",file); error->one(FLERR,str); } } diff --git a/src/USER-MISC/pair_edip_multi.cpp b/src/USER-MISC/pair_edip_multi.cpp index fc76aadb0b..f56650d2f6 100644 --- a/src/USER-MISC/pair_edip_multi.cpp +++ b/src/USER-MISC/pair_edip_multi.cpp @@ -644,7 +644,7 @@ void PairEDIPMulti::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open EDIP potential file %s",file); + snprintf(str,128,"Cannot open EDIP potential file %s",file); error->one(FLERR,str); } } diff --git a/src/USER-MISC/pair_extep.cpp b/src/USER-MISC/pair_extep.cpp index 49c562471f..1e7d17f040 100644 --- a/src/USER-MISC/pair_extep.cpp +++ b/src/USER-MISC/pair_extep.cpp @@ -591,7 +591,7 @@ void PairExTeP::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open ExTeP potential file %s",file); + snprintf(str,128,"Cannot open ExTeP potential file %s",file); error->one(FLERR,str); } } diff --git a/src/USER-MISC/pair_ilp_graphene_hbn.cpp b/src/USER-MISC/pair_ilp_graphene_hbn.cpp index 7e11cdff4f..6b92595472 100644 --- a/src/USER-MISC/pair_ilp_graphene_hbn.cpp +++ b/src/USER-MISC/pair_ilp_graphene_hbn.cpp @@ -880,7 +880,7 @@ void PairILPGrapheneHBN::read_file(char *filename) fp = force->open_potential(filename); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open ILP potential file %s",filename); + snprintf(str,128,"Cannot open ILP potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/USER-MISC/pair_kolmogorov_crespi_full.cpp b/src/USER-MISC/pair_kolmogorov_crespi_full.cpp index bc3bfaeba9..18870ef69a 100644 --- a/src/USER-MISC/pair_kolmogorov_crespi_full.cpp +++ b/src/USER-MISC/pair_kolmogorov_crespi_full.cpp @@ -885,7 +885,7 @@ void PairKolmogorovCrespiFull::read_file(char *filename) fp = force->open_potential(filename); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open KC potential file %s",filename); + snprintf(str,128,"Cannot open KC potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/USER-MISC/pair_kolmogorov_crespi_z.cpp b/src/USER-MISC/pair_kolmogorov_crespi_z.cpp index fb7d5ae40e..b39b9fdb72 100644 --- a/src/USER-MISC/pair_kolmogorov_crespi_z.cpp +++ b/src/USER-MISC/pair_kolmogorov_crespi_z.cpp @@ -315,7 +315,7 @@ void PairKolmogorovCrespiZ::read_file(char *filename) fp = force->open_potential(filename); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open KC potential file %s",filename); + snprintf(str,128,"Cannot open KC potential file %s",filename); error->one(FLERR,str); } } diff --git a/src/USER-MISC/pair_meam_spline.cpp b/src/USER-MISC/pair_meam_spline.cpp index e6ea6c2ae4..0300e2c7a2 100644 --- a/src/USER-MISC/pair_meam_spline.cpp +++ b/src/USER-MISC/pair_meam_spline.cpp @@ -439,7 +439,7 @@ void PairMEAMSpline::read_file(const char* filename) FILE *fp = force->open_potential(filename); if(fp == NULL) { char str[1024]; - sprintf(str,"Cannot open spline MEAM potential file %s", filename); + snprintf(str,128,"Cannot open spline MEAM potential file %s", filename); error->one(FLERR,str); } diff --git a/src/USER-MISC/pair_meam_sw_spline.cpp b/src/USER-MISC/pair_meam_sw_spline.cpp index 891913ccfc..20dade5e5f 100644 --- a/src/USER-MISC/pair_meam_sw_spline.cpp +++ b/src/USER-MISC/pair_meam_sw_spline.cpp @@ -462,64 +462,64 @@ void PairMEAMSWSpline::coeff(int narg, char **arg) void PairMEAMSWSpline::read_file(const char* filename) { - if(comm->me == 0) { - FILE *fp = force->open_potential(filename); - if(fp == NULL) { - char str[1024]; - sprintf(str,"Cannot open spline MEAM potential file %s", filename); - error->one(FLERR,str); - } + if(comm->me == 0) { + FILE *fp = force->open_potential(filename); + if(fp == NULL) { + char str[1024]; + snprintf(str,128,"Cannot open spline MEAM potential file %s", filename); + error->one(FLERR,str); + } - // Skip first line of file. - char line[MAXLINE]; - fgets(line, MAXLINE, fp); + // Skip first line of file. + char line[MAXLINE]; + fgets(line, MAXLINE, fp); - // Parse spline functions. - phi.parse(fp, error); - F.parse(fp, error); - G.parse(fp, error); - rho.parse(fp, error); - U.parse(fp, error); - f.parse(fp, error); - g.parse(fp, error); + // Parse spline functions. + phi.parse(fp, error); + F.parse(fp, error); + G.parse(fp, error); + rho.parse(fp, error); + U.parse(fp, error); + f.parse(fp, error); + g.parse(fp, error); - fclose(fp); - } + fclose(fp); + } - // Transfer spline functions from master processor to all other processors. - phi.communicate(world, comm->me); - rho.communicate(world, comm->me); - f.communicate(world, comm->me); - U.communicate(world, comm->me); - g.communicate(world, comm->me); - F.communicate(world, comm->me); - G.communicate(world, comm->me); + // Transfer spline functions from master processor to all other processors. + phi.communicate(world, comm->me); + rho.communicate(world, comm->me); + f.communicate(world, comm->me); + U.communicate(world, comm->me); + g.communicate(world, comm->me); + F.communicate(world, comm->me); + G.communicate(world, comm->me); - // Calculate 'zero-point energy' of single atom in vacuum. - zero_atom_energy = U.eval(0.0); + // Calculate 'zero-point energy' of single atom in vacuum. + zero_atom_energy = U.eval(0.0); - // Determine maximum cutoff radius of all relevant spline functions. - cutoff = 0.0; - if(phi.cutoff() > cutoff) cutoff = phi.cutoff(); - if(rho.cutoff() > cutoff) cutoff = rho.cutoff(); - if(f.cutoff() > cutoff) cutoff = f.cutoff(); - if(F.cutoff() > cutoff) cutoff = F.cutoff(); + // Determine maximum cutoff radius of all relevant spline functions. + cutoff = 0.0; + if(phi.cutoff() > cutoff) cutoff = phi.cutoff(); + if(rho.cutoff() > cutoff) cutoff = rho.cutoff(); + if(f.cutoff() > cutoff) cutoff = f.cutoff(); + if(F.cutoff() > cutoff) cutoff = F.cutoff(); - // Set LAMMPS pair interaction flags. - for(int i = 1; i <= atom->ntypes; i++) { - for(int j = 1; j <= atom->ntypes; j++) { - setflag[i][j] = 1; - cutsq[i][j] = cutoff; - } - } + // Set LAMMPS pair interaction flags. + for(int i = 1; i <= atom->ntypes; i++) { + for(int j = 1; j <= atom->ntypes; j++) { + setflag[i][j] = 1; + cutsq[i][j] = cutoff; + } + } - // phi.writeGnuplot("phi.gp", "Phi(r)"); - // rho.writeGnuplot("rho.gp", "Rho(r)"); - // f.writeGnuplot("f.gp", "f(r)"); - // U.writeGnuplot("U.gp", "U(rho)"); - // g.writeGnuplot("g.gp", "g(x)"); - // F.writeGnuplot("F.gp", "F(r)"); - // G.writeGnuplot("G.gp", "G(x)"); + // phi.writeGnuplot("phi.gp", "Phi(r)"); + // rho.writeGnuplot("rho.gp", "Rho(r)"); + // f.writeGnuplot("f.gp", "f(r)"); + // U.writeGnuplot("U.gp", "U(rho)"); + // g.writeGnuplot("g.gp", "g(x)"); + // F.writeGnuplot("F.gp", "F(r)"); + // G.writeGnuplot("G.gp", "G(x)"); } /* ---------------------------------------------------------------------- diff --git a/src/USER-MISC/pair_tersoff_table.cpp b/src/USER-MISC/pair_tersoff_table.cpp index d7e28a1e40..d1044cc336 100644 --- a/src/USER-MISC/pair_tersoff_table.cpp +++ b/src/USER-MISC/pair_tersoff_table.cpp @@ -845,7 +845,7 @@ void PairTersoffTable::read_file(char *file) fp = force->open_potential(file); if (fp == NULL) { char str[128]; - sprintf(str,"Cannot open Tersoff potential file %s",file); + snprintf(str,128,"Cannot open Tersoff potential file %s",file); error->one(FLERR,str); } } diff --git a/src/USER-MOLFILE/reader_molfile.cpp b/src/USER-MOLFILE/reader_molfile.cpp index 6348009d8f..8e49f56d5c 100644 --- a/src/USER-MOLFILE/reader_molfile.cpp +++ b/src/USER-MOLFILE/reader_molfile.cpp @@ -113,12 +113,12 @@ void ReaderMolfile::open_file(const char *file) rv = mf->open(file,&natoms); if (rv != MFI::E_NONE) { - sprintf(str,"Cannot open file %s",file); + snprintf(str,1024,"Cannot open file %s",file); error->one(FLERR,str); } if (natoms < 1) { - sprintf(str,"No atoms in file %s",file); + snprintf(str,1024,"No atoms in file %s",file); error->one(FLERR,str); }