ICODE-ADC/lammps
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avoid out of bounds access to string under cursor

Browse Source
This commit is contained in:
Axel Kohlmeyer
2023-10-13 08:17:10 -04:00
parent 2f67826363
commit ae8791c682
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tools/lammps-gui/codeeditor.cpp
View File

@ -572,7 +572,8 @@ void CodeEditor::keyPressEvent(QKeyEvent *event)
// QTextCursor::WordUnderCursor is unusable here since recognizes '/' as word boundary. // QTextCursor::WordUnderCursor is unusable here since recognizes '/' as word boundary.
// Work around it by manually searching for the location of the beginning of the word. // Work around it by manually searching for the location of the beginning of the word.
int begin = cursor.positionInBlock(); int begin = qMin(cursor.positionInBlock(), line.length() - 1);
while (begin >= 0) { while (begin >= 0) {
if (line[begin].isSpace()) break; if (line[begin].isSpace()) break;
--begin; --begin;
@ -749,7 +750,7 @@ void CodeEditor::runCompletion()
// QTextCursor::WordUnderCursor is unusable here since it recognizes '/' as word boundary. // QTextCursor::WordUnderCursor is unusable here since it recognizes '/' as word boundary.
// Work around it by manually searching for the beginning and end position of the word // Work around it by manually searching for the beginning and end position of the word
// under the cursor and then using that substring. // under the cursor and then using that substring.
int begin = cursor.positionInBlock(); int begin = qMin(cursor.positionInBlock(), line.length() - 1);
line = cursor.block().text(); line = cursor.block().text();
while (begin >= 0) { while (begin >= 0) {
if (line[begin].isSpace()) break; if (line[begin].isSpace()) break;