From b093094d5e1ce8785e61b3a3f207cbf1207df598 Mon Sep 17 00:00:00 2001
From: Axel Kohlmeyer <akohlmey@gmail.com>
Date: Wed, 25 Jun 2025 19:55:10 -0400
Subject: [PATCH] avoid copying vectors as arguments and pass a const reference
 instead

---
 src/ELECTRODE/fix_electrode_conp.h   | 2 +-
 src/ELECTRODE/fix_electrode_conq.cpp | 2 +-
 src/ELECTRODE/fix_electrode_conq.h   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/ELECTRODE/fix_electrode_conp.h b/src/ELECTRODE/fix_electrode_conp.h
index 5063e9d008..583da05310 100644
--- a/src/ELECTRODE/fix_electrode_conp.h
+++ b/src/ELECTRODE/fix_electrode_conp.h
@@ -73,7 +73,7 @@ class FixElectrodeConp : public Fix {
   enum class VarStyle { CONST, EQUAL, UNSET };
   virtual void update_psi();
   virtual void pre_update() {};
-  virtual void recompute_potential(std::vector<double>, std::vector<double>){};
+  virtual void recompute_potential(const std::vector<double> &, const std::vector<double> &) {};
   virtual std::vector<double> constraint_projection(std::vector<double>);
   virtual std::vector<double> constraint_correction(std::vector<double>);
   virtual void compute_macro_matrices();
diff --git a/src/ELECTRODE/fix_electrode_conq.cpp b/src/ELECTRODE/fix_electrode_conq.cpp
index 07c000c56d..9020c82d31 100644
--- a/src/ELECTRODE/fix_electrode_conq.cpp
+++ b/src/ELECTRODE/fix_electrode_conq.cpp
@@ -113,7 +113,7 @@ std::vector<double> FixElectrodeConq::constraint_projection(std::vector<double>
    Recompute group potential as average for output if using cg algo
 ------------------------------------------------------------------------- */
 
-void FixElectrodeConq::recompute_potential(std::vector<double> b, std::vector<double> q_local)
+void FixElectrodeConq::recompute_potential(const std::vector<double> &b, const std::vector<double> &q_local)
 {
   const int n = b.size();
   auto a = ele_ele_interaction(q_local);
diff --git a/src/ELECTRODE/fix_electrode_conq.h b/src/ELECTRODE/fix_electrode_conq.h
index f013fb0d29..ee0a2f27a2 100644
--- a/src/ELECTRODE/fix_electrode_conq.h
+++ b/src/ELECTRODE/fix_electrode_conq.h
@@ -34,7 +34,7 @@ class FixElectrodeConq : public FixElectrodeConp {
  public:
   FixElectrodeConq(class LAMMPS *, int, char **);
   void update_psi() override;
-  void recompute_potential(std::vector<double>, std::vector<double>) override;
+  void recompute_potential(const std::vector<double> &, const std::vector<double> &) override;
   std::vector<double> constraint_projection(std::vector<double>) override;
   std::vector<double> constraint_correction(std::vector<double>) override;