remove BUILD_EXE and BUILD_LIB options from CMake files. we always build both.

cmake/CMakeLists.txt

@@ -80,18 +80,13 @@ endif()
 ########################################################################
 # User input options                                                   #
 ########################################################################
-option(BUILD_EXE "Build lmp binary" ON)
-if(BUILD_EXE)
 set(LAMMPS_MACHINE "" CACHE STRING "Suffix to append to lmp binary (WON'T enable any features automatically")
 mark_as_advanced(LAMMPS_MACHINE)
 if(LAMMPS_MACHINE)
   set(LAMMPS_MACHINE "_${LAMMPS_MACHINE}")
 endif()
 set(LAMMPS_BINARY lmp${LAMMPS_MACHINE})
-endif()
 
-option(BUILD_LIB "Build LAMMPS library" OFF)
-if(BUILD_LIB)
 option(BUILD_SHARED_LIBS "Build shared library" OFF)
 if(BUILD_SHARED_LIBS) # for all pkg libs, mpi_stubs and linalg
   set(CMAKE_POSITION_INDEPENDENT_CODE ON)
@@ -101,30 +96,18 @@ if(BUILD_LIB)
 if(LAMMPS_LIB_SUFFIX)
   set(LAMMPS_LIB_SUFFIX "_${LAMMPS_LIB_SUFFIX}")
 endif()
-endif()
 
 option(BUILD_TOOLS "Build and install LAMMPS tools (msi2lmp, binary2txt, chain)" OFF)
 
 include(GNUInstallDirs)
 file(GLOB ALL_SOURCES ${LAMMPS_SOURCE_DIR}/[^.]*.cpp)
-if(BUILD_LIB)
 file(GLOB MAIN_SOURCES ${LAMMPS_SOURCE_DIR}/main.cpp)
 list(REMOVE_ITEM ALL_SOURCES ${MAIN_SOURCES})
 add_library(lammps ${ALL_SOURCES})
-  if(BUILD_EXE)
 add_executable(lmp ${MAIN_SOURCES})
 target_link_libraries(lmp PRIVATE lammps)
 set_target_properties(lmp PROPERTIES OUTPUT_NAME ${LAMMPS_BINARY})
 install(TARGETS lmp EXPORT LAMMPS_Targets DESTINATION ${CMAKE_INSTALL_BINDIR})
-  endif()
-else()
-  if(NOT BUILD_EXE)
-    message(FATAL_ERROR "You need to at least enable one of two following options: BUILD_LIB or BUILD_EXE")
-  endif()
-  add_executable(lammps ${ALL_SOURCES})
-  set_target_properties(lammps PROPERTIES OUTPUT_NAME ${LAMMPS_BINARY})
-  install(TARGETS lammps DESTINATION ${CMAKE_INSTALL_BINDIR})
-endif()
 
 option(CMAKE_VERBOSE_MAKEFILE "Generate verbose Makefiles" OFF)
 
@@ -184,7 +167,7 @@ else()
   enable_language(C)
   file(GLOB MPI_SOURCES ${LAMMPS_SOURCE_DIR}/STUBS/mpi.c)
   add_library(mpi_stubs STATIC ${MPI_SOURCES})
-  if(BUILD_LIB AND NOT BUILD_SHARED_LIBS)
+  if(NOT BUILD_SHARED_LIBS)
     install(TARGETS mpi_stubs EXPORT LAMMPS_Targets LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
   endif()
   set_target_properties(mpi_stubs PROPERTIES OUTPUT_NAME lammps_mpi_stubs${LAMMPS_LIB_SUFFIX})
@@ -271,7 +254,7 @@ if(PKG_MSCG OR PKG_USER-ATC OR PKG_USER-AWPMD OR PKG_USER-QUIP OR PKG_LATTE)
     enable_language(Fortran)
     file(GLOB LAPACK_SOURCES ${LAMMPS_LIB_SOURCE_DIR}/linalg/[^.]*.[fF])
     add_library(linalg STATIC ${LAPACK_SOURCES})
-    if(BUILD_LIB AND NOT BUILD_SHARED_LIBS)
+    if(NOT BUILD_SHARED_LIBS)
       install(TARGETS linalg EXPORT LAMMPS_Targets LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
     endif()
     set_target_properties(linalg PROPERTIES OUTPUT_NAME lammps_linalg${LAMMPS_LIB_SUFFIX})
@@ -432,7 +415,7 @@ foreach(SIMPLE_LIB POEMS USER-ATC USER-AWPMD USER-H5MD)
       ${LAMMPS_LIB_SOURCE_DIR}/${PKG_LIB}/[^.]*.c
       ${LAMMPS_LIB_SOURCE_DIR}/${PKG_LIB}/[^.]*.cpp)
     add_library(${PKG_LIB} STATIC ${${PKG_LIB}_SOURCES})
-    if(BUILD_LIB AND NOT BUILD_SHARED_LIBS)
+    if(NOT BUILD_SHARED_LIBS)
       install(TARGETS ${PKG_LIB} EXPORT LAMMPS_Targets LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
     endif()
     set_target_properties(${PKG_LIB} PROPERTIES OUTPUT_NAME lammps_${PKG_LIB}${LAMMPS_LIB_SUFFIX})
@@ -532,7 +515,6 @@ list (FIND LANGUAGES "Fortran" _index)
 if (${_index} GREATER -1)
   target_link_libraries(lammps PRIVATE ${CMAKE_Fortran_IMPLICIT_LINK_LIBRARIES})
 endif()
-if(BUILD_LIB)
 set(LAMMPS_CXX_HEADERS angle.h atom.h bond.h citeme.h comm.h compute.h dihedral.h domain.h error.h fix.h force.h group.h improper.h
   input.h info.h kspace.h lammps.h lattice.h library.h lmppython.h lmptype.h memory.h modify.h neighbor.h neigh_list.h output.h
   pair.h pointers.h region.h timer.h universe.h update.h variable.h)
@@ -565,11 +547,7 @@ if(BUILD_LIB)
 configure_file(LAMMPSConfig.cmake.in ${CMAKE_CURRENT_BINARY_DIR}/LAMMPSConfig.cmake @ONLY)
 write_basic_package_version_file("LAMMPSConfigVersion.cmake" VERSION ${PROJECT_VERSION} COMPATIBILITY ExactVersion)
 install(FILES "${CMAKE_CURRENT_BINARY_DIR}/LAMMPSConfig.cmake" "${CMAKE_CURRENT_BINARY_DIR}/LAMMPSConfigVersion.cmake" DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/LAMMPS)
-endif()
-
-if(BUILD_EXE)
 install(FILES ${LAMMPS_DOC_DIR}/lammps.1 DESTINATION ${CMAKE_INSTALL_MANDIR}/man1 RENAME ${LAMMPS_BINARY}.1)
-endif()
 
 if(BUILD_TOOLS)
   add_executable(binary2txt ${LAMMPS_TOOLS_DIR}/binary2txt.cpp)
@@ -620,7 +598,7 @@ install(
 # conventional build.  Only available, if a shared library is built.
 # This is primarily for people that only want to use the Python wrapper.
 ###############################################################################
-if(BUILD_LIB AND BUILD_SHARED_LIBS)
+if(BUILD_SHARED_LIBS)
   if(CMAKE_VERSION VERSION_LESS 3.12)
     find_package(PythonInterp) # Deprecated since version 3.12
   else()
@@ -650,7 +628,7 @@ endif()
 # LAMMPS for package managers and with different prefix settings.
 # This requires either a shared library or that the PYTHON package is included.
 ###############################################################################
-if((BUILD_LIB AND BUILD_SHARED_LIBS) OR (PKG_PYTHON))
+if(BUILD_SHARED_LIBS) OR (PKG_PYTHON))
   if(CMAKE_VERSION VERSION_LESS 3.12)
     find_package(PythonInterp) # Deprecated since version 3.12
   else()
@@ -710,9 +688,7 @@ if (${_index} GREATER -1)
       C Flags:      ${CMAKE_C_FLAGS} ${CMAKE_C_FLAGS_${BTYPE}}")
 endif()
 message(STATUS "<<< Linker flags: >>>")
-if(BUILD_EXE)
 message(STATUS "Executable name:  ${LAMMPS_BINARY}")
-endif()
 if(CMAKE_EXE_LINKER_FLAGS)
   message(STATUS "Executable linker flags: ${CMAKE_EXE_LINKER_FLAGS}")
 endif()

cmake/Modules/Packages/GPU.cmake

@@ -200,7 +200,7 @@
   get_property(GPU_SOURCES GLOBAL PROPERTY GPU_SOURCES)
 
   target_link_libraries(gpu PRIVATE MPI::MPI_CXX)
-  if(BUILD_LIB AND NOT BUILD_SHARED_LIBS)
+  if(NOT BUILD_SHARED_LIBS)
     install(TARGETS gpu EXPORT LAMMPS_Targets LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
   endif()
   target_compile_definitions(gpu PRIVATE -DLAMMPS_${LAMMPS_SIZES})

cmake/Modules/Packages/MESSAGE.cmake

@@ -7,7 +7,7 @@ file(GLOB_RECURSE cslib_SOURCES ${LAMMPS_LIB_SOURCE_DIR}/message/cslib/[^.]*.F
     ${LAMMPS_LIB_SOURCE_DIR}/message/cslib/[^.]*.cpp)
 
 add_library(cslib STATIC ${cslib_SOURCES})
-if(BUILD_LIB AND NOT BUILD_SHARED_LIBS)
+if(NOT BUILD_SHARED_LIBS)
   install(TARGETS cslib EXPORT LAMMPS_Targets LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
 endif()
 target_compile_definitions(cslib PRIVATE -DLAMMPS_${LAMMPS_SIZES})

cmake/Modules/Packages/USER-COLVARS.cmake

@@ -9,7 +9,7 @@ if(COLVARS_LEPTON)
   set(LEPTON_DIR ${LAMMPS_LIB_SOURCE_DIR}/colvars/lepton)
   file(GLOB LEPTON_SOURCES ${LEPTON_DIR}/src/[^.]*.cpp)
   add_library(lepton STATIC ${LEPTON_SOURCES})
-  if(BUILD_LIB AND NOT BUILD_SHARED_LIBS)
+  if(NOT BUILD_SHARED_LIBS)
     install(TARGETS lepton EXPORT LAMMPS_Targets LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
   endif()
   set_target_properties(lepton PROPERTIES OUTPUT_NAME lammps_lepton${LAMMPS_LIB_SUFFIX})
@@ -17,7 +17,7 @@ if(COLVARS_LEPTON)
 endif()
 
 add_library(colvars STATIC ${COLVARS_SOURCES})
-if(BUILD_LIB AND NOT BUILD_SHARED_LIBS)
+if(NOT BUILD_SHARED_LIBS)
   install(TARGETS colvars EXPORT LAMMPS_Targets LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
 endif()
 target_compile_definitions(colvars PRIVATE -DLAMMPS_${LAMMPS_SIZES})

cmake/Modules/Packages/USER-MOLFILE.cmake

@@ -1,6 +1,6 @@
 set(MOLFILE_INCLUDE_DIRS "${LAMMPS_LIB_SOURCE_DIR}/molfile" CACHE STRING "Path to VMD molfile plugin headers")
 add_library(molfile INTERFACE)
-if(BUILD_LIB AND NOT BUILD_SHARED_LIBS)
+if(NOT BUILD_SHARED_LIBS)
   install(TARGETS molfile EXPORT LAMMPS_Targets LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
 endif()
 target_include_directories(molfile INTERFACE ${MOLFILE_INCLUDE_DIRS})

cmake/Modules/Packages/USER-QMMM.cmake

@@ -1,13 +1,10 @@
 enable_language(C)
 
-if(NOT BUILD_LIB)
-  message(FATAL_ERROR "Building a QM/MM executable with USER-QMMM requires BUILD_LIB=yes")
-endif()
 if(NOT BUILD_SHARED_LIBS)
   message(WARNING "It is recommended to use BUILD_SHARED_LIBS=yes with USER-QMMM")
 endif()
 add_library(qmmm STATIC ${LAMMPS_LIB_SOURCE_DIR}/qmmm/libqmmm.c)
-if(BUILD_LIB AND NOT BUILD_SHARED_LIBS)
+if(NOT BUILD_SHARED_LIBS)
   install(TARGETS qmmm EXPORT LAMMPS_Targets LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
 endif()
 set_target_properties(qmmm PROPERTIES OUTPUT_NAME lammps_qmmm${LAMMPS_LIB_SUFFIX})

cmake/Modules/Testing.cmake

@@ -2,7 +2,7 @@
 # Testing
 ###############################################################################
 option(ENABLE_TESTING "Enable testing" OFF)
-if(ENABLE_TESTING AND BUILD_EXE)
+if(ENABLE_TESTING)
   enable_testing()
   option(LAMMPS_TESTING_SOURCE_DIR "Location of lammps-testing source directory" "")
   option(LAMMPS_TESTING_GIT_TAG    "Git tag of lammps-testing" "master")

cmake/README.md

@@ -302,26 +302,6 @@ cmake -C ../cmake/presets/all_on.cmake -C ../cmake/presets/nolib.cmake -D PKG_GP
   </dl>
   </td>
 </tr>
-<tr>
-  <td><code>BUILD_LIB</code></td>
-  <td>control whether to build LAMMPS as a library</td>
-  <td>
-  <dl>
-    <dt><code>off</code> (default)</dt>
-    <dt><code>on</code></dt>
-  </dl>
-  </td>
-</tr>
-<tr>
-  <td><code>BUILD_EXE</code></td>
-  <td>control whether to build LAMMPS executable</td>
-  <td>
-  <dl>
-    <dt><code>on</code> (default)</dt>
-    <dt><code>off</code></dt>
-  </dl>
-  </td>
-</tr>
 <tr>
   <td><code>BUILD_SHARED_LIBS</code></td>
   <td>control whether to build LAMMPS as a shared-library</td>