From e26032115c57f6bc39d0a48a102dc807d35b9505 Mon Sep 17 00:00:00 2001 From: ekinaci Date: Wed, 28 Jun 2017 15:10:12 +0200 Subject: [PATCH 1/4] computes in case --- .../test_case/CFD/system/controlDict | 4 +- .../test_case/DEM/in.liggghts_run | 48 +++++++++---------- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/tutorials/cfdemSolverRhoPimpleChem/test_case/CFD/system/controlDict b/tutorials/cfdemSolverRhoPimpleChem/test_case/CFD/system/controlDict index 82d6e262..946debef 100644 --- a/tutorials/cfdemSolverRhoPimpleChem/test_case/CFD/system/controlDict +++ b/tutorials/cfdemSolverRhoPimpleChem/test_case/CFD/system/controlDict @@ -23,13 +23,13 @@ startTime 0; stopAt endTime; -endTime 5; +endTime 4000; deltaT 0.1; writeControl adjustableRunTime; //runTime;//// timeStep; // -writeInterval 0.5; +writeInterval 100; purgeWrite 0; diff --git a/tutorials/cfdemSolverRhoPimpleChem/test_case/DEM/in.liggghts_run b/tutorials/cfdemSolverRhoPimpleChem/test_case/DEM/in.liggghts_run index 2ab52e36..e1af20fa 100644 --- a/tutorials/cfdemSolverRhoPimpleChem/test_case/DEM/in.liggghts_run +++ b/tutorials/cfdemSolverRhoPimpleChem/test_case/DEM/in.liggghts_run @@ -64,7 +64,7 @@ fix Ea all property/global Ea_cfd5 vector 69488 73674 113859 # particle porosities adn tortuosity fix porosity all property/global porosity_ scalar 0.15 fix tortuosity all property/global tortuosity_ scalar 3 -fix pore_diameter all property/global pore_diameter_ scalar 0.00001 #3.91e-9 +fix pore_diameter all property/global pore_diameter_ scalar 3.91e-5 #0.00001 #3.91e-9 # Material properties for unreacted chemical shrink core (activate only when chem/shrink/core is active) fix density all property/global density_all vector 7870 5740 5170 5240 @@ -78,38 +78,38 @@ fix integr all nve/sphere ############################################### ## DEBUG ## -#compute masschange all property/atom mass -#compute massreduce all reduce sum c_masschange -#fix rmass all ave/time 100 1 100 c_massreduce file rmass.dat +compute masschange all property/atom mass +compute massreduce all reduce sum c_masschange +fix rmass all ave/time 100 1 100 c_massreduce file rmass.dat -#compute layerRad1 all reduce sum f_layerRelRad[1] -#fix redRad1 all ave/time 100 1 100 c_layerRad1 file relRad1.dat +compute layerRad1 all reduce sum f_layerRelRad[1] +fix redRad1 all ave/time 100 1 100 c_layerRad1 file relRad1.dat -#compute layerRad2 all reduce sum f_layerRelRad[2] -#fix redRad2 all ave/time 100 1 100 c_layerRad2 file relRad2.dat +compute layerRad2 all reduce sum f_layerRelRad[2] +fix redRad2 all ave/time 100 1 100 c_layerRad2 file relRad2.dat -#compute layerRad3 all reduce sum f_layerRelRad[3] -#fix redRad3 all ave/time 100 1 100 c_layerRad3 file relRad3.dat +compute layerRad3 all reduce sum f_layerRelRad[3] +fix redRad3 all ave/time 100 1 100 c_layerRad3 file relRad3.dat -#compute layerRad4 all reduce sum f_layerRelRad[4] -#fix redRad4 all ave/time 100 1 100 c_layerRad4 file relRad4.dat +compute layerRad4 all reduce sum f_layerRelRad[4] +fix redRad4 all ave/time 100 1 100 c_layerRad4 file relRad4.dat -#variable rad_fe atom "f_layerRelRad[1]*radius" -#compute r_fe all reduce sum v_rad_fe -#fix r_fe1 all ave/time 100 1 100 c_r_fe file rfe.dat +variable rad_fe atom "f_layerRelRad[1]*radius" +compute r_fe all reduce sum v_rad_fe +fix r_fe1 all ave/time 100 1 100 c_r_fe file rfe.dat -#variable rad_w atom "f_layerRelRad[2]*radius" -#compute r_w all reduce sum v_rad_w -#fix r_w1 all ave/time 100 1 100 c_r_w file rw.dat +variable rad_w atom "f_layerRelRad[2]*radius" +compute r_w all reduce sum v_rad_w +fix r_w1 all ave/time 100 1 100 c_r_w file rw.dat -#variable rad_m atom "f_layerRelRad[3]*radius" -#compute r_m all reduce sum v_rad_m -#fix r_m1 all ave/time 100 1 100 c_r_m file rm.dat +variable rad_m atom "f_layerRelRad[3]*radius" +compute r_m all reduce sum v_rad_m +fix r_m1 all ave/time 100 1 100 c_r_m file rm.dat -#variable rad_h atom "f_layerRelRad[4]*radius" -#compute r_h all reduce sum v_rad_h -#fix r_h1 all ave/time 100 1 100 c_r_h file rh.dat +variable rad_h atom "f_layerRelRad[4]*radius" +compute r_h all reduce sum v_rad_h +fix r_h1 all ave/time 100 1 100 c_r_h file rh.dat ############################################### # screen output From 069b824765665624efbbf7da572362c77720d2e6 Mon Sep 17 00:00:00 2001 From: ekinaci Date: Wed, 28 Jun 2017 15:48:57 +0200 Subject: [PATCH 2/4] add default names to chem. models as not to repeat in coup. props. --- .../diffusionCoefficients.C | 12 +++------ .../massTransferCoeff/massTransferCoeff.C | 8 +++--- .../chemistryModel/species/species.C | 27 +++++++++---------- .../test_case/CFD/constant/couplingProperties | 20 ++------------ 4 files changed, 23 insertions(+), 44 deletions(-) diff --git a/src/lagrangian/cfdemParticle/subModels/chemistryModel/diffusionCoefficients/diffusionCoefficients.C b/src/lagrangian/cfdemParticle/subModels/chemistryModel/diffusionCoefficients/diffusionCoefficients.C index ce5cf4cb..af4d419b 100644 --- a/src/lagrangian/cfdemParticle/subModels/chemistryModel/diffusionCoefficients/diffusionCoefficients.C +++ b/src/lagrangian/cfdemParticle/subModels/chemistryModel/diffusionCoefficients/diffusionCoefficients.C @@ -67,13 +67,13 @@ diffusionCoefficient::diffusionCoefficient ), // create a list from the Species table in the specified diffusionCoefficient dictionary speciesNames_(specDict_.lookup("species")), - tempFieldName_(propsDict_.lookup("tempFieldName")), + tempFieldName_(propsDict_.lookupOrDefault("tempFieldName","T")), tempField_(sm.mesh().lookupObject (tempFieldName_)), - pressureFieldName_(propsDict_.lookup("pressureFieldName")), + pressureFieldName_(propsDict_.lookupOrDefault("pressureFieldName","p")), P_(sm.mesh().lookupObject(pressureFieldName_)), - densityFieldName_(propsDict_.lookup("densityFieldName")), + densityFieldName_(propsDict_.lookupOrDefault("densityFieldName","rho")), rho_(sm.mesh().lookupObject (densityFieldName_)), - totalMoleFieldName_(propsDict_.lookup("totalMoleFieldName")), + totalMoleFieldName_(propsDict_.lookupOrDefault("totalMoleFieldName","N")), // needed to calculate the mixture diffusion coefficient // dcoeff is dependent on molar fraction not mass fraction N_(sm.mesh().lookupObject(totalMoleFieldName_)), @@ -81,10 +81,6 @@ diffusionCoefficient::diffusionCoefficient // X_(speciesNames_.size()), diffusantGasNames_(propsDict_.lookup("diffusantGasNames")), diffusionCoefficients_(diffusantGasNames_.size(),NULL) - /* diffusionCoefficientNames_(propsDict_.lookup("diffusionCoefficientNames")), - //volumeScalarFields created in the ts folders - diffusionCoefficients_(diffusionCoefficientNames_.size(),NULL), //the value of diffusionCoefficient concentration for every diffusionCoefficient - */ { Info << " Reading diffusionCoefficient list: " << diffusantGasNames_ << endl; for (int i = 0; i < diffusantGasNames_.size(); i++) diff --git a/src/lagrangian/cfdemParticle/subModels/chemistryModel/massTransferCoeff/massTransferCoeff.C b/src/lagrangian/cfdemParticle/subModels/chemistryModel/massTransferCoeff/massTransferCoeff.C index 1341cf33..f1623605 100644 --- a/src/lagrangian/cfdemParticle/subModels/chemistryModel/massTransferCoeff/massTransferCoeff.C +++ b/src/lagrangian/cfdemParticle/subModels/chemistryModel/massTransferCoeff/massTransferCoeff.C @@ -56,15 +56,15 @@ massTransferCoeff::massTransferCoeff verbose_(propsDict_.lookupOrDefault("verbose",false)), interpolation_(propsDict_.lookupOrDefault("interpolation",false)), mesh_(sm.mesh()), - velFieldName_(propsDict_.lookup("velFieldName")), + velFieldName_(propsDict_.lookupOrDefault("velFieldName","U")), U_(mesh_.lookupObject(velFieldName_)), - voidfractionFieldName_(propsDict_.lookup("voidfractionFieldName")), + voidfractionFieldName_(propsDict_.lookupOrDefault("voidfractionFieldName","voidfraction")), voidfraction_(sm.mesh().lookupObject (voidfractionFieldName_)), densityFieldName_(propsDict_.lookupOrDefault("densityFieldName","rho")), rho_(sm.mesh().lookupObject (densityFieldName_)), - partNuName_(propsDict_.lookup("partNu")), + partNuName_(propsDict_.lookupOrDefault("partViscos","partNu")), partNu_(NULL), - partReynolds_(propsDict_.lookup("partReynolds")), + partReynolds_(propsDict_.lookupOrDefault("partReynolds","partRe")), partRe_(NULL) {} diff --git a/src/lagrangian/cfdemParticle/subModels/chemistryModel/species/species.C b/src/lagrangian/cfdemParticle/subModels/chemistryModel/species/species.C index 58e0b8a3..3d197de1 100644 --- a/src/lagrangian/cfdemParticle/subModels/chemistryModel/species/species.C +++ b/src/lagrangian/cfdemParticle/subModels/chemistryModel/species/species.C @@ -86,20 +86,20 @@ species::species mesh_, dimensionedScalar("zero",dimMass/(dimVol*dimTime),0.0) ), - tempFieldName_(propsDict_.lookup("tempFieldName")), + tempFieldName_(propsDict_.lookupOrDefault("tempFieldName","T")), tempField_(sm.mesh().lookupObject (tempFieldName_)), - partTempName_(propsDict_.lookup("partTempName")), + partTempName_(propsDict_.lookupOrDefault("partTempName","partTemp")), partTemp_(NULL), - densityFieldName_(propsDict_.lookup("densityFieldName")), + densityFieldName_(propsDict_.lookupOrDefault("densityFieldName","rho")), rho_(sm.mesh().lookupObject (densityFieldName_)), - partRhoName_(propsDict_.lookup("partRhoName")), + partRhoName_(propsDict_.lookupOrDefault("partRhoName","partRho")), partRho_(NULL), - voidfractionFieldName_(propsDict_.lookup("voidfractionFieldName")), + voidfractionFieldName_(propsDict_.lookupOrDefault("voidfractionFieldName","voidfraction")), voidfraction_(sm.mesh().lookupObject(voidfractionFieldName_)), // total mole field - totalMoleFieldName_(propsDict_.lookup("totalMoleFieldName")), + totalMoleFieldName_(propsDict_.lookupOrDefault("totalMoleFieldName","N")), N_(sm.mesh().lookupObject(totalMoleFieldName_)), - partMoleName_(propsDict_.lookup("partMoleName")), + partMoleName_(propsDict_.lookupOrDefault("partMoleName","partN")), partN_(NULL), loopCounter_(-1), Nevery_(propsDict_.lookupOrDefault