Commit Graph

1933 Commits

Author SHA1 Message Date
7f5e596271 update .gitignore file
also ignore folders generated by compiling with icc
2022-02-08 09:42:38 +01:00
ff2ff4d251 Merge branch 'develop' of https://github.com/ParticulateFlow/CFDEMcoupling into develop 2022-01-19 09:50:46 +01:00
845cbdd34c Removed unnecessary voidfraction limiter. In this case, even negative values (from massive overpacking) could be tolerated and should be retained to conserve energy. 2022-01-14 09:10:39 +01:00
5f8ac39fad Removed unnecessary and wrong if-clause from FE. Would always return 1.0. Adapted reliable maximum voidfraction for B-B correlation. TODO: Check literature value from original publication. 2022-01-14 09:09:18 +01:00
257b9e0f02 Merge pull request #128 from ParticulateFlow/master
Updates from release 21.11
2022-01-11 12:40:23 +01:00
16a415a152 Merge pull request #125 from ParticulateFlow/release
Release 21.11
21.11
2022-01-11 11:26:26 +01:00
84842df79f fix whitespace 2022-01-11 09:52:58 +01:00
bc1dd9f5e8 fix run.config for vortex shedding test case 2022-01-10 16:26:49 +01:00
6cd16223d1 set log files for test case 2022-01-10 12:31:27 +01:00
c378a73650 explicitly set initial old-time values of rhoeps 2022-01-10 11:35:55 +01:00
62b22d191f bump version number to 21.11 [ci skip] 2021-12-23 17:44:34 +01:00
3c3f1d9651 add run.config file for vortex shedding test case
run configuration for test harness
2021-12-23 17:00:18 +01:00
6147878a1b add vortex shedding test case [ci skip]
add test case based on OpenFOAM tutorial by J. Guerrero to compare p, U,
T, rho from compressible rhoPimpleFoam solver to cfdemSolverRhoPimple
2021-12-23 16:54:55 +01:00
6995a3d7dc add pressure control values to fvSolution files [ci skip]
updated cfdemSolverRhoPimple requires pMin/pMax or pMinFactor/pMaxFactor
for pressure control (OF >= 5) instead of rhoMin/rhoMax (OF 4) for
density control
2021-12-23 16:16:24 +01:00
e010b9f966 bring cfdemSolverRhoPimple more in line with OpenFOAM 6 solver version
use pressure control instead of density control if available (i.e. for
OpenFOAM versions >= 5)
2021-12-23 16:00:46 +01:00
3667af9f56 bring cfdemSolverRhoPimple more in line with OF solver 2021-12-23 15:54:06 +01:00
7213a1d850 remove addSource field
defining the addSource term outside of EEqn for some reason causes
noticeable deviations from the solution produced by the OpenFOAM solver
2021-12-23 15:51:57 +01:00
9750720a5e activate correction in surfaceScalarField phiHbyA
activate correction for large time steps
2021-12-23 15:48:10 +01:00
5b3a148fcf create surfaceScalarField rhorAUf in one go
reduce numerical issues by avoidung multiple interpolations in case of
model 'A'
2021-12-23 15:45:36 +01:00
ae21c7e19a formatting 2021-12-23 15:42:39 +01:00
85e2964d0d just move around creation of rhoMax/rhoMin in createFields.H 2021-12-23 15:39:55 +01:00
3a12684d3b add average value to T ouput 2021-12-23 15:38:01 +01:00
e16e405828 move recalculation of rho in pEqn.H
just move calculation further down
add average value to output of rho
2021-12-23 15:37:12 +01:00
54db2db656 update rhoeps after rhoEqn.H 2021-12-23 15:33:23 +01:00
4bdb5f06d4 move update of rhoeps to pEqn.H 2021-12-23 15:29:31 +01:00
b8ccfb9986 move creation of field phi
to better match order in corresponding OpenFOAM solver and make
comparision easier
2021-12-23 15:26:33 +01:00
a271fd0aa0 create rhoeps field in createFields.H
this was a major issue:
rhoeps must be created outside the run loop and have old time values,
otherwise any time derivative will be zero, leading to incorrect results
2021-12-23 15:22:40 +01:00
30662789fa let parCFDrun() function decompose case for parallel CFD runs [ci skip]
analogous to parCFDDEMrun()
2021-12-21 16:39:27 +01:00
2fb7ca52a3 rename .gitkeep files to .gitignore [ci skip]
for consistency
2021-12-20 17:11:40 +01:00
5ec9393aba use Stefan-Boltzmann constant provided by OpenFOAM
Stefan-Boltzmann constant is already given via
Foam::constant::physicoChemical::sigma
no need to define it again
2021-12-20 16:55:54 +01:00
f72fcf68ba make prefactor in Ranz-Marshall correlation customizable
For a single sphere the data of Ranz suggests
2 + 0.6 * Re^(1/2) * Pr^(1/3)
but for gas flow through a packed bed of particles this may change to
2 + 1.8 * Re^(1/2) * Pr^(1/3)
cf. Kunii and Levenspiel, Fluidization Engineering (1991)
Hence, this commit will make this prefactor configurable in the
couplingProperties dict; if it is not set, use a value of 0.6 to retain
previous behavior;
Also, use the specialized math functions for square root and cube root
instead of the pow function;
2021-12-20 10:50:07 +01:00
ab3f69db66 Added monitoring field for fluid-phase heat conduction. 2021-12-09 06:56:18 +01:00
b5ab312744 Make sure cases without any chemistry models are initialized correctly. 2021-12-09 06:55:14 +01:00
a305383123 The former default value for massTransferModels_ caused a crash if no word list was provided. Works now. 2021-12-07 15:15:58 +01:00
640731e07d Merge branch 'develop' of https://github.com/ParticulateFlow/CFDEMcoupling into develop 2021-12-07 12:21:11 +01:00
ac1e4c5396 Minor fixes in MarkovPath. 2021-12-07 12:20:40 +01:00
2b5fba4ece clean up whitespaces [ci skip] 2021-12-06 13:13:12 +01:00
497ddb3120 let exit value of shell script indicate compilation result
if compilation of all solvers succeeded exit 0
else exit with number of failed solver compilations
2021-12-06 11:22:32 +01:00
b23b1aa0d2 fix compilation of solvers
commit 4897e9b759 was incomplete
2021-12-06 09:48:20 +01:00
4897e9b759 refactor createFields.H files to eliminate unused variable warnings
these warnings are mainly caused by postProcesss.H including
createFields.H in a sub-block
2021-12-06 07:59:58 +01:00
dec6d77baa remove unneeded options from solver Make file 2021-12-06 07:51:11 +01:00
fdc183abb4 remove duplicate entry from solver list [ci skip]
revert duplication introduced in commit 28aaa25
2021-12-03 20:36:58 +01:00
1576391e51 clean up test case file [ci skip] 2021-12-02 13:23:07 +01:00
5214948671 fix warning reorder
member initialization is executed in the order the members are defined
in the class, hence the member initializer list in the constructor
should be in the same order
2021-12-02 10:23:49 +01:00
981ff462c9 fix warning old-style-cast
use static_cast instead of old style cast
2021-12-02 10:14:56 +01:00
c39c0da9f4 add test case for particle-fluid convection using Ranz Marshall [ci skip] 2021-12-01 17:59:52 +01:00
6222d3b6bb [DOC] update list of available models 2021-12-01 14:58:33 +01:00
c626fa5c53 allow omission of massTransferModels list in couplingProperties dict
create an empty list if 'massTransferModels' list is not defined in
couplingProperties
2021-12-01 14:57:08 +01:00
a2f9772ce3 allow omission of diffCoeffModel in couplingProperties dict
if 'diffCoeffModel' is not defined in couplingProperties, create an
instance of noDiffCoeff ("off") and also do not try to read 'D' from
transportProperties dict
2021-12-01 14:52:54 +01:00
32283e8ac3 add a pull request template file [ci skip]
when creating a new pull request on GitHub, the pull request template file is used to provide default text for the pull request description;
must be present in the default branch (e.g. master or main) of the repository to take effect;
2021-11-30 10:22:11 +01:00