PatchFields: Removed simple copy constructors and clone functions

These do not necessarily set the internal field reference correctly and it is
safer that the correct internal field is provided as an argument.

applications/solvers/compressible/rhoCentralFoam/BCs/T/smoluchowskiJumpTFvPatchScalarField.H

@@ -107,15 +107,6 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new smoluchowskiJumpTFvPatchScalarField(*this)
-            );
-        }
-
         //- Construct as copy setting internal field reference
         smoluchowskiJumpTFvPatchScalarField
         (

applications/solvers/compressible/rhoCentralFoam/BCs/U/maxwellSlipUFvPatchVectorField.H

@@ -115,15 +115,6 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual tmp<fvPatchVectorField> clone() const
-        {
-            return tmp<fvPatchVectorField>
-            (
-                new maxwellSlipUFvPatchVectorField(*this)
-            );
-        }
-
         //- Construct as copy setting internal field reference
         maxwellSlipUFvPatchVectorField
         (

applications/solvers/compressible/rhoCentralFoam/BCs/mixedFixedValueSlip/mixedFixedValueSlipFvPatchField.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2019 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2020 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -70,18 +70,6 @@ Foam::mixedFixedValueSlipFvPatchField<Type>::mixedFixedValueSlipFvPatchField
 {}
 
 
-template<class Type>
-Foam::mixedFixedValueSlipFvPatchField<Type>::mixedFixedValueSlipFvPatchField
-(
-    const mixedFixedValueSlipFvPatchField<Type>& ptf
-)
-:
-    transformFvPatchField<Type>(ptf),
-    refValue_(ptf.refValue_),
-    valueFraction_(ptf.valueFraction_)
-{}
-
-
 template<class Type>
 Foam::mixedFixedValueSlipFvPatchField<Type>::mixedFixedValueSlipFvPatchField
 (

applications/solvers/compressible/rhoCentralFoam/BCs/mixedFixedValueSlip/mixedFixedValueSlipFvPatchField.H

@@ -94,20 +94,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         mixedFixedValueSlipFvPatchField
         (
             const mixedFixedValueSlipFvPatchField<Type>&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchField<Type>> clone() const
-        {
-            return tmp<fvPatchField<Type>>
-            (
-                new mixedFixedValueSlipFvPatchField<Type>(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         mixedFixedValueSlipFvPatchField

applications/solvers/compressible/rhoCentralFoam/BCs/rho/fixedRhoFvPatchScalarField.H

@@ -121,15 +121,6 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new fixedRhoFvPatchScalarField(*this)
-            );
-        }
-
         //- Copy constructor setting internal field reference
         fixedRhoFvPatchScalarField
         (

applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointOutletPressure/adjointOutletPressureFvPatchScalarField.H

@@ -83,15 +83,6 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new adjointOutletPressureFvPatchScalarField(*this)
-            );
-        }
-
         //- Construct as copy setting internal field reference
         adjointOutletPressureFvPatchScalarField
         (

applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointOutletVelocity/adjointOutletVelocityFvPatchVectorField.H

@@ -83,15 +83,6 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual tmp<fvPatchVectorField> clone() const
-        {
-            return tmp<fvPatchVectorField>
-            (
-                new adjointOutletVelocityFvPatchVectorField(*this)
-            );
-        }
-
         //- Construct as copy setting internal field reference
         adjointOutletVelocityFvPatchVectorField
         (

applications/solvers/multiphase/compressibleMultiphaseInterFoam/multiphaseMixtureThermo/alphaContactAngle/alphaContactAngleFvPatchScalarField.H

@@ -162,15 +162,6 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new alphaContactAngleFvPatchScalarField(*this)
-            );
-        }
-
         //- Construct as copy setting internal field reference
         alphaContactAngleFvPatchScalarField
         (

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/JohnsonJacksonParticleSlip/JohnsonJacksonParticleSlipFvPatchVectorField.C

@@ -101,17 +101,6 @@ JohnsonJacksonParticleSlipFvPatchVectorField
 }
 
 
-Foam::JohnsonJacksonParticleSlipFvPatchVectorField::
-JohnsonJacksonParticleSlipFvPatchVectorField
-(
-    const JohnsonJacksonParticleSlipFvPatchVectorField& ptf
-)
-:
-    partialSlipFvPatchVectorField(ptf),
-    specularityCoefficient_(ptf.specularityCoefficient_)
-{}
-
-
 Foam::JohnsonJacksonParticleSlipFvPatchVectorField::
 JohnsonJacksonParticleSlipFvPatchVectorField
 (

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/JohnsonJacksonParticleSlip/JohnsonJacksonParticleSlipFvPatchVectorField.H

@@ -104,20 +104,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         JohnsonJacksonParticleSlipFvPatchVectorField
         (
             const JohnsonJacksonParticleSlipFvPatchVectorField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchVectorField> clone() const
-        {
-            return tmp<fvPatchVectorField>
-            (
-                new JohnsonJacksonParticleSlipFvPatchVectorField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         JohnsonJacksonParticleSlipFvPatchVectorField

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/JohnsonJacksonParticleTheta/JohnsonJacksonParticleThetaFvPatchScalarField.C

@@ -120,18 +120,6 @@ JohnsonJacksonParticleThetaFvPatchScalarField
 }
 
 
-Foam::JohnsonJacksonParticleThetaFvPatchScalarField::
-JohnsonJacksonParticleThetaFvPatchScalarField
-(
-    const JohnsonJacksonParticleThetaFvPatchScalarField& ptf
-)
-:
-    mixedFvPatchScalarField(ptf),
-    restitutionCoefficient_(ptf.restitutionCoefficient_),
-    specularityCoefficient_(ptf.specularityCoefficient_)
-{}
-
-
 Foam::JohnsonJacksonParticleThetaFvPatchScalarField::
 JohnsonJacksonParticleThetaFvPatchScalarField
 (

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/JohnsonJacksonParticleTheta/JohnsonJacksonParticleThetaFvPatchScalarField.H

@@ -107,20 +107,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         JohnsonJacksonParticleThetaFvPatchScalarField
         (
             const JohnsonJacksonParticleThetaFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new JohnsonJacksonParticleThetaFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         JohnsonJacksonParticleThetaFvPatchScalarField

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/alphatFixedDmdtfWallBoilingWallFunction/alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField.C

@@ -81,17 +81,6 @@ alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField
 {}
 
 
-alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField::
-alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField
-(
-    const alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField& psf
-)
-:
-    alphatPhaseChangeWallFunctionFvPatchScalarField(psf),
-    fixedDmdtf_(psf.fixedDmdtf_)
-{}
-
-
 alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField::
 alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField
 (

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/alphatFixedDmdtfWallBoilingWallFunction/alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField.H

@@ -97,23 +97,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField
         (
             const alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField
-                (
-                    *this
-                )
-            );
-        }
 
         //- Copy constructor setting internal field reference
         alphatFixedDmdtfWallBoilingWallFunctionFvPatchScalarField

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/alphatPhaseChangeWallFunction/alphatPhaseChangeWallFunctionFvPatchScalarField.C

@@ -102,19 +102,6 @@ alphatPhaseChangeWallFunctionFvPatchScalarField
 {}
 
 
-alphatPhaseChangeWallFunctionFvPatchScalarField::
-alphatPhaseChangeWallFunctionFvPatchScalarField
-(
-    const alphatPhaseChangeWallFunctionFvPatchScalarField& awfpsf
-)
-:
-    alphatPhaseJayatillekeWallFunctionFvPatchScalarField(awfpsf),
-    otherPhaseName_(awfpsf.otherPhaseName_),
-    relax_(awfpsf.relax_),
-    dmdtf_(awfpsf.dmdtf_)
-{}
-
-
 alphatPhaseChangeWallFunctionFvPatchScalarField::
 alphatPhaseChangeWallFunctionFvPatchScalarField
 (

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/alphatPhaseChangeWallFunction/alphatPhaseChangeWallFunctionFvPatchScalarField.H

@@ -104,11 +104,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         alphatPhaseChangeWallFunctionFvPatchScalarField
         (
             const alphatPhaseChangeWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
 
         //- Copy constructor setting internal field reference
         alphatPhaseChangeWallFunctionFvPatchScalarField

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/alphatPhaseJayatillekeWallFunction/alphatPhaseJayatillekeWallFunctionFvPatchScalarField.C

@@ -137,18 +137,6 @@ alphatPhaseJayatillekeWallFunctionFvPatchScalarField
 {}
 
 
-
-alphatPhaseJayatillekeWallFunctionFvPatchScalarField::
-alphatPhaseJayatillekeWallFunctionFvPatchScalarField
-(
-    const alphatPhaseJayatillekeWallFunctionFvPatchScalarField& awfpsf
-)
-:
-    fixedValueFvPatchScalarField(awfpsf),
-    Prt_(awfpsf.Prt_)
-{}
-
-
 alphatPhaseJayatillekeWallFunctionFvPatchScalarField::
 alphatPhaseJayatillekeWallFunctionFvPatchScalarField
 (

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/alphatPhaseJayatillekeWallFunction/alphatPhaseJayatillekeWallFunctionFvPatchScalarField.H

@@ -143,23 +143,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         alphatPhaseJayatillekeWallFunctionFvPatchScalarField
         (
             const alphatPhaseJayatillekeWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new alphatPhaseJayatillekeWallFunctionFvPatchScalarField
-                (
-                    *this
-                )
-            );
-        }
 
         //- Copy constructor setting internal field reference
         alphatPhaseJayatillekeWallFunctionFvPatchScalarField

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/alphatWallBoilingWallFunction/alphatWallBoilingWallFunctionFvPatchScalarField.C

@@ -220,25 +220,6 @@ alphatWallBoilingWallFunctionFvPatchScalarField
 {}
 
 
-alphatWallBoilingWallFunctionFvPatchScalarField::
-alphatWallBoilingWallFunctionFvPatchScalarField
-(
-    const alphatWallBoilingWallFunctionFvPatchScalarField& psf
-)
-:
-    alphatPhaseChangeWallFunctionFvPatchScalarField(psf),
-    phaseType_(psf.phaseType_),
-    AbyV_(psf.AbyV_),
-    alphatConv_(psf.alphatConv_),
-    dDep_(psf.dDep_),
-    qq_(psf.qq_),
-    partitioningModel_(psf.partitioningModel_, false),
-    nucleationSiteModel_(psf.nucleationSiteModel_, false),
-    departureDiamModel_(psf.departureDiamModel_, false),
-    departureFreqModel_(psf.departureFreqModel_, false)
-{}
-
-
 alphatWallBoilingWallFunctionFvPatchScalarField::
 alphatWallBoilingWallFunctionFvPatchScalarField
 (

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/alphatWallBoilingWallFunction/alphatWallBoilingWallFunctionFvPatchScalarField.H

@@ -239,20 +239,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         alphatWallBoilingWallFunctionFvPatchScalarField
         (
             const alphatWallBoilingWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new alphatWallBoilingWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         alphatWallBoilingWallFunctionFvPatchScalarField

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/copiedFixedValue/copiedFixedValueFvPatchScalarField.C

@@ -66,16 +66,6 @@ Foam::copiedFixedValueFvPatchScalarField::copiedFixedValueFvPatchScalarField
 {}
 
 
-Foam::copiedFixedValueFvPatchScalarField::copiedFixedValueFvPatchScalarField
-(
-    const copiedFixedValueFvPatchScalarField& awfpsf
-)
-:
-    fixedValueFvPatchScalarField(awfpsf),
-    sourceFieldName_(awfpsf.sourceFieldName_)
-{}
-
-
 Foam::copiedFixedValueFvPatchScalarField::copiedFixedValueFvPatchScalarField
 (
     const copiedFixedValueFvPatchScalarField& awfpsf,

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/copiedFixedValue/copiedFixedValueFvPatchScalarField.H

@@ -93,20 +93,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         copiedFixedValueFvPatchScalarField
         (
             const copiedFixedValueFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new copiedFixedValueFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         copiedFixedValueFvPatchScalarField

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/fixedMultiPhaseHeatFlux/fixedMultiPhaseHeatFluxFvPatchScalarField.C

@@ -78,19 +78,6 @@ fixedMultiPhaseHeatFluxFvPatchScalarField
 {}
 
 
-Foam::fixedMultiPhaseHeatFluxFvPatchScalarField::
-fixedMultiPhaseHeatFluxFvPatchScalarField
-(
-    const fixedMultiPhaseHeatFluxFvPatchScalarField& psf
-)
-:
-    fixedValueFvPatchScalarField(psf),
-    q_(psf.q_),
-    relax_(psf.relax_),
-    Tmin_(psf.Tmin_)
-{}
-
-
 Foam::fixedMultiPhaseHeatFluxFvPatchScalarField::
 fixedMultiPhaseHeatFluxFvPatchScalarField
 (

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseCompressibleMomentumTransportModels/derivedFvPatchFields/fixedMultiPhaseHeatFlux/fixedMultiPhaseHeatFluxFvPatchScalarField.H

@@ -105,20 +105,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         fixedMultiPhaseHeatFluxFvPatchScalarField
         (
             const fixedMultiPhaseHeatFluxFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new fixedMultiPhaseHeatFluxFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         fixedMultiPhaseHeatFluxFvPatchScalarField

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseEulerFoam/pU/pEqn.H

@@ -212,8 +212,13 @@ while (pimple.correct())
 
     // Update the fixedFluxPressure BCs to ensure flux consistency
     {
-        surfaceScalarField::Boundary phib(phi.boundaryField());
+        surfaceScalarField::Boundary phib
+        (
+            surfaceScalarField::Internal::null(),
+            phi.boundaryField()
+        );
         phib = 0;
+
         forAll(phases, phasei)
         {
             phaseModel& phase = phases[phasei];

applications/solvers/multiphase/multiphaseEulerFoam/multiphaseEulerFoam/pUf/pEqn.H

@@ -195,8 +195,13 @@ while (pimple.correct())
 
     // Update the fixedFluxPressure BCs to ensure flux consistency
     {
-        surfaceScalarField::Boundary phib(phi.boundaryField());
+        surfaceScalarField::Boundary phib
+        (
+            surfaceScalarField::Internal::null(),
+            phi.boundaryField()
+        );
         phib = 0;
+
         forAll(phases, phasei)
         {
             phaseModel& phase = phases[phasei];

applications/solvers/multiphase/multiphaseEulerFoam/phaseSystems/alphaContactAngle/alphaContactAngleFvPatchScalarField.H

@@ -162,15 +162,6 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new alphaContactAngleFvPatchScalarField(*this)
-            );
-        }
-
         //- Construct as copy setting internal field reference
         alphaContactAngleFvPatchScalarField
         (

applications/solvers/multiphase/multiphaseInterFoam/multiphaseMixture/alphaContactAngle/alphaContactAngleFvPatchScalarField.H

@@ -162,15 +162,6 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new alphaContactAngleFvPatchScalarField(*this)
-            );
-        }
-
         //- Construct as copy setting internal field reference
         alphaContactAngleFvPatchScalarField
         (

applications/solvers/stressAnalysis/solidDisplacementFoam/derivedFvPatchFields/hydrostaticDisplacement/hydrostaticDisplacementFvPatchVectorField.C

@@ -74,19 +74,6 @@ hydrostaticDisplacementFvPatchVectorField
 {}
 
 
-Foam::hydrostaticDisplacementFvPatchVectorField::
-hydrostaticDisplacementFvPatchVectorField
-(
-    const hydrostaticDisplacementFvPatchVectorField& tdpvf
-)
-:
-    tractionDisplacementFvPatchVectorField(tdpvf),
-    rhoLiquid_(tdpvf.rhoLiquid_),
-    liquidSurfacePressure_(tdpvf.liquidSurfacePressure_),
-    liquidSurfacePoint_(tdpvf.liquidSurfacePoint_)
-{}
-
-
 Foam::hydrostaticDisplacementFvPatchVectorField::
 hydrostaticDisplacementFvPatchVectorField
 (

applications/solvers/stressAnalysis/solidDisplacementFoam/derivedFvPatchFields/hydrostaticDisplacement/hydrostaticDisplacementFvPatchVectorField.H

@@ -97,20 +97,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         hydrostaticDisplacementFvPatchVectorField
         (
             const hydrostaticDisplacementFvPatchVectorField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchVectorField> clone() const
-        {
-            return tmp<fvPatchVectorField>
-            (
-                new hydrostaticDisplacementFvPatchVectorField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         hydrostaticDisplacementFvPatchVectorField

applications/solvers/stressAnalysis/solidDisplacementFoam/derivedFvPatchFields/tractionDisplacement/tractionDisplacementFvPatchVectorField.C

@@ -76,18 +76,6 @@ tractionDisplacementFvPatchVectorField
 {}
 
 
-Foam::tractionDisplacementFvPatchVectorField::
-tractionDisplacementFvPatchVectorField
-(
-    const tractionDisplacementFvPatchVectorField& tdpvf
-)
-:
-    fixedGradientFvPatchVectorField(tdpvf),
-    traction_(tdpvf.traction_),
-    pressure_(tdpvf.pressure_, false)
-{}
-
-
 Foam::tractionDisplacementFvPatchVectorField::
 tractionDisplacementFvPatchVectorField
 (

applications/solvers/stressAnalysis/solidDisplacementFoam/derivedFvPatchFields/tractionDisplacement/tractionDisplacementFvPatchVectorField.H

@@ -98,20 +98,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         tractionDisplacementFvPatchVectorField
         (
             const tractionDisplacementFvPatchVectorField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchVectorField> clone() const
-        {
-            return tmp<fvPatchVectorField>
-            (
-                new tractionDisplacementFvPatchVectorField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         tractionDisplacementFvPatchVectorField

applications/solvers/stressAnalysis/solidDisplacementFoam/solidEquilibriumDisplacementFoam/tractionDisplacementCorrection/tractionDisplacementCorrectionFvPatchVectorField.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2019 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2020 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -82,18 +82,6 @@ tractionDisplacementCorrectionFvPatchVectorField
 }
 
 
-tractionDisplacementCorrectionFvPatchVectorField::
-tractionDisplacementCorrectionFvPatchVectorField
-(
-    const tractionDisplacementCorrectionFvPatchVectorField& tdpvf
-)
-:
-    fixedGradientFvPatchVectorField(tdpvf),
-    traction_(tdpvf.traction_),
-    pressure_(tdpvf.pressure_)
-{}
-
-
 tractionDisplacementCorrectionFvPatchVectorField::
 tractionDisplacementCorrectionFvPatchVectorField
 (

applications/solvers/stressAnalysis/solidDisplacementFoam/solidEquilibriumDisplacementFoam/tractionDisplacementCorrection/tractionDisplacementCorrectionFvPatchVectorField.H

@@ -90,20 +90,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Construct as copy setting internal field reference
+        //- Disallow copy without setting internal field reference
         tractionDisplacementCorrectionFvPatchVectorField
         (
             const tractionDisplacementCorrectionFvPatchVectorField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchVectorField> clone() const
-        {
-            return tmp<fvPatchVectorField>
-            (
-                new tractionDisplacementCorrectionFvPatchVectorField(*this)
-            );
-        }
 
         //- Construct as copy setting internal field reference
         tractionDisplacementCorrectionFvPatchVectorField

etc/codeTemplates/dynamicCode/fixedValueFvPatchFieldTemplate.C

@@ -137,22 +137,6 @@ ${typeName}FixedValueFvPatch${FieldType}
 }
 
 
-${typeName}FixedValueFvPatch${FieldType}::
-${typeName}FixedValueFvPatch${FieldType}
-(
-    const ${typeName}FixedValueFvPatch${FieldType}& ptf
-)
-:
-    fixedValueFvPatchField<${TemplateType}>(ptf)
-{
-    if (${verbose:-false})
-    {
-        Info<<"construct ${typeName} sha1: ${SHA1sum}"
-            " as copy\n";
-    }
-}
-
-
 ${typeName}FixedValueFvPatch${FieldType}::
 ${typeName}FixedValueFvPatch${FieldType}
 (

etc/codeTemplates/dynamicCode/fixedValueFvPatchFieldTemplate.H

@@ -85,20 +85,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         ${typeName}FixedValueFvPatch${FieldType}
         (
             const ${typeName}FixedValueFvPatch${FieldType}&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatch${FieldType} > clone() const
-        {
-            return tmp<fvPatch${FieldType} >
-            (
-                new ${typeName}FixedValueFvPatch${FieldType}(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         ${typeName}FixedValueFvPatch${FieldType}

etc/codeTemplates/dynamicCode/fixedValuePointPatchFieldTemplate.C

@@ -136,22 +136,6 @@ ${typeName}FixedValuePointPatch${FieldType}
 }
 
 
-${typeName}FixedValuePointPatch${FieldType}::
-${typeName}FixedValuePointPatch${FieldType}
-(
-    const ${typeName}FixedValuePointPatch${FieldType}& ptf
-)
-:
-    fixedValuePointPatchField<${TemplateType}>(ptf)
-{
-    if (${verbose:-false})
-    {
-        Info<<"construct ${typeName} sha1: ${SHA1sum}"
-            " as copy\n";
-    }
-}
-
-
 ${typeName}FixedValuePointPatch${FieldType}::
 ${typeName}FixedValuePointPatch${FieldType}
 (

etc/codeTemplates/dynamicCode/fixedValuePointPatchFieldTemplate.H

@@ -85,20 +85,11 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         ${typeName}FixedValuePointPatch${FieldType}
         (
             const ${typeName}FixedValuePointPatch${FieldType}&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<${TemplateType}>> clone() const
-        {
-            return autoPtr<pointPatchField<${TemplateType}>>
-            (
-                new ${typeName}FixedValuePointPatch${FieldType}(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         ${typeName}FixedValuePointPatch${FieldType}

etc/codeTemplates/dynamicCode/mixedFvPatchFieldTemplate.C

@@ -137,22 +137,6 @@ ${typeName}MixedValueFvPatch${FieldType}
 }
 
 
-${typeName}MixedValueFvPatch${FieldType}::
-${typeName}MixedValueFvPatch${FieldType}
-(
-    const ${typeName}MixedValueFvPatch${FieldType}& ptf
-)
-:
-    mixedFvPatchField<${TemplateType}>(ptf)
-{
-    if (${verbose:-false})
-    {
-        Info<<"construct ${typeName} sha1: ${SHA1sum}"
-            " as copy\n";
-    }
-}
-
-
 ${typeName}MixedValueFvPatch${FieldType}::
 ${typeName}MixedValueFvPatch${FieldType}
 (

etc/codeTemplates/dynamicCode/mixedFvPatchFieldTemplate.H

@@ -85,20 +85,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         ${typeName}MixedValueFvPatch${FieldType}
         (
             const ${typeName}MixedValueFvPatch${FieldType}&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatch${FieldType} > clone() const
-        {
-            return tmp<fvPatch${FieldType} >
-            (
-                new ${typeName}MixedValueFvPatch${FieldType}(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         ${typeName}MixedValueFvPatch${FieldType}

src/MomentumTransportModels/momentumTransportModels/RAS/derivedFvPatchFields/turbulentMixingLengthDissipationRateInlet/turbulentMixingLengthDissipationRateInletFvPatchScalarField.C

@@ -91,18 +91,6 @@ turbulentMixingLengthDissipationRateInletFvPatchScalarField
 }
 
 
-turbulentMixingLengthDissipationRateInletFvPatchScalarField::
-turbulentMixingLengthDissipationRateInletFvPatchScalarField
-(
-    const turbulentMixingLengthDissipationRateInletFvPatchScalarField& ptf
-)
-:
-    inletOutletFvPatchScalarField(ptf),
-    mixingLength_(ptf.mixingLength_),
-    kName_(ptf.kName_)
-{}
-
-
 turbulentMixingLengthDissipationRateInletFvPatchScalarField::
 turbulentMixingLengthDissipationRateInletFvPatchScalarField
 (

src/MomentumTransportModels/momentumTransportModels/RAS/derivedFvPatchFields/turbulentMixingLengthDissipationRateInlet/turbulentMixingLengthDissipationRateInletFvPatchScalarField.H

@@ -132,23 +132,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         turbulentMixingLengthDissipationRateInletFvPatchScalarField
         (
             const turbulentMixingLengthDissipationRateInletFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new turbulentMixingLengthDissipationRateInletFvPatchScalarField
-                (
-                    *this
-                )
-            );
-        }
 
         //- Copy constructor setting internal field reference
         turbulentMixingLengthDissipationRateInletFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/RAS/derivedFvPatchFields/turbulentMixingLengthFrequencyInlet/turbulentMixingLengthFrequencyInletFvPatchScalarField.C

@@ -53,6 +53,7 @@ turbulentMixingLengthFrequencyInletFvPatchScalarField
     this->valueFraction() = 0.0;
 }
 
+
 turbulentMixingLengthFrequencyInletFvPatchScalarField::
 turbulentMixingLengthFrequencyInletFvPatchScalarField
 (
@@ -67,6 +68,7 @@ turbulentMixingLengthFrequencyInletFvPatchScalarField
     kName_(ptf.kName_)
 {}
 
+
 turbulentMixingLengthFrequencyInletFvPatchScalarField::
 turbulentMixingLengthFrequencyInletFvPatchScalarField
 (
@@ -88,16 +90,6 @@ turbulentMixingLengthFrequencyInletFvPatchScalarField
     this->valueFraction() = 0.0;
 }
 
-turbulentMixingLengthFrequencyInletFvPatchScalarField::
-turbulentMixingLengthFrequencyInletFvPatchScalarField
-(
-    const turbulentMixingLengthFrequencyInletFvPatchScalarField& ptf
-)
-:
-    inletOutletFvPatchScalarField(ptf),
-    mixingLength_(ptf.mixingLength_),
-    kName_(ptf.kName_)
-{}
 
 turbulentMixingLengthFrequencyInletFvPatchScalarField::
 turbulentMixingLengthFrequencyInletFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/RAS/derivedFvPatchFields/turbulentMixingLengthFrequencyInlet/turbulentMixingLengthFrequencyInletFvPatchScalarField.H

@@ -133,23 +133,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         turbulentMixingLengthFrequencyInletFvPatchScalarField
         (
             const turbulentMixingLengthFrequencyInletFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new turbulentMixingLengthFrequencyInletFvPatchScalarField
-                (
-                    *this
-                )
-            );
-        }
 
         //- Copy constructor setting internal field reference
         turbulentMixingLengthFrequencyInletFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/fixedShearStress/fixedShearStressFvPatchVectorField.C

@@ -70,16 +70,6 @@ Foam::fixedShearStressFvPatchVectorField::fixedShearStressFvPatchVectorField
 {}
 
 
-Foam::fixedShearStressFvPatchVectorField::fixedShearStressFvPatchVectorField
-(
-    const fixedShearStressFvPatchVectorField& ptf
-)
-:
-    fixedValueFvPatchVectorField(ptf),
-    tau0_(ptf.tau0_)
-{}
-
-
 Foam::fixedShearStressFvPatchVectorField::fixedShearStressFvPatchVectorField
 (
     const fixedShearStressFvPatchVectorField& ptf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/fixedShearStress/fixedShearStressFvPatchVectorField.H

@@ -89,20 +89,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         fixedShearStressFvPatchVectorField
         (
             const fixedShearStressFvPatchVectorField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchVectorField> clone() const
-        {
-            return tmp<fvPatchVectorField>
-            (
-                new fixedShearStressFvPatchVectorField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         fixedShearStressFvPatchVectorField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/porousBafflePressure/porousBafflePressureFvPatchField.C

@@ -83,20 +83,6 @@ Foam::porousBafflePressureFvPatchField::porousBafflePressureFvPatchField
 {}
 
 
-Foam::porousBafflePressureFvPatchField::porousBafflePressureFvPatchField
-(
-    const porousBafflePressureFvPatchField& ptf
-)
-:
-    fixedJumpFvPatchField<scalar>(ptf),
-    phiName_(ptf.phiName_),
-    rhoName_(ptf.rhoName_),
-    D_(ptf.D_),
-    I_(ptf.I_),
-    length_(ptf.length_)
-{}
-
-
 Foam::porousBafflePressureFvPatchField::porousBafflePressureFvPatchField
 (
     const porousBafflePressureFvPatchField& ptf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/porousBafflePressure/porousBafflePressureFvPatchField.H

@@ -148,20 +148,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         porousBafflePressureFvPatchField
         (
             const porousBafflePressureFvPatchField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchField<scalar>> clone() const
-        {
-            return tmp<fvPatchField<scalar>>
-            (
-                new porousBafflePressureFvPatchField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         porousBafflePressureFvPatchField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/epsilonWallFunctions/epsilonWallFunction/epsilonWallFunctionFvPatchScalarField.C

@@ -286,21 +286,6 @@ epsilonWallFunctionFvPatchScalarField
 {}
 
 
-Foam::epsilonWallFunctionFvPatchScalarField::
-epsilonWallFunctionFvPatchScalarField
-(
-    const epsilonWallFunctionFvPatchScalarField& ewfpsf
-)
-:
-    fixedValueFvPatchField<scalar>(ewfpsf),
-    G_(),
-    epsilon_(),
-    initialised_(false),
-    master_(-1),
-    cornerWeights_()
-{}
-
-
 Foam::epsilonWallFunctionFvPatchScalarField::
 epsilonWallFunctionFvPatchScalarField
 (

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/epsilonWallFunctions/epsilonWallFunction/epsilonWallFunctionFvPatchScalarField.H

@@ -179,20 +179,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         epsilonWallFunctionFvPatchScalarField
         (
             const epsilonWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new epsilonWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         epsilonWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/fWallFunctions/fWallFunction/fWallFunctionFvPatchScalarField.C

@@ -71,15 +71,6 @@ fWallFunctionFvPatchScalarField::fWallFunctionFvPatchScalarField
 {}
 
 
-fWallFunctionFvPatchScalarField::fWallFunctionFvPatchScalarField
-(
-    const fWallFunctionFvPatchScalarField& v2wfpsf
-)
-:
-    fixedValueFvPatchField<scalar>(v2wfpsf)
-{}
-
-
 fWallFunctionFvPatchScalarField::fWallFunctionFvPatchScalarField
 (
     const fWallFunctionFvPatchScalarField& v2wfpsf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/fWallFunctions/fWallFunction/fWallFunctionFvPatchScalarField.H

@@ -103,20 +103,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         fWallFunctionFvPatchScalarField
         (
             const fWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new fWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         fWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/kqRWallFunctions/kLowReWallFunction/kLowReWallFunctionFvPatchScalarField.C

@@ -71,16 +71,6 @@ kLowReWallFunctionFvPatchScalarField::kLowReWallFunctionFvPatchScalarField
 {}
 
 
-kLowReWallFunctionFvPatchScalarField::kLowReWallFunctionFvPatchScalarField
-(
-    const kLowReWallFunctionFvPatchScalarField& kwfpsf
-)
-:
-    fixedValueFvPatchField<scalar>(kwfpsf),
-    Ceps2_(kwfpsf.Ceps2_)
-{}
-
-
 kLowReWallFunctionFvPatchScalarField::kLowReWallFunctionFvPatchScalarField
 (
     const kLowReWallFunctionFvPatchScalarField& kwfpsf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/kqRWallFunctions/kLowReWallFunction/kLowReWallFunctionFvPatchScalarField.H

@@ -113,20 +113,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         kLowReWallFunctionFvPatchScalarField
         (
             const kLowReWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new kLowReWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         kLowReWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/kqRWallFunctions/kqRWallFunction/kqRWallFunctionFvPatchField.C

@@ -64,16 +64,6 @@ Foam::kqRWallFunctionFvPatchField<Type>::kqRWallFunctionFvPatchField
 {}
 
 
-template<class Type>
-Foam::kqRWallFunctionFvPatchField<Type>::kqRWallFunctionFvPatchField
-(
-    const kqRWallFunctionFvPatchField& tkqrwfpf
-)
-:
-    zeroGradientFvPatchField<Type>(tkqrwfpf)
-{}
-
-
 template<class Type>
 Foam::kqRWallFunctionFvPatchField<Type>::kqRWallFunctionFvPatchField
 (

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/kqRWallFunctions/kqRWallFunction/kqRWallFunctionFvPatchField.H

@@ -102,20 +102,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         kqRWallFunctionFvPatchField
         (
             const kqRWallFunctionFvPatchField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchField<Type>> clone() const
-        {
-            return tmp<fvPatchField<Type>>
-            (
-                new kqRWallFunctionFvPatchField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         kqRWallFunctionFvPatchField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutLowReWallFunction/nutLowReWallFunctionFvPatchScalarField.C

@@ -77,15 +77,6 @@ nutLowReWallFunctionFvPatchScalarField::nutLowReWallFunctionFvPatchScalarField
 {}
 
 
-nutLowReWallFunctionFvPatchScalarField::nutLowReWallFunctionFvPatchScalarField
-(
-    const nutLowReWallFunctionFvPatchScalarField& nlrwfpsf
-)
-:
-    nutWallFunctionFvPatchScalarField(nlrwfpsf)
-{}
-
-
 nutLowReWallFunctionFvPatchScalarField::nutLowReWallFunctionFvPatchScalarField
 (
     const nutLowReWallFunctionFvPatchScalarField& nlrwfpsf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutLowReWallFunction/nutLowReWallFunctionFvPatchScalarField.H

@@ -107,20 +107,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         nutLowReWallFunctionFvPatchScalarField
         (
             const nutLowReWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new nutLowReWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         nutLowReWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutURoughWallFunction/nutURoughWallFunctionFvPatchScalarField.C

@@ -260,17 +260,6 @@ nutURoughWallFunctionFvPatchScalarField::nutURoughWallFunctionFvPatchScalarField
 {}
 
 
-nutURoughWallFunctionFvPatchScalarField::nutURoughWallFunctionFvPatchScalarField
-(
-    const nutURoughWallFunctionFvPatchScalarField& rwfpsf
-)
-:
-    nutUWallFunctionFvPatchScalarField(rwfpsf),
-    Ks_(rwfpsf.Ks_),
-    Cs_(rwfpsf.Cs_)
-{}
-
-
 nutURoughWallFunctionFvPatchScalarField::nutURoughWallFunctionFvPatchScalarField
 (
     const nutURoughWallFunctionFvPatchScalarField& rwfpsf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutURoughWallFunction/nutURoughWallFunctionFvPatchScalarField.H

@@ -139,20 +139,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         nutURoughWallFunctionFvPatchScalarField
         (
             const nutURoughWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new nutURoughWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         nutURoughWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutUSpaldingWallFunction/nutUSpaldingWallFunctionFvPatchScalarField.C

@@ -167,16 +167,6 @@ nutUSpaldingWallFunctionFvPatchScalarField
 {}
 
 
-nutUSpaldingWallFunctionFvPatchScalarField::
-nutUSpaldingWallFunctionFvPatchScalarField
-(
-    const nutUSpaldingWallFunctionFvPatchScalarField& wfpsf
-)
-:
-    nutWallFunctionFvPatchScalarField(wfpsf)
-{}
-
-
 nutUSpaldingWallFunctionFvPatchScalarField::
 nutUSpaldingWallFunctionFvPatchScalarField
 (

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutUSpaldingWallFunction/nutUSpaldingWallFunctionFvPatchScalarField.H

@@ -123,20 +123,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         nutUSpaldingWallFunctionFvPatchScalarField
         (
             const nutUSpaldingWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new nutUSpaldingWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         nutUSpaldingWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutUTabulatedWallFunction/nutUTabulatedWallFunctionFvPatchScalarField.C

@@ -152,18 +152,6 @@ nutUTabulatedWallFunctionFvPatchScalarField
 {}
 
 
-nutUTabulatedWallFunctionFvPatchScalarField::
-nutUTabulatedWallFunctionFvPatchScalarField
-(
-    const nutUTabulatedWallFunctionFvPatchScalarField& wfpsf
-)
-:
-    nutWallFunctionFvPatchScalarField(wfpsf),
-    uPlusTableName_(wfpsf.uPlusTableName_),
-    uPlusTable_(wfpsf.uPlusTable_)
-{}
-
-
 nutUTabulatedWallFunctionFvPatchScalarField::
 nutUTabulatedWallFunctionFvPatchScalarField
 (

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutUTabulatedWallFunction/nutUTabulatedWallFunctionFvPatchScalarField.H

@@ -131,20 +131,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         nutUTabulatedWallFunctionFvPatchScalarField
         (
             const nutUTabulatedWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new nutUTabulatedWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         nutUTabulatedWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutUWallFunction/nutUWallFunctionFvPatchScalarField.C

@@ -160,15 +160,6 @@ nutUWallFunctionFvPatchScalarField::nutUWallFunctionFvPatchScalarField
 {}
 
 
-nutUWallFunctionFvPatchScalarField::nutUWallFunctionFvPatchScalarField
-(
-    const nutUWallFunctionFvPatchScalarField& sawfpsf
-)
-:
-    nutWallFunctionFvPatchScalarField(sawfpsf)
-{}
-
-
 nutUWallFunctionFvPatchScalarField::nutUWallFunctionFvPatchScalarField
 (
     const nutUWallFunctionFvPatchScalarField& sawfpsf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutUWallFunction/nutUWallFunctionFvPatchScalarField.H

@@ -109,20 +109,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         nutUWallFunctionFvPatchScalarField
         (
             const nutUWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new nutUWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         nutUWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutWallFunction/nutWallFunctionFvPatchScalarField.C

@@ -116,21 +116,6 @@ Foam::nutWallFunctionFvPatchScalarField::nutWallFunctionFvPatchScalarField
 }
 
 
-Foam::nutWallFunctionFvPatchScalarField::nutWallFunctionFvPatchScalarField
-(
-    const nutWallFunctionFvPatchScalarField& wfpsf
-)
-:
-    fixedValueFvPatchScalarField(wfpsf),
-    Cmu_(wfpsf.Cmu_),
-    kappa_(wfpsf.kappa_),
-    E_(wfpsf.E_),
-    yPlusLam_(wfpsf.yPlusLam_)
-{
-    checkType();
-}
-
-
 Foam::nutWallFunctionFvPatchScalarField::nutWallFunctionFvPatchScalarField
 (
     const nutWallFunctionFvPatchScalarField& wfpsf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutWallFunction/nutWallFunctionFvPatchScalarField.H

@@ -144,11 +144,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         nutWallFunctionFvPatchScalarField
         (
             const nutWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
 
         //- Copy constructor setting internal field reference
         nutWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutkRoughWallFunction/nutkRoughWallFunctionFvPatchScalarField.C

@@ -172,17 +172,6 @@ nutkRoughWallFunctionFvPatchScalarField::nutkRoughWallFunctionFvPatchScalarField
 {}
 
 
-nutkRoughWallFunctionFvPatchScalarField::nutkRoughWallFunctionFvPatchScalarField
-(
-    const nutkRoughWallFunctionFvPatchScalarField& rwfpsf
-)
-:
-    nutkWallFunctionFvPatchScalarField(rwfpsf),
-    Ks_(rwfpsf.Ks_),
-    Cs_(rwfpsf.Cs_)
-{}
-
-
 nutkRoughWallFunctionFvPatchScalarField::nutkRoughWallFunctionFvPatchScalarField
 (
     const nutkRoughWallFunctionFvPatchScalarField& rwfpsf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutkRoughWallFunction/nutkRoughWallFunctionFvPatchScalarField.H

@@ -143,20 +143,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         nutkRoughWallFunctionFvPatchScalarField
         (
             const nutkRoughWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new nutkRoughWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         nutkRoughWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutkWallFunction/nutkWallFunctionFvPatchScalarField.C

@@ -113,15 +113,6 @@ nutkWallFunctionFvPatchScalarField::nutkWallFunctionFvPatchScalarField
 {}
 
 
-nutkWallFunctionFvPatchScalarField::nutkWallFunctionFvPatchScalarField
-(
-    const nutkWallFunctionFvPatchScalarField& wfpsf
-)
-:
-    nutWallFunctionFvPatchScalarField(wfpsf)
-{}
-
-
 nutkWallFunctionFvPatchScalarField::nutkWallFunctionFvPatchScalarField
 (
     const nutkWallFunctionFvPatchScalarField& wfpsf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutkWallFunction/nutkWallFunctionFvPatchScalarField.H

@@ -106,20 +106,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         nutkWallFunctionFvPatchScalarField
         (
             const nutkWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new nutkWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         nutkWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/omegaWallFunctions/omegaWallFunction/omegaWallFunctionFvPatchScalarField.C

@@ -331,22 +331,6 @@ omegaWallFunctionFvPatchScalarField::omegaWallFunctionFvPatchScalarField
 {}
 
 
-omegaWallFunctionFvPatchScalarField::omegaWallFunctionFvPatchScalarField
-(
-    const omegaWallFunctionFvPatchScalarField& owfpsf
-)
-:
-    fixedValueFvPatchField<scalar>(owfpsf),
-    beta1_(owfpsf.beta1_),
-    blended_(owfpsf.blended_),
-    G_(),
-    omega_(),
-    initialised_(false),
-    master_(-1),
-    cornerWeights_()
-{}
-
-
 omegaWallFunctionFvPatchScalarField::omegaWallFunctionFvPatchScalarField
 (
     const omegaWallFunctionFvPatchScalarField& owfpsf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/omegaWallFunctions/omegaWallFunction/omegaWallFunctionFvPatchScalarField.H

@@ -187,20 +187,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         omegaWallFunctionFvPatchScalarField
         (
             const omegaWallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new omegaWallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         omegaWallFunctionFvPatchScalarField

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/v2WallFunctions/v2WallFunction/v2WallFunctionFvPatchScalarField.C

@@ -70,15 +70,6 @@ v2WallFunctionFvPatchScalarField::v2WallFunctionFvPatchScalarField
 {}
 
 
-v2WallFunctionFvPatchScalarField::v2WallFunctionFvPatchScalarField
-(
-    const v2WallFunctionFvPatchScalarField& v2wfpsf
-)
-:
-    fixedValueFvPatchField<scalar>(v2wfpsf)
-{}
-
-
 v2WallFunctionFvPatchScalarField::v2WallFunctionFvPatchScalarField
 (
     const v2WallFunctionFvPatchScalarField& v2wfpsf,

src/MomentumTransportModels/momentumTransportModels/derivedFvPatchFields/wallFunctions/v2WallFunctions/v2WallFunction/v2WallFunctionFvPatchScalarField.H

@@ -105,20 +105,11 @@ public:
             const fvPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         v2WallFunctionFvPatchScalarField
         (
             const v2WallFunctionFvPatchScalarField&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual tmp<fvPatchScalarField> clone() const
-        {
-            return tmp<fvPatchScalarField>
-            (
-                new v2WallFunctionFvPatchScalarField(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         v2WallFunctionFvPatchScalarField

src/OpenFOAM/fields/GeometricFields/GeometricField/GeometricBoundaryField.C

@@ -355,42 +355,6 @@ Boundary
 }
 
 
-template<class Type, template<class> class PatchField, class GeoMesh>
-Foam::GeometricField<Type, PatchField, GeoMesh>::Boundary::
-Boundary
-(
-    const typename GeometricField<Type, PatchField, GeoMesh>::
-    Boundary& btf
-)
-:
-    FieldField<PatchField, Type>(btf),
-    bmesh_(btf.bmesh_)
-{
-    if (debug)
-    {
-        InfoInFunction << endl;
-    }
-}
-
-
-template<class Type, template<class> class PatchField, class GeoMesh>
-Foam::GeometricField<Type, PatchField, GeoMesh>::Boundary::
-Boundary
-(
-    typename GeometricField<Type, PatchField, GeoMesh>::
-    Boundary&& btf
-)
-:
-    FieldField<PatchField, Type>(move(btf)),
-    bmesh_(btf.bmesh_)
-{
-    if (debug)
-    {
-        InfoInFunction << endl;
-    }
-}
-
-
 template<class Type, template<class> class PatchField, class GeoMesh>
 Foam::GeometricField<Type, PatchField, GeoMesh>::Boundary::
 Boundary

src/OpenFOAM/fields/GeometricFields/GeometricField/GeometricField.C

@@ -449,7 +449,7 @@ Foam::GeometricField<Type, PatchField, GeoMesh>::GeometricField
     timeIndex_(gf.timeIndex()),
     field0Ptr_(nullptr),
     fieldPrevIterPtr_(nullptr),
-    boundaryField_(move(gf.boundaryField_))
+    boundaryField_(*this, gf.boundaryField_)
 {
     if (debug)
     {

src/OpenFOAM/fields/GeometricFields/GeometricField/GeometricField.H

@@ -130,12 +130,7 @@ public:
             //- Construct from a BoundaryMesh,
             //  reference to the internal field
             //  and a patch field type
-            Boundary
+            Boundary(const BoundaryMesh&, const Internal&, const word&);
-            (
-                const BoundaryMesh&,
-                const Internal&,
-                const word&
-            );
 
             //- Construct from a BoundaryMesh,
             //  reference to the internal field
@@ -160,49 +155,24 @@ public:
             );
 
             //- Construct as copy setting the reference to the internal field
-            Boundary
+            Boundary(const Internal&, const Boundary&);
-            (
-                const Internal&,
-                const Boundary&
-            );
 
-            //- Copy constructor
+            //- Copy constructor deleted
-            //  Dangerous because Field may be set to a field which gets deleted
+            //  as it would not set the internalField reference correctly
-            //  Need new type of BoundaryField, one which is part of a geometric
+            Boundary(const Boundary&) = delete;
-            //  field for which snGrad etc. may be called and a free standing
-            //  BoundaryField for which such operations are unavailable.
-            Boundary
-            (
-                const Boundary&
-            );
 
-            //- Move constructor
+            //- Move constructor deleted
-            //  Dangerous because Field may be set to a field which gets deleted
+            //  as it would not set the internalField reference correctly
-            //  Need new type of BoundaryField, one which is part of a geometric
+            Boundary(Boundary&&) = delete;
-            //  field for which snGrad etc. may be called and a free standing
-            //  BoundaryField for which such operations are unavailable.
-            Boundary
-            (
-                Boundary&&
-            );
 
             //- Construct from dictionary
-            Boundary
+            Boundary(const BoundaryMesh&, const Internal&, const dictionary&);
-            (
-                const BoundaryMesh&,
-                const Internal&,
-                const dictionary&
-            );
 
 
         // Member Functions
 
             //- Read the boundary field
-            void readField
+            void readField(const Internal& field, const dictionary& dict);
-            (
-                const Internal& field,
-                const dictionary& dict
-            );
 
             //- Update the boundary condition coefficients
             void updateCoeffs();
@@ -379,22 +349,13 @@ public:
         );
 
         //- Copy constructor
-        GeometricField
+        GeometricField(const GeometricField<Type, PatchField, GeoMesh>&);
-        (
-            const GeometricField<Type, PatchField, GeoMesh>&
-        );
 
         //- Move constructor
-        GeometricField
+        GeometricField(GeometricField<Type, PatchField, GeoMesh>&&);
-        (
-            GeometricField<Type, PatchField, GeoMesh>&&
-        );
 
         //- Construct as copy of tmp<GeometricField> deleting argument
-        GeometricField
+        GeometricField(const tmp<GeometricField<Type, PatchField, GeoMesh>>&);
-        (
-            const tmp<GeometricField<Type, PatchField, GeoMesh>>&
-        );
 
         //- Construct as copy resetting IO parameters
         GeometricField

src/OpenFOAM/fields/pointPatchFields/basic/basicSymmetry/basicSymmetryPointPatchField.H

@@ -81,18 +81,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new basicSymmetryPointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         basicSymmetryPointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/basic/calculated/calculatedPointPatchField.H

@@ -84,18 +84,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new calculatedPointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         calculatedPointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/basic/coupled/coupledPointPatchField.H

@@ -85,9 +85,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const = 0;
-
         //- Construct as copy setting internal field reference
         coupledPointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/basic/fixedValue/fixedValuePointPatchField.H

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2019 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2020 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -85,18 +85,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new fixedValuePointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         fixedValuePointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/basic/value/valuePointPatchField.H

@@ -90,18 +90,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new valuePointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         valuePointPatchField
         (
@@ -109,8 +97,8 @@ public:
             const DimensionedField<Type, pointMesh>&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
-        valuePointPatchField(const valuePointPatchField<Type>&) = default;
+        valuePointPatchField(const valuePointPatchField<Type>&) = delete;
 
         //- Construct and return a clone setting internal field reference
         virtual autoPtr<pointPatchField<Type>> clone

src/OpenFOAM/fields/pointPatchFields/basic/zeroGradient/zeroGradientPointPatchField.H

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2018 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2020 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -84,18 +84,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new zeroGradientPointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         zeroGradientPointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/constraint/cyclic/cyclicPointPatchField.H

@@ -90,18 +90,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new cyclicPointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         cyclicPointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/constraint/cyclicSlip/cyclicSlipPointPatchField.H

@@ -85,18 +85,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new cyclicSlipPointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         cyclicSlipPointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/constraint/empty/emptyPointPatchField.H

@@ -85,18 +85,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new emptyPointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         emptyPointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/constraint/processor/processorPointPatchField.H

@@ -89,18 +89,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new processorPointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         processorPointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/constraint/processorCyclic/processorCyclicPointPatchField.H

@@ -93,18 +93,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new processorCyclicPointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         processorCyclicPointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/constraint/symmetry/symmetryPointPatchField.H

@@ -85,18 +85,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new symmetryPointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         symmetryPointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/constraint/symmetryPlane/symmetryPlanePointPatchField.H

@@ -90,18 +90,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new symmetryPlanePointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         symmetryPlanePointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/constraint/wedge/wedgePointPatchField.H

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2019 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2020 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -85,18 +85,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new wedgePointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         wedgePointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/derived/codedFixedValue/codedFixedValuePointPatchField.C

@@ -136,18 +136,6 @@ Foam::codedFixedValuePointPatchField<Type>::codedFixedValuePointPatchField
 }
 
 
-template<class Type>
-Foam::codedFixedValuePointPatchField<Type>::codedFixedValuePointPatchField
-(
-    const codedFixedValuePointPatchField<Type>& ptf
-)
-:
-    fixedValuePointPatchField<Type>(ptf),
-    CodedBase<codedFixedValuePointPatchFieldBase>(ptf),
-    redirectPatchFieldPtr_()
-{}
-
-
 template<class Type>
 Foam::codedFixedValuePointPatchField<Type>::codedFixedValuePointPatchField
 (

src/OpenFOAM/fields/pointPatchFields/derived/codedFixedValue/codedFixedValuePointPatchField.H

@@ -159,20 +159,11 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         codedFixedValuePointPatchField
         (
             const codedFixedValuePointPatchField<Type>&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new codedFixedValuePointPatchField<Type>(*this)
-            );
-        }
 
         //- Copy constructor setting internal field reference
         codedFixedValuePointPatchField

src/OpenFOAM/fields/pointPatchFields/derived/fixedNormalSlip/fixedNormalSlipPointPatchField.H

@@ -102,18 +102,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new fixedNormalSlipPointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         fixedNormalSlipPointPatchField
         (
@@ -137,6 +125,7 @@ public:
             );
         }
 
+
     // Member Functions
 
         //- Update the patch field

src/OpenFOAM/fields/pointPatchFields/derived/slip/slipPointPatchField.H

@@ -84,18 +84,6 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new slipPointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
-
         //- Construct as copy setting internal field reference
         slipPointPatchField
         (

src/OpenFOAM/fields/pointPatchFields/derived/uniformFixedValue/uniformFixedValuePointPatchField.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2019 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2020 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -86,18 +86,6 @@ uniformFixedValuePointPatchField
 }
 
 
-template<class Type>
-Foam::uniformFixedValuePointPatchField<Type>::
-uniformFixedValuePointPatchField
-(
-    const uniformFixedValuePointPatchField<Type>& ptf
-)
-:
-    fixedValuePointPatchField<Type>(ptf),
-    uniformValue_(ptf.uniformValue_, false)
-{}
-
-
 template<class Type>
 Foam::uniformFixedValuePointPatchField<Type>::
 uniformFixedValuePointPatchField

src/OpenFOAM/fields/pointPatchFields/derived/uniformFixedValue/uniformFixedValuePointPatchField.H

@@ -102,23 +102,11 @@ public:
             const pointPatchFieldMapper&
         );
 
-        //- Copy constructor
+        //- Disallow copy without setting internal field reference
         uniformFixedValuePointPatchField
         (
             const uniformFixedValuePointPatchField<Type>&
-        );
+        ) = delete;
-
-        //- Construct and return a clone
-        virtual autoPtr<pointPatchField<Type>> clone() const
-        {
-            return autoPtr<pointPatchField<Type>>
-            (
-                new uniformFixedValuePointPatchField<Type>
-                (
-                    *this
-                )
-            );
-        }
 
         //- Copy constructor setting internal field reference
         uniformFixedValuePointPatchField

src/OpenFOAM/fields/pointPatchFields/pointPatchField/pointPatchField.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2019 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2020 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -74,19 +74,6 @@ Foam::pointPatchField<Type>::pointPatchField
 {}
 
 
-template<class Type>
-Foam::pointPatchField<Type>::pointPatchField
-(
-    const pointPatchField<Type>& ptf
-)
-:
-    patch_(ptf.patch_),
-    internalField_(ptf.internalField_),
-    updated_(false),
-    patchType_(ptf.patchType_)
-{}
-
-
 template<class Type>
 Foam::pointPatchField<Type>::pointPatchField
 (