From 86e126a7bc4dbfaed949bbc58c9f0fdd67acc059 Mon Sep 17 00:00:00 2001
From: Will Bainbridge <http://cfd.direct>
Date: Tue, 4 Feb 2025 17:44:38 +0000
Subject: [PATCH] cellsToCells: Fix normalisation of matching and nearest
 methods

---
 .../cellsToCells/matching/matchingCellsToCells.C          | 8 +++-----
 src/meshTools/cellsToCells/nearest/nearestCellsToCells.C  | 8 +++-----
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/src/meshTools/cellsToCells/matching/matchingCellsToCells.C b/src/meshTools/cellsToCells/matching/matchingCellsToCells.C
index 886cf483bf..5ca5dba772 100644
--- a/src/meshTools/cellsToCells/matching/matchingCellsToCells.C
+++ b/src/meshTools/cellsToCells/matching/matchingCellsToCells.C
@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2013-2024 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2013-2025 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -128,7 +128,6 @@ Foam::scalar Foam::cellsToCellss::matching::calculateAddressing
     DynamicList<label> srcSeeds(10);
 
     const scalarField& srcVc = srcMesh.cellVolumes();
-    const scalarField& tgtVc = tgtMesh.cellVolumes();
 
     label srcCelli = srcSeedI;
     label tgtCelli = tgtSeedI;
@@ -162,13 +161,13 @@ Foam::scalar Foam::cellsToCellss::matching::calculateAddressing
     // transfer addressing into persistent storage
     forAll(srcToTgtCellAddr, i)
     {
-        srcToTgtCellWght[i] = scalarList(srcToTgt[i].size(), srcVc[i]);
+        srcToTgtCellWght[i] = scalarList(srcToTgt[i].size(), scalar(1));
         srcToTgtCellAddr[i].transfer(srcToTgt[i]);
     }
 
     forAll(tgtToSrcCellAddr, i)
     {
-        tgtToSrcCellWght[i] = scalarList(tgtToSrc[i].size(), tgtVc[i]);
+        tgtToSrcCellWght[i] = scalarList(tgtToSrc[i].size(), scalar(1));
         tgtToSrcCellAddr[i].transfer(tgtToSrc[i]);
     }
 
@@ -307,7 +306,6 @@ void Foam::cellsToCellss::matching::normalise
         {
             srcToTgtAddr[srcCelli].resize(1);
             srcToTgtWght[srcCelli].resize(1);
-            srcToTgtWght[srcCelli][0] = 1;
         }
     }
 }
diff --git a/src/meshTools/cellsToCells/nearest/nearestCellsToCells.C b/src/meshTools/cellsToCells/nearest/nearestCellsToCells.C
index 5d04e24f05..598efc4f62 100644
--- a/src/meshTools/cellsToCells/nearest/nearestCellsToCells.C
+++ b/src/meshTools/cellsToCells/nearest/nearestCellsToCells.C
@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2013-2023 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2013-2025 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -116,7 +116,6 @@ Foam::scalar Foam::cellsToCellss::nearest::calculateAddressing
     List<DynamicList<label>> tgtToSrc(tgtMesh.nCells());
 
     const scalarField& srcVc = srcMesh.cellVolumes();
-    const scalarField& tgtVc = tgtMesh.cellVolumes();
 
     {
         label srcCelli = srcSeedI;
@@ -202,13 +201,13 @@ Foam::scalar Foam::cellsToCellss::nearest::calculateAddressing
     // transfer addressing into persistent storage
     forAll(srcToTgtCellAddr, i)
     {
-        srcToTgtCellWght[i] = scalarList(srcToTgt[i].size(), srcVc[i]);
+        srcToTgtCellWght[i] = scalarList(srcToTgt[i].size(), scalar(1));
         srcToTgtCellAddr[i].transfer(srcToTgt[i]);
     }
 
     forAll(tgtToSrcCellAddr, i)
     {
-        tgtToSrcCellWght[i] = scalarList(tgtToSrc[i].size(), tgtVc[i]);
+        tgtToSrcCellWght[i] = scalarList(tgtToSrc[i].size(), scalar(1));
         tgtToSrcCellAddr[i].transfer(tgtToSrc[i]);
     }
 
@@ -417,7 +416,6 @@ void Foam::cellsToCellss::nearest::normalise
         {
             srcToTgtAddr[srcCelli].resize(1);
             srcToTgtWght[srcCelli].resize(1);
-            srcToTgtWght[srcCelli][0] = 1;
         }
     }
 }