diff --git a/etc/codeTemplates/dynamicCode/Function1Template.C b/etc/codeTemplates/dynamicCode/Function1Template.C index b0a688f6dc..6b626ff8ae 100644 --- a/etc/codeTemplates/dynamicCode/Function1Template.C +++ b/etc/codeTemplates/dynamicCode/Function1Template.C @@ -62,17 +62,6 @@ extern "C" } -// * * * * * * * * * * * * * Private Member Functions * * * * * * * * * * * // - -void Foam::Function1s::${typeName}Function1${TemplateType}::writeData -( - Ostream& os -) const -{ - NotImplemented; -} - - // * * * * * * * * * * * * * * * * Constructors * * * * * * * * * * * * * * // Foam::Function1s::${typeName}Function1${TemplateType}:: @@ -138,4 +127,13 @@ Foam::Function1s::${typeName}Function1${TemplateType}::integral } +void Foam::Function1s::${typeName}Function1${TemplateType}::write +( + Ostream& os +) const +{ + NotImplemented; +} + + // ************************************************************************* i/ diff --git a/etc/codeTemplates/dynamicCode/Function1Template.H b/etc/codeTemplates/dynamicCode/Function1Template.H index 639ab305f0..572d983ead 100644 --- a/etc/codeTemplates/dynamicCode/Function1Template.H +++ b/etc/codeTemplates/dynamicCode/Function1Template.H @@ -55,11 +55,6 @@ class ${typeName}Function1${TemplateType} : public FieldFunction1<${TemplateType}, ${typeName}Function1${TemplateType}> { - // Private Member Functions - - //- Write data to dictionary stream - virtual void writeData(Ostream& os) const; - public: @@ -113,6 +108,9 @@ public: const scalar x2 ) const; + //- Write data to dictionary stream + virtual void write(Ostream& os) const; + // Member Operators diff --git a/etc/codeTemplates/dynamicCode/Function2Template.C b/etc/codeTemplates/dynamicCode/Function2Template.C index c787d024bf..ecdf3897db 100644 --- a/etc/codeTemplates/dynamicCode/Function2Template.C +++ b/etc/codeTemplates/dynamicCode/Function2Template.C @@ -62,17 +62,6 @@ extern "C" } -// * * * * * * * * * * * * * Private Member Functions * * * * * * * * * * * // - -void Foam::Function2s::${typeName}Function2${TemplateType}::writeData -( - Ostream& os -) const -{ - NotImplemented; -} - - // * * * * * * * * * * * * * * * * Constructors * * * * * * * * * * * * * * // Foam::Function2s::${typeName}Function2${TemplateType}:: @@ -124,4 +113,15 @@ Foam::Function2s::${typeName}Function2${TemplateType}:: } +// * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // + +void Foam::Function2s::${typeName}Function2${TemplateType}::write +( + Ostream& os +) const +{ + NotImplemented; +} + + // ************************************************************************* i/ diff --git a/etc/codeTemplates/dynamicCode/Function2Template.H b/etc/codeTemplates/dynamicCode/Function2Template.H index 13990b1d8b..df346b6be2 100644 --- a/etc/codeTemplates/dynamicCode/Function2Template.H +++ b/etc/codeTemplates/dynamicCode/Function2Template.H @@ -55,11 +55,6 @@ class ${typeName}Function2${TemplateType} : public FieldFunction2<${TemplateType}, ${typeName}Function2${TemplateType}> { - // Private Member Functions - - //- Write data to dictionary stream - virtual void writeData(Ostream& os) const; - public: @@ -110,6 +105,9 @@ public: //}}} end code } + //- Write data to dictionary stream + virtual void write(Ostream& os) const; + // Member Operators diff --git a/src/OpenFOAM/primitives/functions/Function1/Coded/CodedFunction1.C b/src/OpenFOAM/primitives/functions/Function1/Coded/CodedFunction1.C index 381a2fd4dd..07f5235dac 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Coded/CodedFunction1.C +++ b/src/OpenFOAM/primitives/functions/Function1/Coded/CodedFunction1.C @@ -88,23 +88,16 @@ Foam::Function1s::Coded::compileNew() } -template -void Foam::Function1s::Coded::writeData(Ostream& os) const -{ - writeCode(os); -} - - // * * * * * * * * * * * * * * * * Constructors * * * * * * * * * * * * * * // template Foam::Function1s::Coded::Coded ( - const word& entryName, + const word& name, const dictionary& dict ) : - Function1(entryName), + Function1(name), CodedBase(dict) { redirectFunction1Ptr_ = compileNew(); @@ -172,4 +165,11 @@ Foam::tmp> Foam::Function1s::Coded::integral } +template +void Foam::Function1s::Coded::write(Ostream& os) const +{ + writeCode(os); +} + + // ************************************************************************* // diff --git a/src/OpenFOAM/primitives/functions/Function1/Coded/CodedFunction1.H b/src/OpenFOAM/primitives/functions/Function1/Coded/CodedFunction1.H index cd5529249c..469489ec79 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Coded/CodedFunction1.H +++ b/src/OpenFOAM/primitives/functions/Function1/Coded/CodedFunction1.H @@ -116,9 +116,6 @@ class Coded //- Compile, link and return the now coded Function1 autoPtr> compileNew(); - //- Write data to dictionary stream - virtual void writeData(Ostream& os) const; - public: @@ -131,7 +128,7 @@ public: //- Construct from entry name and dictionary Coded ( - const word& entryName, + const word& name, const dictionary& dict ); @@ -164,6 +161,9 @@ public: const scalarField& x2 ) const; + //- Write data to dictionary stream + virtual void write(Ostream& os) const; + // Member Operators diff --git a/src/OpenFOAM/primitives/functions/Function1/Constant/Constant.C b/src/OpenFOAM/primitives/functions/Function1/Constant/Constant.C index 0dddf88059..f11cf1b2f6 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Constant/Constant.C +++ b/src/OpenFOAM/primitives/functions/Function1/Constant/Constant.C @@ -30,11 +30,11 @@ License template Foam::Function1s::Constant::Constant ( - const word& entryName, + const word& name, const Type& val ) : - FieldFunction1>(entryName), + FieldFunction1>(name), value_(val) {} @@ -42,21 +42,22 @@ Foam::Function1s::Constant::Constant template Foam::Function1s::Constant::Constant ( - const word& entryName, + const word& name, const dictionary& dict ) : - FieldFunction1>(entryName), + FieldFunction1>(name), value_(Zero) { - if (!dict.found(entryName)) + if (!dict.found(name)) { dict.lookup("value") >> value_; } else { - Istream& is(dict.lookup(entryName)); + Istream& is(dict.lookup(name)); word entryType(is); + if (is.eof()) { dict.lookup("value") >> value_; @@ -72,11 +73,11 @@ Foam::Function1s::Constant::Constant template Foam::Function1s::Constant::Constant ( - const word& entryName, + const word& name, Istream& is ) : - FieldFunction1>(entryName), + FieldFunction1>(name), value_(pTraits(is)) {} @@ -101,8 +102,7 @@ Foam::Function1s::Constant::~Constant() template void Foam::Function1s::Constant::write(Ostream& os) const { - this->writeType(os) - << token::SPACE << value_ << token::END_STATEMENT << nl; + writeEntry(os, "value", value_); } diff --git a/src/OpenFOAM/primitives/functions/Function1/Constant/Constant.H b/src/OpenFOAM/primitives/functions/Function1/Constant/Constant.H index cd2d73e39b..ee69b26cab 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Constant/Constant.H +++ b/src/OpenFOAM/primitives/functions/Function1/Constant/Constant.H @@ -27,9 +27,9 @@ Class Description Templated function that returns a constant value. - Usage - for entry \ returning the value : + Usage - for entry \ returning the value : \verbatim - constant + constant \endverbatim SourceFiles @@ -73,15 +73,15 @@ public: // Constructors //- Construct from entry name and value - Constant(const word& entryName, const Type& val); + Constant(const word& name, const Type& val); //- Construct from entry name and dictionary - Constant(const word& entryName, const dictionary& dict); + Constant(const word& name, const dictionary& dict); //- Construct from entry name and Istream // Reads the constant value without the Function1 type // for backward compatibility - Constant(const word& entryName, Istream& is); + Constant(const word& name, Istream& is); //- Copy constructor Constant(const Constant& cnst); diff --git a/src/OpenFOAM/primitives/functions/Function1/Function1/Function1.C b/src/OpenFOAM/primitives/functions/Function1/Function1/Function1.C index 51d0e6e4ca..9276400f63 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Function1/Function1.C +++ b/src/OpenFOAM/primitives/functions/Function1/Function1/Function1.C @@ -26,21 +26,12 @@ License #include "Function1.H" -// * * * * * * * * * * * * Protected Member Functions * * * * * * * * * * * // - -template -Foam::Ostream& Foam::Function1::writeType(Ostream& os) const -{ - return writeKeyword(os, name_) << type(); -} - - // * * * * * * * * * * * * * * * * Constructor * * * * * * * * * * * * * * * // template -Foam::Function1::Function1(const word& entryName) +Foam::Function1::Function1(const word& name) : - name_(entryName) + name_(name) {} @@ -55,10 +46,10 @@ Foam::Function1::Function1(const Function1& de) template Foam::FieldFunction1::FieldFunction1 ( - const word& entryName + const word& name ) : - Function1(entryName) + Function1(name) {} @@ -104,20 +95,6 @@ const Foam::word& Foam::Function1::name() const } -template -void Foam::Function1::write(Ostream& os) const -{ - writeKeyword(os, name_) - << nl << indent << token::BEGIN_BLOCK << nl << incrIndent; - - writeEntry(os, "type", type()); - - writeData(os); - - os << decrIndent << indent << token::END_BLOCK << endl; -} - - template Foam::tmp> Foam::FieldFunction1::value ( @@ -161,7 +138,14 @@ Foam::FieldFunction1::integral template void Foam::writeEntry(Ostream& os, const Function1& f1) { + writeKeyword(os, f1.name()) + << nl << indent << token::BEGIN_BLOCK << nl << incrIndent; + + writeEntry(os, "type", f1.type()); + f1.write(os); + + os << decrIndent << indent << token::END_BLOCK << endl; } diff --git a/src/OpenFOAM/primitives/functions/Function1/Function1/Function1.H b/src/OpenFOAM/primitives/functions/Function1/Function1/Function1.H index 8c9f34d29b..d94862458d 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Function1/Function1.H +++ b/src/OpenFOAM/primitives/functions/Function1/Function1/Function1.H @@ -71,15 +71,6 @@ protected: const word name_; - // Protected member functions - - Ostream& writeType(Ostream& os) const; - - //- Write data to dictionary stream - virtual void writeData(Ostream& os) const - {} - - public: typedef Type returnType; @@ -94,17 +85,17 @@ public: Function1, dictionary, ( - const word& entryName, + const word& name, const dictionary& dict ), - (entryName, dict) + (name, dict) ); // Constructors //- Construct from entry name - Function1(const word& entryName); + Function1(const word& name); //- Copy constructor Function1(const Function1& f1); @@ -116,7 +107,7 @@ public: //- Selector static autoPtr> New ( - const word& entryName, + const word& name, const dictionary& dict ); @@ -146,8 +137,8 @@ public: const scalarField& x2 ) const = 0; - //- Write dictionary to stream - virtual void write(Ostream& os) const; + //- Write data to dictionary stream + virtual void write(Ostream& os) const = 0; // Member Operators @@ -186,7 +177,7 @@ public: // Constructors //- Construct from entry name - FieldFunction1(const word& entryName); + FieldFunction1(const word& name); //- Copy constructor FieldFunction1(const FieldFunction1& ff1); diff --git a/src/OpenFOAM/primitives/functions/Function1/Function1/Function1New.C b/src/OpenFOAM/primitives/functions/Function1/Function1/Function1New.C index dc4cc57327..cf45f3a853 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Function1/Function1New.C +++ b/src/OpenFOAM/primitives/functions/Function1/Function1/Function1New.C @@ -30,13 +30,13 @@ License template Foam::autoPtr> Foam::Function1::New ( - const word& entryName, + const word& name, const dictionary& dict ) { - if (dict.isDict(entryName)) + if (dict.isDict(name)) { - const dictionary& coeffsDict(dict.subDict(entryName)); + const dictionary& coeffsDict(dict.subDict(name)); const word Function1Type(coeffsDict.lookup("type")); @@ -48,17 +48,17 @@ Foam::autoPtr> Foam::Function1::New FatalErrorInFunction << "Unknown Function1 type " << Function1Type << " for Function1 " - << entryName << nl << nl + << name << nl << nl << "Valid Function1 types are:" << nl << dictionaryConstructorTablePtr_->sortedToc() << nl << exit(FatalError); } - return cstrIter()(entryName, coeffsDict); + return cstrIter()(name, coeffsDict); } else { - Istream& is(dict.lookup(entryName, false)); + Istream& is(dict.lookup(name, false)); token firstToken(is); word Function1Type; @@ -68,7 +68,7 @@ Foam::autoPtr> Foam::Function1::New is.putBack(firstToken); return autoPtr> ( - new Function1s::Constant(entryName, is) + new Function1s::Constant(name, is) ); } else @@ -84,7 +84,7 @@ Foam::autoPtr> Foam::Function1::New FatalErrorInFunction << "Unknown Function1 type " << Function1Type << " for Function1 " - << entryName << nl << nl + << name << nl << nl << "Valid Function1 types are:" << nl << dictionaryConstructorTablePtr_->sortedToc() << nl << exit(FatalError); @@ -94,18 +94,18 @@ Foam::autoPtr> Foam::Function1::New ( cstrIter() ( - entryName, - dict.found(entryName + "Coeffs") - ? dict.subDict(entryName + "Coeffs") + name, + dict.found(name + "Coeffs") + ? dict.subDict(name + "Coeffs") : dict ) ); - if (dict.found(entryName + "Coeffs")) + if (dict.found(name + "Coeffs")) { IOWarningInFunction(dict) << "Using deprecated " - << (entryName + "Coeffs") << " sub-dictionary."<< nl + << (name + "Coeffs") << " sub-dictionary."<< nl << " Please use the simpler form" << endl; funcPtr->write(Info); } diff --git a/src/OpenFOAM/primitives/functions/Function1/One/OneConstant.C b/src/OpenFOAM/primitives/functions/Function1/One/OneConstant.C index 910f6010ff..bc89b4a829 100644 --- a/src/OpenFOAM/primitives/functions/Function1/One/OneConstant.C +++ b/src/OpenFOAM/primitives/functions/Function1/One/OneConstant.C @@ -28,20 +28,20 @@ License // * * * * * * * * * * * * * * * * Constructors * * * * * * * * * * * * * * // template -Foam::Function1s::OneConstant::OneConstant(const word& entryName) +Foam::Function1s::OneConstant::OneConstant(const word& name) : - FieldFunction1>(entryName) + FieldFunction1>(name) {} template Foam::Function1s::OneConstant::OneConstant ( - const word& entryName, + const word& name, const dictionary& dict ) : - FieldFunction1>(entryName) + FieldFunction1>(name) {} @@ -56,9 +56,7 @@ Foam::Function1s::OneConstant::~OneConstant() template void Foam::Function1s::OneConstant::write(Ostream& os) const -{ - this->writeType(os) << token::END_STATEMENT << nl; -} +{} // ************************************************************************* // diff --git a/src/OpenFOAM/primitives/functions/Function1/One/OneConstant.H b/src/OpenFOAM/primitives/functions/Function1/One/OneConstant.H index bd395c7857..fa1f7167e7 100644 --- a/src/OpenFOAM/primitives/functions/Function1/One/OneConstant.H +++ b/src/OpenFOAM/primitives/functions/Function1/One/OneConstant.H @@ -29,7 +29,7 @@ Description Usage: \verbatim - one; + one; \endverbatim SourceFiles @@ -68,10 +68,10 @@ public: // Constructors //- Construct from entry name - OneConstant(const word& entryName); + OneConstant(const word& name); //- Construct from entry name and dictionary - OneConstant(const word& entryName, const dictionary& dict); + OneConstant(const word& name, const dictionary& dict); //- Destructor diff --git a/src/OpenFOAM/primitives/functions/Function1/PolynomialEntry/PolynomialEntry.C b/src/OpenFOAM/primitives/functions/Function1/PolynomialEntry/PolynomialEntry.C index 9c9226f032..6851852a08 100644 --- a/src/OpenFOAM/primitives/functions/Function1/PolynomialEntry/PolynomialEntry.C +++ b/src/OpenFOAM/primitives/functions/Function1/PolynomialEntry/PolynomialEntry.C @@ -30,18 +30,32 @@ License template Foam::Function1s::Polynomial::Polynomial ( - const word& entryName, + const word& name, const dictionary& dict ) : - FieldFunction1>(entryName), + FieldFunction1>(name), coeffs_(), canIntegrate_(true) { - Istream& is(dict.lookup(entryName)); - word entryType(is); + if (!dict.found(name)) + { + dict.lookup("coeffs") >> coeffs_; + } + else + { + Istream& is(dict.lookup(name)); + word entryType(is); - is >> coeffs_; + if (is.eof()) + { + dict.lookup("coeffs") >> coeffs_; + } + else + { + is >> coeffs_; + } + } if (!coeffs_.size()) { @@ -74,11 +88,11 @@ Foam::Function1s::Polynomial::Polynomial template Foam::Function1s::Polynomial::Polynomial ( - const word& entryName, + const word& name, const List>& coeffs ) : - FieldFunction1>(entryName), + FieldFunction1>(name), coeffs_(coeffs), canIntegrate_(true) { @@ -186,8 +200,7 @@ Type Foam::Function1s::Polynomial::integral template void Foam::Function1s::Polynomial::write(Ostream& os) const { - this->writeType(os) - << nl << indent << coeffs_ << token::END_STATEMENT << nl; + writeKeyword(os, "coeffs") << coeffs_ << token::END_STATEMENT << nl; } diff --git a/src/OpenFOAM/primitives/functions/Function1/PolynomialEntry/PolynomialEntry.H b/src/OpenFOAM/primitives/functions/Function1/PolynomialEntry/PolynomialEntry.H index babf4b3223..4122fe8ed2 100644 --- a/src/OpenFOAM/primitives/functions/Function1/PolynomialEntry/PolynomialEntry.H +++ b/src/OpenFOAM/primitives/functions/Function1/PolynomialEntry/PolynomialEntry.H @@ -27,10 +27,10 @@ Class Description PolynomialEntry container data entry for scalars. Items are stored in a list of Tuple2's. Data is input in the form, - e.g. for an entry \ that describes y = x^2 + 2x^3 + e.g. for an entry \ that describes y = x^2 + 2x^3 \verbatim - polynomial + polynomial ( (1 2) (2 3) @@ -82,12 +82,12 @@ public: // Constructors - Polynomial(const word& entryName, const dictionary& dict); + Polynomial(const word& name, const dictionary& dict); //- Construct from components Polynomial ( - const word& entryName, + const word& name, const List>& ); diff --git a/src/OpenFOAM/primitives/functions/Function1/Ramp/Ramp.C b/src/OpenFOAM/primitives/functions/Function1/Ramp/Ramp.C index 1e621f9e2f..b363b912de 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Ramp/Ramp.C +++ b/src/OpenFOAM/primitives/functions/Function1/Ramp/Ramp.C @@ -25,16 +25,6 @@ License #include "Ramp.H" -// * * * * * * * * * * * * * Private Member Functions * * * * * * * * * * * // - -template -void Foam::Function1s::Ramp::writeData(Ostream& os) const -{ - writeEntry(os, "start", start_); - writeEntry(os, "duration", duration_); -} - - // * * * * * * * * * * * * * * * * Constructors * * * * * * * * * * * * * * // template @@ -48,11 +38,11 @@ void Foam::Function1s::Ramp::read(const dictionary& coeffs) template Foam::Function1s::Ramp::Ramp ( - const word& entryName, + const word& name, const dictionary& dict ) : - FieldFunction1(entryName) + FieldFunction1(name) { read(dict); } @@ -65,4 +55,14 @@ Foam::Function1s::Ramp::~Ramp() {} +// * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // + +template +void Foam::Function1s::Ramp::write(Ostream& os) const +{ + writeEntry(os, "start", start_); + writeEntry(os, "duration", duration_); +} + + // ************************************************************************* // diff --git a/src/OpenFOAM/primitives/functions/Function1/Ramp/Ramp.H b/src/OpenFOAM/primitives/functions/Function1/Ramp/Ramp.H index c8f15b7b72..f24a1577fe 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Ramp/Ramp.H +++ b/src/OpenFOAM/primitives/functions/Function1/Ramp/Ramp.H @@ -31,8 +31,8 @@ Description Usage: \verbatim - ; - Coeffs + ; + Coeffs { start 10; duration 20; @@ -40,7 +40,7 @@ Description \endverbatim or \verbatim - + { type ; start 10; @@ -114,9 +114,6 @@ protected: return 1/duration_; } - //- Write data to dictionary stream - virtual void writeData(Ostream& os) const; - private: @@ -133,7 +130,7 @@ public: //- Construct from entry name and dictionary Ramp ( - const word& entryName, + const word& name, const dictionary& dict ); @@ -147,6 +144,9 @@ public: //- Return value for time t virtual scalar value(const scalar t) const = 0; + //- Write data to dictionary stream + virtual void write(Ostream& os) const; + // Member Operators diff --git a/src/OpenFOAM/primitives/functions/Function1/Scale/Scale.C b/src/OpenFOAM/primitives/functions/Function1/Scale/Scale.C index 783b94b27f..a25b78ff8b 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Scale/Scale.C +++ b/src/OpenFOAM/primitives/functions/Function1/Scale/Scale.C @@ -47,25 +47,16 @@ void Foam::Function1s::Scale::read(const dictionary& coeffs) } -template -void Foam::Function1s::Scale::writeData(Ostream& os) const -{ - scale_->write(os); - xScale_->write(os); - value_->write(os); -} - - // * * * * * * * * * * * * * * * * Constructors * * * * * * * * * * * * * * // template Foam::Function1s::Scale::Scale ( - const word& entryName, + const word& name, const dictionary& dict ) : - FieldFunction1>(entryName) + FieldFunction1>(name) { read(dict); } @@ -90,4 +81,15 @@ Foam::Function1s::Scale::~Scale() {} +// * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // + +template +void Foam::Function1s::Scale::write(Ostream& os) const +{ + scale_->write(os); + xScale_->write(os); + value_->write(os); +} + + // ************************************************************************* // diff --git a/src/OpenFOAM/primitives/functions/Function1/Scale/Scale.H b/src/OpenFOAM/primitives/functions/Function1/Scale/Scale.H index a9c4ffa7d9..da3f7b92f7 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Scale/Scale.H +++ b/src/OpenFOAM/primitives/functions/Function1/Scale/Scale.H @@ -34,7 +34,7 @@ Description Usage for a vector: \verbatim - + { type scale; @@ -60,7 +60,7 @@ Description Simplified usage to scale by a constant factor, e.g. 2: \verbatim - + { type scale; @@ -80,7 +80,7 @@ Description Usage including the optional 'xScale' function: \verbatim - + { type scale; @@ -160,9 +160,6 @@ class Scale //- Read the coefficients from the given dictionary void read(const dictionary& coeffs); - //- Write data to dictionary stream - virtual void writeData(Ostream& os) const; - public: @@ -175,7 +172,7 @@ public: //- Construct from entry name and dictionary Scale ( - const word& entryName, + const word& name, const dictionary& dict ); @@ -195,6 +192,9 @@ public: //- Integrate between two values virtual inline Type integral(const scalar x1, const scalar x2) const; + //- Write data to dictionary stream + virtual void write(Ostream& os) const; + // Member Operators diff --git a/src/OpenFOAM/primitives/functions/Function1/Sine/Sine.C b/src/OpenFOAM/primitives/functions/Function1/Sine/Sine.C index 93d0a62f5b..62ab6471aa 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Sine/Sine.C +++ b/src/OpenFOAM/primitives/functions/Function1/Sine/Sine.C @@ -41,26 +41,16 @@ void Foam::Function1s::Sine::read(const dictionary& coeffs) } -template -void Foam::Function1s::Sine::writeData(Ostream& os) const -{ - amplitude_->write(os); - writeEntry(os, "frequency", frequency_); - writeEntry(os, "start", start_); - level_->write(os); -} - - // * * * * * * * * * * * * * * * * Constructors * * * * * * * * * * * * * * // template Foam::Function1s::Sine::Sine ( - const word& entryName, + const word& name, const dictionary& dict ) : - FieldFunction1>(entryName) + FieldFunction1>(name) { read(dict); } @@ -85,4 +75,16 @@ Foam::Function1s::Sine::~Sine() {} +// * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // + +template +void Foam::Function1s::Sine::write(Ostream& os) const +{ + amplitude_->write(os); + writeEntry(os, "frequency", frequency_); + writeEntry(os, "start", start_); + level_->write(os); +} + + // ************************************************************************* // diff --git a/src/OpenFOAM/primitives/functions/Function1/Sine/Sine.H b/src/OpenFOAM/primitives/functions/Function1/Sine/Sine.H index e4bd9719e8..96d9a50a08 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Sine/Sine.H +++ b/src/OpenFOAM/primitives/functions/Function1/Sine/Sine.H @@ -43,8 +43,8 @@ Description Example for a scalar: \verbatim - sine; - Coeffs + sine; + Coeffs { amplitude 2e-7; frequency 10; @@ -55,8 +55,8 @@ Description Example for a vector: \verbatim - sine; - Coeffs + sine; + Coeffs { amplitude (1 0.1 0); frequency 10; @@ -114,9 +114,6 @@ class Sine //- Read the coefficients from the given dictionary void read(const dictionary& coeffs); - //- Write data to dictionary stream - virtual void writeData(Ostream& os) const; - public: @@ -129,7 +126,7 @@ public: //- Construct from entry name and dictionary Sine ( - const word& entryName, + const word& name, const dictionary& dict ); @@ -149,6 +146,9 @@ public: //- Integrate between two values virtual inline Type integral(const scalar x1, const scalar x2) const; + //- Write data to dictionary stream + virtual void write(Ostream& os) const; + // Member Operators diff --git a/src/OpenFOAM/primitives/functions/Function1/Square/Square.C b/src/OpenFOAM/primitives/functions/Function1/Square/Square.C index de0c4a5295..08f376bfab 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Square/Square.C +++ b/src/OpenFOAM/primitives/functions/Function1/Square/Square.C @@ -42,27 +42,16 @@ void Foam::Function1s::Square::read(const dictionary& coeffs) } -template -void Foam::Function1s::Square::writeData(Ostream& os) const -{ - amplitude_->write(os); - writeEntry(os, "frequency", frequency_); - writeEntry(os, "start", start_); - level_->write(os); - writeEntry(os, "markSpace", markSpace_); -} - - // * * * * * * * * * * * * * * * * Constructors * * * * * * * * * * * * * * // template Foam::Function1s::Square::Square ( - const word& entryName, + const word& name, const dictionary& dict ) : - FieldFunction1>(entryName) + FieldFunction1>(name) { read(dict); } @@ -88,4 +77,17 @@ Foam::Function1s::Square::~Square() {} +// * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // + +template +void Foam::Function1s::Square::write(Ostream& os) const +{ + amplitude_->write(os); + writeEntry(os, "frequency", frequency_); + writeEntry(os, "start", start_); + level_->write(os); + writeEntry(os, "markSpace", markSpace_); +} + + // ************************************************************************* // diff --git a/src/OpenFOAM/primitives/functions/Function1/Square/Square.H b/src/OpenFOAM/primitives/functions/Function1/Square/Square.H index 703088994b..cd5dbe1d0c 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Square/Square.H +++ b/src/OpenFOAM/primitives/functions/Function1/Square/Square.H @@ -47,8 +47,8 @@ Description Example for a scalar: \verbatim - square; - Coeffs + square; + Coeffs { amplitude 2e-7; frequency 10; @@ -60,8 +60,8 @@ Description Example for a vector: \verbatim - square; - Coeffs + square; + Coeffs { amplitude (1 0.1 0); frequency 10; @@ -125,9 +125,6 @@ class Square //- Read the coefficients from the given dictionary void read(const dictionary& coeffs); - //- Write data to dictionary stream - virtual void writeData(Ostream& os) const; - public: @@ -140,7 +137,7 @@ public: //- Construct from entry name and dictionary Square ( - const word& entryName, + const word& name, const dictionary& dict ); @@ -160,6 +157,9 @@ public: //- Integrate between two values virtual inline Type integral(const scalar x1, const scalar x2) const; + //- Write data to dictionary stream + virtual void write(Ostream& os) const; + // Member Operators diff --git a/src/OpenFOAM/primitives/functions/Function1/Table/Table.C b/src/OpenFOAM/primitives/functions/Function1/Table/Table.C index 76768d7075..3bd5741a0d 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Table/Table.C +++ b/src/OpenFOAM/primitives/functions/Function1/Table/Table.C @@ -130,29 +130,6 @@ Foam::scalar Foam::Function1s::Table::bound } -template -void Foam::Function1s::Table::writeData(Ostream& os) const -{ - writeEntryIfDifferent - ( - os, - "outOfBounds", - tableBase::boundsHandlingNames_[tableBase::boundsHandling::clamp], - tableBase::boundsHandlingNames_[boundsHandling_] - ); - - writeEntryIfDifferent - ( - os, - "interpolationScheme", - linearInterpolationWeights::typeName, - interpolationScheme_ - ); - - reader_->write(os, table_); -} - - // * * * * * * * * * * * * * * * * Constructors * * * * * * * * * * * * * * // template @@ -316,4 +293,27 @@ Foam::Function1s::Table::y() const } +template +void Foam::Function1s::Table::write(Ostream& os) const +{ + writeEntryIfDifferent + ( + os, + "outOfBounds", + tableBase::boundsHandlingNames_[tableBase::boundsHandling::clamp], + tableBase::boundsHandlingNames_[boundsHandling_] + ); + + writeEntryIfDifferent + ( + os, + "interpolationScheme", + linearInterpolationWeights::typeName, + interpolationScheme_ + ); + + reader_->write(os, table_); +} + + // ************************************************************************* // diff --git a/src/OpenFOAM/primitives/functions/Function1/Table/Table.H b/src/OpenFOAM/primitives/functions/Function1/Table/Table.H index 28b2793711..7db117e55b 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Table/Table.H +++ b/src/OpenFOAM/primitives/functions/Function1/Table/Table.H @@ -32,7 +32,7 @@ Description Usage: \verbatim - table + table ( (0.0 (1 2 3)) (1.0 (4 5 6)) @@ -41,7 +41,7 @@ Description or in dictionary form which supports the setting of options, e.g. \verbatim - table; + table; values ( @@ -57,7 +57,7 @@ Description other entries in the dictionary: \verbatim - + { type table; @@ -76,7 +76,7 @@ Description Usage: \verbatim - + { type table; file ""; // Name/path of thedata file @@ -162,9 +162,6 @@ class Table // as the interpolator already performs that function. scalar bound(const scalar x) const; - //- Write data to dictionary stream - virtual void writeData(Ostream& os) const; - public: @@ -208,6 +205,9 @@ public: //- Return the dependent values virtual tmp> y() const; + //- Write data to dictionary stream + virtual void write(Ostream& os) const; + // Member Operators diff --git a/src/OpenFOAM/primitives/functions/Function1/Uniform/Uniform.C b/src/OpenFOAM/primitives/functions/Function1/Uniform/Uniform.C index f0d166d412..b86930331e 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Uniform/Uniform.C +++ b/src/OpenFOAM/primitives/functions/Function1/Uniform/Uniform.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | Website: https://openfoam.org - \\ / A nd | Copyright (C) 2017-2019 OpenFOAM Foundation + \\ / A nd | Copyright (C) 2017-2020 OpenFOAM Foundation \\/ M anipulation | ------------------------------------------------------------------------------- License @@ -30,11 +30,11 @@ License template Foam::Function1s::Uniform::Uniform ( - const word& entryName, + const word& name, const dictionary& dict ) : - Constant(entryName, dict) + Constant(name, dict) {} diff --git a/src/OpenFOAM/primitives/functions/Function1/Uniform/Uniform.H b/src/OpenFOAM/primitives/functions/Function1/Uniform/Uniform.H index bd611ae4ea..ad7900c85f 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Uniform/Uniform.H +++ b/src/OpenFOAM/primitives/functions/Function1/Uniform/Uniform.H @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | Website: https://openfoam.org - \\ / A nd | Copyright (C) 2017-2019 OpenFOAM Foundation + \\ / A nd | Copyright (C) 2017-2020 OpenFOAM Foundation \\/ M anipulation | ------------------------------------------------------------------------------- License @@ -30,9 +30,9 @@ Description Provides backward-compatibility for cases where a field is spatially "uniform" and may be treated as a constant value. - Usage - for entry \ returning the value : + Usage - for entry \ returning the value : \verbatim - uniform + uniform \endverbatim SourceFiles @@ -71,7 +71,7 @@ public: // Constructors //- Construct from entry name and dictionary - Uniform(const word& entryName, const dictionary& dict); + Uniform(const word& name, const dictionary& dict); // Member Operators diff --git a/src/OpenFOAM/primitives/functions/Function1/Zero/ZeroConstant.C b/src/OpenFOAM/primitives/functions/Function1/Zero/ZeroConstant.C index d286d2f8ba..1c47568bd1 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Zero/ZeroConstant.C +++ b/src/OpenFOAM/primitives/functions/Function1/Zero/ZeroConstant.C @@ -30,11 +30,11 @@ License template Foam::Function1s::ZeroConstant::ZeroConstant ( - const word& entryName, + const word& name, const dictionary& dict ) : - FieldFunction1>(entryName) + FieldFunction1>(name) {} @@ -49,9 +49,7 @@ Foam::Function1s::ZeroConstant::~ZeroConstant() template void Foam::Function1s::ZeroConstant::write(Ostream& os) const -{ - this->writeType(os) << token::END_STATEMENT << nl; -} +{} // ************************************************************************* // diff --git a/src/OpenFOAM/primitives/functions/Function1/Zero/ZeroConstant.H b/src/OpenFOAM/primitives/functions/Function1/Zero/ZeroConstant.H index a785f1d129..a679cf335c 100644 --- a/src/OpenFOAM/primitives/functions/Function1/Zero/ZeroConstant.H +++ b/src/OpenFOAM/primitives/functions/Function1/Zero/ZeroConstant.H @@ -29,7 +29,7 @@ Description Usage: \verbatim - zero; + zero; \endverbatim SourceFiles @@ -68,7 +68,7 @@ public: // Constructors //- Construct from entry name and dictionary - ZeroConstant(const word& entryName, const dictionary& dict); + ZeroConstant(const word& name, const dictionary& dict); //- Destructor diff --git a/src/OpenFOAM/primitives/functions/Function1/halfCosineRamp/halfCosineRamp.C b/src/OpenFOAM/primitives/functions/Function1/halfCosineRamp/halfCosineRamp.C index 0af8f3a35d..aa58ae0ac0 100644 --- a/src/OpenFOAM/primitives/functions/Function1/halfCosineRamp/halfCosineRamp.C +++ b/src/OpenFOAM/primitives/functions/Function1/halfCosineRamp/halfCosineRamp.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | Website: https://openfoam.org - \\ / A nd | Copyright (C) 2017-2019 OpenFOAM Foundation + \\ / A nd | Copyright (C) 2017-2020 OpenFOAM Foundation \\/ M anipulation | ------------------------------------------------------------------------------- License @@ -40,11 +40,11 @@ namespace Function1s Foam::Function1s::halfCosineRamp::halfCosineRamp ( - const word& entryName, + const word& name, const dictionary& dict ) : - Ramp(entryName, dict) + Ramp(name, dict) {} diff --git a/src/OpenFOAM/primitives/functions/Function1/halfCosineRamp/halfCosineRamp.H b/src/OpenFOAM/primitives/functions/Function1/halfCosineRamp/halfCosineRamp.H index ded35b8a61..1b1befcab8 100644 --- a/src/OpenFOAM/primitives/functions/Function1/halfCosineRamp/halfCosineRamp.H +++ b/src/OpenFOAM/primitives/functions/Function1/halfCosineRamp/halfCosineRamp.H @@ -68,7 +68,7 @@ public: //- Construct from entry name and dictionary halfCosineRamp ( - const word& entryName, + const word& name, const dictionary& dict ); diff --git a/src/OpenFOAM/primitives/functions/Function1/linearRamp/linearRamp.C b/src/OpenFOAM/primitives/functions/Function1/linearRamp/linearRamp.C index 497d7af565..428874aaa5 100644 --- a/src/OpenFOAM/primitives/functions/Function1/linearRamp/linearRamp.C +++ b/src/OpenFOAM/primitives/functions/Function1/linearRamp/linearRamp.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | Website: https://openfoam.org - \\ / A nd | Copyright (C) 2017-2019 OpenFOAM Foundation + \\ / A nd | Copyright (C) 2017-2020 OpenFOAM Foundation \\/ M anipulation | ------------------------------------------------------------------------------- License @@ -40,11 +40,11 @@ namespace Function1s Foam::Function1s::linearRamp::linearRamp ( - const word& entryName, + const word& name, const dictionary& dict ) : - Ramp(entryName, dict) + Ramp(name, dict) {} diff --git a/src/OpenFOAM/primitives/functions/Function1/linearRamp/linearRamp.H b/src/OpenFOAM/primitives/functions/Function1/linearRamp/linearRamp.H index da6e690d28..5d66d40107 100644 --- a/src/OpenFOAM/primitives/functions/Function1/linearRamp/linearRamp.H +++ b/src/OpenFOAM/primitives/functions/Function1/linearRamp/linearRamp.H @@ -68,7 +68,7 @@ public: //- Construct from entry name and dictionary linearRamp ( - const word& entryName, + const word& name, const dictionary& dict ); diff --git a/src/OpenFOAM/primitives/functions/Function1/objectFunction1/objectFunction1.H b/src/OpenFOAM/primitives/functions/Function1/objectFunction1/objectFunction1.H index 1774930b60..6cb1e703ed 100644 --- a/src/OpenFOAM/primitives/functions/Function1/objectFunction1/objectFunction1.H +++ b/src/OpenFOAM/primitives/functions/Function1/objectFunction1/objectFunction1.H @@ -70,7 +70,7 @@ class objectFunction1 template objectFunction1 ( - const word& entryName, + const word& name, const dictionary& dict, const type& ); @@ -83,7 +83,7 @@ public: template