diff --git a/applications/test/rigidBodyDynamics/sphericalJoint/sphericalJoint.C b/applications/test/rigidBodyDynamics/sphericalJoint/sphericalJoint.C index 75c63f273b..d69fdb54ca 100644 --- a/applications/test/rigidBodyDynamics/sphericalJoint/sphericalJoint.C +++ b/applications/test/rigidBodyDynamics/sphericalJoint/sphericalJoint.C @@ -64,8 +64,7 @@ int main(int argc, char *argv[]) sphericalJoint.joints()[1] ( quaternion(quaternion::ZYX, vector(0.3, 0, 0)), - sphericalJoint.state().q(), - sphericalJoint.state().w() + sphericalJoint.state().q() ); // Set the gravitational acceleration @@ -90,8 +89,7 @@ int main(int argc, char *argv[]) << t << " " << sphericalJoint.joints()[1] ( - sphericalJoint.state().q(), - sphericalJoint.state().w() + sphericalJoint.state().q() ).eulerAngles(quaternion::ZYX).x() << endl; } diff --git a/src/rigidBodyDynamics/joints/Pa/Pa.C b/src/rigidBodyDynamics/joints/Pa/Pa.C index 0bdfa0a42b..b30997acad 100644 --- a/src/rigidBodyDynamics/joints/Pa/Pa.C +++ b/src/rigidBodyDynamics/joints/Pa/Pa.C @@ -85,7 +85,6 @@ void Foam::RBD::joints::Pa::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Pa/Pa.H b/src/rigidBodyDynamics/joints/Pa/Pa.H index f27a8c850a..d67af31d9a 100644 --- a/src/rigidBodyDynamics/joints/Pa/Pa.H +++ b/src/rigidBodyDynamics/joints/Pa/Pa.H @@ -92,7 +92,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; diff --git a/src/rigidBodyDynamics/joints/Px/Px.C b/src/rigidBodyDynamics/joints/Px/Px.C index 412a3df472..a4a382c2a4 100644 --- a/src/rigidBodyDynamics/joints/Px/Px.C +++ b/src/rigidBodyDynamics/joints/Px/Px.C @@ -84,7 +84,6 @@ void Foam::RBD::joints::Px::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Px/Px.H b/src/rigidBodyDynamics/joints/Px/Px.H index b7d77f344a..979abcf5c0 100644 --- a/src/rigidBodyDynamics/joints/Px/Px.H +++ b/src/rigidBodyDynamics/joints/Px/Px.H @@ -92,7 +92,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/joints/Pxyz/Pxyz.C b/src/rigidBodyDynamics/joints/Pxyz/Pxyz.C index fcb5dac7e8..6d87412e81 100644 --- a/src/rigidBodyDynamics/joints/Pxyz/Pxyz.C +++ b/src/rigidBodyDynamics/joints/Pxyz/Pxyz.C @@ -88,7 +88,6 @@ void Foam::RBD::joints::Pxyz::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Pxyz/Pxyz.H b/src/rigidBodyDynamics/joints/Pxyz/Pxyz.H index 5fbdeb7833..02746bf14c 100644 --- a/src/rigidBodyDynamics/joints/Pxyz/Pxyz.H +++ b/src/rigidBodyDynamics/joints/Pxyz/Pxyz.H @@ -92,7 +92,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/joints/Py/Py.C b/src/rigidBodyDynamics/joints/Py/Py.C index 4b297bbcab..6fb02c4f54 100644 --- a/src/rigidBodyDynamics/joints/Py/Py.C +++ b/src/rigidBodyDynamics/joints/Py/Py.C @@ -84,7 +84,6 @@ void Foam::RBD::joints::Py::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Py/Py.H b/src/rigidBodyDynamics/joints/Py/Py.H index 981e7154af..bcbcd47785 100644 --- a/src/rigidBodyDynamics/joints/Py/Py.H +++ b/src/rigidBodyDynamics/joints/Py/Py.H @@ -92,7 +92,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/joints/Pz/Pz.C b/src/rigidBodyDynamics/joints/Pz/Pz.C index 83850020dd..6c90c36790 100644 --- a/src/rigidBodyDynamics/joints/Pz/Pz.C +++ b/src/rigidBodyDynamics/joints/Pz/Pz.C @@ -84,7 +84,6 @@ void Foam::RBD::joints::Pz::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Pz/Pz.H b/src/rigidBodyDynamics/joints/Pz/Pz.H index 18783f0d49..611397ded5 100644 --- a/src/rigidBodyDynamics/joints/Pz/Pz.H +++ b/src/rigidBodyDynamics/joints/Pz/Pz.H @@ -92,7 +92,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/joints/Ra/Ra.C b/src/rigidBodyDynamics/joints/Ra/Ra.C index 926f56a3b8..468985ea67 100644 --- a/src/rigidBodyDynamics/joints/Ra/Ra.C +++ b/src/rigidBodyDynamics/joints/Ra/Ra.C @@ -85,7 +85,6 @@ void Foam::RBD::joints::Ra::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Ra/Ra.H b/src/rigidBodyDynamics/joints/Ra/Ra.H index def3724c13..cd634f7b89 100644 --- a/src/rigidBodyDynamics/joints/Ra/Ra.H +++ b/src/rigidBodyDynamics/joints/Ra/Ra.H @@ -92,7 +92,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; diff --git a/src/rigidBodyDynamics/joints/Rs/Rs.C b/src/rigidBodyDynamics/joints/Rs/Rs.C index 9658b7595e..e7b284ebed 100644 --- a/src/rigidBodyDynamics/joints/Rs/Rs.C +++ b/src/rigidBodyDynamics/joints/Rs/Rs.C @@ -94,11 +94,10 @@ void Foam::RBD::joints::Rs::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { - J.X.E() = operator()(q, w).R().T(); + J.X.E() = operator()(q).R().T(); J.X.r() = Zero; J.S = Zero; diff --git a/src/rigidBodyDynamics/joints/Rs/Rs.H b/src/rigidBodyDynamics/joints/Rs/Rs.H index 386a869bf6..9672168e8f 100644 --- a/src/rigidBodyDynamics/joints/Rs/Rs.H +++ b/src/rigidBodyDynamics/joints/Rs/Rs.H @@ -97,7 +97,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/joints/Rx/Rx.C b/src/rigidBodyDynamics/joints/Rx/Rx.C index 87343fe55f..e2d3f6953d 100644 --- a/src/rigidBodyDynamics/joints/Rx/Rx.C +++ b/src/rigidBodyDynamics/joints/Rx/Rx.C @@ -84,7 +84,6 @@ void Foam::RBD::joints::Rx::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Rx/Rx.H b/src/rigidBodyDynamics/joints/Rx/Rx.H index 3da54830a9..892cfcb709 100644 --- a/src/rigidBodyDynamics/joints/Rx/Rx.H +++ b/src/rigidBodyDynamics/joints/Rx/Rx.H @@ -92,7 +92,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/joints/Rxyz/Rxyz.C b/src/rigidBodyDynamics/joints/Rxyz/Rxyz.C index 39b3d5f7de..2055c67488 100644 --- a/src/rigidBodyDynamics/joints/Rxyz/Rxyz.C +++ b/src/rigidBodyDynamics/joints/Rxyz/Rxyz.C @@ -88,7 +88,6 @@ void Foam::RBD::joints::Rxyz::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Rxyz/Rxyz.H b/src/rigidBodyDynamics/joints/Rxyz/Rxyz.H index 3a63a4ffbe..43582796de 100644 --- a/src/rigidBodyDynamics/joints/Rxyz/Rxyz.H +++ b/src/rigidBodyDynamics/joints/Rxyz/Rxyz.H @@ -93,7 +93,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/joints/Ry/Ry.C b/src/rigidBodyDynamics/joints/Ry/Ry.C index d771a7130f..89d414ecc3 100644 --- a/src/rigidBodyDynamics/joints/Ry/Ry.C +++ b/src/rigidBodyDynamics/joints/Ry/Ry.C @@ -84,7 +84,6 @@ void Foam::RBD::joints::Ry::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Ry/Ry.H b/src/rigidBodyDynamics/joints/Ry/Ry.H index 4bfa32401f..0a870bd925 100644 --- a/src/rigidBodyDynamics/joints/Ry/Ry.H +++ b/src/rigidBodyDynamics/joints/Ry/Ry.H @@ -92,7 +92,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/joints/Ryxz/Ryxz.C b/src/rigidBodyDynamics/joints/Ryxz/Ryxz.C index 2de4088517..fd5f942e33 100644 --- a/src/rigidBodyDynamics/joints/Ryxz/Ryxz.C +++ b/src/rigidBodyDynamics/joints/Ryxz/Ryxz.C @@ -88,7 +88,6 @@ void Foam::RBD::joints::Ryxz::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Ryxz/Ryxz.H b/src/rigidBodyDynamics/joints/Ryxz/Ryxz.H index 02a7fe4200..1371abcf80 100644 --- a/src/rigidBodyDynamics/joints/Ryxz/Ryxz.H +++ b/src/rigidBodyDynamics/joints/Ryxz/Ryxz.H @@ -93,7 +93,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/joints/Rz/Rz.C b/src/rigidBodyDynamics/joints/Rz/Rz.C index 9027e2d8c7..c02ba9cec1 100644 --- a/src/rigidBodyDynamics/joints/Rz/Rz.C +++ b/src/rigidBodyDynamics/joints/Rz/Rz.C @@ -84,7 +84,6 @@ void Foam::RBD::joints::Rz::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Rz/Rz.H b/src/rigidBodyDynamics/joints/Rz/Rz.H index 19a7697503..01ed3139b0 100644 --- a/src/rigidBodyDynamics/joints/Rz/Rz.H +++ b/src/rigidBodyDynamics/joints/Rz/Rz.H @@ -92,7 +92,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/joints/Rzyx/Rzyx.C b/src/rigidBodyDynamics/joints/Rzyx/Rzyx.C index 7b1a8bc1fc..1e35932222 100644 --- a/src/rigidBodyDynamics/joints/Rzyx/Rzyx.C +++ b/src/rigidBodyDynamics/joints/Rzyx/Rzyx.C @@ -88,7 +88,6 @@ void Foam::RBD::joints::Rzyx::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/Rzyx/Rzyx.H b/src/rigidBodyDynamics/joints/Rzyx/Rzyx.H index 344ad4fbc1..3aeb85dd63 100644 --- a/src/rigidBodyDynamics/joints/Rzyx/Rzyx.H +++ b/src/rigidBodyDynamics/joints/Rzyx/Rzyx.H @@ -93,7 +93,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/joints/composite/compositeJoint.C b/src/rigidBodyDynamics/joints/composite/compositeJoint.C index 28044e9493..819d575962 100644 --- a/src/rigidBodyDynamics/joints/composite/compositeJoint.C +++ b/src/rigidBodyDynamics/joints/composite/compositeJoint.C @@ -96,11 +96,10 @@ void Foam::RBD::joints::composite::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { - last().jcalc(J, q, w, qDot); + last().jcalc(J, q, qDot); } diff --git a/src/rigidBodyDynamics/joints/composite/compositeJoint.H b/src/rigidBodyDynamics/joints/composite/compositeJoint.H index c3033b4abd..80f3496fa7 100644 --- a/src/rigidBodyDynamics/joints/composite/compositeJoint.H +++ b/src/rigidBodyDynamics/joints/composite/compositeJoint.H @@ -109,7 +109,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; diff --git a/src/rigidBodyDynamics/joints/joint/joint.H b/src/rigidBodyDynamics/joints/joint/joint.H index bdab806be3..eb06419e93 100644 --- a/src/rigidBodyDynamics/joints/joint/joint.H +++ b/src/rigidBodyDynamics/joints/joint/joint.H @@ -236,7 +236,6 @@ public: ( XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const = 0; @@ -250,8 +249,7 @@ public: // if it uses a quaternion representation for rotation inline quaternion operator() ( - const scalarField& q, - const scalarField& w + const scalarField& q ) const; //- Set the state quaternion for this joint @@ -259,8 +257,7 @@ public: inline void operator() ( const quaternion& quat, - scalarField& q, - scalarField& w + scalarField& q ) const; diff --git a/src/rigidBodyDynamics/joints/joint/jointI.H b/src/rigidBodyDynamics/joints/joint/jointI.H index 0b33fb9322..090adb18d2 100644 --- a/src/rigidBodyDynamics/joints/joint/jointI.H +++ b/src/rigidBodyDynamics/joints/joint/jointI.H @@ -71,8 +71,7 @@ inline const Foam::List& Foam::RBD::joint::S() const inline Foam::quaternion Foam::RBD::joint::operator() ( - const scalarField& q, - const scalarField& w + const scalarField& q ) const { if (nw() != 1) @@ -82,15 +81,14 @@ inline Foam::quaternion Foam::RBD::joint::operator() << abort(FatalError); } - return quaternion(w[wIndex_], q.block(qIndex_)); + return quaternion::unit(q.block(qIndex_)); } inline void Foam::RBD::joint::operator() ( const quaternion& quat, - scalarField& q, - scalarField& w + scalarField& q ) const { if (nw() != 1) @@ -100,7 +98,6 @@ inline void Foam::RBD::joint::operator() << abort(FatalError); } - w[wIndex_] = quat.w(); q[qIndex_] = quat.v().x(); q[qIndex_+1] = quat.v().y(); q[qIndex_+2] = quat.v().z(); diff --git a/src/rigidBodyDynamics/joints/null/nullJoint.C b/src/rigidBodyDynamics/joints/null/nullJoint.C index 30b72b1907..baed48767f 100644 --- a/src/rigidBodyDynamics/joints/null/nullJoint.C +++ b/src/rigidBodyDynamics/joints/null/nullJoint.C @@ -80,7 +80,6 @@ void Foam::RBD::joints::null::jcalc ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const { diff --git a/src/rigidBodyDynamics/joints/null/nullJoint.H b/src/rigidBodyDynamics/joints/null/nullJoint.H index 68844d2e5f..cc97aed72b 100644 --- a/src/rigidBodyDynamics/joints/null/nullJoint.H +++ b/src/rigidBodyDynamics/joints/null/nullJoint.H @@ -92,7 +92,6 @@ public: ( joint::XSvc& J, const scalarField& q, - const scalarField& w, const scalarField& qDot ) const; }; diff --git a/src/rigidBodyDynamics/rigidBodyModel/forwardDynamics.C b/src/rigidBodyDynamics/rigidBodyModel/forwardDynamics.C index fafce3431f..a43e57a828 100644 --- a/src/rigidBodyDynamics/rigidBodyModel/forwardDynamics.C +++ b/src/rigidBodyDynamics/rigidBodyModel/forwardDynamics.C @@ -54,7 +54,6 @@ void Foam::RBD::rigidBodyModel::forwardDynamics ) const { const scalarField& q = state.q(); - const scalarField& w = state.w(); const scalarField& qDot = state.qDot(); scalarField& qDdot = state.qDdot(); @@ -71,7 +70,7 @@ void Foam::RBD::rigidBodyModel::forwardDynamics for (label i=1; i> ) { is >> state.q_ - >> state.w_ >> state.qDot_ >> state.qDdot_; @@ -77,7 +74,6 @@ Foam::Ostream& Foam::RBD::operator<< ) { os << token::SPACE << state.q_ - << token::SPACE << state.w_ << token::SPACE << state.qDot_ << token::SPACE << state.qDdot_; diff --git a/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolver.C b/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolver.C index 7cfc931778..9156db842c 100644 --- a/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolver.C +++ b/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolver.C @@ -76,11 +76,11 @@ void Foam::RBD::rigidBodySolver::correctQuaternionJoints() // Transform the previous time quaternion quaternion quat ( - normalize(model_.joints()[i](q0(), w0())*dQuat) + normalize(model_.joints()[i](q0())*dQuat) ); // Update the joint state - model_.joints()[i](quat, q(), w()); + model_.joints()[i](quat, q()); } } } diff --git a/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolver.H b/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolver.H index 0183a4be71..cdcdc0af59 100644 --- a/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolver.H +++ b/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolver.H @@ -75,7 +75,6 @@ protected: inline scalarField& q(); //- Return the current joint quaternion - inline scalarField& w(); //- Return the current joint velocity inline scalarField& qDot(); @@ -88,7 +87,6 @@ protected: inline const scalarField& q0() const; //- Return the current joint quaternion - inline const scalarField& w0() const; //- Return the current joint velocity inline const scalarField& qDot0() const; diff --git a/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolverI.H b/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolverI.H index d1ddbd6880..1d781854b1 100644 --- a/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolverI.H +++ b/src/rigidBodyDynamics/rigidBodySolvers/rigidBodySolver/rigidBodySolverI.H @@ -56,12 +56,6 @@ inline Foam::scalarField& Foam::RBD::rigidBodySolver::q() } -inline Foam::scalarField& Foam::RBD::rigidBodySolver::w() -{ - return state().w(); -} - - inline Foam::scalarField& Foam::RBD::rigidBodySolver::qDot() { return state().qDot(); @@ -80,12 +74,6 @@ inline const Foam::scalarField& Foam::RBD::rigidBodySolver::q0() const } -inline const Foam::scalarField& Foam::RBD::rigidBodySolver::w0() const -{ - return state0().w(); -} - - inline const Foam::scalarField& Foam::RBD::rigidBodySolver::qDot0() const { return state0().qDot();