Commit Graph

5599 Commits

Author SHA1 Message Date
e5892377d8 snappyHexMesh::refinementParameters: Rationalised handling of cell region selection parameters 2021-09-27 14:25:58 +01:00
b39d6b224f snappyHexMesh: Added locationsInMesh specification
In order to select to keep the cells in multiple disconnected regions it is
necessary to specify a location in each of those regions as a list of points,
e.g.

castellatedMeshControls
{
.
.
.
    locationsInMesh
    (
        (-0.18 0.003 0.05 )
        (-0.09 0.003 0.05)
        (0.09  0.003 0.05)
        (0.18  0.003 0.05)
    );
.
.
.
}

The locationInMesh control is still available for backward compatibility and to
specify a point when meshing a single region.
2021-09-27 11:43:01 +01:00
98686ae760 turbulentTemperatureCoupledBaffleMixedFvPatchScalarField: Corrected handling of qs 2021-09-23 22:37:05 +01:00
96a86fac56 turbulentTemperatureCoupledBaffleMixedFvPatchScalarField: Improved the error message
when both qs and Qs are specified.
2021-09-23 22:28:38 +01:00
5fa7c72d95 tutorials::circuitBoardCooling: Updated 1DTemperatureMasterBafflePatches 2021-09-23 17:39:35 +01:00
185b718499 dimensionedType: Generalise the read function
to support re-reading with or without name or dimensions.
2021-09-23 17:20:29 +01:00
f1b862390f turbulentTemperatureCoupledBaffleMixedFvPatchScalarField: Added support for a heat source
Description
    Mixed boundary condition for temperature, to be used for heat-transfer
    on back-to-back baffles. Optional thin thermal layer resistances can be
    specified through thicknessLayers and kappaLayers entries.

    Specifies gradient and temperature such that the equations are the same
    on both sides:
      - refGradient = (qs_ + qsNbr)/kappa
      - refValue = neighbour value
      - mixFraction = nbrKDelta / (nbrKDelta + myKDelta())

    where KDelta is heat-transfer coefficient K*deltaCoeffs
    and qs is the optional source heat flux.

    The thermal conductivity \c kappa can either be retrieved from various
    possible sources, as detailed in the class temperatureCoupledBase.

Usage
    \table
        Property     | Description             | Required    | Default value
        Tnbr         | name of the field       | no          | T
        thicknessLayers | list of thicknesses per layer [m] | no |
        kappaLayers  | list of thermal conductivities per layer [W/m/K] | no |
        qs           | Optional source heat flux [W/m^2] | no | 0
        Qs           | Optional heat source [W]          | no | 0
    \endtable

    Example of the boundary condition specification:
    \verbatim
    <patchName>
    {
        type            compressible::turbulentTemperatureCoupledBaffleMixed;
        Tnbr            T;
        thicknessLayers (0.1 0.2 0.3 0.4);
        kappaLayers     (1 2 3 4);
        qs              uniform 100;    // Optional source heat flux [W/m^2]
        value           uniform 300;
    }
    \endverbatim

    Needs to be on underlying mapped(Wall)FvPatch.

    Note that in order to provide an optional heat source either qs or Qs
    should be specified, not both.
2021-09-23 16:10:38 +01:00
e627c7e98f thermalBaffle1DFvPatchScalarField: Changed name of source heat flux Qs -> qs for consistency
Qs is used for total heat source (W) and qs is used for heat flux (W/m^2)

Backward compatibility is provided.
2021-09-23 14:13:26 +01:00
fdb118878b solidSpecie/transport: Reverted consistency change to write
in order to support the current implementation of
thermalBaffle1DFvPatchScalarField
2021-09-23 14:11:31 +01:00
285a4502c3 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-09-22 19:25:46 +01:00
3466d8f58c tabulatedSolidTransport: New tabulated solid thermal conductivity model
Description
    Transport properties package using non-uniformly-spaced tabulated data for
    thermal conductivity vs temperature.

Usage
    \table
        Property        | Description
        kappa           | Thermal conductivity vs temperature table
    \endtable

    Example of the specification of the transport properties:
    \verbatim
    transport
    {
        kappa
        {
            values
            (
                (200 380)
                (350 400)
                (400 450)
            );
        }
    }
    \endverbatim
2021-09-22 19:23:50 +01:00
af3769dc4e foamInfo: added character classes to bracket expressions 20210922 2021-09-22 16:31:36 +01:00
1ca8ff74a9 solidThermo: Added support for run-time compilation
This required standardisation of the mapping between the class and selection
names of the solid transport models:

constIso -> constIsoSolid
exponential -> exponentialSolid
polynomial -> polynomialSolid
2021-09-22 14:39:18 +01:00
59a91e28f1 Function1, Function2: Added ';' to TypeName statements for consistency
This is not strictly necessary but it makes the code look more regular.
2021-09-22 10:04:52 +01:00
280251ca55 error::notImplemented: Added Foam scope to FatalError
so that notImplemented can be used outside the Foam namespace
2021-09-21 12:50:08 +01:00
d7133914fc regIOobject::rename: Only rename the object if the name is different avoiding the checkOut/checkIn 2021-09-20 16:23:18 +01:00
102149135e fvConstraints: Corrected evaluation order
Resolves bug-report https://bugs.openfoam.org/view.php?id=3728
2021-09-16 21:51:54 +01:00
7515124752 etc/codeTemplates/dynamicCode/basicChemistryModelTemplate.C: Updated for merged chemistryModel 2021-09-16 16:45:40 +01:00
a3f1a29988 coordinateSystems: Removed test Pout 2021-09-15 08:49:24 +01:00
b03b6f0dc4 codedFvModelTemplate.C: Added missing return statement 2021-09-14 21:39:24 +01:00
47014e0c7c coordinateSystems: Corrected handing for parallel running 2021-09-14 21:08:00 +01:00
3e15722567 coordinateSystem: Added copy constructor and assignment operator
Resolves bug-report https://bugs.openfoam.org/view.php?id=3727
2021-09-14 09:24:26 +01:00
5da0d1cf6f functionObjects::comfort: Corrected for clang 2021-09-14 08:48:53 +01:00
8fd9f5758c chemistryModel: new general chemistry solver created by merging standardChemistryModel and TDACChemistryModel
To simplify maintenance and further development of chemistry solution the
standardChemistryModel and TDACChemistryModel have been merged into the single
chemistryModel class.  Now the TDAC mechanism reduction and tabulation
components can be individually selected or set to "none" or the corresponding
entries in the chemistryProperties dictionary omitted to switch them off thus
reproducing the behaviour of the standardChemistryModel.

For example the following chemistryProperties includes TDAC:

    #includeEtc "caseDicts/solvers/chemistry/TDAC/chemistryProperties.cfg"

    chemistryType
    {
        solver            ode;
    }

    chemistry       on;

    initialChemicalTimeStep 1e-7;

    odeCoeffs
    {
        solver          seulex;
        absTol          1e-8;
        relTol          1e-1;
    }

    reduction
    {
        tolerance   1e-4;
    }

    tabulation
    {
        tolerance   3e-3;
    }

    #include "reactionsGRI"

and to run without TDAC the following is sufficient:

    chemistryType
    {
        solver            ode;
    }

    chemistry       on;

    initialChemicalTimeStep 1e-7;

    odeCoeffs
    {
        solver          seulex;
        absTol          1e-8;
        relTol          1e-1;
    }

    #include "reactionsGRI"

or the "reduction" and "tabulation" entries can be disabled explicitly:

    #includeEtc "caseDicts/solvers/chemistry/TDAC/chemistryProperties.cfg"

    chemistryType
    {
        solver            ode;
    }

    chemistry       on;

    initialChemicalTimeStep 1e-7;

    odeCoeffs
    {
        solver          seulex;
        absTol          1e-8;
        relTol          1e-1;
    }

    reduction
    {
        method      none;
        tolerance   1e-4;
    }

    tabulation
    {
        method      none;
        tolerance   3e-3;
    }

    #include "reactionsGRI"
2021-09-13 12:17:40 +01:00
8a104e2d53 TDACChemistryModel: Completed separation from standardChemistryModel
Another step towards merging TDACChemistryModel with standardChemistryModel to
create a single general chemistryModel.
2021-09-10 23:31:07 +01:00
8805c03c4d Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-09-10 16:34:08 +01:00
41be50ab58 TDACChemistryModel: Further simplification and rationalisation
removed confusing duplicate storage of the complete species composition field.
2021-09-10 16:32:22 +01:00
7f926bb1da DimensionedSymmTensorField: Added missing includes 2021-09-08 09:49:38 +01:00
5d1a756178 etc/config.sh/unset: Added missing environment variables 2021-09-08 09:04:40 +01:00
18bd2b24df Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-09-07 21:09:22 +01:00
1932addc2c TDACChemistryModel: Rationalised interface to reduction and tabulation methods
Most tabulation and reduction specific code in TDACChemistryModel has been moved
into the appropriate tabulation and reduction classes and the "none" methods of
each simplified so that they can be instantiated without any user input.  This
allows the "none" tabulation and reduction methods to be selected automatically
when the "tabulation" or "reduction" entries are not present in the
chemistryProperties dictionary so that the TDACChemistryModel can be run in the
same manner as the standardChemistryModel when tabulation and reduction are not
required.

This is the first step towards merging TDACChemistryModel with standardChemistryModel.
2021-09-07 21:03:55 +01:00
3f8baf9c12 Merge branch 'master' of github.com:OpenFOAM/OpenFOAM-dev 2021-09-07 17:19:36 +01:00
8830b2fa1e etc/bashrc: removed sourcing of additional files passed as
arguments to the original sourced file. Caused an infinite loop if original source command
is called within a function, e.g.

sourceFile() {
    . $1
}
2021-09-07 17:19:13 +01:00
4736c42343 etc/bashrc: removed sourcing of additional files passed as
arguments to the original sourced file. Causes an infinite loop if original source command
is called within a function, e.g.

sourceFile() {
    .
}

sourceFile etc/bashrc
2021-09-07 17:10:13 +01:00
19950fa3b8 functionObjects::comfort: extended to calculate the draught rate (DR)
The draught rate determines the percentage of affected people by an airflow
caused due to room ventilation or buoyancy effects (cold windows). The draught
rate calculation is valid for room temperatures between 20 and 26 degrees
Celsius and airspeed less than 0.5 m/s.  This quantity is used widely for
quantifying offices, auditoriums, or similar rooms in which persons are working.

Patch contributed by Tobias Holzmann
2021-09-03 19:38:16 +01:00
531904ebae AMIMethod, mapNearestMethod: Removed unnecessary and inconsistent name enumerations
Both AMIMethod and mapNearestMethod are run-time selectable using the standard
OpenFOAM constructor tables, they do not need a separate enumeration-based
selection method which requires duplicate constructors and a lot of other
clutter.
2021-09-03 16:27:39 +01:00
c180395e0c topoSet: rotatedBoxToCell: Added box and rotation specification
The rotatedBoxToCell topoSet source can now be specified by providing
the geometry of a non-rotated box and how it should be rotated. For
example, in system/topoSetDict:

    actions
    (
        {
            name    c1;
            type    cellSet;
            action  new;
            source  rotatedBoxToCell;
            box     (0.4 0.4 -100) (0.6 0.6 100);
            centre  (0.4 0.4 0);
            n1      (1 0 0);
            n2      (1 1 0);
        }
    );

This selects cells in a box rotated from (1 0 0) to (1 1 0) (i.e., 45
degrees around the z-axis), with width and depth of 0.2, height of 200,
and with a bottom left corner at (0.4 0.4 -100).

The origin, i, j, k, specification is still available, and will be used
if the keyword "box" is not present. The equivalent input to the above
in this form is as follows:

    actions
    (
        {
            name    c1;
            type    cellSet;
            action  new;
            source  rotatedBoxToCell;
            origin  (0.4 0.4 -100);
            i       (0.141421 0.141421 0);
            j       (-0.141421 0.141421 0);
            k       (0 0 200);
        }
    );
2021-09-03 15:08:39 +01:00
e6fdd180e8 mapFieldsPar: Corrected handling of argList and reverted change to createTimes.H 2021-09-02 19:45:14 +01:00
3554f2140e Test-IOField: Updated and improved to use typeIOobject 2021-09-02 07:55:49 +01:00
2b5edb1119 specieTransferVelocity: Use base class dictionary constructor 2021-09-01 14:01:11 +01:00
c4187efc28 tutorials: DTCHullWave: Increase upstream mesh density
The mesh in the upstream region of this case has been refined back to
its original density. This restores the wave propagation behaviour
through this region.
2021-09-01 10:56:47 +01:00
559fe8ca7e waves: Optionally input period rather than length for Stokes-type waves
Stokes-type waves (i.e., Airy, Stokes2 and Stokes5) now support
specification in terms of wave period, as well as length. The following
specifications are therefore equivalent:

    Stokes2
    {
        length      300; // <-- Wave length specified
        amplitude   2.5;
        phase       0;
        angle       0;
        depth       50;
    }

    Stokes2
    {
        period      15.643; // <-- Wave period specified
        amplitude   2.5;
        phase       0;
        angle       0;
        depth       50;
    }

Note that the period is that of the wave in a reference frame with zero
mean flow. Specifying a doppler shifted period is not yet supported.

Exactly one of period or length must be specified. If both, or neither,
are provided then an error will be generated.

Corrections have also been made to the calculation of the celerity of
Stokes2 and Stokes5 waves.
2021-09-01 10:56:26 +01:00
d07713062a specieTransfer: Improved inlet-outlet handling for velocity boundary condition 2021-09-01 10:56:08 +01:00
96508b8406 waves: Removed unused pressure method and simplified handling of gravity 2021-09-01 10:55:51 +01:00
1c48685b09 waves: Improved reverse flow formulation and new test cases
It is now possible to use waveVelocity and waveAlpha boundary conditions
in cases in which the waves generate localised flow reversals along the
boundary. This means waves can be speficied at arbitrary directions and
with zero mean flow. Previously and integral approach, similar to
flowRateOutlet, was used, which was only correct when the direction of
wave propagation was aligned with the boundary normal.

This improvement has been achieved by reformulating the waveVelocity and
waveAlpha boundary conditions in terms of a new fixedValueInletOutlet
boundary condition type. This condition enforces a fixed value in all
cases except that of advection terms in the presence of outflow. In this
configuration a gradient condition is applied that will relax towards
the desired fixed value.

The wavePressure boundary condition has been removed, as it is no longer
necessary or advisable to locally switch between velocity and pressure
formulations along a wave boundary. Wave boundaries should now have the
general fixedFluxPressure or fixedFluxExtrapolatedPressure conditions
applied to the pressure field.

Two new tutorial cases have been created to demonstrate the new
functionality. The multiphase/interFoam/laminar/wave3D case demonstrates
wave generation with zero mean flow and at arbitrary angles to the
boundaries, and incompressible/pimpleFoam/RAS/waveSubSurface
demonstrates usage for sub-surface problems.
2021-09-01 10:55:23 +01:00
984066f81e Corrected typos 2021-08-30 16:37:38 +01:00
8dbbe122f1 thermophysicalModels/specie/transport: Added documentation with examples 2021-08-30 16:29:45 +01:00
b3e02df01a thermophysicalModels/specie/thermo: Added documentation with examples 2021-08-30 14:31:41 +01:00
61174d8fa8 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-08-30 10:31:30 +01:00
e6d7b7aa3f mapFieldsPar: added createTimes.H from mapFields
Resolves bug-report https://bugs.openfoam.org/view.php?id=3722
2021-08-30 10:29:56 +01:00