Commit Graph

3895 Commits

Author SHA1 Message Date
52225b96ab CorrectPhi: Added switch to control evaluation of U boundary conditions
This switch should be on for phi-correction within the time loop, where
the correction simply serves to keep the phi-field up to date before the
U-equation is solved. It should be off for initialisation
phi-correction, as the necessary data to update the conditions may not
yet exist.

Resolves bug report https://bugs.openfoam.org/view.php?id=3198
2019-03-18 16:02:25 +00:00
118f7c88f8 tutorials::membrane/Allrun: Fixed scipting typo 2019-03-18 12:23:32 +00:00
51edeaaa1f tutorials/multiphase/interFoam/RAS/mixerVesselAMI: Rationalised phase names and properties 2019-03-16 18:10:33 +00:00
becf7d2905 Function1: Improved error messages when evaluation or integration are undefined 20190316 2019-03-15 14:09:51 +00:00
2dd8b51d2a Removed redundant file 2019-03-15 11:52:15 +00:00
18bd64314c Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2019-03-15 11:17:57 +00:00
c97e133c04 tutorials/incompressible/simpleFoam/motorBike/system/controlDict: Reverted change 2019-03-15 11:17:07 +00:00
4519f47ab8 phasesScalarTransport: Corrected compressible fvOptions usage 2019-03-15 08:49:39 +00:00
081db9a350 lagrangian: drag: Various improvements
The dense drag models (WenYu, ErgunWenYu and PlessisMasliyah) have been
extended so that they can create their own void-fraction field when one
is not otherwise available.

The duplicated functionality in the drag models has been generalised and
is now utilised by multiple models.

References have been added for all models for which they could be found.
In addition, an additional drag model, SchillerNaumann, has been added.
This is of the same form as sphereDrag, and is designed for the same
scenario; sparsely distributed spherical particles. The SchillerNaumann
form is more widely referenced and should now be considered standard.

The thermo-parcel-specific force instantiation macro has been removed,
as all the force models are now possible to use with all parcel types.

Resolves bug report https://bugs.openfoam.org/view.php?id=3191
2019-03-15 08:49:39 +00:00
d41166187a writeEntry: Rationalised for consistency, ease of use and maintainability
The writeEntry form is now defined and used consistently throughout OpenFOAM
making it easier to use and extend, particularly to support binary IO of complex
dictionary entries.
2019-03-14 20:54:10 +00:00
c1d0fa6cac hooks: Added check to ensure scripts are executable
Based on a patch contributed by Institute of Fluid Dynamics,
Helmholtz-Zentrum Dresden - Rossendorf (HZDR)
2019-03-13 14:12:47 +00:00
0ce996ffd4 hooks: Refactor
The hook functions now all work in terms of local variables and argument
passing. They return error codes rather than exiting. Fixing issues
(updating copyright and correcting ifndef/define names) is now optional.
The "interactive" aspect of the pre-recieve hook has been removed and
placed into a new interactive-hook script that can be used for checking
without commiting. The pre-recieve-hook has been updated to include all
the newer checking added to pre-commit-hook.
2019-03-13 12:40:25 +00:00
fec55234b6 LangmuirHinshelwoodReactionRate: Removed unused species_ member 2019-03-12 17:28:51 +00:00
d6f6747d63 PrimitivePatch: Added Istream constructor and iNew 2019-03-12 17:28:03 +00:00
23d7371592 CompactIOList: Derived from ListCompactIO to reuse the steam IO 2019-03-12 17:26:19 +00:00
64b7793422 ListCompactIO: Separated the stream IO functions from CompactIOList
as a separate class.
2019-03-12 17:24:30 +00:00
6b5f0928e5 UPtrList: Added writeEntry and writeEntryList
to write the list as a dictionary entry.  Consistent with the equivalent
functions in UList.
2019-03-12 17:23:19 +00:00
59b533e961 UList: Added writeEntryList
for writing list-lists dictionary entries efficiently in binary.
2019-03-12 17:21:49 +00:00
9a22110c14 rigidBodyState: Added compilation to src/Allwmake 2019-03-08 09:07:35 +00:00
88bea2740c data: Reset solver data only when non-sub cycled time index changes
Resolves bug report https://bugs.openfoam.org/view.php?id=3189
2019-03-07 16:23:33 +00:00
5e7c0aaac1 swirlFlowRateInletVelocityFvPatchVectorField: Added reduction to patch size
Resolves bug-report https://bugs.openfoam.org/view.php?id=3185
2019-03-05 12:07:19 +00:00
b5e27b7a9d polyMesh/particle: Optionally store old-cell centres
The moving-mesh tracking algorithm needs the cell-centres at the
previous time-step. These were not originally stored by the polyMesh, so
they were being generated on-the-fly. In some tracking-dominated cases
this caused an unacceptable overhead.

The polyMesh now stores the old-time cell-centres on demand. They are
not stored by default (like the old-time points), so if they are needed
then the accessor should be called before any mesh motion. Typically
this will be during construction of whatever functionality requires it.
See Cloud.C for an example.

The logic for storage and update of the old-time points has also been
improved to account for the possibility of the mesh motion coming to an
end.
20190304
2019-03-04 08:59:24 +00:00
8f0772d7d2 tutorials::floatingObject: Added rigidBodyState functionObject 2019-03-01 13:51:59 +00:00
d399b83f08 rigidBodyState: New functionObject which writes the state of the rigid body model
It is the rigidBody equivalent of the sixDoFRigidBodyState functionObject.

    Example of function object specification:
    rigidBodyState
    {
        type           rigidBodyState;
        libs           ("librigidBodyState.so");
        angleFormat    degrees;
    }

Based on patch contributed by SeongMo Yeon
Resolves patch request https://bugs.openfoam.org/view.php?id=3180
2019-03-01 13:49:08 +00:00
5c8b15d49d sixDoFRigidBodyState: Minor clean-up 2019-03-01 13:48:52 +00:00
58019d64f9 rigidBodyMeshMotion, rigidBodyMeshMotionSolver: Derive from RBD::rigidBodyMotion
Provides easy access to the state of the rigid body model.
2019-03-01 13:48:02 +00:00
b294ab1d7c rigidBodyModel: Added movingBodyNames() member function
which returns the list of names of the moving bodies in the model.
2019-03-01 13:47:22 +00:00
e68246b392 Revert "rigidBodyModel: Added movingBodyNames() member function"
This reverts commit a395752fa8.
2019-03-01 13:45:43 +00:00
a395752fa8 rigidBodyModel: Added movingBodyNames() member function
which returns the list of names of the moving bodies in the model.
2019-03-01 13:44:01 +00:00
f60147fc11 waveDisplacementPointPatchVectorField: Added spacial and temporal ramping 2019-02-26 09:40:32 +00:00
9038895701 swirlInletVelocityFvPatchVectorField: Minor correction to documentation 2019-02-26 09:40:11 +00:00
850a347b69 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2019-02-25 11:34:40 +00:00
fa33e8e198 blockMesh: Added printing of cell edge lengths for distorted blocks 2019-02-25 11:33:46 +00:00
7f09e1901d CloudFunctionObjects: Added relativeVelocity
This cloud function object will write out a lagrangian field of the
relative velocity between the parcels and the surrounding fluid. It
does not have any additional controls.
2019-02-25 09:31:32 +00:00
a88405a138 foamDictionary: Added support for writing dictionaries containing binary entries 2019-02-22 15:59:55 +00:00
190dd33576 externalWallHeatFluxTemperature: Changed relaxation strategy
Now uses previous valueFraction and refValue values rather than the previous
boundary temperature for relaxation.

Resolves bug-report https://bugs.openfoam.org/view.php?id=3175
2019-02-22 12:34:38 +00:00
a4e6adcd54 foamDictionary: Added initial support for dictionaries containing binary data
The dictionary read is set to binary if there is a "FoamFile" header present
which specifies binary format.
2019-02-21 20:02:13 +00:00
2433fe950c Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2019-02-21 13:58:45 +00:00
b162c4818b ddtScheme::fvcDdtPhiCoeff: Reverted to previous flux-normalised scheme
The current Courant number limited formulation is preferable for cases running
with VERY small Courant numbers but there are stability issues with it on some
cases for which the previous flux-normalised scheme worked well.  Overall the
previous scheme has proved more reliable and fvcDdtPhiCoeff has been reverted to
it pending further research and development in this area which will require
funding:

https://openfoam.org/news/funding-2019/
https://openfoam.org/maintenance/
2019-02-21 13:54:41 +00:00
d7a5456aae convergenceControl: Store solve index per-field not per-entry
Resolves bug report https://bugs.openfoam.org/view.php?id=3173
2019-02-20 14:23:09 +00:00
4f3c3eaab1 functionObjects: phaseScalarTransport: Made writing of alpha*s switchable 2019-02-18 15:20:40 +00:00
c56f2a2e15 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2019-02-18 12:29:06 +00:00
d2bddb8cca pressureControl: Added p.correctBoundaryConditions() after the pressure limiting
to ensure boundary consistency.
2019-02-18 12:26:52 +00:00
a86fe1f3ac functionObjects: phaseScalarTransport: Solution control update 2019-02-15 16:55:18 +00:00
111cdf3a65 solutionControl: Renaming and improved final logic
The sub-loops of the solution control are now named more consistently,
with ambiguously named methods such as finalIter replaced with ones
like finalPimpleIter, so that it is clear which loop they represent.

In addition, the final logic has been improved so that it restores state
after a sub-iteration, and so that sub-iterations can be used on their
own without an outer iteration in effect. Previously, if the
non-orthogonal loop were used outside of a pimple/piso iteration, the
final iteration would not execute with final settings.
2019-02-15 16:55:11 +00:00
7b1840c7d3 functionObjects: Added phaseScalarTransport function
This is like the scalarTrasport function except that the transported
scalar is confined to a single phase of a multiphase simulation. In
addition to the usual specification for the scalarTransport function
(i.e., a field, schemes and solution parameters), the user needs to
specify the phase-flux or a pressure field which can be used to generate
it.

Example usage for interFoam:

    phaseScalarTransport1
    {
        type            phaseScalarTransport;
        libs            ("libsolverFunctionObjects.so");

        field           s.water;
        p               p_rgh;
    }

Example usage for reactingTwoPhaseEulerFoam:

    phaseScalarTransport1
    {
        type            phaseScalarTransport;
        libs            ("libsolverFunctionObjects.so");

        field           s.water;
        alphaPhi        alphaRhoPhi.water;
        rho             thermo:rho.water;
    }

The function will write out both the per-unit-phase field that is solved
for (s.water in the above examples) and also the mixture-total field
(alphaS.water), which is often more convenient for post-processing.
2019-02-15 10:56:33 +00:00
e9f3811218 chtMultiRegionFoam,reactingParcelFoam: Improved pressure and density limiting 2019-02-15 10:28:15 +00:00
f9cb8e21d9 rhoPimpleFoam: Improved pressure and density limiting 2019-02-15 08:30:32 +00:00
fbb7b5dfaf solidDisplacementFoam/Make/options: Added -I option for dependency checking 2019-02-14 12:10:29 +00:00
dfc10f67a4 equationOfState::perfectFluid: Added Cp departure function 2019-02-14 10:11:00 +00:00