zhyang-dev/openfoam
1
0
Fork 0
mirror of https://develop.openfoam.com/Development/openfoam.git synced 2025-11-28 03:28:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

BUG: isoSurfaceCell: pre-filtering of cells misses lopping off a corner. Fixes #1062.

Browse Source
This commit is contained in:
mattijs
2018-11-01 13:06:06 +00:00
parent bde7d4bb6c
commit 097e54a74f
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/sampling/surface/isoSurface/isoSurfaceCell.C
View File

@ -120,10 +120,10 @@ Foam::isoSurfaceCell::cellCutType Foam::isoSurfaceCell::calcCutType
{ {
const face& f = mesh_.faces()[facei]; const face& f = mesh_.faces()[facei];
// Check pyramids cut // Check pyramid edges (corner point to cell centre)
for (const label labi : f) for (const label pointi : f)
{ {
if (cellLower != (pointValues[labi] < iso_)) if (cellLower != (pointValues[pointi] < iso_))
{ {
edgeCut = true; edgeCut = true;
break; break;
@ -135,6 +135,7 @@ Foam::isoSurfaceCell::cellCutType Foam::isoSurfaceCell::calcCutType
break; break;
} }
// Check (triangulated) face edges
const label fp0 = mesh_.tetBasePtIs()[facei]; const label fp0 = mesh_.tetBasePtIs()[facei];
label fp = f.fcIndex(fp0); label fp = f.fcIndex(fp0);
for (label i = 2; i < f.size(); ++i) for (label i = 2; i < f.size(); ++i)
@ -165,23 +166,23 @@ Foam::isoSurfaceCell::cellCutType Foam::isoSurfaceCell::calcCutType
const labelList& cPoints = mesh_.cellPoints(celli); const labelList& cPoints = mesh_.cellPoints(celli);
label nCuts = 0; label nPyrEdgeCuts = 0;
for (const label pointi : cPoints) for (const label pointi : cPoints)
{ {
if (cellLower != (pointValues[pointi] < iso_)) if (cellLower != (pointValues[pointi] < iso_))
{ {
++nCuts; ++nPyrEdgeCuts;
} }
} }
if (nCuts == cPoints.size()) if (nPyrEdgeCuts == cPoints.size())
{ {
return SPHERE; return SPHERE;
} }
else if (nCuts > 1) else if (nPyrEdgeCuts)
{ {
// Need at least two edge cuts, otherwise this is a spurious cut // There is a pyramid edge cut. E.g. lopping off a tet from a corner
return CUT; return CUT;
} }
} }