zhyang-dev/openfoam
1
0
Fork 0
mirror of https://develop.openfoam.com/Development/openfoam.git synced 2025-11-28 03:28:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

BUG: bad names if ensight mask contains NO placeholder (fixes #1747)

Browse Source 
- affects ensightSurfaceReader only.

  If there are no `*` characters, protect against replacement.
  Otherwise it would attempt to replace a zero-length string with
  a single `0`, which results in prepending the name.

STYLE: ensightSurfaceReader constructor explicit
This commit is contained in:
Mark Olesen
2020-06-25 09:40:21 +02:00
parent 013a52238d
commit 0a7eb6e6dc
2 changed files with 20 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/sampling/sampledSurface/readers/ensight/ensightSurfaceReader.C
View File

@ -127,16 +127,24 @@ Foam::fileName Foam::ensightSurfaceReader::replaceMask
(
const fileName& fName,
const label timeIndex
) const
)
{
fileName result(fName);
std::ostringstream oss;
label nMask = stringOps::count(fName, '*');
const std::string maskStr(nMask, '*');
oss << std::setfill('0') << std::setw(nMask) << timeIndex;
const word indexStr = oss.str();
result.replace(maskStr, indexStr);
const auto nMask = stringOps::count(fName, '*');
// If there are any '*' chars, they are assumed to be contiguous
// Eg, data/******/geometry
if (nMask)
{
std::ostringstream oss;
oss << std::setfill('0') << std::setw(nMask) << timeIndex;
const std::string maskStr(nMask, '*');
const std::string indexStr = oss.str();
result.replace(maskStr, indexStr);
}
return result;
}

9
src/sampling/sampledSurface/readers/ensight/ensightSurfaceReader.H
View File

@ -112,12 +112,12 @@ protected:
//- Read and check a section header
void debugSection(const word& expected, IFstream& is) const;
//- Replace the mask with an 0 padded string
fileName replaceMask
//- Replace the '*' mask chars with a 0 padded string.
static fileName replaceMask
(
const fileName& fName,
const label timeIndex
) const;
);
//- Read (and discard) geometry file header.
// \return information about node/element id handling
@ -158,10 +158,11 @@ public:
//- Runtime type information
TypeName("ensight");
// Constructors
//- Construct from fileName
ensightSurfaceReader(const fileName& fName);
explicit ensightSurfaceReader(const fileName& fName);
//- Destructor