From 0d662c74c69e13ee5ac617ee6e6b219821a8ec24 Mon Sep 17 00:00:00 2001 From: Mark Olesen Date: Fri, 26 Nov 2010 20:39:46 +0100 Subject: [PATCH] STYLE: use triSurface::FaceType where triangle or region information not required --- .../surface/surfaceCheck/surfaceCheck.C | 21 +++---- .../surface/surfaceClean/collapseBase.C | 4 +- .../surface/surfaceClean/collapseEdge.C | 6 +- .../surfaceSplitNonManifolds.C | 13 ++-- .../surface/surfaceSubset/surfaceSubset.C | 3 +- .../indexedOctree/treeDataTriSurface.C | 28 ++++----- .../searchableSurface/triSurfaceMesh.C | 16 ++--- .../booleanSurface/booleanSurface.C | 15 +---- .../intersectedSurface/intersectedSurface.C | 8 +-- .../surfaceIntersection/edgeIntersections.C | 17 ++--- .../surfaceIntersection/surfaceIntersection.C | 49 ++++++--------- .../surfaceIntersectionFuncs.C | 4 +- .../octreeData/octreeDataTriSurface.C | 30 +++------ .../orientedSurface/orientedSurface.C | 42 ++----------- .../orientedSurface/orientedSurface.H | 7 +-- .../triSurfaceTools/triSurfaceTools.C | 35 ++++------- .../distributedTriSurfaceMesh.C | 35 +++++------ .../isoSurface/isoSurfaceCell.C | 28 ++++----- .../sampledTriSurfaceMesh.C | 12 ++-- .../tools/labelledTri/labelledTri.H | 7 +++ .../tools/labelledTri/labelledTriI.H | 46 +++++++------- .../triSurface/interfaces/AC3D/writeAC.C | 10 +-- .../triSurface/interfaces/GTS/readGTS.C | 10 +-- .../triSurface/interfaces/OBJ/readOBJ.C | 11 +--- .../triSurface/interfaces/OFF/readOFF.C | 11 +--- .../triSurface/interfaces/STL/readSTLBINARY.C | 10 +-- .../triSurface/interfaces/STL/writeSTL.C | 13 +--- src/triSurface/triSurface/stitchTriangles.C | 17 ++--- src/triSurface/triSurface/triSurface.C | 62 +++++++------------ .../triSurface/triSurfaceAddressing.C | 12 +--- 30 files changed, 198 insertions(+), 384 deletions(-) diff --git a/applications/utilities/surface/surfaceCheck/surfaceCheck.C b/applications/utilities/surface/surfaceCheck/surfaceCheck.C index 577f1470ae..a5e8429cb9 100644 --- a/applications/utilities/surface/surfaceCheck/surfaceCheck.C +++ b/applications/utilities/surface/surfaceCheck/surfaceCheck.C @@ -47,19 +47,16 @@ bool validTri const labelledTri& f = surf[faceI]; - if - ( - (f[0] < 0) || (f[0] >= surf.points().size()) - || (f[1] < 0) || (f[1] >= surf.points().size()) - || (f[2] < 0) || (f[2] >= surf.points().size()) - ) + forAll(f, fp) { - WarningIn("validTri(const triSurface&, const label)") - << "triangle " << faceI << " vertices " << f - << " uses point indices outside point range 0.." - << surf.points().size()-1 << endl; - - return false; + if (f[fp] < 0 || f[fp] >= surf.points().size()) + { + WarningIn("validTri(const triSurface&, const label)") + << "triangle " << faceI << " vertices " << f + << " uses point indices outside point range 0.." + << surf.points().size()-1 << endl; + return false; + } } if ((f[0] == f[1]) || (f[0] == f[2]) || (f[1] == f[2])) diff --git a/applications/utilities/surface/surfaceClean/collapseBase.C b/applications/utilities/surface/surfaceClean/collapseBase.C index dd92967a5f..109aa07248 100644 --- a/applications/utilities/surface/surfaceClean/collapseBase.C +++ b/applications/utilities/surface/surfaceClean/collapseBase.C @@ -100,8 +100,8 @@ static void splitTri label oldNTris = tris.size(); label fp = findIndex(f, e[0]); - label fp1 = (fp+1)%3; - label fp2 = (fp1+1)%3; + label fp1 = f.fcIndex(fp); + label fp2 = f.fcIndex(fp1); if (f[fp1] == e[1]) { diff --git a/applications/utilities/surface/surfaceClean/collapseEdge.C b/applications/utilities/surface/surfaceClean/collapseEdge.C index 66fba4cd97..c7be020cab 100644 --- a/applications/utilities/surface/surfaceClean/collapseEdge.C +++ b/applications/utilities/surface/surfaceClean/collapseEdge.C @@ -34,7 +34,7 @@ static void markPointNbrs boolList& okToCollapse ) { - const labelledTri& f = surf.localFaces()[faceI]; + const triSurface::FaceType& f = surf.localFaces()[faceI]; forAll(f, fp) { @@ -108,12 +108,12 @@ label collapseEdge(triSurface& surf, const scalar minLen) if (okToCollapse[faceI]) { // Check edge lengths. - const labelledTri& f = localFaces[faceI]; + const triSurface::FaceType& f = localFaces[faceI]; forAll(f, fp) { label v = f[fp]; - label v1 = f[(fp+1) % 3]; + label v1 = f[f.fcIndex(fp)]; if (mag(localPoints[v1] - localPoints[v]) < minLen) { diff --git a/applications/utilities/surface/surfaceSplitNonManifolds/surfaceSplitNonManifolds.C b/applications/utilities/surface/surfaceSplitNonManifolds/surfaceSplitNonManifolds.C index e52a32010a..2611a7863a 100644 --- a/applications/utilities/surface/surfaceSplitNonManifolds/surfaceSplitNonManifolds.C +++ b/applications/utilities/surface/surfaceSplitNonManifolds/surfaceSplitNonManifolds.C @@ -128,9 +128,7 @@ void dumpFaces forAllConstIter(Map