BUG: activePressureForceBaffleVelocity: fix calculated area (fixes #2360)

This patch provides the correct behavior of
the boundary condition and its opening values.
This commit is contained in:
Tobias Holzmann
2022-02-10 23:55:20 +01:00
committed by Andrew Heather
parent c323cbd35b
commit 123fe09fda

View File

@ -6,7 +6,7 @@
\\/ M anipulation | \\/ M anipulation |
------------------------------------------------------------------------------- -------------------------------------------------------------------------------
Copyright (C) 2011-2016 OpenFOAM Foundation Copyright (C) 2011-2016 OpenFOAM Foundation
Copyright (C) 2016-2020 OpenCFD Ltd. Copyright (C) 2016-2022 OpenCFD Ltd.
------------------------------------------------------------------------------- -------------------------------------------------------------------------------
License License
This file is part of OpenFOAM. This file is part of OpenFOAM.
@ -260,11 +260,13 @@ void Foam::activePressureForceBaffleVelocityFvPatchVectorField::updateCoeffs()
const labelList& nbrFaceCells = nbrPatch.patch().faceCells(); const labelList& nbrFaceCells = nbrPatch.patch().faceCells();
scalar valueDiff = 0; scalar valueDiff = 0;
scalar area = 0;
// Add this side (p*area) // Add this side (p*area)
forAll(cyclicFaceCells, facei) forAll(cyclicFaceCells, facei)
{ {
valueDiff +=p[cyclicFaceCells[facei]]*mag(initCyclicSf_[facei]); valueDiff +=p[cyclicFaceCells[facei]]*mag(initCyclicSf_[facei]);
area += mag(initCyclicSf_[facei]);
} }
// Remove other side // Remove other side
@ -275,7 +277,7 @@ void Foam::activePressureForceBaffleVelocityFvPatchVectorField::updateCoeffs()
if (!fBased_) //pressure based then weighted by area if (!fBased_) //pressure based then weighted by area
{ {
valueDiff = valueDiff/gSum(patch().magSf()); valueDiff = valueDiff/(area + VSMALL);
} }
reduce(valueDiff, sumOp<scalar>()); reduce(valueDiff, sumOp<scalar>());
@ -284,12 +286,13 @@ void Foam::activePressureForceBaffleVelocityFvPatchVectorField::updateCoeffs()
{ {
if (fBased_) if (fBased_)
{ {
Info<< "Force difference = " << valueDiff << endl; Info<< "Force difference (threshold) = " << valueDiff
<< "(" << minThresholdValue_ << ")" << endl;
} }
else else
{ {
Info<< "Area-averaged pressure difference = " Info<< "Area-averaged pressure difference (threshold) = "
<< valueDiff << endl; << valueDiff << "(" << minThresholdValue_ << ")" << endl;
} }
} }