From 29a5793b5beeeefc9b8f28024234c5e24ef7e773 Mon Sep 17 00:00:00 2001 From: Mark Olesen Date: Wed, 12 Dec 2018 12:10:39 +0100 Subject: [PATCH] STYLE: argList::opt method instead of the longer argList::lookupOrDefault - also replaced a few instances of readIfPresent with opt<> for constant values. --- .../solvers/basic/potentialFoam/createFields.H | 5 ++--- .../potentialFoam/overPotentialFoam/createFields.H | 5 ++--- .../solvers/lagrangian/DPMFoam/createFields.H | 6 ++++-- .../icoUncoupledKinematicParcelFoam/createFields.H | 6 ++++-- .../uncoupledKinematicParcelFoam/createFields.H | 2 +- .../test/checkDecomposePar/Test-checkDecomposePar.C | 3 +-- applications/test/decomposePar/Test-decomposePar.C | 10 ++++------ .../externalFileCoupler/Test-externalFileCoupler.C | 2 +- .../test/momentOfInertia/Test-momentOfInertia.C | 2 +- applications/test/spline/Test-spline.C | 2 +- .../surfaceIntersection/Test-surfaceIntersection.C | 2 +- .../surfaceMeshConvert/Test-surfaceMeshConvert.C | 2 +- applications/test/tokenize/Test-tokenize.C | 2 +- .../test/vtkSeriesWriter/Test-vtkSeriesWriter.C | 2 +- .../mesh/advanced/collapseEdges/collapseEdges.C | 1 - .../advanced/combinePatchFaces/combinePatchFaces.C | 3 +-- .../utilities/mesh/advanced/splitCells/splitCells.C | 2 +- .../mesh/conversion/ansysToFoam/ansysToFoam.L | 2 +- .../mesh/conversion/ccm/ccmToFoam/ccmToFoam.C | 2 +- .../mesh/conversion/cfx4ToFoam/cfx4ToFoam.C | 2 +- .../mesh/conversion/fireToFoam/fireToFoam.C | 2 +- .../conversion/fluentMeshToFoam/fluentMeshToFoam.L | 2 +- .../mesh/conversion/foamToStarMesh/foamToStarMesh.C | 2 +- .../mesh/conversion/foamToSurface/foamToSurface.C | 3 +-- .../mesh/conversion/gambitToFoam/gambitToFoam.L | 2 +- .../mesh/conversion/gmshToFoam/gmshToFoam.C | 9 ++------- .../mesh/conversion/kivaToFoam/kivaToFoam.C | 6 ++---- .../mesh/conversion/plot3dToFoam/plot3dToFoam.C | 2 +- .../mesh/conversion/star4ToFoam/star4ToFoam.C | 2 +- .../utilities/mesh/generation/blockMesh/blockMesh.C | 4 ++-- .../generation/foamyMesh/foamyHexMesh/foamyHexMesh.C | 4 ++-- .../foamyHexMeshBackgroundMesh.C | 7 +++---- .../mesh/generation/snappyHexMesh/snappyHexMesh.C | 4 ++-- .../mesh/manipulation/checkMesh/checkMesh.C | 5 +++-- .../mesh/manipulation/createPatch/createPatch.C | 2 +- .../mesh/manipulation/mergeMeshes/mergeMeshes.C | 12 ++---------- .../mesh/manipulation/refineMesh/refineMesh.C | 2 +- .../parallelProcessing/decomposePar/decomposePar.C | 6 ++---- .../reconstructParMesh/reconstructParMesh.C | 3 +-- .../redistributePar/redistributePar.C | 11 ++++------- .../dataConversion/foamToEnsight/foamToEnsight.C | 4 ++-- .../foamToEnsightParts/foamToEnsightParts.C | 4 ++-- .../dataConversion/foamToVTK/foamToVTK.C | 5 ++--- .../lumped/lumpedPointMovement/lumpedPointMovement.C | 6 +++--- .../temporalInterpolate/temporalInterpolate.C | 11 ++++------- .../createExternalCoupledPatchGeometry.C | 2 +- .../foamUpgradeCyclics/foamUpgradeCyclics.C | 6 ++---- .../utilities/preProcessing/mapFields/mapFields.C | 2 +- .../utilities/surface/surfaceAdd/surfaceAdd.C | 2 +- .../surfaceBooleanFeatures/surfaceBooleanFeatures.C | 2 +- .../utilities/surface/surfaceCheck/surfaceCheck.C | 6 +++--- .../utilities/surface/surfaceClean/surfaceClean.C | 2 +- .../surface/surfaceCoarsen/surfaceCoarsen.C | 2 +- .../surface/surfaceConvert/surfaceConvert.C | 2 +- .../utilities/surface/surfaceFind/surfaceFind.C | 6 +++--- .../surface/surfaceInertia/surfaceInertia.C | 2 +- .../surface/surfaceInflate/surfaceInflate.C | 8 ++------ .../surface/surfaceMeshConvert/surfaceMeshConvert.C | 2 +- .../surface/surfaceMeshExport/surfaceMeshExport.C | 4 ++-- .../surface/surfaceMeshImport/surfaceMeshImport.C | 4 ++-- .../surface/surfaceMeshInfo/surfaceMeshInfo.C | 2 +- .../utilities/surface/surfaceOrient/surfaceOrient.C | 2 +- .../surface/surfacePointMerge/surfacePointMerge.C | 2 +- .../surfaceRedistributePar/surfaceRedistributePar.C | 2 +- .../surface/surfaceToPatch/surfaceToPatch.C | 2 +- .../functionObjectList/functionObjectList.C | 7 +++---- src/OpenFOAM/include/setConstantMeshDictionaryIO.H | 2 +- .../include/setConstantRunTimeDictionaryIO.H | 2 +- src/OpenFOAM/include/setSystemMeshDictionaryIO.H | 2 +- src/OpenFOAM/include/setSystemRunTimeDictionaryIO.H | 2 +- 70 files changed, 112 insertions(+), 148 deletions(-) diff --git a/applications/solvers/basic/potentialFoam/createFields.H b/applications/solvers/basic/potentialFoam/createFields.H index 5152727b1d..4b3352557a 100644 --- a/applications/solvers/basic/potentialFoam/createFields.H +++ b/applications/solvers/basic/potentialFoam/createFields.H @@ -38,10 +38,9 @@ if (args.found("initialiseUBCs")) // Construct a pressure field // If it is available read it otherwise construct from the velocity BCs // converting fixed-value BCs to zero-gradient and vice versa. -word pName("p"); -// Update name of the pressure field from the command-line option -args.readIfPresent("pName", pName); +// Allow override from command-line -pName option +const word pName = args.opt("pName", "p"); // Infer the pressure BCs from the velocity wordList pBCTypes diff --git a/applications/solvers/basic/potentialFoam/overPotentialFoam/createFields.H b/applications/solvers/basic/potentialFoam/overPotentialFoam/createFields.H index 67c1c67e59..80f04a8a68 100644 --- a/applications/solvers/basic/potentialFoam/overPotentialFoam/createFields.H +++ b/applications/solvers/basic/potentialFoam/overPotentialFoam/createFields.H @@ -38,10 +38,9 @@ if (args.found("initialiseUBCs")) // Construct a pressure field // If it is available read it otherwise construct from the velocity BCs // converting fixed-value BCs to zero-gradient and vice versa. -word pName("p"); -// Update name of the pressure field from the command-line option -args.readIfPresent("pName", pName); +// Allow override from command-line -pName option +const word pName = args.opt("pName", "p"); // Infer the pressure BCs from the velocity wordList pBCTypes diff --git a/applications/solvers/lagrangian/DPMFoam/createFields.H b/applications/solvers/lagrangian/DPMFoam/createFields.H index 527e465177..07ff05738b 100644 --- a/applications/solvers/lagrangian/DPMFoam/createFields.H +++ b/applications/solvers/lagrangian/DPMFoam/createFields.H @@ -119,8 +119,10 @@ volScalarField alphac dimensionedScalar(dimless, Zero) ); -word kinematicCloudName("kinematicCloud"); -args.readIfPresent("cloud", kinematicCloudName); +const word kinematicCloudName +( + args.opt("cloud", "kinematicCloud") +); Info<< "Constructing kinematicCloud " << kinematicCloudName << endl; basicKinematicTypeCloud kinematicCloud diff --git a/applications/solvers/lagrangian/icoUncoupledKinematicParcelFoam/createFields.H b/applications/solvers/lagrangian/icoUncoupledKinematicParcelFoam/createFields.H index fe2134e3c8..1031e81a9a 100644 --- a/applications/solvers/lagrangian/icoUncoupledKinematicParcelFoam/createFields.H +++ b/applications/solvers/lagrangian/icoUncoupledKinematicParcelFoam/createFields.H @@ -57,8 +57,10 @@ volScalarField mu laminarTransport.nu()*rhoInfValue ); -word kinematicCloudName("kinematicCloud"); -args.readIfPresent("cloud", kinematicCloudName); +const word kinematicCloudName +( + args.opt("cloud", "kinematicCloud") +); Info<< "Constructing kinematicCloud " << kinematicCloudName << endl; basicKinematicCollidingCloud kinematicCloud diff --git a/applications/solvers/lagrangian/uncoupledKinematicParcelFoam/createFields.H b/applications/solvers/lagrangian/uncoupledKinematicParcelFoam/createFields.H index e8dd95b2e8..f4675bbdb6 100644 --- a/applications/solvers/lagrangian/uncoupledKinematicParcelFoam/createFields.H +++ b/applications/solvers/lagrangian/uncoupledKinematicParcelFoam/createFields.H @@ -51,7 +51,7 @@ autoPtr turbulence const word kinematicCloudName ( - args.lookupOrDefault("cloud", "kinematicCloud") + args.opt("cloud", "kinematicCloud") ); Info<< "Constructing kinematicCloud " << kinematicCloudName << endl; diff --git a/applications/test/checkDecomposePar/Test-checkDecomposePar.C b/applications/test/checkDecomposePar/Test-checkDecomposePar.C index a34d695b86..c9f8ca34de 100644 --- a/applications/test/checkDecomposePar/Test-checkDecomposePar.C +++ b/applications/test/checkDecomposePar/Test-checkDecomposePar.C @@ -84,8 +84,7 @@ int main(int argc, char *argv[]) instantList times = timeSelector::selectIfPresent(runTime, args); // Allow override of decomposeParDict location - fileName decompDictFile; - args.readIfPresent("decomposeParDict", decompDictFile); + const fileName decompDictFile = args.opt("decomposeParDict", ""); wordList regionNames; wordList regionDirs; diff --git a/applications/test/decomposePar/Test-decomposePar.C b/applications/test/decomposePar/Test-decomposePar.C index 4747c4e9ca..0d925ec96d 100644 --- a/applications/test/decomposePar/Test-decomposePar.C +++ b/applications/test/decomposePar/Test-decomposePar.C @@ -98,8 +98,8 @@ int main(int argc, char *argv[]) const bool allRegions = args.found("allRegions"); const bool verbose = args.found("verbose"); - const label numSubdomains = args.lookupOrDefault