From ffed13435a303dd3814e9ce4be573b86ec71ccd0 Mon Sep 17 00:00:00 2001 From: Prashant Date: Wed, 30 Aug 2017 09:38:36 +0530 Subject: [PATCH 1/3] BugFix: corrected keyword for flowRateInletVelocity BC fixes #577 --- .../boundaryConditions/fluid/incompressible/inletOptions | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/caseDicts/createZeroDirectoryTemplates/boundaryConditions/fluid/incompressible/inletOptions b/etc/caseDicts/createZeroDirectoryTemplates/boundaryConditions/fluid/incompressible/inletOptions index c2bce6055e..7488d1093d 100644 --- a/etc/caseDicts/createZeroDirectoryTemplates/boundaryConditions/fluid/incompressible/inletOptions +++ b/etc/caseDicts/createZeroDirectoryTemplates/boundaryConditions/fluid/incompressible/inletOptions @@ -41,7 +41,7 @@ flowSpecification U { type flowRateInletVelocity; - volumeFlowRate ${:VALUE.volumeFlowRate}; + volumetricFlowRate ${:VALUE.volumeFlowRate}; value ${:VALUE.U}; } p From 870a0a1d60a0e8d35ccdb3d1a6de71274054f724 Mon Sep 17 00:00:00 2001 From: Prashant Date: Wed, 30 Aug 2017 09:48:45 +0530 Subject: [PATCH 2/3] BugFix: keyword for caseDict also syncrhonized --- .../boundaryConditions/fluid/incompressible/inletOptions | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/caseDicts/createZeroDirectoryTemplates/boundaryConditions/fluid/incompressible/inletOptions b/etc/caseDicts/createZeroDirectoryTemplates/boundaryConditions/fluid/incompressible/inletOptions index 7488d1093d..56abfefd0f 100644 --- a/etc/caseDicts/createZeroDirectoryTemplates/boundaryConditions/fluid/incompressible/inletOptions +++ b/etc/caseDicts/createZeroDirectoryTemplates/boundaryConditions/fluid/incompressible/inletOptions @@ -41,7 +41,7 @@ flowSpecification U { type flowRateInletVelocity; - volumetricFlowRate ${:VALUE.volumeFlowRate}; + volumetricFlowRate ${:VALUE.volumetricFlowRate}; value ${:VALUE.U}; } p From 6d8b6516b6c09d2053ea6feeacb1eb59b282384e Mon Sep 17 00:00:00 2001 From: Andrew Heather Date: Thu, 31 Aug 2017 14:05:05 +0100 Subject: [PATCH 3/3] BUG: Corrected Curle analogy implementation. See #574 --- src/functionObjects/field/Curle/Curle.C | 2 +- src/functionObjects/field/Curle/Curle.H | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/functionObjects/field/Curle/Curle.C b/src/functionObjects/field/Curle/Curle.C index 200568ef75..fcdcdd05cb 100644 --- a/src/functionObjects/field/Curle/Curle.C +++ b/src/functionObjects/field/Curle/Curle.C @@ -99,7 +99,7 @@ bool Foam::functionObjects::Curle::calc() volScalarField& pDash = tpDash.ref(); const volVectorField d(scopedName("d"), C - x0_); - pDash = 4*mathematical::pi/c0_*(d/magSqr(d) & dfdt); + pDash = (d/magSqr(d) & dfdt)/(4.0*mathematical::pi*c0_); return store(resultName_, tpDash); } diff --git a/src/functionObjects/field/Curle/Curle.H b/src/functionObjects/field/Curle/Curle.H index 050970a05b..04e9f73112 100644 --- a/src/functionObjects/field/Curle/Curle.H +++ b/src/functionObjects/field/Curle/Curle.H @@ -33,7 +33,7 @@ Description Curle's analogy is implemented as: \f[ - p' = 4 \frac{\pi}{c_0}\frac{\vec d}{|\vec d|^2}\frac{d(F)}{d(t)} + p' = \frac{1}{4 \pi c_0}\frac{\vec d}{|\vec d|^2}\frac{d(F)}{d(t)} \f] @@ -68,8 +68,8 @@ Usage type | Type name: Curle | yes | field | Pressure field name | no | p result | Acoustic pressure field name | no | Curle - patches | Sound generation patch names | yes | - c0 | Reference speed of sound | yes | + patches | Sound generation patch names | yes | + c0 | Reference speed of sound | yes | \endtable