From a0a05c1b7745747f177e518ceb08314fd0fc6a28 Mon Sep 17 00:00:00 2001
From: mattijs <mattijs>
Date: Wed, 2 Dec 2009 16:37:59 +0000
Subject: [PATCH 1/5] allow region interfaces on processor patches

---
 .../splitMeshRegions/splitMeshRegions.C       | 94 ++++++++++++++-----
 1 file changed, 72 insertions(+), 22 deletions(-)

diff --git a/applications/utilities/mesh/manipulation/splitMeshRegions/splitMeshRegions.C b/applications/utilities/mesh/manipulation/splitMeshRegions/splitMeshRegions.C
index b61d997399..6abde97e61 100644
--- a/applications/utilities/mesh/manipulation/splitMeshRegions/splitMeshRegions.C
+++ b/applications/utilities/mesh/manipulation/splitMeshRegions/splitMeshRegions.C
@@ -36,9 +36,10 @@ Description
     - mesh with cells put into cellZones (-makeCellZones)
 
     Note:
-    - Should work in parallel but cellZone interfaces cannot align with
-    processor boundaries so use the correct option in decomposition to
-    preserve those interfaces.
+    - Should work in parallel.
+    cellZones can differ on either side of processor boundaries in which case
+    the faces get moved from processor patch to directMapped patch. Not
+    ery well tested.
     - If a cell zone gets split into more than one region it can detect
     the largest matching region (-sloppyCellZones). This will accept any
     region that covers more than 50% of the zone. It has to be a subset
@@ -514,6 +515,10 @@ void getInterfaceSizes
     EdgeMap<label>& interfaceSizes
 )
 {
+
+    // Internal faces
+    // ~~~~~~~~~~~~~~
+
     forAll(mesh.faceNeighbour(), faceI)
     {
         label ownRegion = cellRegion[mesh.faceOwner()[faceI]];
@@ -540,6 +545,47 @@ void getInterfaceSizes
         }
     }
 
+    // Boundary faces
+    // ~~~~~~~~~~~~~~
+
+    // Neighbour cellRegion.
+    labelList coupledRegion(mesh.nFaces()-mesh.nInternalFaces());
+
+    forAll(coupledRegion, i)
+    {
+        label cellI = mesh.faceOwner()[i+mesh.nInternalFaces()];
+        coupledRegion[i] = cellRegion[cellI];
+    }
+    syncTools::swapBoundaryFaceList(mesh, coupledRegion, false);
+
+    forAll(coupledRegion, i)
+    {
+        label faceI = i+mesh.nInternalFaces();
+        label ownRegion = cellRegion[mesh.faceOwner()[faceI]];
+        label neiRegion = coupledRegion[i];
+
+        if (ownRegion != neiRegion)
+        {
+            edge interface
+            (
+                min(ownRegion, neiRegion),
+                max(ownRegion, neiRegion)
+            );
+
+            EdgeMap<label>::iterator iter = interfaceSizes.find(interface);
+
+            if (iter != interfaceSizes.end())
+            {
+                iter()++;
+            }
+            else
+            {
+                interfaceSizes.insert(interface, 1);
+            }
+        }
+    }
+
+
     if (sumParallel && Pstream::parRun())
     {
         if (Pstream::master())
@@ -672,6 +718,17 @@ autoPtr<mapPolyMesh> createRegionMesh
     }
 
 
+    // Neighbour cellRegion.
+    labelList coupledRegion(mesh.nFaces()-mesh.nInternalFaces());
+
+    forAll(coupledRegion, i)
+    {
+        label cellI = mesh.faceOwner()[i+mesh.nInternalFaces()];
+        coupledRegion[i] = cellRegion[cellI];
+    }
+    syncTools::swapBoundaryFaceList(mesh, coupledRegion, false);
+
+
     // Topology change container. Start off from existing mesh.
     polyTopoChange meshMod(mesh);
 
@@ -691,16 +748,17 @@ autoPtr<mapPolyMesh> createRegionMesh
     {
         label faceI = exposedFaces[i];
 
-        if (!mesh.isInternalFace(faceI))
-        {
-            FatalErrorIn("createRegionMesh(..)")
-                << "Exposed face:" << faceI << " is not an internal face."
-                << " fc:" << mesh.faceCentres()[faceI]
-                << exit(FatalError);
-        }
-
         label ownRegion = cellRegion[mesh.faceOwner()[faceI]];
-        label neiRegion = cellRegion[mesh.faceNeighbour()[faceI]];
+        label neiRegion = -1;
+
+        if (mesh.isInternalFace(faceI))
+        {
+            neiRegion = cellRegion[mesh.faceNeighbour()[faceI]];
+        }
+        else
+        {
+            neiRegion = coupledRegion[faceI-mesh.nInternalFaces()];
+        }
 
         label otherRegion = -1;
 
@@ -1357,22 +1415,14 @@ int main(int argc, char *argv[])
             }
         }
 
-        // Different cellZones on either side of processor patch are not
-        // allowed for now. Convert to processorPatches or what?
+        // Different cellZones on either side of processor patch.
         forAll(neiZoneID, i)
         {
             label faceI = i+mesh.nInternalFaces();
 
             if (zoneID[mesh.faceOwner()[faceI]] != neiZoneID[i])
             {
-                //blockedFace[faceI] = true;
-                FatalErrorIn(args.executable())
-                    << "Coupled face " << faceI
-                    << " fc:" << mesh.faceCentres()[faceI]
-                    << " has cellZone " << zoneID[mesh.faceOwner()[faceI]]
-                    << " on owner side but cellZone " << neiZoneID[i]
-                    << " on other side. This is not allowed."
-                    << exit(FatalError);
+                blockedFace[faceI] = true;
             }
         }
     }

From 5ee1f98e2ccbffc69bf6073c2babad879996132b Mon Sep 17 00:00:00 2001
From: mattijs <mattijs>
Date: Wed, 2 Dec 2009 16:38:19 +0000
Subject: [PATCH 2/5] linear interpolation always

---
 .../foamToTecplot360/foamToTecplot360.C       | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/applications/utilities/postProcessing/dataConversion/foamToTecplot360/foamToTecplot360.C b/applications/utilities/postProcessing/dataConversion/foamToTecplot360/foamToTecplot360.C
index 8ed17ebffb..82d02f2523 100644
--- a/applications/utilities/postProcessing/dataConversion/foamToTecplot360/foamToTecplot360.C
+++ b/applications/utilities/postProcessing/dataConversion/foamToTecplot360/foamToTecplot360.C
@@ -797,7 +797,7 @@ int main(int argc, char *argv[])
                 (
                     writer.getFaceField
                     (
-                        fvc::interpolate(vsf[i])(),
+                        linearInterpolate(vsf[i])(),
                         faceLabels
                     )()
                 );
@@ -808,7 +808,7 @@ int main(int argc, char *argv[])
                 (
                     writer.getFaceField
                     (
-                        fvc::interpolate(vvf[i])(),
+                        linearInterpolate(vvf[i])(),
                         faceLabels
                     )()
                 );
@@ -819,7 +819,7 @@ int main(int argc, char *argv[])
                 (
                     writer.getFaceField
                     (
-                        fvc::interpolate(vSpheretf[i])(),
+                        linearInterpolate(vSpheretf[i])(),
                         faceLabels
                     )()
                 );
@@ -830,7 +830,7 @@ int main(int argc, char *argv[])
                 (
                     writer.getFaceField
                     (
-                        fvc::interpolate(vSymmtf[i])(),
+                        linearInterpolate(vSymmtf[i])(),
                         faceLabels
                     )()
                 );
@@ -841,7 +841,7 @@ int main(int argc, char *argv[])
                 (
                     writer.getFaceField
                     (
-                        fvc::interpolate(vtf[i])(),
+                        linearInterpolate(vtf[i])(),
                         faceLabels
                     )()
                 );
@@ -1094,7 +1094,7 @@ int main(int argc, char *argv[])
                     (
                         writer.getFaceField
                         (
-                            fvc::interpolate(vsf[i])(),
+                            linearInterpolate(vsf[i])(),
                             pp
                         )()
                     );
@@ -1105,7 +1105,7 @@ int main(int argc, char *argv[])
                     (
                         writer.getFaceField
                         (
-                            fvc::interpolate(vvf[i])(),
+                            linearInterpolate(vvf[i])(),
                             pp
                         )()
                     );
@@ -1116,7 +1116,7 @@ int main(int argc, char *argv[])
                     (
                         writer.getFaceField
                         (
-                            fvc::interpolate(vSpheretf[i])(),
+                            linearInterpolate(vSpheretf[i])(),
                             pp
                         )()
                     );
@@ -1127,7 +1127,7 @@ int main(int argc, char *argv[])
                     (
                         writer.getFaceField
                         (
-                            fvc::interpolate(vSymmtf[i])(),
+                            linearInterpolate(vSymmtf[i])(),
                             pp
                         )()
                     );
@@ -1138,7 +1138,7 @@ int main(int argc, char *argv[])
                     (
                         writer.getFaceField
                         (
-                            fvc::interpolate(vtf[i])(),
+                            linearInterpolate(vtf[i])(),
                             pp
                         )()
                     );

From e31f1c3aebaa0872f19a3531ac0ef5cc63106a91 Mon Sep 17 00:00:00 2001
From: mattijs <mattijs>
Date: Wed, 2 Dec 2009 16:38:34 +0000
Subject: [PATCH 3/5] changed comment

---
 .../surfaceInterpolation/surfaceInterpolate.H                 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/finiteVolume/interpolation/surfaceInterpolation/surfaceInterpolation/surfaceInterpolate.H b/src/finiteVolume/interpolation/surfaceInterpolation/surfaceInterpolation/surfaceInterpolate.H
index c22174451b..115aedc9fe 100644
--- a/src/finiteVolume/interpolation/surfaceInterpolation/surfaceInterpolation/surfaceInterpolate.H
+++ b/src/finiteVolume/interpolation/surfaceInterpolation/surfaceInterpolation/surfaceInterpolate.H
@@ -157,14 +157,14 @@ namespace fvc
     );
 
 
-    //- Interpolate tmp field onto faces using central differencing
+    //- Interpolate tmp field onto faces using 'interpolate(<name>)'
     template<class Type>
     static tmp<GeometricField<Type, fvsPatchField, surfaceMesh> > interpolate
     (
         const tmp<GeometricField<Type, fvPatchField, volMesh> >& tvf
     );
 
-    //- Interpolate field onto faces using central differencing
+    //- Interpolate tmp field onto faces using 'interpolate(<name>)'
     template<class Type>
     static tmp<GeometricField<Type, fvsPatchField, surfaceMesh> > interpolate
     (

From 4eb40f90ee507dd1449d5ce351a92c1ed0c3436f Mon Sep 17 00:00:00 2001
From: mattijs <mattijs>
Date: Wed, 2 Dec 2009 16:41:28 +0000
Subject: [PATCH 4/5] link all libraries

---
 .../foamDebugSwitches/Make/options            | 30 ++++++++++++++-----
 1 file changed, 23 insertions(+), 7 deletions(-)

diff --git a/applications/utilities/miscellaneous/foamDebugSwitches/Make/options b/applications/utilities/miscellaneous/foamDebugSwitches/Make/options
index 421e59a7f1..e473b84bb9 100644
--- a/applications/utilities/miscellaneous/foamDebugSwitches/Make/options
+++ b/applications/utilities/miscellaneous/foamDebugSwitches/Make/options
@@ -1,43 +1,59 @@
 EXE_LIBS = \
+    -lautoMesh \
+    -lbarotropicCompressibilityModel \
     -lbasicThermophysicalModels \
+    -lblockMesh \
     -lchemistryModel \
-    -lreactionThermophysicalModels \
+    -lcoalCombustion \
     -lcompressibleLESModels \
+    -lcompressibleRASModels \
+    -lcompressibleTurbulenceModel \
+    -lconversion \
     -ldecompositionMethods \
     -ldieselSpray \
+    -ldsmc \
     -ldynamicFvMesh \
     -ldynamicMesh \
     -ledgeMesh \
     -lengine \
     -lerrorEstimation \
+    -lfieldFunctionObjects \
     -lfiniteVolume \
     -lforces \
     -lfvMotionSolvers \
+    -lgenericPatchFields \
     -lincompressibleLESModels \
-    -lincompressibleTransportModels \
-    -lcompressibleRASModels \
     -lincompressibleRASModels \
+    -lincompressibleTransportModels \
+    -lincompressibleTurbulenceModel \
     -linterfaceProperties \
-    -llagrangianIntermediate \
+    -lIOFunctionObjects \
     -llagrangian \
+    -llagrangianIntermediate \
     -llaminarFlameSpeedModels \
     -lLESdeltas \
     -lLESfilters \
     -lliquidMixture \
     -lliquids \
     -lmeshTools \
+    -lmolecularMeasurements \
+    -lmolecule \
     -lODE \
     -lOpenFOAM \
     -lpdf \
-    -lphaseModel \
+    -lpotential \
     -lradiation \
     -lrandomProcesses \
+    -lreactionThermophysicalModels \
     -lsampling \
     -lsolidMixture \
+    -lsolidParticle \
     -lsolids \
     -lspecie \
+    -lsurfMesh \
+    -lsystemCall \
+    -lthermalPorousZone \
     -lthermophysicalFunctions \
     -ltopoChangerFvMesh \
     -ltriSurface \
-    -lautoMesh \
-    -lblockMesh
+    -lutilityFunctionObjects

From 1665a862064f136b6d5f51b3d1079ddfb4bbb3b7 Mon Sep 17 00:00:00 2001
From: mattijs <mattijs>
Date: Wed, 2 Dec 2009 18:32:03 +0000
Subject: [PATCH 5/5] more Icc11.1 changes

---
 .../extrude2DMesh/doExtrude2DMesh.C           |  2 +-
 .../foamToEnsight/ensightMesh.H               |  2 ++
 .../containers/Lists/ListOps/ListOps.H        |  2 +-
 src/OpenFOAM/primitives/hashes/SHA1/SHA1.C    | 35 ++++++++++---------
 .../PatchInteractionModel.C                   |  4 +++
 5 files changed, 26 insertions(+), 19 deletions(-)

diff --git a/applications/utilities/mesh/generation/extrude2DMesh/doExtrude2DMesh.C b/applications/utilities/mesh/generation/extrude2DMesh/doExtrude2DMesh.C
index c71f91079c..ff8f118d1c 100644
--- a/applications/utilities/mesh/generation/extrude2DMesh/doExtrude2DMesh.C
+++ b/applications/utilities/mesh/generation/extrude2DMesh/doExtrude2DMesh.C
@@ -89,7 +89,7 @@ int main(int argc, char *argv[])
     // ~~~~~~~~~~~~~~~~~~~~~~
 
     scalar minRange = GREAT;
-    direction extrudeDir = -1;
+    direction extrudeDir = 4;   //illegal value.
 
     for (direction dir = 0; dir < 3; dir++)
     {
diff --git a/applications/utilities/postProcessing/dataConversion/foamToEnsight/ensightMesh.H b/applications/utilities/postProcessing/dataConversion/foamToEnsight/ensightMesh.H
index 4855bfbb0e..3eb9a1e612 100644
--- a/applications/utilities/postProcessing/dataConversion/foamToEnsight/ensightMesh.H
+++ b/applications/utilities/postProcessing/dataConversion/foamToEnsight/ensightMesh.H
@@ -57,6 +57,7 @@ class argList;
 
 class ensightMesh
 {
+public:
         class nFacePrimitives
         {
         public:
@@ -75,6 +76,7 @@ class ensightMesh
             {}
         };
 
+private:
 
     // Private data
 
diff --git a/src/OpenFOAM/containers/Lists/ListOps/ListOps.H b/src/OpenFOAM/containers/Lists/ListOps/ListOps.H
index 1504fb4d78..98c7660155 100644
--- a/src/OpenFOAM/containers/Lists/ListOps/ListOps.H
+++ b/src/OpenFOAM/containers/Lists/ListOps/ListOps.H
@@ -172,7 +172,7 @@ template<class ListType>
 ListType createWithValues
 (
     const label sz,
-    const typename ListType::const_reference initValue,
+    typename ListType::const_reference initValue,
     const UList<label>& indices,
     typename ListType::const_reference setValue
 );
diff --git a/src/OpenFOAM/primitives/hashes/SHA1/SHA1.C b/src/OpenFOAM/primitives/hashes/SHA1/SHA1.C
index db45597ba7..14fac1ba8c 100644
--- a/src/OpenFOAM/primitives/hashes/SHA1/SHA1.C
+++ b/src/OpenFOAM/primitives/hashes/SHA1/SHA1.C
@@ -129,28 +129,29 @@ void Foam::SHA1::processBytes(const void *data, size_t len)
     }
 
     // Process available complete blocks
-    if (len >= 64)
-    {
-#if !_STRING_ARCH_unaligned
-# define alignof(type) offsetof (struct { char c; type x; }, x)
-# define UNALIGNED_P(p) (((size_t) p) % alignof (uint32_t) != 0)
-        if (UNALIGNED_P (data))
-        {
-            while (len > 64)
+//    if (len >= 64)
+//    {
+//#if !_STRING_ARCH_unaligned
+//# define alignof(type) offsetof (struct { char c; type x; }, x)
+//# define UNALIGNED_P(p) (((size_t) p) % alignof (uint32_t) != 0)
+//        if (UNALIGNED_P (data))
+//        {
+//            while (len > 64)
+            while (len >= 64)
             {
                 processBlock(memcpy (buffer_, data, 64), 64);
                 data = reinterpret_cast<const unsigned char*>(data) + 64;
                 len -= 64;
             }
-        }
-        else
-#endif
-        {
-            processBlock(data, len & ~63);
-            data = reinterpret_cast<const unsigned char*>(data) + (len & ~63);
-            len &= 63;
-        }
-    }
+//        }
+//        else
+//#endif
+//        {
+//            processBlock(data, len & ~63);
+//            data = reinterpret_cast<const unsigned char*>(data) + (len & ~63);
+//            len &= 63;
+//        }
+//    }
 
     // Move remaining bytes in internal buffer.
     if (len > 0)
diff --git a/src/lagrangian/intermediate/submodels/Kinematic/PatchInteractionModel/PatchInteractionModel/PatchInteractionModel.C b/src/lagrangian/intermediate/submodels/Kinematic/PatchInteractionModel/PatchInteractionModel/PatchInteractionModel.C
index 873d5fb346..b300ea5525 100644
--- a/src/lagrangian/intermediate/submodels/Kinematic/PatchInteractionModel/PatchInteractionModel/PatchInteractionModel.C
+++ b/src/lagrangian/intermediate/submodels/Kinematic/PatchInteractionModel/PatchInteractionModel/PatchInteractionModel.C
@@ -67,6 +67,10 @@ Foam::word Foam::PatchInteractionModel<CloudType>::interactionTypeToWord
             return "other";
         }
     }
+#ifdef __ICC
+    // Prevent Icc complaining about missing return statement.
+    return word::null;
+#endif
 }