From 473e14418a038fa786c2ab888782458a5352ceee Mon Sep 17 00:00:00 2001 From: Mark Olesen Date: Tue, 23 Aug 2022 15:58:32 +0200 Subject: [PATCH] ENH: more consistent use of broadcast, combineReduce etc. - broadcast : (replaces scatter) - combineReduce == combineGather + broadcast - listCombineReduce == listCombineGather + broadcast - mapCombineReduce == mapCombineGather + broadcast - allGatherList == gatherList + scatterList Before settling on a more consistent naming convention, some intermediate namings were used in OpenFOAM-v2206: - combineReduce (2206: combineAllGather) - listCombineReduce (2206: listCombineAllGather) - mapCombineReduce (2206: mapCombineAllGather) --- .../test/IndirectList/Test-IndirectList.C | 2 +- applications/test/Tuple2/Test-Tuple2.C | 8 +++--- .../Test-decomposedBlockData.C | 2 +- .../test/globalIndex/Test-globalIndex.C | 2 +- applications/test/minMax1/Test-minMax1.C | 6 +--- .../Test-parallel-communicators.C | 2 +- .../Test-parallel-nonBlocking.C | 4 +-- .../extrudeToRegionMesh/extrudeToRegionMesh.C | 8 +++--- .../conformalVoronoiMeshConformToSurface.C | 4 +-- .../generation/snappyHexMesh/snappyHexMesh.C | 10 ++++--- .../manipulation/checkMesh/checkTopology.C | 6 +--- .../manipulation/createPatch/createPatch.C | 2 +- .../splitMeshRegions/splitMeshRegions.C | 2 +- .../foamFormatConvert/foamFormatConvert.C | 8 +++--- .../parLagrangianDistributor.C | 17 +++++------ .../parLagrangianDistributorTemplates.C | 11 ++------ .../redistributePar/redistributePar.C | 10 +++---- .../foamToEnsight/findCloudFields.H | 2 +- .../foamToVTK/convertLagrangian.H | 6 ++-- .../particleTracks/particleTracks.C | 2 +- .../particleTracksSamplerTemplates.C | 3 +- .../postChannel/channelIndexTemplates.C | 2 +- .../surfaceMeshExtract/surfaceMeshExtract.C | 28 +++++++++---------- .../surfaceRedistributePar.C | 2 +- .../Lists/SortableList/ParSortableList.C | 2 +- src/OpenFOAM/db/IOobjectList/IOobjectList.C | 6 ++-- .../fields/Fields/Field/FieldFunctions.C | 8 +++--- src/OpenFOAM/fields/Fields/Field/FieldOps.C | 4 +-- .../procFacesGAMGProcAgglomeration.C | 4 +-- .../polyMesh/globalMeshData/globalMeshData.C | 8 +++--- .../mapDistribute/mapDistributeBase.H | 4 +-- .../polyMesh/syncTools/syncToolsTemplates.C | 4 +-- .../globalIndexAndTransform.C | 4 +-- .../primitives/random/Random/Random.C | 26 ++++++++--------- .../random/Random/RandomTemplates.C | 18 ++++++------ .../extrudePatchMesh/extrudePatchMesh.C | 2 +- .../fvMeshDistribute/fvMeshDistribute.C | 2 +- .../polyTopoChange/hexRef8/hexRef8.C | 4 +-- src/fileFormats/vtk/file/foamVtkFileWriter.H | 2 +- .../faGlobalMeshData/faGlobalMeshData.C | 2 +- .../turbulentDFSEMInletFvPatchVectorField.C | 2 +- .../fvMesh/fvMeshSubset/fvMeshSubset.C | 2 +- src/functionObjects/field/Curle/Curle.C | 2 +- .../field/DMD/DMDModels/derived/STDMD/STDMD.C | 24 ++++++++-------- .../columnAverage/columnAverageTemplates.C | 4 +-- .../field/externalCoupled/externalCoupled.C | 2 +- .../extractEulerianParticles.C | 4 +-- .../regionSizeDistribution.C | 4 +-- .../field/streamLine/streamLineBase.C | 2 +- .../forces/propellerInfo/propellerInfo.C | 4 +-- .../lagrangian/vtkCloud/vtkCloudTemplates.C | 9 ++---- src/functionObjects/utilities/abort/abort.C | 8 +++--- .../utilities/areaWrite/areaWrite.C | 2 +- .../utilities/areaWrite/areaWriteTemplates.C | 12 +++----- .../utilities/parProfiling/parProfiling.C | 1 - .../utilities/systemCall/systemCall.C | 4 +-- src/lagrangian/basic/Cloud/CloudIO.C | 2 +- .../ParticleZoneInfo/ParticleZoneInfo.C | 3 +- .../CellZoneInjection/CellZoneInjection.C | 2 +- .../InflationInjection/InflationInjection.C | 4 +-- .../InjectedParticleDistributionInjection.C | 17 ++++------- .../InjectedParticleInjection.C | 14 ++++------ .../PatchInjection/patchInjectionBase.C | 2 +- .../clouds/Templates/SprayCloud/SprayCloudI.H | 2 +- .../movement/lumpedPointMovement.C | 6 ++-- .../meshRefinement/meshRefinement.C | 2 +- .../meshRefinement/meshRefinementBaffles.C | 10 +++---- .../snappyHexMeshDriver/snappyRefineDriver.C | 6 ++-- src/meshTools/coupling/externalFileCoupler.C | 12 ++++---- .../mappedPolyPatch/mappedPatchBase.C | 2 +- .../multiWorld/multiWorldConnectionsObject.C | 9 ++---- .../output/vtk/topoSet/foamVtkWriteTopoSet.H | 8 +++--- src/meshTools/regionSplit2D/regionSplit2D.C | 2 +- .../triSurfaceMesh/triSurfaceMesh.C | 4 +-- .../cellSources/nearestToCell/nearestToCell.C | 2 +- .../faceSources/regionToFace/regionToFace.C | 2 +- .../planeToFaceZone/planeToFaceZone.C | 4 +-- .../nearestToPoint/nearestToPoint.C | 2 +- .../NURBS3DVolume/NURBS3DVolume.C | 4 +-- .../cellVolumeWeightCellCellStencil.C | 4 +-- .../inverseDistanceCellCellStencil.C | 4 +-- .../trackingInverseDistanceCellCellStencil.C | 2 +- src/overset/regionsToCell/findRefCells.C | 4 +-- .../decompositionMethod/decompositionMethod.C | 4 +-- .../multiLevelDecomp/multiLevelDecomp.C | 8 ++---- .../faReconstruct/faMeshReconstructor.C | 19 +++++-------- .../singleLayerRegion/singleLayerRegion.C | 2 +- .../rigidBodyMotion/rigidBodyMotion.C | 2 +- src/sampling/probes/patchProbes.C | 2 +- src/sampling/probes/patchProbesTemplates.C | 4 +-- src/sampling/probes/probesTemplates.C | 4 +-- src/sampling/sampledSet/cloud/cloudSet.C | 4 +-- .../sampledSet/patchCloud/patchCloudSet.C | 2 +- .../sampledSet/patchSeed/patchSeedSet.C | 6 +--- .../sampledSet/sampledSets/sampledSets.C | 2 +- .../sampledSet/shortestPath/shortestPathSet.C | 2 +- .../sampledMeshedSurface.C | 2 +- .../sampledSurfaces/sampledSurfaces.C | 2 +- .../surface/isoSurface/isoSurfacePoint.C | 2 +- .../sixDoFRigidBodyMotion.C | 2 +- .../TDACChemistryModel/TDACChemistryModel.C | 2 +- .../solarLoad/faceReflecting/faceReflecting.C | 4 +-- .../radiationModels/viewFactor/viewFactor.C | 10 ++----- 103 files changed, 248 insertions(+), 307 deletions(-) diff --git a/applications/test/IndirectList/Test-IndirectList.C b/applications/test/IndirectList/Test-IndirectList.C index eb22bf3b30..399d43906c 100644 --- a/applications/test/IndirectList/Test-IndirectList.C +++ b/applications/test/IndirectList/Test-IndirectList.C @@ -182,7 +182,7 @@ int main(int argc, char *argv[]) // MPI barrier bool barrier = true; - Pstream::scatter(barrier); + Pstream::broadcast(barrier); } diff --git a/applications/test/Tuple2/Test-Tuple2.C b/applications/test/Tuple2/Test-Tuple2.C index 95df0e5a42..9163f14e54 100644 --- a/applications/test/Tuple2/Test-Tuple2.C +++ b/applications/test/Tuple2/Test-Tuple2.C @@ -138,8 +138,8 @@ int main() maxFirstEqOp