From 4ecc6ccfcadf90410b0b89c214cca664d23e19d7 Mon Sep 17 00:00:00 2001 From: Mark Olesen Date: Mon, 27 Jan 2020 15:54:30 +0100 Subject: [PATCH] ENH: declare generated methods for vector-space, primitives - make read construct from Istream explicit BUG: sph(const SymmTensor2D&) - had incorrect constant, but the 2D routines still need more attention (#1575) --- .../polyMesh/syncTools/dummyTransform.H | 9 ++-- .../primitives/Barycentric/Barycentric.H | 21 +++++---- .../primitives/Barycentric/BarycentricI.H | 5 --- .../Barycentric/BarycentricTensor.H | 25 ++++++----- .../Barycentric/BarycentricTensorI.H | 5 --- .../Barycentric/barycentric/barycentric.C | 15 +++---- .../primitives/Barycentric2D/Barycentric2D.H | 22 +++++---- .../primitives/Barycentric2D/Barycentric2DI.H | 5 --- .../barycentric2D/barycentric2D.C | 13 +++--- .../primitives/DiagTensor/DiagTensor.H | 28 ++++++++---- .../primitives/DiagTensor/DiagTensorI.H | 10 ++--- .../primitives/MatrixSpace/MatrixSpace.H | 34 +++++++------- .../primitives/MatrixSpace/MatrixSpaceI.H | 5 --- src/OpenFOAM/primitives/Scalar/Scalar.H | 25 ++++++----- .../SphericalTensor/SphericalTensor.H | 34 +++++++++----- .../SphericalTensor/SphericalTensorI.H | 5 --- .../SphericalTensor2D/SphericalTensor2D.H | 32 +++++++++---- .../SphericalTensor2D/SphericalTensor2DI.H | 5 --- .../primitives/SymmTensor/SymmTensor.H | 30 ++++++++----- .../primitives/SymmTensor/SymmTensorI.H | 18 ++++---- .../primitives/SymmTensor2D/SymmTensor2D.H | 30 ++++++++----- .../primitives/SymmTensor2D/SymmTensor2DI.H | 14 +++--- src/OpenFOAM/primitives/Tensor/Tensor.H | 30 ++++++++----- src/OpenFOAM/primitives/Tensor/TensorI.H | 18 +++----- src/OpenFOAM/primitives/Tensor2D/Tensor2D.H | 24 ++++++---- src/OpenFOAM/primitives/Tensor2D/Tensor2DI.H | 11 ++--- src/OpenFOAM/primitives/Vector/Vector.H | 27 +++++++---- src/OpenFOAM/primitives/Vector/VectorI.H | 5 --- src/OpenFOAM/primitives/Vector2D/Vector2D.H | 29 +++++++----- src/OpenFOAM/primitives/Vector2D/Vector2DI.H | 5 --- .../primitives/VectorSpace/VectorSpace.H | 28 +++++++----- .../primitives/VectorSpace/VectorSpaceI.H | 13 ------ src/OpenFOAM/primitives/bools/bool/bool.H | 25 ++++++----- src/OpenFOAM/primitives/complex/complex.H | 45 ++++++++++++------- src/OpenFOAM/primitives/complex/complexI.H | 7 --- .../vectorTensorTransform.H | 41 ++++++++++++----- .../vectorTensorTransformI.H | 11 ----- src/OpenFOAM/primitives/ints/int32/int32.H | 19 ++++---- src/OpenFOAM/primitives/ints/int64/int64.H | 18 ++++---- src/OpenFOAM/primitives/ints/uint32/uint32.H | 14 +++--- src/OpenFOAM/primitives/ints/uint64/uint64.H | 14 +++--- src/OpenFOAM/primitives/pTraits/pTraits.H | 9 ++-- .../primitives/quaternion/quaternion.H | 32 +++++++++---- .../primitives/quaternion/quaternionI.H | 14 +----- .../primitives/septernion/septernion.C | 13 +++--- .../primitives/septernion/septernion.H | 41 ++++++++++++----- .../primitives/septernion/septernionI.H | 20 ++++++--- 47 files changed, 500 insertions(+), 403 deletions(-) diff --git a/src/OpenFOAM/meshes/polyMesh/syncTools/dummyTransform.H b/src/OpenFOAM/meshes/polyMesh/syncTools/dummyTransform.H index 3691e80c93..3f803d7847 100644 --- a/src/OpenFOAM/meshes/polyMesh/syncTools/dummyTransform.H +++ b/src/OpenFOAM/meshes/polyMesh/syncTools/dummyTransform.H @@ -6,6 +6,7 @@ \\/ M anipulation | ------------------------------------------------------------------------------- Copyright (C) 2011-2016 OpenFOAM Foundation + Copyright (C) 2020 OpenCFD Ltd. ------------------------------------------------------------------------------- License This file is part of OpenFOAM. @@ -73,7 +74,7 @@ class pTraits> public: typedef label cmptType; - pTraits(Istream& is) + explicit pTraits(Istream& is) : List(is) {} @@ -87,7 +88,7 @@ class pTraits> public: typedef label cmptType; - pTraits(Istream& is) + explicit pTraits(Istream& is) : UList(is) {} @@ -101,7 +102,7 @@ class pTraits> public: typedef label cmptType; - pTraits(Istream& is) + explicit pTraits(Istream& is) : Field(is) {} @@ -115,7 +116,7 @@ class pTraits public: typedef label cmptType; - pTraits(Istream& is) + explicit pTraits(Istream& is) : face(is) {} diff --git a/src/OpenFOAM/primitives/Barycentric/Barycentric.H b/src/OpenFOAM/primitives/Barycentric/Barycentric.H index 8a76a26f42..4112a157e4 100644 --- a/src/OpenFOAM/primitives/Barycentric/Barycentric.H +++ b/src/OpenFOAM/primitives/Barycentric/Barycentric.H @@ -6,7 +6,7 @@ \\/ M anipulation | ------------------------------------------------------------------------------- Copyright (C) 2016-2017 OpenFOAM Foundation - Copyright (C) 2019 OpenCFD Ltd. + Copyright (C) 2019-2020 OpenCFD Ltd. ------------------------------------------------------------------------------- License This file is part of OpenFOAM. @@ -58,11 +58,13 @@ class Barycentric { public: - //- Equivalent type of labels used for valid component indexing - typedef Barycentric