diff --git a/src/lagrangian/DSMC/clouds/Templates/DSMCCloud/DSMCCloud.C b/src/lagrangian/DSMC/clouds/Templates/DSMCCloud/DSMCCloud.C index 250c3f8e74..7e128716da 100644 --- a/src/lagrangian/DSMC/clouds/Templates/DSMCCloud/DSMCCloud.C +++ b/src/lagrangian/DSMC/clouds/Templates/DSMCCloud/DSMCCloud.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | + \\ / A nd | Copyright (C) 2019 OpenCFD Ltd. \\/ M anipulation | ------------------------------------------------------------------------------- | Copyright (C) 2011-2017 OpenFOAM Foundation @@ -50,7 +50,7 @@ void Foam::DSMCCloud::buildConstProps() forAll(typeIdList_, i) { - const word& id(typeIdList_[i]); + const word& id = typeIdList_[i]; Info<< " " << id << endl; @@ -64,14 +64,14 @@ void Foam::DSMCCloud::buildConstProps() template void Foam::DSMCCloud::buildCellOccupancy() { - forAll(cellOccupancy_, cO) + for (auto& list : cellOccupancy_) { - cellOccupancy_[cO].clear(); + list.clear(); } - forAllIter(typename DSMCCloud, *this, iter) + for (ParcelType& p : *this) { - cellOccupancy_[iter().cell()].append(&iter()); + cellOccupancy_[p.cell()].append(&p); } } @@ -400,9 +400,8 @@ void Foam::DSMCCloud::calculateFields() scalarField& iDof = iDof_.primitiveFieldRef(); vectorField& momentum = momentum_.primitiveFieldRef(); - forAllConstIter(typename DSMCCloud, *this, iter) + for (const ParcelType& p : *this) { - const ParcelType& p = iter(); const label celli = p.cell(); rhoN[celli]++; @@ -692,7 +691,7 @@ Foam::DSMCCloud::DSMCCloud const fvMesh& mesh, const IOdictionary& dsmcInitialiseDict ) - : +: Cloud(mesh, cloudName, false), DSMCBaseCloud(), cloudName_(cloudName), @@ -1038,13 +1037,11 @@ void Foam::DSMCCloud::dumpParticlePositions() const + this->db().time().timeName() + ".obj" ); - forAllConstIter(typename DSMCCloud, *this, iter) + for (const ParcelType& p : *this) { - const ParcelType& p = iter(); - pObj<< "v " << p.position().x() - << " " << p.position().y() - << " " << p.position().z() + << ' ' << p.position().y() + << ' ' << p.position().z() << nl; } diff --git a/src/lagrangian/DSMC/clouds/Templates/DSMCCloud/DSMCCloudI.H b/src/lagrangian/DSMC/clouds/Templates/DSMCCloud/DSMCCloudI.H index d0e96515af..91182dfd01 100644 --- a/src/lagrangian/DSMC/clouds/Templates/DSMCCloud/DSMCCloudI.H +++ b/src/lagrangian/DSMC/clouds/Templates/DSMCCloud/DSMCCloudI.H @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | + \\ / A nd | Copyright (C) 2019 OpenCFD Ltd. \\/ M anipulation | ------------------------------------------------------------------------------- | Copyright (C) 2011-2016 OpenFOAM Foundation @@ -259,10 +259,8 @@ inline Foam::scalar Foam::DSMCCloud::massInSystem() const { scalar sysMass = 0.0; - forAllConstIter(typename DSMCCloud, *this, iter) + for (const ParcelType& p : *this) { - const ParcelType& p = iter(); - const typename ParcelType::constantProperties& cP = constProps ( p.typeId() @@ -280,10 +278,8 @@ inline Foam::vector Foam::DSMCCloud::linearMomentumOfSystem() const { vector linearMomentum(Zero); - forAllConstIter(typename DSMCCloud, *this, iter) + for (const ParcelType& p : *this) { - const ParcelType& p = iter(); - const typename ParcelType::constantProperties& cP = constProps ( p.typeId() @@ -302,10 +298,8 @@ Foam::DSMCCloud::linearKineticEnergyOfSystem() const { scalar linearKineticEnergy = 0.0; - forAllConstIter(typename DSMCCloud, *this, iter) + for (const ParcelType& p : *this) { - const ParcelType& p = iter(); - const typename ParcelType::constantProperties& cP = constProps ( p.typeId() @@ -324,10 +318,8 @@ Foam::DSMCCloud::internalEnergyOfSystem() const { scalar internalEnergy = 0.0; - forAllConstIter(typename DSMCCloud, *this, iter) + for (const ParcelType& p : *this) { - const ParcelType& p = iter(); - internalEnergy += p.Ei(); } diff --git a/src/lagrangian/DSMC/parcels/Templates/DSMCParcel/DSMCParcelIO.C b/src/lagrangian/DSMC/parcels/Templates/DSMCParcel/DSMCParcelIO.C index c066219452..556b0a8f28 100644 --- a/src/lagrangian/DSMC/parcels/Templates/DSMCParcel/DSMCParcelIO.C +++ b/src/lagrangian/DSMC/parcels/Templates/DSMCParcel/DSMCParcelIO.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | Copyright (C) 2016 OpenCFD Ltd. + \\ / A nd | Copyright (C) 2016-2019 OpenCFD Ltd. \\/ M anipulation | ------------------------------------------------------------------------------- | Copyright (C) 2011-2017 OpenFOAM Foundation @@ -94,14 +94,12 @@ void Foam::DSMCParcel::readFields(Cloud>& c) c.checkFieldIOobject(c, typeId); label i = 0; - forAllIter(typename Cloud>, c, iter) + for (DSMCParcel& p : c) { - DSMCParcel& p = iter(); - p.U_ = U[i]; p.Ei_ = Ei[i]; p.typeId_ = typeId[i]; - i++; + ++i; } } @@ -121,14 +119,12 @@ void Foam::DSMCParcel::writeFields IOField