zhyang-dev/openfoam
1
0
Fork 0
mirror of https://develop.openfoam.com/Development/openfoam.git synced 2025-11-28 03:28:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

BUG: clearing objectRegistry can leak memory (#1180)

Browse Source 
- now free anything owned by the registry when doing a clear.

- the myriad of other ways to remove items (and potentially leaking)
  have not yet been addressed:
  * set, erase, retain, filterKeys, filterValues, filterEntries
This commit is contained in:
Mark Olesen
2019-01-23 15:52:43 +01:00
parent f33061cc2a
commit 5878b6edc5
2 changed files with 37 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/OpenFOAM/db/objectRegistry/objectRegistry.C
View File

@ -3,7 +3,7 @@
\\ / F ield | OpenFOAM: The Open Source CFD Toolbox
\\ / O peration |
\\ / A nd | Copyright (C) 2011-2017 OpenFOAM Foundation
\\/ M anipulation | Copyright (C) 2015-2018 OpenCFD Ltd.
\\/ M anipulation | Copyright (C) 2015-2019 OpenCFD Ltd.
-------------------------------------------------------------------------------
License
This file is part of OpenFOAM.
@ -85,21 +85,7 @@ Foam::objectRegistry::objectRegistry(const IOobject& io, const label nObjects)
Foam::objectRegistry::~objectRegistry()
{
List<regIOobject*> myObjects(size());
label nObjects = 0;
for (iterator iter = begin(); iter != end(); ++iter)
{
if (iter.val()->ownedByRegistry())
{
myObjects[nObjects++] = iter.val();
}
}
for (label i=0; i < nObjects; ++i)
{
checkOut(*myObjects[i]);
}
objectRegistry::clear();
}
@ -265,6 +251,30 @@ bool Foam::objectRegistry::checkOut(regIOobject& io) const
}
void Foam::objectRegistry::clear()
{
// Free anything owned by the registry
for (iterator iter = begin(); iter != end(); ++iter)
{
regIOobject* ptr = iter.val();
if (ptr && ptr->ownedByRegistry())
{
delete ptr;
}
}
HashTable<regIOobject*>::clear();
}
void Foam::objectRegistry::clearStorage()
{
objectRegistry::clear();
HashTable<regIOobject*>::clearStorage();
}
void Foam::objectRegistry::rename(const word& newName)
{
regIOobject::rename(newName);

15
src/OpenFOAM/db/objectRegistry/objectRegistry.H
View File

@ -3,7 +3,7 @@
\\ / F ield | OpenFOAM: The Open Source CFD Toolbox
\\ / O peration |
\\ / A nd | Copyright (C) 2011-2016 OpenFOAM Foundation
\\/ M anipulation | Copyright (C) 2016-2018 OpenCFD Ltd.
\\/ M anipulation | Copyright (C) 2016-2019 OpenCFD Ltd.
-------------------------------------------------------------------------------
License
This file is part of OpenFOAM.
@ -430,15 +430,22 @@ public:
// Edit
//- Rename
virtual void rename(const word& newName);
//- Add a regIOobject to registry
bool checkIn(regIOobject& io) const;
//- Remove a regIOobject from registry
bool checkOut(regIOobject& io) const;
//- Clear all entries from the registry
// Performs a checkOut() for all objects that are ownedByRegistry
void clear();
//- Clear all entries from the registry and the table itself.
void clearStorage();
//- Rename
virtual void rename(const word& newName);
// Reading