From 5c62d8188056d77604ec732e7628254e7bcf3862 Mon Sep 17 00:00:00 2001 From: Henry Weller Date: Sat, 8 Apr 2017 22:23:40 +0100 Subject: [PATCH] radiation: Corrected the name of the radiative heat flux from Qr to qr The standard naming convention for heat flux is "q" and this is used for the conductive and convective heat fluxes is OpenFOAM. The use of "Qr" for radiative heat flux is an anomaly which causes confusion, particularly for boundary conditions in which "Q" is used to denote power in Watts. The name of the radiative heat flux has now been corrected to "qr" and all models, boundary conditions and tutorials updated. --- .../viewFactorsGen/viewFactorsGen.C | 18 +++--- .../thermalBaffle1DFvPatchScalarField.C | 56 ++++++++-------- .../thermalBaffle1DFvPatchScalarField.H | 18 +++--- ...eratureRadCoupledMixedFvPatchScalarField.C | 38 +++++------ ...eratureRadCoupledMixedFvPatchScalarField.H | 14 ++-- .../field/wallHeatFlux/wallHeatFlux.C | 8 +-- .../reactingOneDim/reactingOneDim.C | 48 +++++++------- .../reactingOneDim/reactingOneDim.H | 10 +-- ...sRadiativeCoupledMixedFvPatchScalarField.C | 32 +++++----- ...sRadiativeCoupledMixedFvPatchScalarField.H | 10 +-- .../constantRadiation/constantRadiation.C | 8 +-- .../constantRadiation/constantRadiation.H | 4 +- .../primaryRadiation/primaryRadiation.H | 2 +- .../standardRadiation/standardRadiation.C | 12 ++-- .../standardRadiation/standardRadiation.H | 4 +- .../thermalBaffleFvPatchScalarField.H | 4 +- ...iffusiveRadiationMixedFvPatchScalarField.C | 4 +- ...veViewFactorFixedValueFvPatchScalarField.C | 14 ++-- ...veViewFactorFixedValueFvPatchScalarField.H | 14 ++-- ...iffusiveRadiationMixedFvPatchScalarField.C | 4 +- .../radiation/radiationModels/P1/P1.C | 18 +++--- .../radiation/radiationModels/P1/P1.H | 4 +- .../radiationModels/fvDOM/fvDOM/fvDOM.C | 18 +++--- .../radiationModels/fvDOM/fvDOM/fvDOM.H | 6 +- .../radiationModels/fvDOM/fvDOM/fvDOMI.H | 6 +- .../radiativeIntensityRay.C | 10 +-- .../radiativeIntensityRay.H | 8 +-- .../radiativeIntensityRayI.H | 10 +-- .../radiationModels/viewFactor/viewFactor.C | 64 +++++++++---------- .../radiationModels/viewFactor/viewFactor.H | 6 +- .../radiationModels/viewFactor/viewFactorI.H | 7 +- .../LES/flameSpreadWaterSuppressionPanel/0/T | 4 +- .../0/pyrolysisRegion/T | 4 +- .../0/pyrolysisRegion/{Qr => qr} | 4 +- .../constant/pyrolysisZones | 4 +- .../fireFoam/LES/oppositeBurningPanels/0/T | 4 +- .../LES/oppositeBurningPanels/0/panelRegion/T | 4 +- .../0/panelRegion/{Qr => qr} | 6 +- .../constant/pyrolysisZones | 2 +- .../smallPoolFire2D/constant/pyrolysisZones | 2 +- .../smallPoolFire3D/constant/pyrolysisZones | 2 +- .../multiRegionHeaterRadiation/0/{Qr => qr} | 2 +- .../multiRegionHeaterRadiation/Allrun.pre | 2 +- .../system/bottomAir/changeDictionaryDict | 10 +-- .../system/bottomAir/fvSolution | 2 +- .../system/heater/changeDictionaryDict | 8 +-- .../system/leftSolid/changeDictionaryDict | 8 +-- .../system/rightSolid/changeDictionaryDict | 8 +-- .../system/topAir/changeDictionaryDict | 10 +-- .../system/topAir/fvSolution | 2 +- 50 files changed, 283 insertions(+), 284 deletions(-) rename tutorials/combustion/fireFoam/LES/flameSpreadWaterSuppressionPanel/0/pyrolysisRegion/{Qr => qr} (94%) rename tutorials/combustion/fireFoam/LES/oppositeBurningPanels/0/panelRegion/{Qr => qr} (96%) rename tutorials/heatTransfer/chtMultiRegionSimpleFoam/multiRegionHeaterRadiation/0/{Qr => qr} (98%) diff --git a/applications/utilities/preProcessing/viewFactorsGen/viewFactorsGen.C b/applications/utilities/preProcessing/viewFactorsGen/viewFactorsGen.C index e5a9f2094e..d318bd7384 100644 --- a/applications/utilities/preProcessing/viewFactorsGen/viewFactorsGen.C +++ b/applications/utilities/preProcessing/viewFactorsGen/viewFactorsGen.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | Copyright (C) 2011-2016 OpenFOAM Foundation + \\ / A nd | Copyright (C) 2011-2017 OpenFOAM Foundation \\/ M anipulation | ------------------------------------------------------------------------------- License @@ -31,7 +31,7 @@ Description Each view factor between the agglomerated faces i and j (Fij) is calculated using a double integral of the sub-areas composing the agglomaration. - The patches involved in the view factor calculation are taken from the Qr + The patches involved in the view factor calculation are taken from the qr volScalarField (radiative flux) when is greyDiffusiveRadiationViewFactor otherwise they are not included. @@ -272,11 +272,11 @@ int main(int argc, char *argv[]) const label debug = viewFactorDict.lookupOrDefault