mirror of
https://develop.openfoam.com/Development/openfoam.git
synced 2025-12-28 03:37:59 +00:00
ENH: code reduction in PackedList, PackedBoolList (issue #751)
- eliminate iterators from PackedList since they were unused, had
lower performance than direct access and added unneeded complexity.
- eliminate auto-vivify for the PackedList '[] operator.
The set() method provides any required auto-vivification and
removing this ability from the '[]' operator allows for a lower
when accessing the values. Replaced the previous cascade of iterators
with simpler reference class.
PackedBoolList:
- (temporarily) eliminate logic and addition operators since
these contained partially unclear semantics.
- the new test() method tests the value of a single bit position and
returns a bool without any ambiguity caused by the return type
(like the get() method), nor the const/non-const access (like
operator[] has). The name corresponds to what std::bitset uses.
- more consistent use of PackedBoolList test(), set(), unset() methods
for fewer operation and clearer code. Eg,
if (list.test(index)) ... | if (list[index]) ...
if (!list.test(index)) ... | if (list[index] == 0u) ...
list.set(index); | list[index] = 1u;
list.unset(index); | list[index] = 0u;
- deleted the operator=(const labelUList&) and replaced with a setMany()
method for more clarity about the intended operation and to avoid any
potential inadvertent behaviour.
This commit is contained in:
@ -84,7 +84,7 @@ void modifyOrAddFace
|
||||
PackedBoolList& modifiedFace
|
||||
)
|
||||
{
|
||||
if (!modifiedFace[facei])
|
||||
if (modifiedFace.set(facei))
|
||||
{
|
||||
// First usage of face. Modify.
|
||||
meshMod.setAction
|
||||
@ -102,7 +102,6 @@ void modifyOrAddFace
|
||||
zoneFlip // face flip in zone
|
||||
)
|
||||
);
|
||||
modifiedFace[facei] = 1;
|
||||
}
|
||||
else
|
||||
{
|
||||
@ -342,7 +341,7 @@ void subsetTopoSets
|
||||
PackedBoolList isSet(set.maxSize(mesh));
|
||||
forAllConstIter(labelHashSet, set, iter)
|
||||
{
|
||||
isSet[iter.key()] = true;
|
||||
isSet.set(iter.key());
|
||||
}
|
||||
label nSet = 0;
|
||||
forAll(map, i)
|
||||
@ -375,7 +374,7 @@ void createCoupledBaffles
|
||||
fvMesh& mesh,
|
||||
const labelList& coupledWantedPatch,
|
||||
polyTopoChange& meshMod,
|
||||
PackedBoolList& modifiedFace
|
||||
PackedBoolList& modifiedFace
|
||||
)
|
||||
{
|
||||
const faceZoneMesh& faceZones = mesh.faceZones();
|
||||
@ -443,7 +442,7 @@ void createCyclicCoupledBaffles
|
||||
const labelList& cyclicMasterPatch,
|
||||
const labelList& cyclicSlavePatch,
|
||||
polyTopoChange& meshMod,
|
||||
PackedBoolList& modifiedFace
|
||||
PackedBoolList& modifiedFace
|
||||
)
|
||||
{
|
||||
const faceZoneMesh& faceZones = mesh.faceZones();
|
||||
|
||||
Reference in New Issue
Block a user