diff --git a/src/thermophysicalModels/basic/basicThermo/basicThermoTemplates.C b/src/thermophysicalModels/basic/basicThermo/basicThermoTemplates.C index 364311183f..19db3c6476 100644 --- a/src/thermophysicalModels/basic/basicThermo/basicThermoTemplates.C +++ b/src/thermophysicalModels/basic/basicThermo/basicThermoTemplates.C @@ -269,7 +269,7 @@ Foam::autoPtr Foam::basicThermo::New ) ); - typename Thermo::fvMeshDictPhaseConstructorTable::iterator cstrIter = + auto cstrIter = lookupThermo ( thermoDict, diff --git a/src/thermophysicalModels/chemistryModel/chemistryModel/TDACChemistryModel/tabulation/ISAT/ISAT.C b/src/thermophysicalModels/chemistryModel/chemistryModel/TDACChemistryModel/tabulation/ISAT/ISAT.C index afb16ad856..01f4c87b42 100644 --- a/src/thermophysicalModels/chemistryModel/chemistryModel/TDACChemistryModel/tabulation/ISAT/ISAT.C +++ b/src/thermophysicalModels/chemistryModel/chemistryModel/TDACChemistryModel/tabulation/ISAT/ISAT.C @@ -142,14 +142,13 @@ void Foam::chemistryTabulationMethods::ISAT::addToMRU { if (maxMRUSize_ > 0 && MRURetrieve_) { - typename SLList*>::iterator iter = - MRUList_.begin(); + auto iter = MRUList_.begin(); // First search if the chemPoint is already in the list bool isInList = false; - for ( ; iter != MRUList_.end(); ++iter) + for (; iter.good(); ++iter) { - if (iter() == phi0) + if (*iter == phi0) { isInList = true; break; @@ -161,10 +160,7 @@ void Foam::chemistryTabulationMethods::ISAT::addToMRU // If it is in the list, then move it to front if (iter != MRUList_.begin()) { - // iter hold the position of the element to move MRUList_.remove(iter); - - // Insert the element in front of the list MRUList_.insert(phi0); } } diff --git a/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/greyMeanSolidAbsorptionEmission/greyMeanSolidAbsorptionEmission.C b/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/greyMeanSolidAbsorptionEmission/greyMeanSolidAbsorptionEmission.C index 6e92e3f47a..abc441d0b0 100644 --- a/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/greyMeanSolidAbsorptionEmission/greyMeanSolidAbsorptionEmission.C +++ b/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/greyMeanSolidAbsorptionEmission/greyMeanSolidAbsorptionEmission.C @@ -134,12 +134,6 @@ greyMeanSolidAbsorptionEmission } } -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -Foam::radiation::greyMeanSolidAbsorptionEmission:: -~greyMeanSolidAbsorptionEmission() -{} - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // @@ -167,7 +161,7 @@ calc(const label propertyId) const scalarField& a = ta.ref().primitiveFieldRef(); - forAllConstIter(HashTable