From afc69b20105198c9512e0d19d56376e3ceb4218d Mon Sep 17 00:00:00 2001 From: Henry Date: Wed, 6 Apr 2011 22:04:47 +0100 Subject: [PATCH 1/2] snappyHexMesh/flange tutorial: Removed refinement of boss and increased overall resolution --- .../flange/constant/polyMesh/blockMeshDict | 2 +- .../snappyHexMesh/flange/system/snappyHexMeshDict | 15 --------------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/tutorials/mesh/snappyHexMesh/flange/constant/polyMesh/blockMeshDict b/tutorials/mesh/snappyHexMesh/flange/constant/polyMesh/blockMeshDict index 83ee691b8c..75bf99b399 100644 --- a/tutorials/mesh/snappyHexMesh/flange/constant/polyMesh/blockMeshDict +++ b/tutorials/mesh/snappyHexMesh/flange/constant/polyMesh/blockMeshDict @@ -30,7 +30,7 @@ vertices blocks ( - hex (0 1 2 3 4 5 6 7) (15 15 9) simpleGrading (1 1 1) + hex (0 1 2 3 4 5 6 7) (20 16 12) simpleGrading (1 1 1) ); edges diff --git a/tutorials/mesh/snappyHexMesh/flange/system/snappyHexMeshDict b/tutorials/mesh/snappyHexMesh/flange/system/snappyHexMeshDict index d7f6fd3439..46980c8d2f 100644 --- a/tutorials/mesh/snappyHexMesh/flange/system/snappyHexMeshDict +++ b/tutorials/mesh/snappyHexMesh/flange/system/snappyHexMeshDict @@ -42,16 +42,6 @@ geometry centre (0 0 -0.012); radius 0.003; } - - //- Refine a bit extra around the edge of the flange. With only two cells - // across it might/might not mesh correctly. - refineCap - { - type searchableCylinder; - point1 (0 0.021 -0.01075); - point2 (0 0.025 -0.01075); - radius 0.013; - } }; @@ -144,11 +134,6 @@ castellatedMeshControls mode inside; levels ((1E15 3)); } - refineCap - { - mode inside; - levels ((1E15 3)); - } } From 1a0095489b83a8941777ad9cfa0cca7a78678ef8 Mon Sep 17 00:00:00 2001 From: Henry Date: Wed, 6 Apr 2011 22:55:47 +0100 Subject: [PATCH 2/2] gcc-4.6.0 warnings: removed initialised but unused variables --- .../utilities/mesh/conversion/sammToFoam/readPoints.C | 2 +- .../mesh/conversion/star3ToFoam/readPoints.C | 9 ++++----- .../miscellaneous/foamDebugSwitches/Make/options | 1 - .../PV3FoamReader/vtkPV3Foam/vtkPV3FoamMeshVolume.C | 10 +--------- src/OpenFOAM/include/checkTimeOptions.H | 8 ++++---- .../meshes/primitiveMesh/primitiveMeshClear.C | 3 ++- src/engine/ignition/ignitionSite.C | 4 +--- .../basic/InteractionLists/InteractionLists.C | 2 -- src/lagrangian/dieselSpray/parcel/parcel.C | 2 -- .../spraySubModels/atomizationModel/LISA/LISA.C | 3 +-- .../dieselSpray/spraySubModels/breakupModel/SHF/SHF.C | 3 --- .../injectorModel/blobsSwirl/blobsSwirlInjector.C | 9 +-------- src/mesh/blockMesh/blockMesh/blockMeshMerge.C | 11 +---------- .../triSurface/triSurfaceTools/geompack/geompack.C | 3 +-- .../linearAxialAngularSpring.C | 11 +++-------- .../tabulatedAxialAngularSpring.C | 8 +++----- 16 files changed, 23 insertions(+), 66 deletions(-) diff --git a/applications/utilities/mesh/conversion/sammToFoam/readPoints.C b/applications/utilities/mesh/conversion/sammToFoam/readPoints.C index c6b793ff82..00c0a3cc37 100644 --- a/applications/utilities/mesh/conversion/sammToFoam/readPoints.C +++ b/applications/utilities/mesh/conversion/sammToFoam/readPoints.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | Copyright (C) 2004-2010 OpenCFD Ltd. + \\ / A nd | Copyright (C) 2004-2011 OpenCFD Ltd. \\/ M anipulation | ------------------------------------------------------------------------------- License diff --git a/applications/utilities/mesh/conversion/star3ToFoam/readPoints.C b/applications/utilities/mesh/conversion/star3ToFoam/readPoints.C index 5c364266f6..bc931fd5c7 100644 --- a/applications/utilities/mesh/conversion/star3ToFoam/readPoints.C +++ b/applications/utilities/mesh/conversion/star3ToFoam/readPoints.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | Copyright (C) 2004-2010 OpenCFD Ltd. + \\ / A nd | Copyright (C) 2004-2011 OpenCFD Ltd. \\/ M anipulation | ------------------------------------------------------------------------------- License @@ -86,7 +86,6 @@ void starMesh::readPoints(const scalar scaleFactor) if (pointsFile.good()) { label pointLabel; - scalar x, y, z; maxLabel = -1; while (pointsFile) @@ -97,9 +96,9 @@ void starMesh::readPoints(const scalar scaleFactor) maxLabel = max(maxLabel, pointLabel); - x = readVtxCmpt(pointsFile); - y = readVtxCmpt(pointsFile); - z = readVtxCmpt(pointsFile); + readVtxCmpt(pointsFile); + readVtxCmpt(pointsFile); + readVtxCmpt(pointsFile); readToNl(pointsFile); diff --git a/applications/utilities/miscellaneous/foamDebugSwitches/Make/options b/applications/utilities/miscellaneous/foamDebugSwitches/Make/options index abee4af7eb..988d2a4edb 100644 --- a/applications/utilities/miscellaneous/foamDebugSwitches/Make/options +++ b/applications/utilities/miscellaneous/foamDebugSwitches/Make/options @@ -33,7 +33,6 @@ EXE_LIBS = \ -linterfaceProperties \ -lIOFunctionObjects \ -ljobControl \ - -lkineticTheoryModel \ -llagrangian \ -llagrangianIntermediate \ -llaminarFlameSpeedModels \ diff --git a/applications/utilities/postProcessing/graphics/PV3Readers/PV3FoamReader/vtkPV3Foam/vtkPV3FoamMeshVolume.C b/applications/utilities/postProcessing/graphics/PV3Readers/PV3FoamReader/vtkPV3Foam/vtkPV3FoamMeshVolume.C index 099e8d4f37..77b53c5815 100644 --- a/applications/utilities/postProcessing/graphics/PV3Readers/PV3FoamReader/vtkPV3Foam/vtkPV3FoamMeshVolume.C +++ b/applications/utilities/postProcessing/graphics/PV3Readers/PV3FoamReader/vtkPV3Foam/vtkPV3FoamMeshVolume.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | Copyright (C) 2004-2010 OpenCFD Ltd. + \\ / A nd | Copyright (C) 2004-2011 OpenCFD Ltd. \\/ M anipulation | ------------------------------------------------------------------------------- License @@ -383,16 +383,12 @@ vtkUnstructuredGrid* Foam::vtkPV3Foam::volumeVTKMesh forAll(quadFcs, quadI) { - label thisCellI; - if (substituteCell) { - thisCellI = cellI; substituteCell = false; } else { - thisCellI = mesh.nCells() + addCellI; superCells[addCellI++] = cellI; } @@ -430,16 +426,12 @@ vtkUnstructuredGrid* Foam::vtkPV3Foam::volumeVTKMesh forAll(triFcs, triI) { - label thisCellI; - if (substituteCell) { - thisCellI = cellI; substituteCell = false; } else { - thisCellI = mesh.nCells() + addCellI; superCells[addCellI++] = cellI; } diff --git a/src/OpenFOAM/include/checkTimeOptions.H b/src/OpenFOAM/include/checkTimeOptions.H index f5e7248322..a52fc1d05b 100644 --- a/src/OpenFOAM/include/checkTimeOptions.H +++ b/src/OpenFOAM/include/checkTimeOptions.H @@ -2,11 +2,11 @@ // checkTimeOptions.H // ~~~~~~~~~~~~~~~~~~ - Foam::label startTime = 0; - Foam::label endTime = Times.size(); +Foam::label startTime = 0; +Foam::label endTime = Times.size(); // unless -constant is present, skip startTime if it is "constant" -# include "checkConstantOption.H" +#include "checkConstantOption.H" // check -time and -latestTime options -# include "checkTimeOption.H" +#include "checkTimeOption.H" diff --git a/src/OpenFOAM/meshes/primitiveMesh/primitiveMeshClear.C b/src/OpenFOAM/meshes/primitiveMesh/primitiveMeshClear.C index cc232c162f..13c94fcfae 100644 --- a/src/OpenFOAM/meshes/primitiveMesh/primitiveMeshClear.C +++ b/src/OpenFOAM/meshes/primitiveMesh/primitiveMeshClear.C @@ -24,9 +24,10 @@ License \*---------------------------------------------------------------------------*/ #include "primitiveMesh.H" +#include "indexedOctree.H" +#include "treeDataCell.H" #include "demandDrivenData.H" - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // void Foam::primitiveMesh::printAllocated() const diff --git a/src/engine/ignition/ignitionSite.C b/src/engine/ignition/ignitionSite.C index b83580bd92..866dfb5ae8 100644 --- a/src/engine/ignition/ignitionSite.C +++ b/src/engine/ignition/ignitionSite.C @@ -2,7 +2,7 @@ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | - \\ / A nd | Copyright (C) 2004-2010 OpenCFD Ltd. + \\ / A nd | Copyright (C) 2004-2011 OpenCFD Ltd. \\/ M anipulation | ------------------------------------------------------------------------------- License @@ -51,7 +51,6 @@ void Foam::ignitionSite::findIgnitionCells(const fvMesh& mesh) cellVolumes_[0] = vols[ignCell]; scalar minDist = GREAT; - label nearestCell = 0; label nIgnCells = 1; forAll(centres, celli) @@ -60,7 +59,6 @@ void Foam::ignitionSite::findIgnitionCells(const fvMesh& mesh) if (dist < minDist) { - nearestCell = celli; minDist = dist; } diff --git a/src/lagrangian/basic/InteractionLists/InteractionLists.C b/src/lagrangian/basic/InteractionLists/InteractionLists.C index 3a138449b5..552ae6fb70 100644 --- a/src/lagrangian/basic/InteractionLists/InteractionLists.C +++ b/src/lagrangian/basic/InteractionLists/InteractionLists.C @@ -654,8 +654,6 @@ void Foam::InteractionLists::findExtendedProcBbsInRange { List