STYLE: mark deprecated findIndices methods with warnings

- were deprecated Aug-2018, but not marked as such

src/OpenFOAM/meshes/pointMesh/pointBoundaryMesh/pointBoundaryMesh.H

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2013 OpenFOAM Foundation
-    Copyright (C) 2018 OpenCFD Ltd.
+    Copyright (C) 2018-2020 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -115,11 +115,11 @@ public:
     // Housekeeping
 
         //- Identical to the indices() method (AUG-2018)
+        FOAM_DEPRECATED_FOR(2018-08, "indices() method")
         labelList findIndices(const keyType& key, const bool useGroups) const
         {
             return indices(key, useGroups);
         }
-
 };
 
 

src/OpenFOAM/meshes/polyMesh/polyBoundaryMesh/polyBoundaryMesh.H

@@ -298,6 +298,7 @@ public:
     // Housekeeping
 
         //- Identical to the indices() method (AUG-2018)
+        FOAM_DEPRECATED_FOR(2018-08, "indices() method")
         labelList findIndices
         (
             const keyType& key,

src/OpenFOAM/meshes/polyMesh/polyBoundaryMesh/polyBoundaryMeshEntries.C

@@ -6,6 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2012 OpenFOAM Foundation
+    Copyright (C) 2020 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -31,7 +32,7 @@ License
 
 namespace Foam
 {
-    defineTypeNameAndDebug(polyBoundaryMeshEntries, 0);
+    defineTypeName(polyBoundaryMeshEntries);
 }
 
 

src/OpenFOAM/meshes/polyMesh/polyBoundaryMesh/polyBoundaryMeshEntries.H

@@ -6,6 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2015 OpenFOAM Foundation
+    Copyright (C) 2020 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -27,7 +28,7 @@ Class
     Foam::polyBoundaryMeshEntries
 
 Description
-    Foam::polyBoundaryMeshEntries
+    Read and store dictionary entries for boundary patches
 
 SourceFiles
     polyBoundaryMeshEntries.C
@@ -46,18 +47,19 @@ SourceFiles
 namespace Foam
 {
 
-// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //
+/*---------------------------------------------------------------------------*\
+                   Class polyBoundaryMeshEntries Declaration
+\*---------------------------------------------------------------------------*/
 
 class polyBoundaryMeshEntries
 :
     public regIOobject,
     public PtrList<entry>
 {
-
 public:
 
     //- Runtime type information
-    TypeName("polyBoundaryMesh");
+    TypeNameNoDebug("polyBoundaryMesh");
 
 
     // Constructors

src/OpenFOAM/meshes/polyMesh/zones/ZoneMesh/ZoneMesh.H

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2016 OpenFOAM Foundation
-    Copyright (C) 2016-2018 OpenCFD Ltd.
+    Copyright (C) 2016-2020 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -50,7 +50,7 @@ SourceFiles
 namespace Foam
 {
 
-// Forward declarations
+// Forward Declarations
 
 template<class ZoneType, class MeshType> class ZoneMesh;
 
@@ -68,7 +68,7 @@ class ZoneMesh
     public PtrList<ZoneType>,
     public regIOobject
 {
-    // Private data
+    // Private Data
 
         //- Reference to mesh
         const MeshType& mesh_;
@@ -289,7 +289,7 @@ public:
         ZoneType& operator()(const word& zoneName, const bool verbose=false);
 
 
-    // Ostream operator
+    // Ostream Operator
 
         friend Ostream& operator<< <ZoneType, MeshType>
         (
@@ -301,6 +301,7 @@ public:
     // Housekeeping
 
         //- Identical to the indices() method (AUG-2018)
+        FOAM_DEPRECATED_FOR(2018-08, "indices() method")
         labelList findIndices(const keyType& key) const
         {
             return indices(key);

src/finiteArea/faMesh/faBoundaryMesh/faBoundaryMesh.H

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2016-2017 Wikki Ltd
-    Copyright (C) 2018 OpenCFD Ltd.
+    Copyright (C) 2018-2020 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -131,11 +131,11 @@ public:
             wordList types() const;
 
             //- Return patch indices for all matches.
-            //  Matching patchGroups currently not supported
+            //  \not Matching patchGroups currently not supported
             labelList indices
             (
                 const keyType& key,
-                const bool useGroups = false
+                const bool useGroups = false  /* ignored */
             ) const;
 
             //- Return patch index for the first match, return -1 if not found
@@ -171,6 +171,7 @@ public:
     // Housekeeping
 
         //- Identical to the indices() method (AUG-2018)
+        FOAM_DEPRECATED_FOR(2018-08, "indices() method")
         labelList findIndices
         (
             const keyType& key,
@@ -179,7 +180,6 @@ public:
         {
             return indices(key, useGroups);
         }
-
 };
 
 

src/finiteVolume/fvMesh/fvBoundaryMesh/fvBoundaryMesh.H

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2016 OpenFOAM Foundation
-    Copyright (C) 2018 OpenCFD Ltd.
+    Copyright (C) 2018-2020 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -135,6 +135,7 @@ public:
     // Housekeeping
 
         //- Identical to the indices() method (AUG-2018)
+        FOAM_DEPRECATED_FOR(2018-08, "indices() method")
         labelList findIndices(const keyType& key, const bool useGroups) const
         {
             return indices(key, useGroups);

src/functionObjects/field/fieldExtents/fieldExtents.C

@@ -140,7 +140,7 @@ bool Foam::functionObjects::fieldExtents::read(const dictionary& dict)
         {
             for (const wordRe& name : patchNames)
             {
-                patchIDs_.insert(pbm.findIndices(name));
+                patchIDs_.insert(pbm.indices(name));
             }
         }
         else

src/meshTools/coordinate/systems/coordinateSystems.H

@@ -188,6 +188,7 @@ public:
     // Housekeeping
 
         //- Identical to the indices() method (AUG-2018)
+        FOAM_DEPRECATED_FOR(2018-08, "indices() method")
         labelList findIndices(const keyType& key) const
         {
             return this->indices(key);