From 9dffad7cad1c731a9e6155fbe32937ab6c2b6ccc Mon Sep 17 00:00:00 2001 From: Henry Date: Tue, 4 Feb 2014 16:24:23 +0000 Subject: [PATCH] Compressible solvers: change interpolation of rho*HbyA back to HbyA to avoid instability in prism and NACA test cases --- applications/solvers/compressible/rhoPimpleFoam/pEqn.H | 6 +++--- .../compressible/rhoPimpleFoam/rhoPimpleDyMFoam/pEqn.H | 6 +++--- .../compressible/rhoPimpleFoam/rhoPimplecFoam/pEqn.H | 5 +++-- applications/solvers/compressible/rhoSimpleFoam/pEqn.H | 3 +-- .../compressible/rhoSimpleFoam/rhoSimplecFoam/pEqn.H | 3 +-- applications/solvers/compressible/sonicFoam/pEqn.H | 6 +++--- .../solvers/compressible/sonicFoam/sonicDyMFoam/pEqn.H | 6 +++--- .../sonicFoam/sonicLiquidFoam/sonicLiquidFoam.C | 6 +++--- 8 files changed, 20 insertions(+), 21 deletions(-) diff --git a/applications/solvers/compressible/rhoPimpleFoam/pEqn.H b/applications/solvers/compressible/rhoPimpleFoam/pEqn.H index a4e5fa20da..e0619a513b 100644 --- a/applications/solvers/compressible/rhoPimpleFoam/pEqn.H +++ b/applications/solvers/compressible/rhoPimpleFoam/pEqn.H @@ -21,9 +21,9 @@ if (pimple.transonic()) "phid", fvc::interpolate(psi) *( - (fvc::interpolate(rho*HbyA) & mesh.Sf()) - + rhorAUf*fvc::ddtCorr(rho, U, phi) - )/fvc::interpolate(rho) + (fvc::interpolate(HbyA) & mesh.Sf()) + + rhorAUf*fvc::ddtCorr(rho, U, phi)/fvc::interpolate(rho) + ) ); fvOptions.makeRelative(fvc::interpolate(psi), phid); diff --git a/applications/solvers/compressible/rhoPimpleFoam/rhoPimpleDyMFoam/pEqn.H b/applications/solvers/compressible/rhoPimpleFoam/rhoPimpleDyMFoam/pEqn.H index 1c58a02c33..e9fab27bc7 100644 --- a/applications/solvers/compressible/rhoPimpleFoam/rhoPimpleDyMFoam/pEqn.H +++ b/applications/solvers/compressible/rhoPimpleFoam/rhoPimpleDyMFoam/pEqn.H @@ -21,9 +21,9 @@ if (pimple.transonic()) "phid", fvc::interpolate(psi) *( - (fvc::interpolate(rho*HbyA) & mesh.Sf()) - + rhorAUf*fvc::ddtCorr(rho, U, rhoUf) - )/fvc::interpolate(rho) + (fvc::interpolate(HbyA) & mesh.Sf()) + + rhorAUf*fvc::ddtCorr(rho, U, rhoUf)/fvc::interpolate(rho) + ) ); fvc::makeRelative(phid, psi, U); diff --git a/applications/solvers/compressible/rhoPimpleFoam/rhoPimplecFoam/pEqn.H b/applications/solvers/compressible/rhoPimpleFoam/rhoPimplecFoam/pEqn.H index 0503db4207..7363add2b9 100644 --- a/applications/solvers/compressible/rhoPimpleFoam/rhoPimplecFoam/pEqn.H +++ b/applications/solvers/compressible/rhoPimpleFoam/rhoPimplecFoam/pEqn.H @@ -20,9 +20,10 @@ if (pimple.transonic()) "phid", fvc::interpolate(psi) *( - (fvc::interpolate(rho*HbyA) & mesh.Sf()) + (fvc::interpolate(HbyA) & mesh.Sf()) + fvc::interpolate(rho*rAU)*fvc::ddtCorr(rho, U, phi) - )/fvc::interpolate(rho) + /fvc::interpolate(rho) + ) ); fvOptions.makeRelative(fvc::interpolate(psi), phid); diff --git a/applications/solvers/compressible/rhoSimpleFoam/pEqn.H b/applications/solvers/compressible/rhoSimpleFoam/pEqn.H index 444f5e996a..b1fc930be9 100644 --- a/applications/solvers/compressible/rhoSimpleFoam/pEqn.H +++ b/applications/solvers/compressible/rhoSimpleFoam/pEqn.H @@ -13,8 +13,7 @@ ( "phid", fvc::interpolate(psi) - *(fvc::interpolate(rho*HbyA) & mesh.Sf()) - /fvc::interpolate(rho) + *(fvc::interpolate(HbyA) & mesh.Sf()) ); fvOptions.makeRelative(fvc::interpolate(psi), phid); diff --git a/applications/solvers/compressible/rhoSimpleFoam/rhoSimplecFoam/pEqn.H b/applications/solvers/compressible/rhoSimpleFoam/rhoSimplecFoam/pEqn.H index c656b3c3d7..78878dcfaf 100644 --- a/applications/solvers/compressible/rhoSimpleFoam/rhoSimplecFoam/pEqn.H +++ b/applications/solvers/compressible/rhoSimpleFoam/rhoSimplecFoam/pEqn.H @@ -14,8 +14,7 @@ if (simple.transonic()) ( "phid", fvc::interpolate(psi) - *(fvc::interpolate(rho*HbyA) & mesh.Sf()) - /fvc::interpolate(rho) + *(fvc::interpolate(HbyA) & mesh.Sf()) ); surfaceScalarField phic diff --git a/applications/solvers/compressible/sonicFoam/pEqn.H b/applications/solvers/compressible/sonicFoam/pEqn.H index edde4b198e..022abc466a 100644 --- a/applications/solvers/compressible/sonicFoam/pEqn.H +++ b/applications/solvers/compressible/sonicFoam/pEqn.H @@ -11,9 +11,9 @@ surfaceScalarField phid "phid", fvc::interpolate(psi)* ( - (mesh.Sf() & fvc::interpolate(rho*HbyA)) - + rhorAUf*fvc::ddtCorr(rho, U, phi) - )/fvc::interpolate(rho) + (mesh.Sf() & fvc::interpolate(HbyA)) + + rhorAUf*fvc::ddtCorr(rho, U, phi)/fvc::interpolate(rho) + ) ); // Non-orthogonal pressure corrector loop diff --git a/applications/solvers/compressible/sonicFoam/sonicDyMFoam/pEqn.H b/applications/solvers/compressible/sonicFoam/sonicDyMFoam/pEqn.H index 4799f64567..b375f0e82a 100644 --- a/applications/solvers/compressible/sonicFoam/sonicDyMFoam/pEqn.H +++ b/applications/solvers/compressible/sonicFoam/sonicDyMFoam/pEqn.H @@ -12,9 +12,9 @@ surfaceScalarField phid fvc::interpolate(psi) *( ( - (fvc::interpolate(rho*HbyA) & mesh.Sf()) - + rhorAUf*fvc::ddtCorr(rho, U, rhoUf) - )/fvc::interpolate(rho) + (fvc::interpolate(HbyA) & mesh.Sf()) + + rhorAUf*fvc::ddtCorr(rho, U, rhoUf)/fvc::interpolate(rho) + ) ) ); diff --git a/applications/solvers/compressible/sonicFoam/sonicLiquidFoam/sonicLiquidFoam.C b/applications/solvers/compressible/sonicFoam/sonicLiquidFoam/sonicLiquidFoam.C index df3f3cdc61..a727ece55f 100644 --- a/applications/solvers/compressible/sonicFoam/sonicLiquidFoam/sonicLiquidFoam.C +++ b/applications/solvers/compressible/sonicFoam/sonicLiquidFoam/sonicLiquidFoam.C @@ -89,9 +89,9 @@ int main(int argc, char *argv[]) "phid", psi *( - (fvc::interpolate(rho*U) & mesh.Sf()) - + rhorAUf*fvc::ddtCorr(rho, U, phi) - )/fvc::interpolate(rho) + (fvc::interpolate(U) & mesh.Sf()) + + rhorAUf*fvc::ddtCorr(rho, U, phi)/fvc::interpolate(rho) + ) ); phi = (rhoO/psi)*phid;