From a592ebc073741add89be6a3e8bf5d82196959d7b Mon Sep 17 00:00:00 2001 From: Mark Olesen Date: Wed, 18 Jul 2018 13:33:00 +0200 Subject: [PATCH] STYLE: avoid unrestricted dictionary lookup in conversion, sampling, surfMesh - aids with detection of excess tokens (issue #762) - deprecated dictionary::operator[] in favour of the lookup() method which offers more flexibilty and clarity of purpose. Additionally, the read<> and get<> forms should generally be used instead anyhow. --- .../conversion/ccm/foamToCcm/getTimeIndex.H | 20 ++--------- .../conversion/foamToFireMesh/getTimeIndex.H | 20 ++--------- .../conversion/foamToStarMesh/getTimeIndex.H | 19 ++--------- .../conversion/foamToSurface/getTimeIndex.H | 19 ++--------- .../createBaffles/createBaffles.C | 10 +++--- .../manipulation/mergeMeshes/mergePolyMesh.C | 2 +- .../mesh/manipulation/stitchMesh/stitchMesh.C | 8 ++--- .../foamUpgradeCyclics/foamUpgradeCyclics.C | 22 ++++++------- .../surfaceFeatureExtract.C | 12 ++++--- src/ODE/ODESolvers/ODESolver/ODESolver.C | 4 +-- src/ODE/ODESolvers/ODESolver/ODESolverNew.C | 2 +- src/OpenFOAM/db/dictionary/dictionary.C | 6 ---- src/OpenFOAM/db/dictionary/dictionary.H | 10 +++--- src/OpenFOAM/dimensionSet/dimensionSetIO.C | 4 +-- src/OpenFOAM/global/argList/argList.C | 28 +++++----------- .../global/constants/dimensionedConstants.C | 2 +- .../fileOperation/fileOperation.C | 12 +++---- .../fileOperation/fileOperation.H | 2 +- src/conversion/ccm/reader/ccmReader.C | 2 +- src/conversion/ccm/reader/ccmReaderMesh.C | 18 +++++----- src/conversion/ccm/writer/ccmWriter.C | 33 ++++++++----------- src/conversion/ccm/writer/ccmWriterSolution.C | 21 ++---------- src/conversion/common/tables/boundaryRegion.C | 2 +- .../refinementFeatures/refinementFeatures.C | 4 +-- src/sampling/probes/patchProbes.C | 4 +-- src/sampling/probes/probes.C | 4 +-- src/sampling/sampledSet/array/arraySet.C | 4 +-- src/sampling/sampledSet/array/arraySet.H | 5 +-- src/sampling/sampledSet/circle/circleSet.C | 9 ++--- src/sampling/sampledSet/cloud/cloudSet.C | 2 +- src/sampling/sampledSet/cloud/cloudSet.H | 2 +- src/sampling/sampledSet/face/faceOnlySet.C | 4 +-- .../sampledSet/patchCloud/patchCloudSet.C | 7 ++-- .../sampledSet/patchCloud/patchCloudSet.H | 2 +- .../sampledSet/patchSeed/patchSeedSet.C | 5 +-- .../sampledSet/polyLine/polyLineSet.C | 2 +- .../sampledSet/polyLine/polyLineSet.H | 2 +- .../sampledSet/sampledSets/sampledSets.C | 12 +++---- .../sampledSet/shortestPath/shortestPathSet.C | 4 +-- src/sampling/sampledSet/uniform/uniformSet.C | 4 +-- .../isoSurface/sampledIsoSurface.C | 6 ++-- .../isoSurface/sampledIsoSurfaceCell.C | 4 +-- .../sampledCuttingPlane/sampledCuttingPlane.C | 2 +- .../sampledPatch/sampledPatch.C | 2 +- .../sampledPatchInternalField.C | 11 +++---- .../sampledSurface/sampledSurface.C | 2 +- .../sampledSurfaces/sampledSurfaces.C | 6 ++-- .../sampledTriSurfaceMesh.C | 2 +- .../sampledThresholdCellFaces.C | 2 +- .../ensight/ensightSurfaceWriterTemplates.C | 2 +- .../writers/nastran/nastranSurfaceWriter.C | 3 +- .../writers/raw/rawSurfaceWriter.C | 2 +- .../surfMeshSample/surfMeshSample.C | 2 +- .../surfMeshSamplers/surfMeshSamplers.C | 2 +- .../surface/distanceSurface/distanceSurface.C | 4 +-- .../surface/triSurfaceMesh/discreteSurface.C | 2 +- src/surfMesh/surfZone/surfZone/surfZone.C | 4 +-- .../surfZone/surfZone/surfZoneIOList.C | 4 +-- .../triSurface/patches/surfacePatch.C | 4 +-- 59 files changed, 158 insertions(+), 262 deletions(-) diff --git a/applications/utilities/mesh/conversion/ccm/foamToCcm/getTimeIndex.H b/applications/utilities/mesh/conversion/ccm/foamToCcm/getTimeIndex.H index 4547e06457..b8cb089b4b 100644 --- a/applications/utilities/mesh/conversion/ccm/foamToCcm/getTimeIndex.H +++ b/applications/utilities/mesh/conversion/ccm/foamToCcm/getTimeIndex.H @@ -21,23 +21,8 @@ if (io.typeHeaderOk(true)) { - IOdictionary timeObject - ( - IOobject - ( - "time", - runTime.timeName(), - "uniform", - runTime, - IOobject::MUST_READ, - IOobject::NO_WRITE, - false - ) - ); - - label index; - timeObject.lookup("index") >> index; - timeName = Foam::name(index); + const label timeIndex = IOdictionary(io).get