From b76595df42fc2b0392221d420b3dd5cf5561287f Mon Sep 17 00:00:00 2001 From: Mark Olesen Date: Tue, 3 Oct 2023 14:17:10 +0200 Subject: [PATCH] ENH: improve stream output of std::string etc. - change write(const string&) to write(const std::string&). This allows output of std::string without an intermediate copy. - additional writeQuoted method to handle range of char data: writeQuoted(const char* str, std::streamsize len, bool) This helps with supporting string_view and span - add operator<< for stdFoam::span and std::string_view (c++17) - avoid duplicate code in OBJstream STYLE: add override keyword for IO stream methods --- .../test/compoundToken1/Test-compoundToken1.C | 2 +- applications/test/string_view1/Make/files | 3 + applications/test/string_view1/Make/options | 2 + .../test/string_view1/Test-string_view1.C | 94 ++++++++ .../makeFaMesh/faMeshWriteEdgesOBJ.H | 8 +- src/OpenFOAM/db/IOstreams/Fstreams/IFstream.H | 8 +- src/OpenFOAM/db/IOstreams/Fstreams/OFstream.H | 12 +- src/OpenFOAM/db/IOstreams/IOstreams/Ostream.C | 18 +- src/OpenFOAM/db/IOstreams/IOstreams/Ostream.H | 69 ++++-- .../db/IOstreams/Pstreams/UIPstream.H | 116 +++++----- .../db/IOstreams/Pstreams/UIPstreamBase.C | 2 +- .../db/IOstreams/Pstreams/UOPstream.H | 201 ++++++++++-------- .../db/IOstreams/Pstreams/UOPstreamBase.C | 58 ++--- src/OpenFOAM/db/IOstreams/Sstreams/ISstream.H | 133 ++++++------ src/OpenFOAM/db/IOstreams/Sstreams/OSstream.C | 90 +++++--- src/OpenFOAM/db/IOstreams/Sstreams/OSstream.H | 151 ++++++------- .../db/IOstreams/Sstreams/prefixOSstream.C | 40 ++-- .../db/IOstreams/Sstreams/prefixOSstream.H | 86 ++++---- .../db/IOstreams/StringStreams/StringStream.H | 4 +- src/OpenFOAM/db/IOstreams/Tstreams/ITstream.H | 32 +-- src/OpenFOAM/db/IOstreams/Tstreams/OTstream.C | 55 ++--- src/OpenFOAM/db/IOstreams/Tstreams/OTstream.H | 79 ++++--- .../db/IOstreams/dummy/dummyISstream.H | 161 +++++++------- .../db/IOstreams/hashes/OSHA1stream.H | 4 +- .../db/IOstreams/memory/ICharStream.H | 16 +- .../db/IOstreams/memory/ISpanStream.H | 4 +- .../db/IOstreams/memory/OCharStream.H | 16 +- .../db/IOstreams/memory/OCountStream.H | 2 +- .../db/IOstreams/memory/OSpanStream.H | 2 +- .../primitives/strings/string/stringIO.C | 4 +- src/fileFormats/ensight/file/ensightFile.C | 33 +-- src/fileFormats/ensight/file/ensightFile.H | 33 +-- .../ensight/read/ensightReadFile.H | 16 +- src/fileFormats/obj/OBJstream.C | 113 ++++++---- src/fileFormats/obj/OBJstream.H | 157 +++++++------- 35 files changed, 1036 insertions(+), 788 deletions(-) create mode 100644 applications/test/string_view1/Make/files create mode 100644 applications/test/string_view1/Make/options create mode 100644 applications/test/string_view1/Test-string_view1.C diff --git a/applications/test/compoundToken1/Test-compoundToken1.C b/applications/test/compoundToken1/Test-compoundToken1.C index 8eabd24fb1..bfb56875b2 100644 --- a/applications/test/compoundToken1/Test-compoundToken1.C +++ b/applications/test/compoundToken1/Test-compoundToken1.C @@ -57,7 +57,7 @@ class IFstreamDelayed : public IFstream { - virtual bool readCompoundToken(token& tok, const word& type) + virtual bool readCompoundToken(token& tok, const word& type) override { auto& is = *this; diff --git a/applications/test/string_view1/Make/files b/applications/test/string_view1/Make/files new file mode 100644 index 0000000000..4d92aada22 --- /dev/null +++ b/applications/test/string_view1/Make/files @@ -0,0 +1,3 @@ +Test-string_view1.C + +EXE = $(FOAM_USER_APPBIN)/Test-string_view1 diff --git a/applications/test/string_view1/Make/options b/applications/test/string_view1/Make/options new file mode 100644 index 0000000000..18e6fe47af --- /dev/null +++ b/applications/test/string_view1/Make/options @@ -0,0 +1,2 @@ +/* EXE_INC = */ +/* EXE_LIBS = */ diff --git a/applications/test/string_view1/Test-string_view1.C b/applications/test/string_view1/Test-string_view1.C new file mode 100644 index 0000000000..155e364165 --- /dev/null +++ b/applications/test/string_view1/Test-string_view1.C @@ -0,0 +1,94 @@ +/*---------------------------------------------------------------------------*\ + ========= | + \\ / F ield | OpenFOAM: The Open Source CFD Toolbox + \\ / O peration | + \\ / A nd | www.openfoam.com + \\/ M anipulation | +------------------------------------------------------------------------------- + Copyright (C) 2023 OpenCFD Ltd. +------------------------------------------------------------------------------- +License + This file is part of OpenFOAM. + + OpenFOAM is free software: you can redistribute it and/or modify it + under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + OpenFOAM is distributed in the hope that it will be useful, but WITHOUT + ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + for more details. + + You should have received a copy of the GNU General Public License + along with OpenFOAM. If not, see . + +Description + Test some string_view functionality + +\*---------------------------------------------------------------------------*/ + +#include "string.H" +#include "IOstreams.H" +#include "List.H" + +using namespace Foam; + +// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // +// Main program: + +int main(int argc, char *argv[]) +{ + Info<< "Compiled with C++ " << __cplusplus; + #if __cplusplus >= 201703L + Info<< " - has std::string_view" << nl << nl; + #else + Info<< " - NO std::string_view" << nl << nl; + #endif + + // basics + { + for + ( + const auto& cstr + : + { + "abcdef" + } + ) + { + const auto len = strlen(cstr); + + Info<< nl + << "input: <" << cstr << '>' + << " type: " << typeid(cstr).name() << " len:" << len << nl; + + #if __cplusplus >= 201703L + Info<< " view: " << std::string_view(cstr) << nl; + #endif + + Info<< " span: " + << stdFoam::span(cstr, len) << nl; + Info<< " span: " + << stdFoam::span(const_cast(cstr), len) << nl; + } + } + + // This should fail to compile: + #if 0 + { + labelList values(identity(4)); + + Info<< "values: " << values << nl; + + Info<< " span: " + << stdFoam::span