diff --git a/applications/solvers/multiphase/interCondensingEvaporatingFoam/UEqn.H b/applications/solvers/multiphase/interCondensingEvaporatingFoam/UEqn.H index 1e27597292..249c5a3cb1 100644 --- a/applications/solvers/multiphase/interCondensingEvaporatingFoam/UEqn.H +++ b/applications/solvers/multiphase/interCondensingEvaporatingFoam/UEqn.H @@ -2,7 +2,6 @@ ( fvm::ddt(rho, U) + fvm::div(rhoPhi, U) - - fvm::Sp(fvc::ddt(rho) + fvc::div(rhoPhi), U) + turbulence->divDevRhoReff(rho, U) ); diff --git a/applications/solvers/multiphase/interCondensingEvaporatingFoam/continuityError.H b/applications/solvers/multiphase/interCondensingEvaporatingFoam/continuityError.H deleted file mode 100644 index 9a33fb896d..0000000000 --- a/applications/solvers/multiphase/interCondensingEvaporatingFoam/continuityError.H +++ /dev/null @@ -1,12 +0,0 @@ -volScalarField contErr(fvc::ddt(rho) + fvc::div(rhoPhi)); - -scalar sumLocalContErr = runTime.deltaTValue()* - mag(contErr)().weightedAverage(mesh.V()).value(); - -scalar globalContErr = runTime.deltaTValue()* - contErr.weightedAverage(mesh.V()).value(); - -Info<< "time step continuity errors : sum local = " << sumLocalContErr - << ", global = " << globalContErr - << endl; - diff --git a/applications/solvers/multiphase/interCondensingEvaporatingFoam/createFields.H b/applications/solvers/multiphase/interCondensingEvaporatingFoam/createFields.H index 20d3677bfc..c0e2adcb51 100644 --- a/applications/solvers/multiphase/interCondensingEvaporatingFoam/createFields.H +++ b/applications/solvers/multiphase/interCondensingEvaporatingFoam/createFields.H @@ -28,20 +28,6 @@ #include "createPhi.H" - // Create p before the thermo - volScalarField p - ( - IOobject - ( - "p", - runTime.timeName(), - mesh, - IOobject::NO_READ, - IOobject::AUTO_WRITE - ), - p_rgh - ); - // Creating e based thermo autoPtr thermo; thermo.set(new twoPhaseMixtureEThermo(U, phi)); @@ -54,9 +40,10 @@ volScalarField& T = thermo->T(); volScalarField& e = thermo->he(); + e.oldTime(); // Correct e from T and alpha - thermo->correct(); + //thermo->correct(); volScalarField& alpha1(thermo->alpha1()); volScalarField& alpha2(thermo->alpha2()); @@ -80,7 +67,6 @@ ); rho.oldTime(); - // Construct interface from alpha1 distribution interfaceProperties interface ( @@ -100,8 +86,7 @@ volScalarField gh("gh", g & mesh.C()); surfaceScalarField ghf("ghf", g & mesh.Cf()); - //Update p with rho - p = p_rgh + rho*gh; + volScalarField& p = thermo->p(); label pRefCell = 0; scalar pRefValue = 0.0; diff --git a/applications/solvers/multiphase/interCondensingEvaporatingFoam/eEqn.H b/applications/solvers/multiphase/interCondensingEvaporatingFoam/eEqn.H index 291d574d8a..386e4cdff9 100644 --- a/applications/solvers/multiphase/interCondensingEvaporatingFoam/eEqn.H +++ b/applications/solvers/multiphase/interCondensingEvaporatingFoam/eEqn.H @@ -14,9 +14,7 @@ fvScalarMatrix eEqn ( fvm::ddt(rho, e) - + fvc::ddt(rho, K) + fvc::div(rhoPhi, K) + fvm::div(rhoPhi, e) - - fvm::Sp(fvc::ddt(rho) + fvc::div(rhoPhi), e) - fvm::laplacian(kappaEff/cp, e) + pDivU ); diff --git a/applications/solvers/multiphase/interCondensingEvaporatingFoam/interCondensatingEvaporatingFoam.C b/applications/solvers/multiphase/interCondensingEvaporatingFoam/interCondensatingEvaporatingFoam.C index 2fb0013224..362e4d0132 100644 --- a/applications/solvers/multiphase/interCondensingEvaporatingFoam/interCondensatingEvaporatingFoam.C +++ b/applications/solvers/multiphase/interCondensingEvaporatingFoam/interCondensatingEvaporatingFoam.C @@ -63,20 +63,21 @@ int main(int argc, char *argv[]) pimpleControl pimple(mesh); #include "readGravitationalAcceleration.H" - #include "initContinuityErrs.H" #include "createFields.H" #include "createFvOptions.H" #include "createTimeControls.H" #include "CourantNo.H" #include "setInitialDeltaT.H" + turbulence->validate(); + // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // Info<< "\nStarting time loop\n" << endl; while (runTime.run()) { - #include "readTimeControls.H" + #include "createTimeControls.H" #include "CourantNo.H" #include "setDeltaT.H" @@ -101,9 +102,12 @@ int main(int argc, char *argv[]) dimensionedScalar("0", dimMass/dimTime, 0) ); - #include "alphaEqnSubCycle.H" mixture->correct(); + #include "alphaEqnSubCycle.H" + + solve(fvm::ddt(rho) + fvc::div(rhoPhi)); + #include "UEqn.H" #include "eEqn.H" @@ -113,14 +117,14 @@ int main(int argc, char *argv[]) #include "pEqn.H" } - #include "continuityError.H" - if (pimple.turbCorr()) { turbulence->correct(); } } + rho = alpha1*rho1 + alpha2*rho2; + runTime.write(); Info<< "ExecutionTime = " << runTime.elapsedCpuTime() << " s" diff --git a/applications/solvers/multiphase/interCondensingEvaporatingFoam/pEqn.H b/applications/solvers/multiphase/interCondensingEvaporatingFoam/pEqn.H index 62de089533..366dc78a12 100644 --- a/applications/solvers/multiphase/interCondensingEvaporatingFoam/pEqn.H +++ b/applications/solvers/multiphase/interCondensingEvaporatingFoam/pEqn.H @@ -1,9 +1,7 @@ { volScalarField rAU("rAU", 1.0/UEqn.A()); surfaceScalarField rAUf("rAUf", fvc::interpolate(rAU)); - volVectorField HbyA(constrainHbyA(rAU*UEqn.H(), U, p_rgh)); - surfaceScalarField phiHbyA ( "phiHbyA", @@ -53,8 +51,7 @@ } } - - p == p_rgh + rho*gh; + p = p_rgh + rho*gh; if (p_rgh.needReference()) { diff --git a/applications/solvers/multiphase/interCondensingEvaporatingFoam/temperaturePhaseChangeTwoPhaseMixtures/constant/constant.C b/applications/solvers/multiphase/interCondensingEvaporatingFoam/temperaturePhaseChangeTwoPhaseMixtures/constant/constant.C index 6d3f21c2fb..c215b3d21c 100644 --- a/applications/solvers/multiphase/interCondensingEvaporatingFoam/temperaturePhaseChangeTwoPhaseMixtures/constant/constant.C +++ b/applications/solvers/multiphase/interCondensingEvaporatingFoam/temperaturePhaseChangeTwoPhaseMixtures/constant/constant.C @@ -78,8 +78,8 @@ Foam::temperaturePhaseChangeTwoPhaseMixtures::constant::mDotAlphal() const return Pair> ( - coeffC_*mixture_.rho2()*max(TSat - T, T0), - -coeffE_*mixture_.rho1()*max(T - TSat, T0) + coeffC_*mixture_.rho2()*max(TSat - T.oldTime(), T0), + -coeffE_*mixture_.rho1()*max(T.oldTime() - TSat, T0) ); } @@ -112,8 +112,8 @@ Foam::temperaturePhaseChangeTwoPhaseMixtures::constant::mDot() const return Pair> ( - coeffC_*mixture_.rho2()*limitedAlpha2*max(TSat - T, T0), - coeffE_*mixture_.rho1()*limitedAlpha1*max(T - TSat, T0) + coeffC_*mixture_.rho2()*limitedAlpha2*max(TSat - T.oldTime(), T0), + coeffE_*mixture_.rho1()*limitedAlpha1*max(T.oldTime() - TSat, T0) ); } @@ -144,8 +144,8 @@ Foam::temperaturePhaseChangeTwoPhaseMixtures::constant::mDotDeltaT() const return Pair> ( - coeffC_*mixture_.rho2()*limitedAlpha2*pos(TSat - T), - coeffE_*mixture_.rho1()*limitedAlpha1*pos(T - TSat) + coeffC_*mixture_.rho2()*limitedAlpha2*pos(TSat - T.oldTime()), + coeffE_*mixture_.rho1()*limitedAlpha1*pos(T.oldTime() - TSat) ); } diff --git a/applications/utilities/mesh/conversion/ansysToFoam/ansysToFoam.L b/applications/utilities/mesh/conversion/ansysToFoam/ansysToFoam.L index 5c4c321850..3268db2108 100644 --- a/applications/utilities/mesh/conversion/ansysToFoam/ansysToFoam.L +++ b/applications/utilities/mesh/conversion/ansysToFoam/ansysToFoam.L @@ -702,6 +702,7 @@ int main(int argc, char *argv[]) IOstream::defaultPrecision(max(10u, IOstream::defaultPrecision())); Info<< "Writing polyMesh" << endl; + pShapeMesh.removeFiles(); pShapeMesh.write(); Info<< nl << "end" << endl; diff --git a/applications/utilities/mesh/conversion/cfx4ToFoam/cfx4ToFoam.C b/applications/utilities/mesh/conversion/cfx4ToFoam/cfx4ToFoam.C index 45477dd4fb..ee5b4f073b 100644 --- a/applications/utilities/mesh/conversion/cfx4ToFoam/cfx4ToFoam.C +++ b/applications/utilities/mesh/conversion/cfx4ToFoam/cfx4ToFoam.C @@ -753,6 +753,7 @@ int main(int argc, char *argv[]) IOstream::defaultPrecision(max(10u, IOstream::defaultPrecision())); Info<< "Writing polyMesh" << endl; + pShapeMesh.removeFiles(); pShapeMesh.write(); Info<< "End\n" << endl; diff --git a/applications/utilities/mesh/conversion/fluentMeshToFoam/fluentMeshToFoam.L b/applications/utilities/mesh/conversion/fluentMeshToFoam/fluentMeshToFoam.L index 5a0ebc94aa..fbb98236c8 100644 --- a/applications/utilities/mesh/conversion/fluentMeshToFoam/fluentMeshToFoam.L +++ b/applications/utilities/mesh/conversion/fluentMeshToFoam/fluentMeshToFoam.L @@ -1177,6 +1177,9 @@ int main(int argc, char *argv[]) patchPhysicalTypes ); + // Remove files now, to ensure all mesh files written are consistent. + pShapeMesh.removeFiles(); + //dont write mesh yet, otherwise preservePatchTypes will be broken //and zones wont be written //checkmesh done after patch addition as well diff --git a/applications/utilities/mesh/conversion/gambitToFoam/gambitToFoam.L b/applications/utilities/mesh/conversion/gambitToFoam/gambitToFoam.L index f9ce3c3423..ff3ae5737e 100644 --- a/applications/utilities/mesh/conversion/gambitToFoam/gambitToFoam.L +++ b/applications/utilities/mesh/conversion/gambitToFoam/gambitToFoam.L @@ -865,6 +865,7 @@ int main(int argc, char *argv[]) IOstream::defaultPrecision(max(10u, IOstream::defaultPrecision())); Info<< "Writing polyMesh" << endl; + pShapeMesh.removeFiles(); pShapeMesh.write(); Info<< "\nEnd\n" << endl; diff --git a/applications/utilities/mesh/conversion/gmshToFoam/gmshToFoam.C b/applications/utilities/mesh/conversion/gmshToFoam/gmshToFoam.C index a1d4f55668..add9bf0392 100644 --- a/applications/utilities/mesh/conversion/gmshToFoam/gmshToFoam.C +++ b/applications/utilities/mesh/conversion/gmshToFoam/gmshToFoam.C @@ -942,6 +942,9 @@ int main(int argc, char *argv[]) boundaryPatchPhysicalTypes ); + // Remove files now, to ensure all mesh files written are consistent. + mesh.removeFiles(); + repatchPolyTopoChanger repatcher(mesh); // Now use the patchFaces to patch up the outside faces of the mesh. @@ -1140,6 +1143,9 @@ int main(int argc, char *argv[]) repatcher.changePatches(newPatchPtrList); } + // Set the precision of the points data to 10 + IOstream::defaultPrecision(max(10u, IOstream::defaultPrecision())); + mesh.write(); Info<< "End\n" << endl; diff --git a/applications/utilities/mesh/conversion/ideasUnvToFoam/ideasUnvToFoam.C b/applications/utilities/mesh/conversion/ideasUnvToFoam/ideasUnvToFoam.C index 6c3c2451e0..9239b81a5d 100644 --- a/applications/utilities/mesh/conversion/ideasUnvToFoam/ideasUnvToFoam.C +++ b/applications/utilities/mesh/conversion/ideasUnvToFoam/ideasUnvToFoam.C @@ -1158,8 +1158,6 @@ int main(int argc, char *argv[]) Info<< endl; - - // Construct mesh polyMesh mesh ( @@ -1179,8 +1177,10 @@ int main(int argc, char *argv[]) wordList(0) // boundaryPatchPhysicalTypes ); + // Remove files now, to ensure all mesh files written are consistent. + mesh.removeFiles(); - if (faceZones.size() > 0 || cellZones.size() > 0) + if (faceZones.size() || cellZones.size()) { Info << "Adding cell and face zones" << endl; @@ -1188,7 +1188,7 @@ int main(int argc, char *argv[]) List fZones(faceZones.size()); List cZones(cellZones.size()); - if (cellZones.size() > 0) + if (cellZones.size()) { forAll(cellZones.toc(), cnt) { @@ -1205,7 +1205,7 @@ int main(int argc, char *argv[]) ); } } - if (faceZones.size() > 0) + if (faceZones.size()) { const labelList& own = mesh.faceOwner(); const labelList& nei = mesh.faceNeighbour(); @@ -1289,6 +1289,9 @@ int main(int argc, char *argv[]) Info << endl; } + // Set the precision of the points data to 10 + IOstream::defaultPrecision(max(10u, IOstream::defaultPrecision())); + mesh.write(); Info<< "End\n" << endl; diff --git a/applications/utilities/mesh/conversion/kivaToFoam/readKivaGrid.H b/applications/utilities/mesh/conversion/kivaToFoam/readKivaGrid.H index 994f0c57a7..6b5fa8621c 100644 --- a/applications/utilities/mesh/conversion/kivaToFoam/readKivaGrid.H +++ b/applications/utilities/mesh/conversion/kivaToFoam/readKivaGrid.H @@ -574,7 +574,11 @@ polyMesh pShapeMesh defaultFacesType ); +// Set the precision of the points data to 10 +IOstream::defaultPrecision(max(10u, IOstream::defaultPrecision())); + Info << "Writing polyMesh" << endl; +pShapeMesh.removeFiles(); pShapeMesh.write(); fileName czPath diff --git a/applications/utilities/mesh/conversion/mshToFoam/mshToFoam.C b/applications/utilities/mesh/conversion/mshToFoam/mshToFoam.C index 28e99a7a1d..ac225fd735 100644 --- a/applications/utilities/mesh/conversion/mshToFoam/mshToFoam.C +++ b/applications/utilities/mesh/conversion/mshToFoam/mshToFoam.C @@ -154,11 +154,14 @@ int main(int argc, char *argv[]) wordList(0) ); + // Set the precision of the points data to 10 + IOstream::defaultPrecision(max(10u, IOstream::defaultPrecision())); + Info<< "Writing mesh ..." << endl; + mesh.removeFiles(); mesh.write(); - Info<< "End\n" << endl; return 0; diff --git a/applications/utilities/mesh/conversion/netgenNeutralToFoam/netgenNeutralToFoam.C b/applications/utilities/mesh/conversion/netgenNeutralToFoam/netgenNeutralToFoam.C index d953cc9782..bb8730370e 100644 --- a/applications/utilities/mesh/conversion/netgenNeutralToFoam/netgenNeutralToFoam.C +++ b/applications/utilities/mesh/conversion/netgenNeutralToFoam/netgenNeutralToFoam.C @@ -313,11 +313,13 @@ int main(int argc, char *argv[]) patchPhysicalTypes ); - Info<< "Writing mesh to " << runTime.constant() << endl << endl; + // Set the precision of the points data to 10 + IOstream::defaultPrecision(max(10u, IOstream::defaultPrecision())); + Info<< "Writing mesh ..." << endl; + mesh.removeFiles(); mesh.write(); - Info<< "End\n" << endl; return 0; diff --git a/applications/utilities/mesh/conversion/plot3dToFoam/plot3dToFoam.C b/applications/utilities/mesh/conversion/plot3dToFoam/plot3dToFoam.C index ac62937367..1a24ab8623 100644 --- a/applications/utilities/mesh/conversion/plot3dToFoam/plot3dToFoam.C +++ b/applications/utilities/mesh/conversion/plot3dToFoam/plot3dToFoam.C @@ -262,6 +262,7 @@ int main(int argc, char *argv[]) IOstream::defaultPrecision(max(10u, IOstream::defaultPrecision())); Info<< "Writing polyMesh" << endl; + pShapeMesh.removeFiles(); pShapeMesh.write(); Info<< "End\n" << endl; diff --git a/applications/utilities/mesh/conversion/tetgenToFoam/tetgenToFoam.C b/applications/utilities/mesh/conversion/tetgenToFoam/tetgenToFoam.C index 39d8ff5a76..de11e14a74 100644 --- a/applications/utilities/mesh/conversion/tetgenToFoam/tetgenToFoam.C +++ b/applications/utilities/mesh/conversion/tetgenToFoam/tetgenToFoam.C @@ -342,7 +342,6 @@ int main(int argc, char *argv[]) const polyMesh& mesh = meshPtr; - if (readFaceFile) { label nPatches = 0; @@ -474,7 +473,7 @@ int main(int argc, char *argv[]) boundaryPatch.setSize(facei); - // Print region to patch mapping + // Print region to patch mapping Info<< "Regions:" << endl; forAllConstIter(Map