From 068e6779e43e249733bda73fd8dd6d3b29d0a9cc Mon Sep 17 00:00:00 2001 From: andy Date: Mon, 15 Feb 2010 19:22:07 +0000 Subject: [PATCH 01/25] STYLE: Header clean-up for Thermo and Reacting Parcels --- .../parcels/Templates/ReactingParcel/ReactingParcel.H | 5 ----- .../parcels/Templates/ThermoParcel/ThermoParcel.H | 5 ----- 2 files changed, 10 deletions(-) diff --git a/src/lagrangian/intermediate/parcels/Templates/ReactingParcel/ReactingParcel.H b/src/lagrangian/intermediate/parcels/Templates/ReactingParcel/ReactingParcel.H index 1c7ed466d2..986f420b95 100644 --- a/src/lagrangian/intermediate/parcels/Templates/ReactingParcel/ReactingParcel.H +++ b/src/lagrangian/intermediate/parcels/Templates/ReactingParcel/ReactingParcel.H @@ -39,11 +39,6 @@ SourceFiles #ifndef ReactingParcel_H #define ReactingParcel_H -#include "IOstream.H" -#include "autoPtr.H" -#include "interpolationCellPoint.H" -#include "contiguous.H" - #include "ThermoParcel.H" #include "ReactingCloud.H" #include "reactingParcel.H" diff --git a/src/lagrangian/intermediate/parcels/Templates/ThermoParcel/ThermoParcel.H b/src/lagrangian/intermediate/parcels/Templates/ThermoParcel/ThermoParcel.H index 4bcdc43707..7ef2e02016 100644 --- a/src/lagrangian/intermediate/parcels/Templates/ThermoParcel/ThermoParcel.H +++ b/src/lagrangian/intermediate/parcels/Templates/ThermoParcel/ThermoParcel.H @@ -40,11 +40,6 @@ SourceFiles #ifndef ThermoParcel_H #define ThermoParcel_H -#include "IOstream.H" -#include "autoPtr.H" -#include "interpolationCellPoint.H" -#include "contiguous.H" - #include "KinematicParcel.H" #include "ThermoCloud.H" From 0d1833a44e09d2de56f4869b6f1a97c2d1c70123 Mon Sep 17 00:00:00 2001 From: henry Date: Thu, 18 Feb 2010 16:16:08 +0000 Subject: [PATCH 02/25] Thermodynamics: Corrected the boundary condition for Cp. --- .../basic/psiThermo/ePsiThermo/ePsiThermo.C | 3 +-- .../basic/psiThermo/hPsiThermo/hPsiThermo.C | 3 +-- .../basic/psiThermo/hsPsiThermo/hsPsiThermo.C | 3 +-- .../basic/rhoThermo/hRhoThermo/hRhoThermo.C | 3 +-- .../basic/rhoThermo/hsRhoThermo/hsRhoThermo.C | 3 +-- 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/thermophysicalModels/basic/psiThermo/ePsiThermo/ePsiThermo.C b/src/thermophysicalModels/basic/psiThermo/ePsiThermo/ePsiThermo.C index 789f35bed9..2d255977be 100644 --- a/src/thermophysicalModels/basic/psiThermo/ePsiThermo/ePsiThermo.C +++ b/src/thermophysicalModels/basic/psiThermo/ePsiThermo/ePsiThermo.C @@ -246,8 +246,7 @@ Foam::tmp Foam::ePsiThermo::Cp() const IOobject::NO_WRITE ), mesh, - dimensionSet(0, 2, -2, -1, 0), - this->T_.boundaryField().types() + dimensionSet(0, 2, -2, -1, 0) ) ); diff --git a/src/thermophysicalModels/basic/psiThermo/hPsiThermo/hPsiThermo.C b/src/thermophysicalModels/basic/psiThermo/hPsiThermo/hPsiThermo.C index ab85557cf4..11f1e1b2b6 100644 --- a/src/thermophysicalModels/basic/psiThermo/hPsiThermo/hPsiThermo.C +++ b/src/thermophysicalModels/basic/psiThermo/hPsiThermo/hPsiThermo.C @@ -244,8 +244,7 @@ Foam::tmp Foam::hPsiThermo::Cp() const IOobject::NO_WRITE ), mesh, - dimensionSet(0, 2, -2, -1, 0), - this->T_.boundaryField().types() + dimensionSet(0, 2, -2, -1, 0) ) ); diff --git a/src/thermophysicalModels/basic/psiThermo/hsPsiThermo/hsPsiThermo.C b/src/thermophysicalModels/basic/psiThermo/hsPsiThermo/hsPsiThermo.C index 2683e3f851..cb33763fd6 100644 --- a/src/thermophysicalModels/basic/psiThermo/hsPsiThermo/hsPsiThermo.C +++ b/src/thermophysicalModels/basic/psiThermo/hsPsiThermo/hsPsiThermo.C @@ -244,8 +244,7 @@ Foam::tmp Foam::hsPsiThermo::Cp() const IOobject::NO_WRITE ), mesh, - dimensionSet(0, 2, -2, -1, 0), - this->T_.boundaryField().types() + dimensionSet(0, 2, -2, -1, 0) ) ); diff --git a/src/thermophysicalModels/basic/rhoThermo/hRhoThermo/hRhoThermo.C b/src/thermophysicalModels/basic/rhoThermo/hRhoThermo/hRhoThermo.C index ce3486fa15..3aca91c124 100644 --- a/src/thermophysicalModels/basic/rhoThermo/hRhoThermo/hRhoThermo.C +++ b/src/thermophysicalModels/basic/rhoThermo/hRhoThermo/hRhoThermo.C @@ -243,8 +243,7 @@ Foam::tmp Foam::hRhoThermo::Cp() const IOobject::NO_WRITE ), mesh, - dimensionSet(0, 2, -2, -1, 0), - this->T_.boundaryField().types() + dimensionSet(0, 2, -2, -1, 0) ) ); diff --git a/src/thermophysicalModels/basic/rhoThermo/hsRhoThermo/hsRhoThermo.C b/src/thermophysicalModels/basic/rhoThermo/hsRhoThermo/hsRhoThermo.C index 1e5e118077..fe0a4aedc4 100644 --- a/src/thermophysicalModels/basic/rhoThermo/hsRhoThermo/hsRhoThermo.C +++ b/src/thermophysicalModels/basic/rhoThermo/hsRhoThermo/hsRhoThermo.C @@ -243,8 +243,7 @@ Foam::tmp Foam::hsRhoThermo::Cp() const IOobject::NO_WRITE ), mesh, - dimEnergy/dimMass/dimTemperature, - this->T_.boundaryField().types() + dimEnergy/dimMass/dimTemperature ) ); From c1e7fd9ef6e363c288a470bb42b55b5da75175ec Mon Sep 17 00:00:00 2001 From: henry Date: Thu, 18 Feb 2010 16:16:37 +0000 Subject: [PATCH 03/25] multiRegionHeater tutorial: Changed to generate the split-mesh and fields at time 0 rather th an 0.001. --- .../multiRegionHeater/Allclean | 21 +++++++++++++++++++ .../multiRegionHeater/Allrun | 2 +- .../snappyMultiRegionHeater/Allclean | 1 + 3 files changed, 23 insertions(+), 1 deletion(-) create mode 100755 tutorials/heatTransfer/chtMultiRegionFoam/multiRegionHeater/Allclean diff --git a/tutorials/heatTransfer/chtMultiRegionFoam/multiRegionHeater/Allclean b/tutorials/heatTransfer/chtMultiRegionFoam/multiRegionHeater/Allclean new file mode 100755 index 0000000000..a76e8dff53 --- /dev/null +++ b/tutorials/heatTransfer/chtMultiRegionFoam/multiRegionHeater/Allclean @@ -0,0 +1,21 @@ +#!/bin/sh + +# Source tutorial clean functions +. $WM_PROJECT_DIR/bin/tools/CleanFunctions + +cleanCase +rm -rf VTK +rm -rf constant/cellToRegion constant/polyMesh/sets +rm -rf 0/bottomAir +rm -rf 0/topAir +rm -rf 0/heater +rm -rf 0/leftSolid +rm -rf 0/rightSolid +rm -f 0/cellToRegion +rm -rf constant/bottomAir/polyMesh +rm -rf constant/topAir/polyMesh +rm -rf constant/heater/polyMesh +rm -rf constant/leftSolid/polyMesh +rm -rf constant/rightSolid/polyMesh + +# ----------------------------------------------------------------------------- diff --git a/tutorials/heatTransfer/chtMultiRegionFoam/multiRegionHeater/Allrun b/tutorials/heatTransfer/chtMultiRegionFoam/multiRegionHeater/Allrun index 56cc2a348c..231c46e6ec 100755 --- a/tutorials/heatTransfer/chtMultiRegionFoam/multiRegionHeater/Allrun +++ b/tutorials/heatTransfer/chtMultiRegionFoam/multiRegionHeater/Allrun @@ -11,7 +11,7 @@ runApplication setSet -batch makeCellSets.setSet rm -f constant/polyMesh/sets/*_old runApplication setsToZones -noFlipMap -runApplication splitMeshRegions -cellZones +runApplication splitMeshRegions -cellZones -overwrite # remove fluid fields from solid regions (important for post-processing) for i in heater leftSolid rightSolid diff --git a/tutorials/heatTransfer/chtMultiRegionFoam/snappyMultiRegionHeater/Allclean b/tutorials/heatTransfer/chtMultiRegionFoam/snappyMultiRegionHeater/Allclean index 6771f180d8..a76e8dff53 100755 --- a/tutorials/heatTransfer/chtMultiRegionFoam/snappyMultiRegionHeater/Allclean +++ b/tutorials/heatTransfer/chtMultiRegionFoam/snappyMultiRegionHeater/Allclean @@ -11,6 +11,7 @@ rm -rf 0/topAir rm -rf 0/heater rm -rf 0/leftSolid rm -rf 0/rightSolid +rm -f 0/cellToRegion rm -rf constant/bottomAir/polyMesh rm -rf constant/topAir/polyMesh rm -rf constant/heater/polyMesh From 91532a8bcba60fc047e0241914cba0c2c64facea Mon Sep 17 00:00:00 2001 From: mattijs Date: Fri, 19 Feb 2010 12:47:01 +0000 Subject: [PATCH 04/25] STYLE: removed unused variable. --- .../pointMesh/pointPatches/constraint/cyclic/cyclicPointPatch.C | 1 - 1 file changed, 1 deletion(-) diff --git a/src/OpenFOAM/meshes/pointMesh/pointPatches/constraint/cyclic/cyclicPointPatch.C b/src/OpenFOAM/meshes/pointMesh/pointPatches/constraint/cyclic/cyclicPointPatch.C index 20727c1752..e25244da12 100644 --- a/src/OpenFOAM/meshes/pointMesh/pointPatches/constraint/cyclic/cyclicPointPatch.C +++ b/src/OpenFOAM/meshes/pointMesh/pointPatches/constraint/cyclic/cyclicPointPatch.C @@ -57,7 +57,6 @@ void Foam::cyclicPointPatch::calcGeometry(PstreamBuffers&) { const edgeList& cp = cyclicPolyPatch_.coupledPoints(); const labelList& mp = cyclicPolyPatch_.meshPoints(); - const pointField& points = cyclicPolyPatch_.points(); DynamicList