diff --git a/src/functionObjects/field/fieldValues/surfaceFieldValue/surfaceFieldValue.C b/src/functionObjects/field/fieldValues/surfaceFieldValue/surfaceFieldValue.C index ddbec77f43..1df74fc79d 100644 --- a/src/functionObjects/field/fieldValues/surfaceFieldValue/surfaceFieldValue.C +++ b/src/functionObjects/field/fieldValues/surfaceFieldValue/surfaceFieldValue.C @@ -61,7 +61,7 @@ Foam::functionObjects::fieldValues::surfaceFieldValue::regionTypeNames_ { regionTypes::stFaceZone, "faceZone" }, { regionTypes::stPatch, "patch" }, { regionTypes::stSurface, "surface" }, - { regionTypes::stSampledSurface, "sampledSurface" }, + { regionTypes::stSampled, "sampledSurface" }, }); @@ -118,7 +118,7 @@ Foam::functionObjects::fieldValues::surfaceFieldValue::postOperationTypeNames_ const Foam::objectRegistry& Foam::functionObjects::fieldValues::surfaceFieldValue::obr() const { - if (regionType_ == stSurface) + if (stSurface == regionType_) { return mesh_.lookupObject(regionName_); } @@ -135,7 +135,7 @@ void Foam::functionObjects::fieldValues::surfaceFieldValue::setFaceZoneFaces() { FatalErrorInFunction << type() << " " << name() << ": " - << regionTypeNames_[regionType_] << "(" << regionName_ << "):" << nl + << regionTypeNames_[regionType_] << '(' << regionName_ << "):" << nl << " Unknown face zone name: " << regionName_ << ". Valid face zones are: " << mesh_.faceZones().names() << nl << exit(FatalError); @@ -213,7 +213,7 @@ void Foam::functionObjects::fieldValues::surfaceFieldValue::setPatchFaces() { FatalErrorInFunction << type() << " " << name() << ": " - << regionTypeNames_[regionType_] << "(" << regionName_ << "):" << nl + << regionTypeNames_[regionType_] << '(' << regionName_ << "):" << nl << " Unknown patch name: " << regionName_ << ". Valid patch names are: " << mesh_.boundaryMesh().names() << nl @@ -368,7 +368,7 @@ combineSurfaceGeometry pointField& points ) const { - if (regionType_ == stSurface) + if (stSurface == regionType_) { const surfMesh& s = dynamicCast(obr()); @@ -398,9 +398,9 @@ combineSurfaceGeometry points = s.points(); } } - else if (surfacePtr_.valid()) + else if (sampledPtr_.valid()) { - const sampledSurface& s = surfacePtr_(); + const sampledSurface& s = sampledPtr_(); if (Pstream::parRun()) { @@ -436,15 +436,15 @@ Foam::functionObjects::fieldValues::surfaceFieldValue::totalArea() const { scalar totalArea = 0; - if (regionType_ == stSurface) + if (stSurface == regionType_) { const surfMesh& s = dynamicCast(obr()); totalArea = gSum(s.magSf()); } - else if (surfacePtr_.valid()) + else if (sampledPtr_.valid()) { - totalArea = gSum(surfacePtr_().magSf()); + totalArea = gSum(sampledPtr_().magSf()); } else { @@ -481,20 +481,17 @@ bool Foam::functionObjects::fieldValues::surfaceFieldValue::usesSf() const } -void Foam::functionObjects::fieldValues::surfaceFieldValue::initialise -( - const dictionary& dict -) +bool Foam::functionObjects::fieldValues::surfaceFieldValue::update() { - dict.readEntry("name", regionName_); + if (sampledPtr_.valid()) + { + sampledPtr_->update(); + } - totalArea_ = 0; - nFaces_ = 0; - faceId_.clear(); - facePatchId_.clear(); - faceFlip_.clear(); - surfacePtr_.clear(); - surfaceWriterPtr_.clear(); + if (!needsUpdate_) + { + return false; + } switch (regionType_) { @@ -514,124 +511,33 @@ void Foam::functionObjects::fieldValues::surfaceFieldValue::initialise nFaces_ = returnReduce(s.size(), sumOp