From c103331a6a94ec54a4ae071c1f3006dc839bc74c Mon Sep 17 00:00:00 2001 From: Andrew Heather Date: Wed, 20 Jun 2018 16:28:48 +0100 Subject: [PATCH] INT: integration updates --- .../alphaCourantNo.H | 1 + .../createFieldRefs.H | 2 + .../createFields.H | 3 - .../icoReactingMultiphaseInterFoam.C | 15 +- .../laserDTRM/DTRMParticle/DTRMParticle.H | 12 -- .../laserDTRM/DTRMParticle/DTRMParticleIO.C | 3 +- .../laserDTRM/laserDTRM.C | 132 ++++++++---------- .../laserDTRM/laserDTRM.H | 2 +- .../localDensityAbsorptionEmission.C | 13 +- .../localDensityAbsorptionEmission.H | 6 +- .../reflectionModel/Fresnel/Fresnel.C | 3 +- .../reflectionModel/Fresnel/Fresnel.H | 22 +-- .../FresnelLaser/FresnelLaser.C | 8 +- .../FresnelLaser/FresnelLaser.H | 21 +-- .../noReflection/noReflection.C | 6 - .../noReflection/noReflection.H | 16 +-- .../reflectionModel/reflectionModel.C | 6 - .../reflectionModel/reflectionModel.H | 14 +- .../reflectionModel/reflectionModelNew.C | 18 +-- .../InterfaceCompositionModel.C | 20 +-- .../InterfaceCompositionModel.H | 11 +- .../InterfaceCompositionModels.C | 4 +- .../massTransferModels/Lee/Lee.C | 10 +- .../massTransferModels/Lee/Lee.H | 12 +- .../massTransferModels/Make/files | 2 +- .../interfaceCompositionModel.C | 11 +- .../interfaceCompositionModel.H | 6 +- ...Model.C => interfaceCompositionModelNew.C} | 10 +- .../kineticGasEvaporation.C | 9 +- .../kineticGasEvaporation.H | 25 ++-- .../phasesSystem/Make/files | 6 +- .../MassTransferPhaseSystem.C | 28 ++-- .../MassTransferPhaseSystem.H | 2 +- .../VollerPrakash/VollerPrakash.C | 7 - .../VollerPrakash/VollerPrakash.H | 8 +- .../porousModels/porousModel/porousModel.C | 6 - .../porousModels/porousModel/porousModel.H | 4 +- .../{newPorousModel.C => porousModelNew.C} | 18 ++- .../constantSurfaceTensionCoefficient.C | 26 ++-- .../constantSurfaceTensionCoefficient.H | 8 +- .../surfaceTensionModel/surfaceTensionModel.C | 6 - .../surfaceTensionModel/surfaceTensionModel.H | 6 +- ...ensionModel.C => surfaceTensionModelNew.C} | 20 ++- .../MovingPhaseModel/MovingPhaseModel.C | 27 ++-- .../MovingPhaseModel/MovingPhaseModel.H | 4 +- .../MultiComponentPhaseModel.C | 15 +- .../MultiComponentPhaseModel.H | 5 +- .../PurePhaseModel/PurePhaseModel.C | 20 +-- .../PurePhaseModel/PurePhaseModel.H | 2 +- .../StaticPhaseModel/StaticPhaseModel.C | 27 ++-- .../StaticPhaseModel/StaticPhaseModel.H | 4 +- .../phaseModel/phaseModel/makePhaseTypes.H | 13 +- .../phaseModel/phaseModel/phaseModel.C | 6 - .../phaseModel/phaseModel/phaseModel.H | 31 ++-- .../{newphaseModel.C => phaseModelNew.C} | 16 +-- .../orderedPhasePair/orderedPhasePair.C | 14 +- .../orderedPhasePair/orderedPhasePair.H | 5 +- .../phasePair/phasePair/phasePair.C | 10 +- .../phasePair/phasePair/phasePair.H | 9 +- .../phasePair/phasePairKey/phasePairKey.C | 16 +-- .../phasePair/phasePairKey/phasePairKey.H | 2 +- .../multiphaseSystem/multiphaseSystem.C | 14 +- .../multiphaseSystem/multiphaseSystem.H | 7 +- ...ltiphaseSystem.C => multiphaseSystemNew.C} | 13 +- .../phasesSystem/phaseSystem/phaseSystem.C | 4 +- .../phasesSystem/phaseSystem/phaseSystem.H | 8 -- .../phaseSystem/phaseSystemTemplates.H | 5 +- .../setDeltaT.H | 1 + 68 files changed, 292 insertions(+), 554 deletions(-) create mode 100644 applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/createFieldRefs.H rename applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/massTransferModels/interfaceCompositionModel/{newInterfaceCompositionModel.C => interfaceCompositionModelNew.C} (89%) rename applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/phasesSystem/interfaceModels/porousModels/porousModel/{newPorousModel.C => porousModelNew.C} (78%) rename applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/phasesSystem/interfaceModels/surfaceTensionModels/surfaceTensionModel/{newSurfaceTensionModel.C => surfaceTensionModelNew.C} (74%) rename applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/phasesSystem/phaseModel/phaseModel/{newphaseModel.C => phaseModelNew.C} (80%) rename applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/phasesSystem/phaseSystem/multiphaseSystem/{newMultiphaseSystem.C => multiphaseSystemNew.C} (87%) diff --git a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/alphaCourantNo.H b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/alphaCourantNo.H index 3daf8ed28c..c1dfd7ca1f 100644 --- a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/alphaCourantNo.H +++ b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/alphaCourantNo.H @@ -74,4 +74,5 @@ Info<< "Maximum ddtAlpha : " << ddtAlphaNum << endl; Info<< "Maximum DiffNum : " << DiNum << endl; + // ************************************************************************* // diff --git a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/createFieldRefs.H b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/createFieldRefs.H new file mode 100644 index 0000000000..e42eb26222 --- /dev/null +++ b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/createFieldRefs.H @@ -0,0 +1,2 @@ +// Volumatric flux +surfaceScalarField& phi = fluid.phi(); diff --git a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/createFields.H b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/createFields.H index e1bfdebea3..f469209076 100644 --- a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/createFields.H +++ b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/createFields.H @@ -114,9 +114,6 @@ p_rgh = p - rho*gh; } - // Total volumetric flux - surfaceScalarField& phi = fluid.phi(); - // Mass flux surfaceScalarField& rhoPhi = fluid.rhoPhi(); diff --git a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/icoReactingMultiphaseInterFoam.C b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/icoReactingMultiphaseInterFoam.C index 62af2a05cf..827b2c5e28 100644 --- a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/icoReactingMultiphaseInterFoam.C +++ b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/icoReactingMultiphaseInterFoam.C @@ -29,7 +29,8 @@ Group Description Solver for n incompressible, non-isothermal immiscible fluids with - phase-change. Uses a VOF (volume of fluid) phase-fraction based interface capturing approach. + phase-change. Uses a VOF (volume of fluid) phase-fraction based interface + capturing approach. The momentum, energy and other fluid properties are of the "mixture" and a single momentum equation is solved. @@ -54,6 +55,8 @@ Description int main(int argc, char *argv[]) { + #include "postProcess.H" + #include "setRootCase.H" #include "createTime.H" #include "createMesh.H" @@ -61,12 +64,15 @@ int main(int argc, char *argv[]) pimpleControl pimple(mesh); #include "createFields.H" + #include "createFieldRefs.H" #include "createFvOptions.H" #include "createTimeControls.H" #include "CourantNo.H" - #include "alphaCourantNo.H" + //#include "alphaCourantNo.H" #include "setInitialDeltaT.H" + turbulence->validate(); + // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // Info<< "\nStarting time loop\n" << endl; @@ -92,6 +98,7 @@ int main(int argc, char *argv[]) #include "UEqn.H" #include "YEqns.H" #include "TEqn.H" + // --- Pressure corrector loop while (pimple.correct()) { @@ -108,9 +115,7 @@ int main(int argc, char *argv[]) runTime.write(); - Info<< "ExecutionTime = " << runTime.elapsedCpuTime() << " s" - << " ClockTime = " << runTime.elapsedClockTime() << " s" - << nl << endl; + runTime.printExecutionTime(Info); } Info<< "End\n" << endl; diff --git a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/DTRMParticle/DTRMParticle.H b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/DTRMParticle/DTRMParticle.H index a527fb73a2..f69c56134d 100644 --- a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/DTRMParticle/DTRMParticle.H +++ b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/DTRMParticle/DTRMParticle.H @@ -62,9 +62,6 @@ class DTRMParticle : public particle { -private: - - // Private data //- Size in bytes of the fields @@ -98,8 +95,6 @@ public: : public particle::trackingData { - - // Interpolators for continuous phase fields const interpolationCell& aInterp_; @@ -135,10 +130,6 @@ public: volScalarField& Q ); - // Public data - - - // Member functions @@ -151,7 +142,6 @@ public: inline const UPtrList& reflection() const; inline scalar& Q(label celli); - }; // Static data members @@ -268,7 +258,6 @@ public: // Edit - //- Return access to the target position inline point& p1(); @@ -293,7 +282,6 @@ public: // Member Operators - //- Overridable function to handle the particle hitting a processorPatch void hitProcessorPatch ( diff --git a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/DTRMParticle/DTRMParticleIO.C b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/DTRMParticle/DTRMParticleIO.C index a74dbed3b2..e899ca35d8 100644 --- a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/DTRMParticle/DTRMParticleIO.C +++ b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/DTRMParticle/DTRMParticleIO.C @@ -60,7 +60,6 @@ Foam::DTRMParticle::DTRMParticle if (is.format() == IOstream::ASCII) { is >> p0_ >> p1_ >> I0_ >> I_ >> dA_ >> transmissiveId_; - DebugVar(transmissiveId_); } else { @@ -95,7 +94,7 @@ Foam::Ostream& Foam::operator<<(Ostream& os, const DTRMParticle& p) } // Check state of Ostream - os.check("Ostream& operator<<(Ostream&, const DTRMParticle&)"); + os.check(FUNCTION_NAME); return os; } diff --git a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/laserDTRM.C b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/laserDTRM.C index 4ef3a07986..c73f597e7a 100644 --- a/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/laserDTRM.C +++ b/applications/solvers/multiphase/icoReactingMultiPhaseInterFoam/laserDTRM/laserDTRM.C @@ -54,20 +54,17 @@ namespace Foam 0 ); - namespace radiation + template<> + const char* Foam::NamedEnum + < + Foam::radiation::laserDTRM::powerDistributionMode, + 3 + >::names[] = { - template<> - const char* Foam::NamedEnum - < - Foam::radiation::laserDTRM::powerDistributionMode, - 3 - >::names[] = - { - "Gaussian", - "manual", - "uniform" - }; - } + "Gaussian", + "manual", + "uniform" + }; } const Foam::NamedEnum @@ -82,35 +79,32 @@ const Foam::NamedEnum Foam::scalar Foam::radiation::laserDTRM::calculateIp(scalar r, scalar theta) { const scalar t = mesh_.time().value(); + const scalar power = laserPower_->value(t); switch(mode_) { case pdGaussian: { - scalar I0 = - laserPower_->value(t)/(mathematical::twoPi*sqr(sigma_)); - - return(I0*exp(-sqr(r)/2.0/sqr(sigma_))); + scalar I0 = power/(mathematical::twoPi*sqr(sigma_)); + return I0*exp(-sqr(r)/2.0/sqr(sigma_)); break; } case pdManual: { - return(laserPower_->value(t)*powerDistribution_()(theta, r)); + return power*powerDistribution_()(theta, r); break; } case pdUniform: { - return - ( - laserPower_->value(t)/(mathematical::pi*sqr(focalLaserRadius_)) - ); + return power/(mathematical::pi*sqr(focalLaserRadius_)); + break; } default: { FatalErrorInFunction - << "Unhandled type " << powerDistypeNames_ - << abort(FatalError); - return(0); + << "Unhandled type " << powerDistypeNames_ + << abort(FatalError); + return (0); } } } @@ -125,7 +119,7 @@ Foam::tmp Foam::radiation::laserDTRM::nHatfv const dimensionedScalar deltaN ( "deltaN", - 1e-7/pow(average(mesh_.V()), 1.0/3.0) + 1e-7/cbrt(average(mesh_.V())) ); const volVectorField gradAlphaf @@ -134,8 +128,8 @@ Foam::tmp Foam::radiation::laserDTRM::nHatfv - alpha1*fvc::grad(alpha2) ); - // Face unit interface normal - return gradAlphaf/(mag(gradAlphaf)+ deltaN); + // Face unit interface normal + return gradAlphaf/(mag(gradAlphaf)+ deltaN); } @@ -203,7 +197,7 @@ void Foam::radiation::laserDTRM::initialise() nParticles_ = ndr_*ndTheta_; - switch(mode_) + switch (mode_) { case pdGaussian: { @@ -285,8 +279,8 @@ void Foam::radiation::laserDTRM::initialise() if (cellI != -1) { // Create a new particle - DTRMParticle* pPtr = new DTRMParticle - (mesh_, p0, p1, Ip, cellI, dAi, -1); + DTRMParticle* pPtr = + new DTRMParticle(mesh_, p0, p1, Ip, cellI, dAi, -1); // Add to cloud DTRMCloud_.addParticle(pPtr); @@ -294,7 +288,7 @@ void Foam::radiation::laserDTRM::initialise() if (returnReduce(cellI, maxOp