zhyang-dev/openfoam
1
0
Fork 0
mirror of https://develop.openfoam.com/Development/openfoam.git synced 2025-11-28 03:28:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge branch 'fix-ATC-extraConvection' into 'master'

Browse Source 
BUG: extraConvection in ATC missing a multiplication with ATClimiter

See merge request Development/openfoam!591
This commit is contained in:
Andrew Heather
2023-02-03 15:36:17 +00:00
parent ff13cdd39d 26420a88d7
commit cc6ba5c1a0
2 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/optimisation/adjointOptimisation/adjoint/ATCModel/ATCUaGradU/ATCUaGradU.C
View File

@ -5,8 +5,8 @@
\\ / A nd | www.openfoam.com \\ / A nd | www.openfoam.com
\\/ M anipulation | \\/ M anipulation |
------------------------------------------------------------------------------- -------------------------------------------------------------------------------
Copyright (C) 2007-2021 PCOpt/NTUA Copyright (C) 2007-2023 PCOpt/NTUA
Copyright (C) 2013-2021 FOSS GP Copyright (C) 2013-2023 FOSS GP
Copyright (C) 2019 OpenCFD Ltd. Copyright (C) 2019 OpenCFD Ltd.
------------------------------------------------------------------------------- -------------------------------------------------------------------------------
License License
@ -86,10 +86,9 @@ void ATCUaGradU::addATC(fvVectorMatrix& UaEqn)
if (extraConvection_ > 0) if (extraConvection_ > 0)
{ {
// Implicit part added to increase diagonal dominance // Implicit part added to increase diagonal dominance
// Note: Maybe this needs to be multiplied with the ATClimiter ?? UaEqn += ATClimiter_*extraConvection_*fvm::div(-phi, Ua);
UaEqn += extraConvection_*fvm::div(-phi, Ua);
// correct rhs due to implicitly augmenting the adjoint convection // Correct rhs due to implicitly augmenting the adjoint convection
ATC_ += extraConvection_*(fvc::grad(UaForATC(), "gradUaATC")().T() & U); ATC_ += extraConvection_*(fvc::grad(UaForATC(), "gradUaATC")().T() & U);
} }

9
src/optimisation/adjointOptimisation/adjoint/ATCModel/ATCstandard/ATCstandard.C
View File

@ -5,8 +5,8 @@
\\ / A nd | www.openfoam.com \\ / A nd | www.openfoam.com
\\/ M anipulation | \\/ M anipulation |
------------------------------------------------------------------------------- -------------------------------------------------------------------------------
Copyright (C) 2007-2021 PCOpt/NTUA Copyright (C) 2007-2023 PCOpt/NTUA
Copyright (C) 2013-2021 FOSS GP Copyright (C) 2013-2023 FOSS GP
Copyright (C) 2019 OpenCFD Ltd. Copyright (C) 2019 OpenCFD Ltd.
------------------------------------------------------------------------------- -------------------------------------------------------------------------------
License License
@ -90,10 +90,9 @@ void ATCstandard::addATC(fvVectorMatrix& UaEqn)
if (extraConvection_ > 0) if (extraConvection_ > 0)
{ {
// Implicit part added to increase diagonal dominance // Implicit part added to increase diagonal dominance
// Note: Maybe this needs to be multiplied with the ATClimiter ?? UaEqn += ATClimiter_*extraConvection_*fvm::div(-phi, Ua);
UaEqn += extraConvection_*fvm::div(-phi, Ua);
// correct rhs due to implicitly augmenting the adjoint convection // Correct rhs due to implicitly augmenting the adjoint convection
ATC_ += extraConvection_*(fvc::grad(Ua, "gradUaATC")().T() & U); ATC_ += extraConvection_*(fvc::grad(Ua, "gradUaATC")().T() & U);
} }