From cde12ad9e574bac0edc3ffc8c067ef5e61d9d18f Mon Sep 17 00:00:00 2001 From: Mark Olesen Date: Tue, 13 Jun 2017 14:10:07 +0200 Subject: [PATCH] ENH: consolidate vtk classes into 'Foam::vtk' namespace - elminate the foamVtkFormatter operator() in favour of xmlAttr. Improves readability and the purpose is clearer. --- .../mesh/manipulation/setSet/setSet.C | 12 +- .../dataConversion/foamToVTK/foamToVTK.C | 36 ++-- .../foamToVTK/foamVtkLagrangianWriter.C | 66 +++---- .../foamToVTK/foamVtkLagrangianWriter.H | 12 +- .../foamVtkLagrangianWriterTemplates.C | 4 +- .../vtkPVFoam/vtkPVFoamMeshVolume.C | 10 +- src/conversion/Make/files | 2 +- .../vtk/output/foamVtkInternalWriter.C | 135 +++++++-------- .../vtk/output/foamVtkInternalWriter.H | 18 +- .../output/foamVtkInternalWriterTemplates.C | 42 ++--- .../vtk/output/foamVtkOutputFields.H | 48 +++--- .../vtk/output/foamVtkOutputFieldsTemplates.C | 85 ++++----- .../vtk/output/foamVtkPatchWriter.C | 73 ++++---- .../vtk/output/foamVtkPatchWriter.H | 12 +- .../vtk/output/foamVtkPatchWriterTemplates.C | 16 +- .../vtk/output/foamVtkSurfaceMeshWriter.C | 63 ++++--- .../vtk/output/foamVtkSurfaceMeshWriter.H | 12 +- .../foamVtkSurfaceMeshWriterTemplates.C | 6 +- .../vtk/output/foamVtkWriteSurfFields.C | 38 ++-- .../vtk/output/foamVtkWriteSurfFields.H | 8 +- src/conversion/vtk/part/foamVtkMeshMaps.H | 14 +- .../part/{foamVtkCells.C => foamVtuCells.C} | 46 ++--- .../part/{foamVtkCells.H => foamVtuCells.H} | 49 +++--- .../part/{foamVtkCellsI.H => foamVtuCellsI.H} | 25 +-- src/conversion/vtk/part/foamVtuSizing.C | 40 ++--- src/conversion/vtk/part/foamVtuSizing.H | 55 +++--- src/conversion/vtk/part/foamVtuSizingI.H | 40 ++--- .../vtk/part/foamVtuSizingTemplates.C | 26 ++- src/fileFormats/Make/files | 5 +- src/fileFormats/vtk/core/foamVtkCore.C | 71 ++++++++ src/fileFormats/vtk/core/foamVtkCore.H | 163 ++++++++++++++++++ .../vtk/{type => core}/foamVtkPTraits.C | 18 +- .../vtk/{type => core}/foamVtkPTraits.H | 22 +-- src/fileFormats/vtk/foamVtkCore.C | 54 ------ src/fileFormats/vtk/foamVtkCore.H | 109 ------------ .../vtk/format/foamVtkAppendBase64Formatter.C | 16 +- .../vtk/format/foamVtkAppendBase64Formatter.H | 6 +- .../vtk/format/foamVtkAppendRawFormatter.C | 34 ++-- .../vtk/format/foamVtkAppendRawFormatter.H | 6 +- .../vtk/format/foamVtkAsciiFormatter.C | 38 ++-- .../vtk/format/foamVtkAsciiFormatter.H | 6 +- .../vtk/format/foamVtkBase64Formatter.C | 18 +- .../vtk/format/foamVtkBase64Formatter.H | 6 +- .../vtk/format/foamVtkBase64Layer.C | 24 +-- .../vtk/format/foamVtkBase64Layer.H | 6 +- src/fileFormats/vtk/format/foamVtkFormatter.C | 64 ++++--- src/fileFormats/vtk/format/foamVtkFormatter.H | 69 ++++---- .../vtk/format/foamVtkFormatterI.H | 127 ++++++-------- .../vtk/format/foamVtkFormatterTemplates.C | 28 +-- .../vtk/format/foamVtkLegacyAsciiFormatter.C | 20 +-- .../vtk/format/foamVtkLegacyAsciiFormatter.H | 8 +- .../vtk/format/foamVtkLegacyRawFormatter.C | 32 ++-- .../vtk/format/foamVtkLegacyRawFormatter.H | 6 +- src/fileFormats/vtk/output/foamVtkOutput.C | 46 ++--- src/fileFormats/vtk/output/foamVtkOutput.H | 46 +++-- src/fileFormats/vtk/output/foamVtkOutputI.H | 30 ++-- .../vtk/output/foamVtkOutputOptions.C | 18 +- .../vtk/output/foamVtkOutputOptions.H | 6 +- .../vtk/output/foamVtkOutputOptionsI.H | 26 +-- .../vtk/output/foamVtkOutputTemplates.C | 16 +- .../vtk/read/vtkUnstructuredReader.C | 22 +-- .../vtk/read/vtkUnstructuredReader.H | 5 +- src/fileFormats/vtk/type/foamVtkFileEnums.C | 64 ------- src/fileFormats/vtk/type/foamVtkFileEnums.H | 90 ---------- src/fileFormats/vtk/type/foamVtkOutputTypes.H | 77 --------- .../utilities/writeVTK/writeVTK.C | 10 +- .../output/foamVtkWriteCellSetFaces.C | 16 +- .../output/foamVtkWriteCellSetFaces.H | 10 +- src/meshTools/output/foamVtkWriteFaceSet.C | 16 +- src/meshTools/output/foamVtkWriteFaceSet.H | 8 +- src/meshTools/output/foamVtkWritePointSet.C | 14 +- src/meshTools/output/foamVtkWritePointSet.H | 8 +- .../surfaceFormats/vtk/VTKsurfaceFormat.C | 24 +-- .../surfaceFormats/vtk/VTKsurfaceFormat.H | 2 +- .../surfaceFormats/vtk/VTKsurfaceFormatCore.C | 28 +-- .../surfaceFormats/vtk/VTKsurfaceFormatCore.H | 6 +- .../surfaceFormats/vtp/VTPsurfaceFormat.C | 36 ++-- .../surfaceFormats/vtp/VTPsurfaceFormat.H | 2 +- .../surfaceFormats/vtp/VTPsurfaceFormatCore.C | 38 ++-- .../surfaceFormats/vtp/VTPsurfaceFormatCore.H | 8 +- .../triSurface/interfaces/VTK/writeVTK.C | 36 ++-- 81 files changed, 1249 insertions(+), 1408 deletions(-) rename src/conversion/vtk/part/{foamVtkCells.C => foamVtuCells.C} (77%) rename src/conversion/vtk/part/{foamVtkCells.H => foamVtuCells.H} (90%) rename src/conversion/vtk/part/{foamVtkCellsI.H => foamVtuCellsI.H} (77%) create mode 100644 src/fileFormats/vtk/core/foamVtkCore.C create mode 100644 src/fileFormats/vtk/core/foamVtkCore.H rename src/fileFormats/vtk/{type => core}/foamVtkPTraits.C (77%) rename src/fileFormats/vtk/{type => core}/foamVtkPTraits.H (76%) delete mode 100644 src/fileFormats/vtk/foamVtkCore.C delete mode 100644 src/fileFormats/vtk/foamVtkCore.H delete mode 100644 src/fileFormats/vtk/type/foamVtkFileEnums.C delete mode 100644 src/fileFormats/vtk/type/foamVtkFileEnums.H delete mode 100644 src/fileFormats/vtk/type/foamVtkOutputTypes.H diff --git a/applications/utilities/mesh/manipulation/setSet/setSet.C b/applications/utilities/mesh/manipulation/setSet/setSet.C index eaa89f2fb7..8ce92fc9b7 100644 --- a/applications/utilities/mesh/manipulation/setSet/setSet.C +++ b/applications/utilities/mesh/manipulation/setSet/setSet.C @@ -82,33 +82,33 @@ void writeVTK if (isA(currentSet)) { // Faces of set with OpenFOAM faceID as value - foamVtkOutput::writeFaceSet + vtk::writeFaceSet ( mesh, currentSet, mesh.time().path()/vtkBaseName, - foamVtkOutput::formatType::LEGACY_BINARY + vtk::formatType::LEGACY_BINARY ); } else if (isA(currentSet)) { // External faces of cellset with OpenFOAM cellID as value - foamVtkOutput::writeCellSetFaces + vtk::writeCellSetFaces ( mesh, currentSet, mesh.time().path()/vtkBaseName, - foamVtkOutput::formatType::LEGACY_BINARY + vtk::formatType::LEGACY_BINARY ); } else if (isA(currentSet)) { - foamVtkOutput::writePointSet + vtk::writePointSet ( mesh, currentSet, mesh.time().path()/vtkBaseName, - foamVtkOutput::formatType::LEGACY_BINARY + vtk::formatType::LEGACY_BINARY ); } else diff --git a/applications/utilities/postProcessing/dataConversion/foamToVTK/foamToVTK.C b/applications/utilities/postProcessing/dataConversion/foamToVTK/foamToVTK.C index b3813f22c3..cb5ab87414 100644 --- a/applications/utilities/postProcessing/dataConversion/foamToVTK/foamToVTK.C +++ b/applications/utilities/postProcessing/dataConversion/foamToVTK/foamToVTK.C @@ -242,9 +242,9 @@ labelList getSelectedPatches // Process args for output options // Default from foamVtkOutputOptions is inline ASCII xml // -foamVtkOutput::outputOptions getOutputOptions(const argList& args) +vtk::outputOptions getOutputOptions(const argList& args) { - foamVtkOutput::outputOptions opts; + vtk::outputOptions opts; if (args.optionFound("xml")) { @@ -421,7 +421,7 @@ int main(int argc, char *argv[]) const bool noLagrangian = args.optionFound("noLagrangian"); const bool nearCellValue = args.optionFound("nearCellValue"); - const foamVtkOutput::outputOptions fmtType = getOutputOptions(args); + const vtk::outputOptions fmtType = getOutputOptions(args); if (nearCellValue) { @@ -515,7 +515,7 @@ int main(int argc, char *argv[]) meshSubsetHelper meshRef(mesh, meshSubsetHelper::SET, cellSetName); // Collect decomposition information etc. - foamVtkCells foamVtkMeshCells(fmtType, decomposePoly); + vtk::vtuCells vtuMeshCells(fmtType, decomposePoly); Info<< "VTK mesh topology: " << timer.cpuTimeIncrement() << " s, " @@ -544,7 +544,7 @@ int main(int argc, char *argv[]) ) { // Trigger change for vtk cells too - foamVtkMeshCells.clear(); + vtuMeshCells.clear(); } // If faceSet: write faceSet only (as polydata) @@ -565,7 +565,7 @@ int main(int argc, char *argv[]) Info<< " faceSet : " << relativeName(runTime, outputName) << nl; - foamVtkOutput::writeFaceSet + vtk::writeFaceSet ( meshRef.mesh(), set, @@ -593,7 +593,7 @@ int main(int argc, char *argv[]) Info<< " pointSet : " << relativeName(runTime, outputName) << nl; - foamVtkOutput::writePointSet + vtk::writePointSet ( meshRef.mesh(), set, @@ -830,14 +830,14 @@ int main(int argc, char *argv[]) if (doWriteInternal) { - if (foamVtkMeshCells.empty()) + if (vtuMeshCells.empty()) { - foamVtkMeshCells.reset(meshRef.mesh()); + vtuMeshCells.reset(meshRef.mesh()); // Convert cellMap, addPointCellLabels to global cell ids if (meshRef.useSubMesh()) { - foamVtkMeshCells.renumberCells + vtuMeshCells.renumberCells ( meshRef.subsetter().cellMap() ); @@ -855,10 +855,10 @@ int main(int argc, char *argv[]) << relativeName(runTime, outputName) << endl; // Write mesh - foamVtkOutput::internalWriter writer + vtk::internalWriter writer ( meshRef.baseMesh(), - foamVtkMeshCells, + vtuMeshCells, outputName, fmtType ); @@ -980,7 +980,7 @@ int main(int argc, char *argv[]) + timeDesc ); - foamVtkOutput::writeSurfFields + vtk::writeSurfFields ( meshRef.mesh(), outputName, @@ -1013,7 +1013,7 @@ int main(int argc, char *argv[]) Info<< " Combined patches : " << relativeName(runTime, outputName) << nl; - foamVtkOutput::patchWriter writer + vtk::patchWriter writer ( meshRef.mesh(), outputName, @@ -1083,7 +1083,7 @@ int main(int argc, char *argv[]) Info<< " Patch : " << relativeName(runTime, outputName) << nl; - foamVtkOutput::patchWriter writer + vtk::patchWriter writer ( meshRef.mesh(), outputName, @@ -1194,7 +1194,7 @@ int main(int argc, char *argv[]) mesh.points() ); - foamVtkOutput::surfaceMeshWriter writer + vtk::surfaceMeshWriter writer ( pp, fz.name(), @@ -1281,7 +1281,7 @@ int main(int argc, char *argv[]) Info<< " tensors :"; print(Info, tensorNames); - foamVtkOutput::lagrangianWriter writer + vtk::lagrangianWriter writer ( meshRef.mesh(), cloudName, @@ -1314,7 +1314,7 @@ int main(int argc, char *argv[]) } else { - foamVtkOutput::lagrangianWriter writer + vtk::lagrangianWriter writer ( meshRef.mesh(), cloudName, diff --git a/applications/utilities/postProcessing/dataConversion/foamToVTK/foamVtkLagrangianWriter.C b/applications/utilities/postProcessing/dataConversion/foamToVTK/foamVtkLagrangianWriter.C index 4101672b69..959485fb19 100644 --- a/applications/utilities/postProcessing/dataConversion/foamToVTK/foamVtkLagrangianWriter.C +++ b/applications/utilities/postProcessing/dataConversion/foamToVTK/foamVtkLagrangianWriter.C @@ -29,30 +29,30 @@ License // * * * * * * * * * * * * * Private Member Functions * * * * * * * * * * * // -void Foam::foamVtkOutput::lagrangianWriter::beginPiece() +void Foam::vtk::lagrangianWriter::beginPiece() { if (!legacy_) { if (useVerts_) { format() - .openTag(vtkFileTag::PIECE) - ( "NumberOfPoints", nParcels_ ) - ( "NumberOfVerts", nParcels_ ) + .openTag(vtk::fileTag::PIECE) + .xmlAttr(fileAttr::NUMBER_OF_POINTS, nParcels_) + .xmlAttr(fileAttr::NUMBER_OF_VERTS, nParcels_) .closeTag(); } else { format() - .openTag(vtkFileTag::PIECE) - ( "NumberOfPoints", nParcels_ ) + .openTag(vtk::fileTag::PIECE) + .xmlAttr(fileAttr::NUMBER_OF_POINTS, nParcels_) .closeTag(); } } } -void Foam::foamVtkOutput::lagrangianWriter::writePoints() +void Foam::vtk::lagrangianWriter::writePoints() { Cloud parcels(mesh_, cloudName_, false); nParcels_ = parcels.size(); @@ -67,8 +67,8 @@ void Foam::foamVtkOutput::lagrangianWriter::writePoints() { beginPiece(); // Tricky - hide in here - format().tag(vtkFileTag::POINTS) - .openDataArray(vtkFileTag::POINTS) + format().tag(vtk::fileTag::POINTS) + .openDataArray(vtk::dataArrayAttr::POINTS) .closeTag(); } @@ -78,7 +78,7 @@ void Foam::foamVtkOutput::lagrangianWriter::writePoints() { const point& pt = iter().position(); - foamVtkOutput::write(format(), pt); + vtk::write(format(), pt); } format().flush(); @@ -86,12 +86,12 @@ void Foam::foamVtkOutput::lagrangianWriter::writePoints() { format() .endDataArray() - .endTag(vtkFileTag::POINTS); + .endTag(vtk::fileTag::POINTS); } } -void Foam::foamVtkOutput::lagrangianWriter::writeVertsLegacy() +void Foam::vtk::lagrangianWriter::writeVertsLegacy() { os_ << "VERTICES " << nParcels_ << ' ' << 2*nParcels_ << nl; @@ -107,9 +107,9 @@ void Foam::foamVtkOutput::lagrangianWriter::writeVertsLegacy() } -void Foam::foamVtkOutput::lagrangianWriter::writeVerts() +void Foam::vtk::lagrangianWriter::writeVerts() { - format().tag(vtkFileTag::VERTS); + format().tag(vtk::fileTag::VERTS); // Same payload throughout const uint64_t payLoad = (nParcels_ * sizeof(label)); @@ -119,7 +119,7 @@ void Foam::foamVtkOutput::lagrangianWriter::writeVerts() // = linear mapping onto points // { - format().openDataArray