zhyang-dev/openfoam
1
0
Fork 0
mirror of https://develop.openfoam.com/Development/openfoam.git synced 2025-11-28 03:28:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ENH: use stl::set instead of hand-rolled HashTable in wmkdependParser

Browse Source
This commit is contained in:
Mark Olesen
2010-02-10 13:07:42 +01:00
parent 3613752115
commit d0fd6f27a3
4 changed files with 73 additions and 335 deletions
Download Patch File Download Diff File Expand all files Collapse all files

163
wmake/src/wmkdependParser.atg
View File

@ -2,6 +2,10 @@
Attributed Grammar for Coco/R (-*- C++ -*- version) Attributed Grammar for Coco/R (-*- C++ -*- version)
compile with: compile with:
coco-cpp wmkdependParser.atg coco-cpp wmkdependParser.atg
For example,
$WM_THIRD_PARTY_DIR/coco-cpp/platforms/$WM_ARCH$WM_COMPILER/bin/coco-cpp \
-frames $WM_THIRD_PARTY_DIR/coco-cpp/platforms/share/coco-cpp \
wmkdependParser.atg
\*---------------------------------------------------------------------------*/ \*---------------------------------------------------------------------------*/
[copy] [copy]
/*---------------------------------*- C++ -*---------------------------------*\ /*---------------------------------*- C++ -*---------------------------------*\
@ -42,140 +46,7 @@ SourceFiles
#include <iostream> #include <iostream>
#include <string> #include <string>
#include <list> #include <list>
#include <set>
//! @brief A simple HashTable implementation
/**
* @note This hash table is only vaguely STL-like. In accordance with
* its present purpose, this hash table only supports a constIterator
* and no deletions. For simplicity, the constIterator increment is
* simply via a next() method. Instead of comparing to an end value,
* the constIterator valid() method is used.
* For example,
* @code
* for
* (
* HashTable<foo>::constIterator iter = myHash.begin();
* iter.valid();
* iter.next()
* )
* {
* std::cerr<< "key: " << iter.key() << "\n";
* }
* @endcode
*
*/
class StringHashSet
{
//! An entry within the HashTable
struct hashedEntry
{
const std::string key_; //<! The lookup key
hashedEntry *next_; //<! Pointer to next hashedEntry in sub-list
hashedEntry(const std::string& key, hashedEntry *next=0)
:
key_(key), next_(next)
{}
};
const int size_; //<! fixed HashTable size
hashedEntry** table_;
public:
//! Construct with a default size
StringHashSet(int size = 500)
:
size_(size),
table_(new hashedEntry*[size_])
{
memset(table_, 0, size_ * sizeof(hashedEntry*));
}
//! Destructor
~StringHashSet()
{
for (int hashIdx = 0; hashIdx < size_; ++hashIdx)
{
hashedEntry* ep = table_[hashIdx];
while (ep)
{
hashedEntry* del = ep;
ep = ep->next_;
delete del;
}
}
delete[] table_;
table_ = 0;
}
//! Return hash index for lookup name in hash table
bool hashKeyIndex(const std::string& name) const
{
int hashIdx = 0;
// calculate hash index
for
(
std::string::const_iterator iter = name.begin();
iter != name.end();
++iter
)
{
hashIdx = hashIdx << 1 ^ *iter;
}
if (hashIdx < 0)
{
hashIdx = -hashIdx;
}
return hashIdx % size_;
}
//! Return true if name is found in hash table
bool found(const std::string& name) const
{
const int hashIdx = hashKeyIndex(name);
for (hashedEntry* ep = table_[hashIdx]; ep; ep = ep->next_)
{
if (name == ep->key_)
{
// found
return true;
}
}
// entry not found
return false;
}
//! Return true if name is found in hash table, insert if not found
bool foundOrInsert(const std::string& name)
{
const int hashIdx = hashKeyIndex(name);
for (hashedEntry* ep = table_[hashIdx]; ep; ep = ep->next_)
{
if (name == ep->key_)
{
// found - return true
return true;
}
}
// not found - insert it
table_[hashIdx] = new hashedEntry(name, table_[hashIdx]);
// entry not found (but was added) - return false
return false;
}
};
/*---------------------------------------------------------------------------*/ /*---------------------------------------------------------------------------*/
@ -188,11 +59,11 @@ COMPILER wmkdepend
/*---------------------------------------------------------------------------*/ /*---------------------------------------------------------------------------*/
private: private:
//! Hash of files already visited //! Set of files already visited
static StringHashSet visitedFiles_; static std::set<std::string> visitedFiles_;
//! Hash of (java) directories already visited //! Set of (java) directories already visited
static StringHashSet visitedDirs_; static std::set<std::string> visitedDirs_;
//! Replace all '.' with '/' //! Replace all '.' with '/'
static void dotToSlash(std::string& name); static void dotToSlash(std::string& name);
@ -224,8 +95,8 @@ public:
#include <sys/types.h> #include <sys/types.h>
#include <dirent.h> #include <dirent.h>
StringHashSet Parser::visitedFiles_; std::set<std::string> Parser::visitedFiles_;
StringHashSet Parser::visitedDirs_; std::set<std::string> Parser::visitedDirs_;
std::list<std::string> Parser::includeDirs; std::list<std::string> Parser::includeDirs;
std::string Parser::sourceFile; std::string Parser::sourceFile;
@ -246,15 +117,15 @@ void Parser::dotToSlash(std::string& name)
void Parser::ignoreDir(const std::string& name) void Parser::ignoreDir(const std::string& name)
{ {
visitedDirs_.foundOrInsert(name); visitedDirs_.insert(name);
} }
void Parser::includeFile(const std::string& name) void Parser::includeFile(const std::string& name)
{ {
if (visitedFiles_.foundOrInsert(name)) if (!visitedFiles_.insert(name).second)
{ {
return; return; // already existed (did not insert)
} }
// use stdio and buffering within Coco/R -- (faster) // use stdio and buffering within Coco/R -- (faster)
@ -312,7 +183,7 @@ void Parser::importFile(const std::string& name)
std::string dirGlob = name.substr(0, dotPos); std::string dirGlob = name.substr(0, dotPos);
dirGlob += ".*"; dirGlob += ".*";
if (visitedDirs_.found(dirGlob)) if (visitedDirs_.find(dirGlob) != visitedDirs_.end())
{ {
return; return;
} }
@ -329,9 +200,9 @@ void Parser::importFile(const std::string& name)
void Parser::importDir(const std::string& name) void Parser::importDir(const std::string& name)
{ {
if (visitedDirs_.foundOrInsert(name)) if (!visitedDirs_.insert(name).second)
{ {
return; return; // already existed (did not insert)
} }
std::string dirName = name; std::string dirName = name;

16
wmake/src/wmkdependParser.cpp
View File

@ -52,8 +52,8 @@ namespace wmake {
#include <sys/types.h> #include <sys/types.h>
#include <dirent.h> #include <dirent.h>
StringHashSet Parser::visitedFiles_; std::set<std::string> Parser::visitedFiles_;
StringHashSet Parser::visitedDirs_; std::set<std::string> Parser::visitedDirs_;
std::list<std::string> Parser::includeDirs; std::list<std::string> Parser::includeDirs;
std::string Parser::sourceFile; std::string Parser::sourceFile;
@ -74,15 +74,15 @@ void Parser::dotToSlash(std::string& name)
void Parser::ignoreDir(const std::string& name) void Parser::ignoreDir(const std::string& name)
{ {
visitedDirs_.foundOrInsert(name); visitedDirs_.insert(name);
} }
void Parser::includeFile(const std::string& name) void Parser::includeFile(const std::string& name)
{ {
if (visitedFiles_.foundOrInsert(name)) if (!visitedFiles_.insert(name).second)
{ {
return; return; // already existed (did not insert)
} }
// use stdio and buffering within Coco/R -- (faster) // use stdio and buffering within Coco/R -- (faster)
@ -140,7 +140,7 @@ void Parser::importFile(const std::string& name)
std::string dirGlob = name.substr(0, dotPos); std::string dirGlob = name.substr(0, dotPos);
dirGlob += ".*"; dirGlob += ".*";
if (visitedDirs_.found(dirGlob)) if (visitedDirs_.find(dirGlob) != visitedDirs_.end())
{ {
return; return;
} }
@ -157,9 +157,9 @@ void Parser::importFile(const std::string& name)
void Parser::importDir(const std::string& name) void Parser::importDir(const std::string& name)
{ {
if (visitedDirs_.foundOrInsert(name)) if (!visitedDirs_.insert(name).second)
{ {
return; return; // already existed (did not insert)
} }
std::string dirName = name; std::string dirName = name;

145
wmake/src/wmkdependParser.h
View File

@ -44,140 +44,7 @@ SourceFiles
#include <iostream> #include <iostream>
#include <string> #include <string>
#include <list> #include <list>
#include <set>
//! @brief A simple HashTable implementation
/**
* @note This hash table is only vaguely STL-like. In accordance with
* its present purpose, this hash table only supports a constIterator
* and no deletions. For simplicity, the constIterator increment is
* simply via a next() method. Instead of comparing to an end value,
* the constIterator valid() method is used.
* For example,
* @code
* for
* (
* HashTable<foo>::constIterator iter = myHash.begin();
* iter.valid();
* iter.next()
* )
* {
* std::cerr<< "key: " << iter.key() << "\n";
* }
* @endcode
*
*/
class StringHashSet
{
//! An entry within the HashTable
struct hashedEntry
{
const std::string key_; //<! The lookup key
hashedEntry *next_; //<! Pointer to next hashedEntry in sub-list
hashedEntry(const std::string& key, hashedEntry *next=0)
:
key_(key), next_(next)
{}
};
const int size_; //<! fixed HashTable size
hashedEntry** table_;
public:
//! Construct with a default size
StringHashSet(int size = 500)
:
size_(size),
table_(new hashedEntry*[size_])
{
memset(table_, 0, size_ * sizeof(hashedEntry*));
}
//! Destructor
~StringHashSet()
{
for (int hashIdx = 0; hashIdx < size_; ++hashIdx)
{
hashedEntry* ep = table_[hashIdx];
while (ep)
{
hashedEntry* del = ep;
ep = ep->next_;
delete del;
}
}
delete[] table_;
table_ = 0;
}
//! Return hash index for lookup name in hash table
bool hashKeyIndex(const std::string& name) const
{
int hashIdx = 0;
// calculate hash index
for
(
std::string::const_iterator iter = name.begin();
iter != name.end();
++iter
)
{
hashIdx = hashIdx << 1 ^ *iter;
}
if (hashIdx < 0)
{
hashIdx = -hashIdx;
}
return hashIdx % size_;
}
//! Return true if name is found in hash table
bool found(const std::string& name) const
{
const int hashIdx = hashKeyIndex(name);
for (hashedEntry* ep = table_[hashIdx]; ep; ep = ep->next_)
{
if (name == ep->key_)
{
// found
return true;
}
}
// entry not found
return false;
}
//! Return true if name is found in hash table, insert if not found
bool foundOrInsert(const std::string& name)
{
const int hashIdx = hashKeyIndex(name);
for (hashedEntry* ep = table_[hashIdx]; ep; ep = ep->next_)
{
if (name == ep->key_)
{
// found - return true
return true;
}
}
// not found - insert it
table_[hashIdx] = new hashedEntry(name, table_[hashIdx]);
// entry not found (but was added) - return false
return false;
}
};
/*---------------------------------------------------------------------------*/ /*---------------------------------------------------------------------------*/
@ -191,7 +58,7 @@ namespace wmake {
/*---------------------------------------------------------------------------*\ /*---------------------------------------------------------------------------*\
Class Errors Declaration Class Errors Declaration
\*---------------------------------------------------------------------------*/ \*---------------------------------------------------------------------------*/
//! Parser error handing //! Parser error handling
class Errors class Errors
{ {
public: public:
@ -255,11 +122,11 @@ public:
private: private:
//! Hash of files already visited //! Set of files already visited
static StringHashSet visitedFiles_; static std::set<std::string> visitedFiles_;
//! Hash of (java) directories already visited //! Set of (java) directories already visited
static StringHashSet visitedDirs_; static std::set<std::string> visitedDirs_;
//! Replace all '.' with '/' //! Replace all '.' with '/'
static void dotToSlash(std::string& name); static void dotToSlash(std::string& name);

2
wmake/src/wmkdependScanner.h
View File

@ -200,7 +200,7 @@ public:
Class Buffer Declaration Class Buffer Declaration
\*---------------------------------------------------------------------------*/ \*---------------------------------------------------------------------------*/
/*! /*!
* @brief Scanner Buffer Token * @brief Scanner Buffer
* *
* This Buffer supports the following cases: * This Buffer supports the following cases:
* -# seekable stream (file) * -# seekable stream (file)