From d7963e6496bd63507e093cef60a7c4d21c543431 Mon Sep 17 00:00:00 2001
From: laurence <laurence>
Date: Thu, 1 Aug 2013 17:16:34 +0100
Subject: [PATCH] BUG: sortPointEdges: Break out of loop if cannot get back to
 starting edge. Print Warning.

---
 .../PatchTools/PatchToolsSortPoints.C         | 42 +++++++++++++++++--
 1 file changed, 39 insertions(+), 3 deletions(-)

diff --git a/src/OpenFOAM/meshes/primitiveMesh/PatchTools/PatchToolsSortPoints.C b/src/OpenFOAM/meshes/primitiveMesh/PatchTools/PatchToolsSortPoints.C
index 5cc074ba96..e6e507caaa 100644
--- a/src/OpenFOAM/meshes/primitiveMesh/PatchTools/PatchToolsSortPoints.C
+++ b/src/OpenFOAM/meshes/primitiveMesh/PatchTools/PatchToolsSortPoints.C
@@ -49,7 +49,7 @@ Foam::PatchTools::sortedPointEdges
     const labelListList& faceEdges = p.faceEdges();
 
     // create the lists for the various results. (resized on completion)
-    labelListList sortedPointEdges(pointEdges.size());
+    labelListList sortedPointEdges(pointEdges);
 
     DynamicList<label> newEdgeList;
 
@@ -57,12 +57,16 @@ Foam::PatchTools::sortedPointEdges
     {
         const labelList& pEdges = pointEdges[pointI];
 
+        label nPointEdges = pEdges.size();
+
         label edgeI = pEdges[0];
 
         label prevFaceI = edgeFaces[edgeI][0];
 
         newEdgeList.clear();
-        newEdgeList.setCapacity(pEdges.size());
+        newEdgeList.setCapacity(nPointEdges);
+
+        label nVisitedEdges = 0;
 
         do
         {
@@ -103,10 +107,42 @@ Foam::PatchTools::sortedPointEdges
 
             prevFaceI = faceI;
 
+            nVisitedEdges++;
+            if (nVisitedEdges > nPointEdges)
+            {
+                WarningIn("Foam::PatchTools::sortedPointEdges()")
+                    << "Unable to order pointEdges as the face connections "
+                    << "are not circular" << nl
+                    << "    Original pointEdges = " << pEdges << nl
+                    << "    New pointEdges = " << newEdgeList
+                    << endl;
+
+                newEdgeList = pEdges;
+
+                break;
+            }
+
         } while (edgeI != pEdges[0]);
 
-        if (newEdgeList.size() == pEdges.size())
+        if (newEdgeList.size() == nPointEdges)
         {
+            forAll(pEdges, eI)
+            {
+                if (findIndex(newEdgeList, pEdges[eI]) == -1)
+                {
+                    WarningIn("Foam::PatchTools::sortedPointEdges()")
+                        << "Cannot find all original edges in the new list"
+                        << nl
+                        << "    Original pointEdges = " << pEdges << nl
+                        << "    New pointEdges = " << newEdgeList
+                        << endl;
+
+                    newEdgeList = pEdges;
+
+                    break;
+                }
+            }
+
             sortedPointEdges[pointI] = newEdgeList;
         }
     }