diff --git a/src/functionObjects/field/wallShearStress/wallShearStress.C b/src/functionObjects/field/wallShearStress/wallShearStress.C index c90a02ea03..ce8281fa10 100644 --- a/src/functionObjects/field/wallShearStress/wallShearStress.C +++ b/src/functionObjects/field/wallShearStress/wallShearStress.C @@ -3,7 +3,7 @@ \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | \\ / A nd | Copyright (C) 2013-2016 OpenFOAM Foundation - \\/ M anipulation | + \\/ M anipulation | Copyright (C) 2017 OpenCFD Ltd. ------------------------------------------------------------------------------- License This file is part of OpenFOAM. @@ -188,29 +188,22 @@ bool Foam::functionObjects::wallShearStress::read(const dictionary& dict) bool Foam::functionObjects::wallShearStress::execute() { - typedef compressible::turbulenceModel cmpModel; - typedef incompressible::turbulenceModel icoModel; - volVectorField& wallShearStress = - const_cast - ( - mesh_.lookupObject(type()) - ); + mesh_.lookupObjectRef(type()); - tmp Reff; - if (mesh_.foundObject(turbulenceModel::propertiesName)) + const word& turbModelName = turbulenceModel::propertiesName; + auto cmpModelPtr = + mesh_.lookupObjectPtr(turbModelName); + auto icoModelPtr = + mesh_.lookupObjectPtr(turbModelName); + + if (cmpModelPtr) { - const cmpModel& model = - mesh_.lookupObject(turbulenceModel::propertiesName); - - Reff = model.devRhoReff(); + calcShearStress(cmpModelPtr->devRhoReff(), wallShearStress); } - else if (mesh_.foundObject(turbulenceModel::propertiesName)) + else if (icoModelPtr) { - const icoModel& model = - mesh_.lookupObject(turbulenceModel::propertiesName); - - Reff = model.devReff(); + calcShearStress(icoModelPtr->devReff(), wallShearStress); } else { @@ -219,8 +212,6 @@ bool Foam::functionObjects::wallShearStress::execute() << "database" << exit(FatalError); } - calcShearStress(Reff(), wallShearStress); - return true; } diff --git a/src/fvOptions/sources/interRegion/interRegionHeatTransfer/tabulatedNTUHeatTransfer/tabulatedNTUHeatTransfer.C b/src/fvOptions/sources/interRegion/interRegionHeatTransfer/tabulatedNTUHeatTransfer/tabulatedNTUHeatTransfer.C index fe7fa6a32a..2ba95833c1 100644 --- a/src/fvOptions/sources/interRegion/interRegionHeatTransfer/tabulatedNTUHeatTransfer/tabulatedNTUHeatTransfer.C +++ b/src/fvOptions/sources/interRegion/interRegionHeatTransfer/tabulatedNTUHeatTransfer/tabulatedNTUHeatTransfer.C @@ -73,15 +73,15 @@ const Foam::basicThermo& Foam::fv::tabulatedNTUHeatTransfer::thermo const fvMesh& mesh ) const { - if (!mesh.foundObject("thermophysicalProperties")) + if (!mesh.foundObject(basicThermo::dictName)) { FatalErrorInFunction << " on mesh " << mesh.name() - << " could not find thermophysicalProperties " + << " could not find " << basicThermo::dictName << exit(FatalError); } - return mesh.lookupObject("thermophysicalProperties"); + return mesh.lookupObject(basicThermo::dictName); } diff --git a/src/meshTools/AABBTree/AABBTree.C b/src/meshTools/AABBTree/AABBTree.C index a8f02d3aa2..3ebd4805d1 100644 --- a/src/meshTools/AABBTree/AABBTree.C +++ b/src/meshTools/AABBTree/AABBTree.C @@ -43,29 +43,26 @@ void Foam::AABBTree::writeOBJ ) const { const pointField pts(bb.points()); - forAll(pts, i) + for (const point& pt : pts) { - meshTools::writeOBJ(os, pts[i]); + meshTools::writeOBJ(os, pt); } if (writeLinesOnly) { - forAll(bb.edges, i) + for (const edge& e : bb.edges) { - const edge& e = bb.edges[i]; os << "l " << e[0] + vertI + 1 << ' ' << e[1] + vertI + 1 << nl; } } else { - forAll(bb.faces, i) + for (const face& f : bb.faces) { - const face& f = bb.faces[i]; - os << 'f'; - forAll(f, fp) + for (const label fpi : f) { - os << ' ' << f[fp] + vertI + 1; + os << ' ' << fpi + vertI + 1; } os << nl; } @@ -144,7 +141,7 @@ void Foam::AABBTree::createBoxes direction maxDir = 0; scalar maxSpan = span[maxDir]; - for (label dirI = 1; dirI < 3; dirI++) + for (label dirI = 1; dirI < 3; ++dirI) { if (span[dirI] > maxSpan) { @@ -163,14 +160,12 @@ void Foam::AABBTree::createBoxes PackedBoolList isUsedPoint(points.size()); DynamicList component(points.size()); - forAll(objectIDs, i) + for (const label objI : objectIDs) { - const label objI = objectIDs[i]; const Type& obj = objects[objI]; - forAll(obj, pI) + for (const label pointI : obj) { - const label pointI = obj[pI]; if (isUsedPoint.set(pointI)) { component.append(points[pointI][maxDir]); @@ -203,17 +198,15 @@ void Foam::AABBTree::createBoxes DynamicList