From 3ef8906a6617059096011b640b26756770c74d07 Mon Sep 17 00:00:00 2001 From: Mark Olesen Date: Mon, 20 Nov 2017 14:55:36 +0100 Subject: [PATCH] ENH: consolidate surfaceFormats for reading/writing triSurface (issue #294) - eliminates previous code duplication and improves maintainability --- .../surface/surfaceConvert/surfaceConvert.C | 32 +- .../surfaceMeshConvert/surfaceMeshConvert.C | 4 +- .../PrimitivePatch/PrimitivePatch.H | 8 +- .../primitives/strings/stringOps/stringOps.H | 9 +- .../strings/stringOps/stringOpsTemplates.C | 5 +- src/fileFormats/fire/FIRECore.C | 6 - src/fileFormats/fire/FIRECore.H | 2 +- src/fileFormats/nas/NASCore.C | 118 +++- src/fileFormats/nas/NASCore.H | 72 ++- src/fileFormats/starcd/STARCDCore.C | 15 +- src/fileFormats/starcd/STARCDCore.H | 23 +- src/fileFormats/stl/STLCore.C | 15 +- src/fileFormats/stl/STLCore.H | 7 +- src/fileFormats/stl/STLReader.C | 25 +- src/fileFormats/stl/STLReader.H | 4 +- src/fileFormats/stl/STLReaderASCII.L | 4 +- src/lumpedPointMotion/lumpedPointState.C | 10 +- .../edgeMeshFormats/edgeMeshFormatsCore.C | 19 +- .../edgeMeshFormats/edgeMeshFormatsCore.H | 8 +- .../edgeMeshFormats/nas/NASedgeFormat.C | 70 ++- .../edgeMeshFormats/nas/NASedgeFormat.H | 21 +- .../writers/nastran/nastranSurfaceWriter.C | 214 +++----- .../writers/nastran/nastranSurfaceWriter.H | 47 +- .../nastran/nastranSurfaceWriterTemplates.C | 58 +- .../writers/vtk/vtkSurfaceWriter.C | 39 +- .../writers/vtk/vtkSurfaceWriter.H | 2 +- src/surfMesh/Make/files | 25 +- src/surfMesh/MeshedSurface/MeshedSurface.C | 146 +++-- src/surfMesh/MeshedSurface/MeshedSurface.H | 61 ++- src/surfMesh/MeshedSurface/MeshedSurfaceIO.C | 11 +- .../MeshedSurface/MeshedSurfaceZones.C | 40 +- .../MeshedSurfaceProxy/MeshedSurfaceProxy.C | 41 +- .../MeshedSurfaceProxy/MeshedSurfaceProxy.H | 58 +- .../ModifiableMeshedSurface.H | 3 +- .../UnsortedMeshedSurface.C | 88 +-- .../UnsortedMeshedSurface.H | 46 +- .../UnsortedMeshedSurfaceNew.C | 6 +- src/surfMesh/mergedSurf/mergedSurf.C | 6 - src/surfMesh/mergedSurf/mergedSurf.H | 2 +- src/surfMesh/meshedSurf/meshedSurf.H | 8 +- src/surfMesh/meshedSurf/meshedSurfRef.H | 6 +- src/surfMesh/surfMesh/surfMesh.C | 31 +- src/surfMesh/surfMesh/surfMesh.H | 38 +- .../surfaceFormats/ac3d/AC3DsurfaceFormat.C | 80 +-- .../surfaceFormats/ac3d/AC3DsurfaceFormat.H | 48 +- .../ac3d/AC3DsurfaceFormatCore.C | 61 ++- .../ac3d/AC3DsurfaceFormatCore.H | 26 +- .../ac3d/AC3DsurfaceFormatCoreTemplates.C | 7 +- .../surfaceFormats/fire/FLMAsurfaceFormat.C | 56 +- .../surfaceFormats/fire/FLMAsurfaceFormat.H | 66 ++- .../surfaceFormats/gts/GTSsurfaceFormat.C | 152 +++--- .../surfaceFormats/gts/GTSsurfaceFormat.H | 53 +- .../gts/triSurfaceGTSformat.C} | 66 ++- .../surfaceFormats/nas/NASsurfaceFormat.C | 258 +++++++-- .../surfaceFormats/nas/NASsurfaceFormat.H | 55 +- .../nas/NASsurfaceFormatRunTime.C | 32 +- src/surfMesh/surfaceFormats/obj/OBJstream.C | 6 - src/surfMesh/surfaceFormats/obj/OBJstream.H | 4 +- .../surfaceFormats/obj/OBJsurfaceFormat.C | 45 +- .../surfaceFormats/obj/OBJsurfaceFormat.H | 43 +- .../surfaceFormats/off/OFFsurfaceFormat.C | 25 +- .../surfaceFormats/off/OFFsurfaceFormat.H | 44 +- .../surfaceFormats/smesh/SMESHsurfaceFormat.C | 49 +- .../surfaceFormats/smesh/SMESHsurfaceFormat.H | 29 +- .../starcd/STARCDsurfaceFormat.C | 48 +- .../starcd/STARCDsurfaceFormat.H | 43 +- .../starcd/STARCDsurfaceFormatCore.C | 6 +- .../starcd/STARCDsurfaceFormatCore.H | 12 +- .../surfaceFormats/stl/STLsurfaceFormat.C | 188 +++---- .../surfaceFormats/stl/STLsurfaceFormat.H | 115 ++-- .../stl/triSurfaceSTLformat.C} | 169 ++++-- .../surfaceFormats/surfaceFormatsCore.C | 23 +- .../surfaceFormats/surfaceFormatsCore.H | 16 +- .../{TRIsurfaceFormatCore.C => TRIReader.C} | 111 ++-- .../{TRIsurfaceFormatCore.H => TRIReader.H} | 45 +- .../surfaceFormats/tri/TRIsurfaceFormat.C | 75 +-- .../surfaceFormats/tri/TRIsurfaceFormat.H | 51 +- .../surfaceFormats/vtk/VTKsurfaceFormat.C | 35 +- .../surfaceFormats/vtk/VTKsurfaceFormat.H | 41 +- .../surfaceFormats/vtk/VTKsurfaceFormatCore.C | 2 +- .../surfaceFormats/vtk/VTKsurfaceFormatCore.H | 13 +- .../surfaceFormats/vtp/VTPsurfaceFormat.C | 23 +- .../surfaceFormats/vtp/VTPsurfaceFormat.H | 31 +- .../surfaceFormats/vtp/VTPsurfaceFormatCore.C | 3 +- .../surfaceFormats/vtp/VTPsurfaceFormatCore.H | 14 +- .../surfaceFormats/x3d/X3DsurfaceFormat.C | 32 +- .../surfaceFormats/x3d/X3DsurfaceFormat.H | 24 +- .../surfaceFormats/x3d/X3DsurfaceFormatCore.H | 7 +- .../surfaceRegistry/surfaceRegistry.C | 10 +- .../surfaceRegistry/surfaceRegistry.H | 7 +- .../triSurface/interfaces/AC3D/readAC.C | 349 ------------ .../triSurface/interfaces/AC3D/writeAC.C | 139 ----- .../triSurface/interfaces/GTS/readGTS.C | 161 ------ .../triSurface/interfaces/NAS/readNAS.C | 359 ------------- .../triSurface/interfaces/OBJ/readOBJ.C | 199 ------- .../triSurface/interfaces/OBJ/writeOBJ.C | 140 ----- .../triSurface/interfaces/OFF/readOFF.C | 134 ----- .../triSurface/interfaces/OFF/writeOFF.C | 116 ---- .../triSurface/interfaces/SMESH/writeSMESH.C | 111 ---- .../triSurface/interfaces/STL/readSTL.C | 92 ---- .../triSurface/interfaces/TRI/readTRI.C | 172 ------ .../triSurface/interfaces/TRI/writeTRI.C | 113 ---- .../triSurface/interfaces/VTK/readVTK.C | 106 ---- .../triSurface/interfaces/VTK/writeVTK.C | 167 ------ .../patches/geometricSurfacePatch.C | 20 +- .../patches/geometricSurfacePatch.H | 12 +- src/surfMesh/triSurface/triSurface.C | 502 +++--------------- src/surfMesh/triSurface/triSurface.H | 162 +++--- .../triSurface/triSurfaceAddressing.C | 1 - src/surfMesh/triSurface/triSurfaceIO.C | 375 +++++++++++++ .../{stitchTriangles.C => triSurfaceStitch.C} | 24 +- 111 files changed, 2646 insertions(+), 4610 deletions(-) rename src/surfMesh/{triSurface/interfaces/GTS/writeGTS.C => surfaceFormats/gts/triSurfaceGTSformat.C} (69%) rename src/surfMesh/{triSurface/interfaces/STL/writeSTL.C => surfaceFormats/stl/triSurfaceSTLformat.C} (50%) rename src/surfMesh/surfaceFormats/tri/{TRIsurfaceFormatCore.C => TRIReader.C} (71%) rename src/surfMesh/surfaceFormats/tri/{TRIsurfaceFormatCore.H => TRIReader.H} (78%) delete mode 100644 src/surfMesh/triSurface/interfaces/AC3D/readAC.C delete mode 100644 src/surfMesh/triSurface/interfaces/AC3D/writeAC.C delete mode 100644 src/surfMesh/triSurface/interfaces/GTS/readGTS.C delete mode 100644 src/surfMesh/triSurface/interfaces/NAS/readNAS.C delete mode 100644 src/surfMesh/triSurface/interfaces/OBJ/readOBJ.C delete mode 100644 src/surfMesh/triSurface/interfaces/OBJ/writeOBJ.C delete mode 100644 src/surfMesh/triSurface/interfaces/OFF/readOFF.C delete mode 100644 src/surfMesh/triSurface/interfaces/OFF/writeOFF.C delete mode 100644 src/surfMesh/triSurface/interfaces/SMESH/writeSMESH.C delete mode 100644 src/surfMesh/triSurface/interfaces/STL/readSTL.C delete mode 100644 src/surfMesh/triSurface/interfaces/TRI/readTRI.C delete mode 100644 src/surfMesh/triSurface/interfaces/TRI/writeTRI.C delete mode 100644 src/surfMesh/triSurface/interfaces/VTK/readVTK.C delete mode 100644 src/surfMesh/triSurface/interfaces/VTK/writeVTK.C create mode 100644 src/surfMesh/triSurface/triSurfaceIO.C rename src/surfMesh/triSurface/{stitchTriangles.C => triSurfaceStitch.C} (88%) diff --git a/applications/utilities/surface/surfaceConvert/surfaceConvert.C b/applications/utilities/surface/surfaceConvert/surfaceConvert.C index deb3dccca0..90c57cf4f5 100644 --- a/applications/utilities/surface/surfaceConvert/surfaceConvert.C +++ b/applications/utilities/surface/surfaceConvert/surfaceConvert.C @@ -64,7 +64,7 @@ int main(int argc, char *argv[]) { argList::addNote ( - "convert between surface formats" + "convert between surface formats, using triSurface library components" ); argList::noParallel(); @@ -96,16 +96,6 @@ int main(int argc, char *argv[]) argList args(argc, argv); - if (args.optionFound("writePrecision")) - { - label writePrecision = args.optionRead