COMP: consistent FatalError/FatalIOError exit types

STYLE: hostName() is short name, don't need parameter

applications/utilities/preProcessing/setAlphaField/alphaFieldFunctions/implicitFunctions/composedFunction/composedFunctionImplicitFunction.C

@@ -137,7 +137,7 @@ composedFunctionImplicitFunction
         {
             FatalIOErrorInFunction(funcDict)
                 << "Entry " << key << " is not a dictionary" << endl
-                << exit(FatalError);
+                << exit(FatalIOError);
         }
 
         const dictionary& subdict = dEntry.dict();

src/OpenFOAM/expressions/exprResult/exprResult.C

@@ -284,16 +284,16 @@ Foam::expressions::exprResult::exprResult
                 valType_ = "none";
             }
 
-            FatalErrorInFunction
+            FatalIOErrorInFunction(dict)
                 << "Do not know how to read data type " << valType_
                 << (uniform ? " as a single value." : ".") << nl
-                << exit(FatalError);
+                << exit(FatalIOError);
         }
     }
     else if (needsValue)
     {
         FatalIOErrorInFunction(dict)
-            << "No entry 'value' defined in " << dict.name() << nl
+            << "No entry 'value' defined" << nl
             << exit(FatalIOError);
     }
 }

src/OpenFOAM/fields/GeometricFields/GeometricField/GeometricField.C

@@ -432,7 +432,7 @@ Foam::GeometricField<Type, PatchField, GeoMesh>::GeometricField
 
     if (this->size() != GeoMesh::size(this->mesh()))
     {
-        FatalErrorInFunction
+        FatalIOErrorInFunction(dict)
             << "   number of field elements = " << this->size()
             << " number of mesh elements = " << GeoMesh::size(this->mesh())
             << exit(FatalIOError);

src/OpenFOAM/global/profiling/profilingSysInfo.C

@@ -5,7 +5,7 @@
     \\  /    A nd           | www.openfoam.com
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
-    Copyright (C) 2016-2017 OpenCFD Ltd.
+    Copyright (C) 2016-2021 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -37,7 +37,7 @@ namespace
 {
 
 // Write environment entry
-inline static void printEnv
+inline void printEnv
 (
     Foam::Ostream& os,
     const Foam::word& key,
@@ -61,7 +61,7 @@ Foam::Ostream& Foam::profilingSysInfo::write
     Ostream& os
 ) const
 {
-    os.writeEntry("host",       Foam::hostName(false)); // short name
+    os.writeEntry("host",       Foam::hostName()); // short name
     os.writeEntry("date",       Foam::clock::dateTime());
 
     // compile-time information

src/OpenFOAM/include/OSspecific.H

@@ -82,8 +82,8 @@ FOAM_DEPRECATED_FOR(2020-05, "hasEnv() function")
 inline bool env(const std::string& envName) { return Foam::hasEnv(envName); }
 
 //- Return the system's host name, as per hostname(1)
-//  Optionally with the full name (as per the '-f' option)
+//  \note the full name (as per the '-f' option) may be unreliable
-string hostName(const bool full=false);
+string hostName(bool full=false);
 
 //- Return the system's domain name, as per hostname(1) with the '-d' option
 string domainName();

src/OpenFOAM/primitives/strings/stringOps/stringOps.C

@@ -564,7 +564,7 @@ static Foam::string recursiveExpand
                 {
                     FatalErrorInFunction
                         << "Expansion ${{ is missing a closing '}}'\n"
-                        << exit(FatalIOError);
+                        << exit(FatalError);
                 }
 
                 ///Info<< "eval <" << out << ">" << endl;

src/finiteArea/fields/faPatchFields/constraint/cyclic/cyclicFaPatchField.C

@@ -62,7 +62,7 @@ Foam::cyclicFaPatchField<Type>::cyclicFaPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/finiteArea/fields/faPatchFields/constraint/empty/emptyFaPatchField.C

@@ -61,7 +61,7 @@ Foam::emptyFaPatchField<Type>::emptyFaPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/finiteArea/fields/faPatchFields/constraint/processor/processorFaPatchField.C

@@ -79,7 +79,7 @@ Foam::processorFaPatchField<Type>::processorFaPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/finiteArea/fields/faPatchFields/constraint/symmetry/symmetryFaPatchField.C

@@ -59,7 +59,7 @@ Foam::symmetryFaPatchField<Type>::symmetryFaPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/finiteVolume/fields/fvPatchFields/constraint/cyclic/cyclicFvPatchField.C

@@ -94,7 +94,7 @@ Foam::cyclicFvPatchField<Type>::cyclicFvPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/finiteVolume/fields/fvPatchFields/constraint/cyclicACMI/cyclicACMIFvPatchField.C

@@ -116,7 +116,7 @@ Foam::cyclicACMIFvPatchField<Type>::cyclicACMIFvPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/finiteVolume/fields/fvPatchFields/constraint/cyclicAMI/cyclicAMIFvPatchField.C

@@ -102,7 +102,7 @@ Foam::cyclicAMIFvPatchField<Type>::cyclicAMIFvPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/finiteVolume/fields/fvPatchFields/constraint/empty/emptyFvPatchField.C

@@ -59,7 +59,7 @@ Foam::emptyFvPatchField<Type>::emptyFvPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/finiteVolume/fields/fvPatchFields/constraint/processor/processorFvPatchField.C

@@ -131,7 +131,7 @@ Foam::processorFvPatchField<Type>::processorFvPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
     if (debug && !ptf.ready())
     {

src/finiteVolume/fields/fvPatchFields/constraint/processorCyclic/processorCyclicFvPatchField.C

@@ -106,7 +106,7 @@ Foam::processorCyclicFvPatchField<Type>::processorCyclicFvPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/finiteVolume/fields/fvPatchFields/constraint/symmetry/symmetryFvPatchField.C

@@ -81,7 +81,7 @@ Foam::symmetryFvPatchField<Type>::symmetryFvPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/finiteVolume/fields/fvPatchFields/constraint/symmetryPlane/symmetryPlaneFvPatchField.C

@@ -61,7 +61,7 @@ Foam::symmetryPlaneFvPatchField<Type>::symmetryPlaneFvPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/finiteVolume/fields/fvPatchFields/constraint/wedge/wedgeFvPatchField.C

@@ -63,7 +63,7 @@ Foam::wedgeFvPatchField<Type>::wedgeFvPatchField
             << "\n    for patch " << p.name()
             << " of field " << this->internalField().name()
             << " in file " << this->internalField().objectPath()
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/functionObjects/field/streamLine/streamLineBase.C

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2015 OpenFOAM Foundation
-    Copyright (C) 2015-2020 OpenCFD Ltd.
+    Copyright (C) 2015-2021 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -911,8 +911,8 @@ bool Foam::functionObjects::streamLineBase::read(const dictionary& dict)
 
         if (dict.found("direction"))
         {
-            FatalIOErrorInFunction(dict) << "Cannot specify both "
+            FatalIOErrorInFunction(dict)
-                << "\"trackForward\" and \"direction\""
+                << "Cannot specify both 'trackForward' and 'direction'" << nl
                 << exit(FatalIOError);
         }
     }
@@ -923,9 +923,9 @@ bool Foam::functionObjects::streamLineBase::read(const dictionary& dict)
     dict.readEntry("lifeTime", lifeTime_);
     if (lifeTime_ < 1)
     {
-        FatalErrorInFunction
+        FatalIOErrorInFunction(dict)
             << "Illegal value " << lifeTime_ << " for lifeTime"
-            << exit(FatalError);
+            << exit(FatalIOError);
     }
 
 

src/fvOptions/sources/derived/actuationDiskSource/actuationDiskSourceTemplates.C

@@ -106,7 +106,7 @@ void Foam::fv::actuationDiskSource::calcFroudeMethod
         FatalErrorInFunction
            << "Cp and Ct must be greater than zero." << nl
            << "Cp = " << Cp << ", Ct = " << Ct
-           << exit(FatalIOError);
+           << exit(FatalError);
     }
 
     // (BJSB:Eq. 3.9)
@@ -213,7 +213,7 @@ void Foam::fv::actuationDiskSource::calcVariableScalingMethod
         FatalErrorInFunction
            << "Cp and Ct must be greater than zero." << nl
            << "Cp = " << Cp << ", Ct = " << Ct
-           << exit(FatalIOError);
+           << exit(FatalError);
     }
 
     // Calibrated thrust/power coeffs from power/thrust curves (LSRMTK:Eq. 6)

src/fvOptions/sources/derived/radialActuationDiskSource/radialActuationDiskSourceTemplates.C

@@ -68,7 +68,7 @@ addRadialActuationDiskAxialInertialResistance
         FatalErrorInFunction
             << "Radial distribution coefficients lead to zero polynomial." << nl
             << "radialCoeffs = " << radialCoeffs_
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 
     // Compute upstream U and rho, spatial-averaged over monitor-region

src/meshTools/sets/cellSources/cylinderAnnulusToCell/cylinderAnnulusToCell.C

@@ -125,9 +125,9 @@ Foam::cylinderAnnulusToCell::cylinderAnnulusToCell
     if (innerRadius_ > radius_)
     {
         FatalErrorInFunction
-            << "inner radius = " << innerRadius_ << "cannot be larger than "
+            << "inner radius = " << innerRadius_ << " cannot be larger than "
             << "outer radius = " << radius_
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/meshTools/sets/cellSources/cylinderToCell/cylinderToCell.C

@@ -114,9 +114,9 @@ Foam::cylinderToCell::cylinderToCell
     if (innerRadius_ > radius_)
     {
         FatalErrorInFunction
-            << "inner radius = " << innerRadius_ << "cannot be larger than "
+            << "inner radius = " << innerRadius_ << " cannot be larger than "
             << "outer radius = " << radius_
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/meshTools/sets/faceSources/cylinderAnnulusToFace/cylinderAnnulusToFace.C

@@ -125,9 +125,9 @@ Foam::cylinderAnnulusToFace::cylinderAnnulusToFace
     if (innerRadius_ > radius_)
     {
         FatalErrorInFunction
-            << "inner radius = " << innerRadius_ << "cannot be larger than "
+            << "inner radius = " << innerRadius_ << " cannot be larger than "
             << "outer radius = " << radius_
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/meshTools/sets/faceSources/cylinderToFace/cylinderToFace.C

@@ -114,9 +114,9 @@ Foam::cylinderToFace::cylinderToFace
     if (innerRadius_ > radius_)
     {
         FatalErrorInFunction
-            << "inner radius = " << innerRadius_ << "cannot be larger than "
+            << "inner radius = " << innerRadius_ << " cannot be larger than "
             << "outer radius = " << radius_
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 }
 

src/parallel/decompose/decompositionMethods/geomDecomp/geomDecomp.C

@@ -60,7 +60,7 @@ void Foam::geomDecomp::setOrder()
                 FatalIOErrorInFunction(decompDict_)
                     << "Illegal decomposition order " << order << nl
                     << "It should only contain x, y or z"
-                    << exit(FatalError);
+                    << exit(FatalIOError);
                 break;
         }
     }
@@ -76,11 +76,11 @@ void Foam::geomDecomp::readCoeffs()
     if (nDomains_ != n_.x()*n_.y()*n_.z())
     {
         // Verify that the input makes sense
-        FatalErrorInFunction
+        FatalIOErrorInFunction(coeffsDict_)
             << "Wrong number of domain divisions in geomDecomp:" << nl
             << "Number of domains    : " << nDomains_ << nl
             << "Wanted decomposition : " << n_
-            << exit(FatalError);
+            << exit(FatalIOError);
     }
     setOrder();
 

src/surfMesh/writers/surfaceWriter.C

@@ -436,7 +436,7 @@ bool Foam::surfaceWriter::checkOpen() const
     {
         FatalErrorInFunction
             << type() << " : Attempted to write without a path" << nl
-            << exit(FatalIOError);
+            << exit(FatalError);
     }
 
     return !outputPath_.empty();

src/thermophysicalModels/specie/reaction/reactionRate/thirdBodyEfficiencies/thirdBodyEfficienciesI.H

@@ -62,7 +62,7 @@ inline Foam::thirdBodyEfficiencies::thirdBodyEfficiencies
     {
         if (coeffs.size() != species_.size())
         {
-            FatalErrorInFunction
+            FatalIOErrorInFunction(dict)
                 << "number of efficiencies = " << coeffs.size()
                 << " is not equat to the number of species " << species_.size()
                 << exit(FatalIOError);