From 87504d501a8abcfa735cb85ede2523335bfc25fa Mon Sep 17 00:00:00 2001 From: mattijs Date: Wed, 2 May 2018 10:55:47 +0100 Subject: [PATCH 01/16] BUG: regionToCell: incorrect indexing of remote values. Fixes #818. --- .../sets/cellSources/regionToCell/regionToCell.C | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/meshTools/sets/cellSources/regionToCell/regionToCell.C b/src/meshTools/sets/cellSources/regionToCell/regionToCell.C index e85fef3cc2..8d5b736b00 100644 --- a/src/meshTools/sets/cellSources/regionToCell/regionToCell.C +++ b/src/meshTools/sets/cellSources/regionToCell/regionToCell.C @@ -3,7 +3,7 @@ \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | \\ / A nd | Copyright (C) 2011-2016 OpenFOAM Foundation - \\/ M anipulation | Copyright (C) 2015 OpenCFD Ltd. + \\/ M anipulation | Copyright (C) 2015-2018 OpenCFD Ltd. ------------------------------------------------------------------------------- License This file is part of OpenFOAM. @@ -90,11 +90,7 @@ void Foam::regionToCell::markRegionFaces { label facei = pp.start()+i; label bFacei = facei-mesh_.nInternalFaces(); - if - ( - selectedCell[faceCells[i]] - != selectedCell[nbrSelected[bFacei]] - ) + if (selectedCell[faceCells[i]] != nbrSelected[bFacei]) { regionFace[facei] = true; } From 4d72c2aac0dcbc20fbf6ec66208ed62c450f29bb Mon Sep 17 00:00:00 2001 From: Mark Olesen Date: Mon, 8 Jan 2018 10:51:00 +0100 Subject: [PATCH 02/16] COMP: incorrect executable path sphereSurfactantFoam (closes #695) --- applications/solvers/finiteArea/sphereSurfactantFoam/Make/files | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/applications/solvers/finiteArea/sphereSurfactantFoam/Make/files b/applications/solvers/finiteArea/sphereSurfactantFoam/Make/files index 574a497031..d10d3fe682 100644 --- a/applications/solvers/finiteArea/sphereSurfactantFoam/Make/files +++ b/applications/solvers/finiteArea/sphereSurfactantFoam/Make/files @@ -1,3 +1,3 @@ surfactantFoam.C -EXE = $(FOAM_USER_APPBIN)/sphereSurfactantFoam +EXE = $(FOAM_APPBIN)/sphereSurfactantFoam From 1513a049e06e4c7465c81d6f8958852614582354 Mon Sep 17 00:00:00 2001 From: mattijs Date: Thu, 10 May 2018 11:12:19 +0100 Subject: [PATCH 03/16] BUG: swirl: decide based on global properties. Fixes #824. --- ...lFlowRateInletVelocityFvPatchVectorField.C | 83 ++++++++++--------- 1 file changed, 44 insertions(+), 39 deletions(-) diff --git a/src/finiteVolume/fields/fvPatchFields/derived/swirlFlowRateInletVelocity/swirlFlowRateInletVelocityFvPatchVectorField.C b/src/finiteVolume/fields/fvPatchFields/derived/swirlFlowRateInletVelocity/swirlFlowRateInletVelocityFvPatchVectorField.C index ebe4ebdd58..89c1ce0008 100644 --- a/src/finiteVolume/fields/fvPatchFields/derived/swirlFlowRateInletVelocity/swirlFlowRateInletVelocityFvPatchVectorField.C +++ b/src/finiteVolume/fields/fvPatchFields/derived/swirlFlowRateInletVelocity/swirlFlowRateInletVelocityFvPatchVectorField.C @@ -75,7 +75,7 @@ swirlFlowRateInletVelocityFvPatchVectorField dict.lookupOrDefault ( "axis", - patch().size() + returnReduce(patch().size(), maxOp