STYLE: mark compatibility level for keyword redirectType (issue #912)

- was replaced with "name" in 1706

src/OpenFOAM/fields/pointPatchFields/derived/codedFixedValue/codedFixedValuePointPatchField.C

@@ -217,12 +217,7 @@ Foam::codedFixedValuePointPatchField<Type>::codedFixedValuePointPatchField
     fixedValuePointPatchField<Type>(p, iF, dict, valueRequired),
     codedBase(),
     dict_(dict),
-    name_
+    name_(dict.getCompat<word>("name", {{"redirectType", 1706}})),
-    (
-        dict.found("redirectType")
-      ? dict.lookup("redirectType")
-      : dict.lookup("name")
-    ),
     redirectPatchFieldPtr_()
 {
     updateLibrary(name_);

src/dynamicMesh/motionSolvers/displacement/codedPoints0/codedPoints0MotionSolver.C

@@ -120,15 +120,7 @@ Foam::codedPoints0MotionSolver::codedPoints0MotionSolver
     motionSolver(mesh, dict, typeName),
     codedBase()
 {
-    // Backward compatibility
+    dict.readCompat<word>("name", {{"redirectType", 1706}}, name_);
-    if (dict.found("redirectType"))
-    {
-        dict.lookup("redirectType") >> name_;
-    }
-    else
-    {
-        dict.lookup("name") >> name_;
-    }
 
     updateLibrary(name_);
     redirectMotionSolver();

src/finiteVolume/fields/fvPatchFields/derived/codedFixedValue/codedFixedValueFvPatchField.C

@@ -215,12 +215,7 @@ Foam::codedFixedValueFvPatchField<Type>::codedFixedValueFvPatchField
     fixedValueFvPatchField<Type>(p, iF, dict),
     codedBase(),
     dict_(dict),
-    name_
+    name_(dict.getCompat<word>("name", {{"redirectType", 1706}})),
-    (
-        dict.found("redirectType")
-      ? dict.lookup("redirectType")
-      : dict.lookup("name")
-    ),
     redirectPatchFieldPtr_()
 {
     updateLibrary(name_);

src/finiteVolume/fields/fvPatchFields/derived/codedMixed/codedMixedFvPatchField.C

@@ -215,12 +215,7 @@ Foam::codedMixedFvPatchField<Type>::codedMixedFvPatchField
     mixedFvPatchField<Type>(p, iF, dict),
     codedBase(),
     dict_(dict),
-    name_
+    name_(dict.getCompat<word>("name", {{"redirectType", 1706}})),
-    (
-        dict.found("redirectType")
-      ? dict.lookup("redirectType")
-      : dict.lookup("name")
-    ),
     redirectPatchFieldPtr_()
 {
     updateLibrary(name_);

src/functionObjects/utilities/codedFunctionObject/codedFunctionObject.C

@@ -191,15 +191,7 @@ bool Foam::functionObjects::codedFunctionObject::read(const dictionary& dict)
 {
     functionObject::read(dict);
 
-    // Backward compatibility
+    dict.readCompat<word>("name", {{"redirectType", 1706}}, name_);
-    if (dict.found("redirectType"))
-    {
-        dict.lookup("redirectType") >> name_;
-    }
-    else
-    {
-        dict.lookup("name") >> name_;
-    }
 
     const entry* dataPtr = dict.lookupEntryPtr
     (

src/fvOptions/sources/general/codedSource/CodedSourceIO.C

@@ -36,15 +36,7 @@ bool Foam::fv::CodedSource<Type>::read(const dictionary& dict)
         coeffs_.lookup("fields") >> fieldNames_;
         applied_.setSize(fieldNames_.size(), false);
 
-        // Backward compatibility
+        dict.readCompat<word>("name", {{"redirectType", 1706}}, name_);
-        if (coeffs_.found("redirectType"))
-        {
-            coeffs_.lookup("redirectType") >> name_;
-        }
-        else
-        {
-            coeffs_.lookup("name") >> name_;
-        }
 
         // Code snippets
         {

tutorials/basic/potentialFoam/cylinder/system/controlDict

@@ -49,13 +49,9 @@ functions
 {
     error
     {
-        // Load the library containing the 'coded' functionObject
+        name    error;
-        libs            ("libutilityFunctionObjects.so");
+        type    coded;
-
+        libs    ("libutilityFunctionObjects.so");
-        type coded;
-
-        // Name of on-the-fly generated functionObject
-        name error;
 
         codeEnd
         #{

tutorials/combustion/XiDyMFoam/oscillatingCylinder/0/pointDisplacementy

@@ -23,13 +23,13 @@ boundaryField
 {
     walls
     {
-        type            fixedValue;
+        type    fixedValue;
-        value           $internalField;
+        value   $internalField;
     }
     cylinder
     {
-        type            codedFixedValue;
+        name    pointDisplacementy_cylinder;
-        name            pointDisplacementy_cylinder;
+        type    codedFixedValue;
         code
         #{
             const scalar t = this->db().time().value();
@@ -37,21 +37,21 @@ boundaryField
             const scalar f = 200;
             operator==(a*sin(constant::mathematical::twoPi*f*t));
         #};
-        value           $internalField;
+        value   $internalField;
     }
     "inlet.*"
     {
-        type            fixedValue;
+        type    fixedValue;
-        value           $internalField;
+        value   $internalField;
     }
     outlet
     {
-        type            fixedValue;
+        type    fixedValue;
-        value           $internalField;
+        value   $internalField;
     }
     frontAndBack
     {
-        type            empty;
+        type    empty;
     }
 }
 

tutorials/combustion/XiEngineFoam/kivaTest/system/controlDict

@@ -55,9 +55,9 @@ functions
 {
     timeStep
     {
-        type coded;
+        name    setDeltaT;
-        libs            ("libutilityFunctionObjects.so");
+        type    coded;
-        name setDeltaT;
+        libs    ("libutilityFunctionObjects.so");
 
         code
         #{

tutorials/compressible/rhoPimpleAdiabaticFoam/rutlandVortex2D/system/preProcess

@@ -19,10 +19,10 @@ functions
 {
     createVortex
     {
-        type            coded;
+        name    createVortices;
-        libs            ("libutilityFunctionObjects.so");
+        type    coded;
-        name            createVortices;
+        libs    ("libutilityFunctionObjects.so");
-        enabled         yes;
+        enabled yes;
 
         codeInclude
         #{

tutorials/incompressible/simpleFoam/pipeCyclic/0.orig/U

@@ -24,8 +24,8 @@ boundaryField
 
     inlet
     {
-        type    codedFixedValue;
         name    swirl;
+        type    codedFixedValue;
 
         code
         #{

tutorials/multiphase/reactingTwoPhaseEulerFoam/laminar/bubbleColumnEvaporating/system/continuityFunctions

@@ -8,8 +8,8 @@
 
 inletMassFlowRate
 {
-    type            surfaceFieldValue;
+    type    surfaceFieldValue;
-    libs            ("libfieldFunctionObjects.so");
+    libs    ("libfieldFunctionObjects.so");
 
     fields
     (
@@ -31,8 +31,8 @@ inletMassFlowRate
 
 outletMassFlowRate
 {
-    type            surfaceFieldValue;
+    type    surfaceFieldValue;
-    libs            ("libfieldFunctionObjects.so");
+    libs    ("libfieldFunctionObjects.so");
 
     fields
     (
@@ -54,9 +54,9 @@ outletMassFlowRate
 
 totalMass
 {
-    type            coded;
-    libs            ("libutilityFunctionObjects.so");
     name    error;
+    type    coded;
+    libs    ("libutilityFunctionObjects.so");
 
     code
     #{