diff --git a/.gitignore b/.gitignore index a95cd603ba..b124c8d887 100644 --- a/.gitignore +++ b/.gitignore @@ -41,10 +41,6 @@ SunOS*Gcc*/ # reinstate wmake/rules that might look like build folders !wmake/rules/*/ -# but do continue to ignore the derived wmake files -wmake/rules/*/dirToString -wmake/rules/*/wmkdep - # doxygen generated documentation doc/[Dd]oxygen/html doc/[Dd]oxygen/latex diff --git a/bin/buildParaView b/bin/buildParaView index 622169e012..c23644e804 100755 --- a/bin/buildParaView +++ b/bin/buildParaView @@ -85,14 +85,14 @@ For finer control, the build stages can be also selected individually -make -makedoc -install - [-envpath] alter absolute paths in CMake files to use env variables + -envpath alter absolute paths in CMake files to use env variables Build and install paraview-$ParaView_VERSION - run from folder above the ParaView source folder or place the ParaView source under \$WM_THIRD_PARTY_DIR ($WM_THIRD_PARTY_DIR) USAGE - exit 1 + exit 1 } #------------------------------------------------------------------------------ @@ -150,8 +150,7 @@ do runINSTALL=true shift ;; - -envpath) # optional: change cmake files to use env variables - # This is now the default behaviour + -envpath) # stage 5: change cmake files to use env variables runCONFIG=false runMAKE=false runMAKEDOC=false diff --git a/bin/foamPack b/bin/foamPack index 5f42ebbb2b..3f35f5b57d 100755 --- a/bin/foamPack +++ b/bin/foamPack @@ -86,9 +86,10 @@ find -H $packDir \ -a ! -name "log[0-9]*" \ -a ! -name "so_locations" \ | sed \ - -e "\@$packDir/.git/@d" \ -e "\@$packDir/lib/@d" \ - -e '\@applications/bin/@d' \ + -e '\@/\.git/@d' \ + -e '\@applications/bin/@d' \ + -e '\@wmake/utilbin/@d' \ -e '\@/t/@d' \ -e '\@Make[.A-Za-z]*/[^/]*/@d' \ -e '\@doc/[Dd]oxygen/html@d' \ @@ -100,7 +101,7 @@ find -H $packDir \ tar czpf $packFile --files-from $tmpFile -if [ $? = 0 ] +if [ $? -eq 0 ] then echo "Finished packing and compressing $packDir into file $packFile" else diff --git a/bin/foamPackBin b/bin/foamPackBin index 00ef0c5af3..5a60b405a9 100755 --- a/bin/foamPackBin +++ b/bin/foamPackBin @@ -33,14 +33,17 @@ if [ $# -eq 0 ] then - echo "Error: architecture type expected, exiting" - echo - echo "Usage : ${0##*/} [outputDir]" - echo - exit 1 + echo "Error: architecture type expected, exiting" + echo + echo "Usage : ${0##*/} [outputDir]" + echo + exit 1 fi arch=$1 +# base arch (w/o precision, optimization, etc) +baseArch=$(echo "$arch" | sed -e 's@[DS]P.*$@@') + timeStamp=$(date +%Y-%m-%d) packDir=$WM_PROJECT-$WM_PROJECT_VERSION packFile=${packDir}.${arch}_${timeStamp}.gtgz @@ -48,49 +51,50 @@ packFile=${packDir}.${arch}_${timeStamp}.gtgz # add optional output directory if [ -d "$2" ] then - packFile="$2/$packFile" + packFile="$2/$packFile" fi if [ -f $packFile ] then - echo "Error: $packFile already exists" - exit 1 + echo "Error: $packFile already exists" + exit 1 fi # check for essential directories for dir in $packDir $packDir/lib/$arch $packDir/applications/bin/$arch do - if [ ! -d $dir ] - then - echo "Error: directory $dir does not exist" - exit 1 - fi + if [ ! -d $dir ] + then + echo "Error: directory $dir does not exist" + exit 1 + fi done # get list of directories dirList=$( - for dir in \ - $packDir/lib/$arch \ - $packDir/applications/bin/$arch \ - $packDir/wmake/rules \ - ; - do - [ -d $dir ] && echo $dir - done + for dir in \ + $packDir/lib/$arch \ + $packDir/applications/bin/$arch \ + $packDir/wmake/rules \ + $packDir/wmake/utilbin/$baseArch \ + ; + do + [ -d $dir ] && echo $dir + done ) echo -echo "Packing $arch port of $packDir into $packFile" +echo "Packing $arch ($baseArch) port of $packDir into $packFile" echo tar czpf $packFile $dirList -if [ $? = 0 ] +if [ $? -eq 0 ] then - echo "Finished packing and compressing file $packFile" + echo "Finished packing and compressing file $packFile" else - echo "Error: failure packing $packFile" - rm -f $packFile 2>/dev/null + echo "Error: failure packing $packFile" + rm -f $packFile 2>/dev/null fi #------------------------------------------------------------------------------ diff --git a/bin/foamPackBinAll b/bin/foamPackBinAll index 01555787cb..57673e9803 100755 --- a/bin/foamPackBinAll +++ b/bin/foamPackBinAll @@ -34,14 +34,14 @@ packDir=$WM_PROJECT-$WM_PROJECT_VERSION if [ ! -d $packDir ] then - echo "Error: directory $packDir does not exist" - exit 1 + echo "Error: directory $packDir does not exist" + exit 1 fi # obtain arch types from lib/ for bin in $packDir/lib/* do - foamPackBin ${bin##*/} $@ + foamPackBin ${bin##*/} $@ done #------------------------------------------------------------------------------ diff --git a/bin/foamPackDoxygen b/bin/foamPackDoxygen index efdcdacc09..4503470846 100755 --- a/bin/foamPackDoxygen +++ b/bin/foamPackDoxygen @@ -41,7 +41,7 @@ Usage: ${0##*/} [-prefix DIR] [-o outputDir] Packs and compresses the OpenFOAM doxygen html for release USAGE - exit 1 + exit 1 } unset prefix outputDir @@ -87,16 +87,16 @@ fi # if [ -d "$outputDir" ] then - packFile="$outputDir/$packDir$packTag" + packFile="$outputDir/$packDir$packTag" else - packFile="$packDir$packTag" + packFile="$packDir$packTag" fi if [ -f $packFile ] then - echo "Error: $packFile already exists" - exit 1 + echo "Error: $packFile already exists" + exit 1 fi # Pack and compress the packFile using GNU tar @@ -107,16 +107,16 @@ echo if [ -n "$prefix" ] then - tar czpf $packFile --transform="s@^@$prefix/@" doc/Doxygen/html + tar czpf $packFile --transform="s@^@$prefix/@" doc/Doxygen/html else - tar czpf $packFile $packDir/doc/Doxygen/html + tar czpf $packFile $packDir/doc/Doxygen/html fi -if [ $? = 0 ] +if [ $? -eq 0 ] then - echo "Finished packing doxygen html into file $packFile" + echo "Finished packing doxygen html into file $packFile" else - echo "Error: failure packing doxygen html file $packFile" + echo "Error: failure packing doxygen html file $packFile" fi #------------------------------------------------------------------------------ diff --git a/bin/foamPackGeneral b/bin/foamPackGeneral index 3da4197226..e55d834bce 100755 --- a/bin/foamPackGeneral +++ b/bin/foamPackGeneral @@ -37,20 +37,20 @@ packFile=${packDir}.General_${timeStamp}.gtgz if [ ! -d $packDir ] then - echo "Error: directory $packDir does not exist" - exit 1 + echo "Error: directory $packDir does not exist" + exit 1 fi # add optional output directory if [ -d "$1" ] then - packFile="$1/$packFile" + packFile="$1/$packFile" fi if [ -f $packFile ] then - echo "Error: $packFile already exists" - exit 1 + echo "Error: $packFile already exists" + exit 1 fi # Create time stamp file @@ -62,7 +62,7 @@ echo $timeStamp 2>/dev/null > $packDir/.timeStamp # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ echo -echo "Packing $packDir into $packFile" +echo "Packing $packDir source files into $packFile" echo foamPackSource $packDir $packFile diff --git a/bin/foamPackSource b/bin/foamPackSource index c4d0fc7eb4..b5e34c8a04 100755 --- a/bin/foamPackSource +++ b/bin/foamPackSource @@ -35,12 +35,12 @@ tmpFile=${TMPDIR:-/tmp}/foamPackFiles.$$ if [ $# -ne 2 ] then - echo "Usage : ${0##*/} directory tarFile" - echo "" - echo "Packs all .C and .H files and Make/options and Make/files into" - echo "" - echo "" - exit 1 + echo "Usage : ${0##*/} directory tarFile" + echo "" + echo "Packs all .C and .H files and Make/options and Make/files into" + echo "" + echo "" + exit 1 fi # canonical form (no double and no trailing dashes) @@ -49,14 +49,14 @@ packFile=$2 if [ ! -d $packDir ] then - echo "Error: directory $packDir does not exist" - exit 1 + echo "Error: directory $packDir does not exist" + exit 1 fi if [ -f $packFile ] then - echo "Error: $packFile already exists" - exit 1 + echo "Error: $packFile already exists" + exit 1 fi # Clean up on termination and on Ctrl-C @@ -78,24 +78,29 @@ find -H $packDir \ -a ! -name "log[0-9]*" \ -a ! -name "libccmio*" \ | sed \ - -e "\@$packDir/.git/@d" \ - -e "\@/.tags/@d" \ -e "\@$packDir/lib/@d" \ - -e "\@libccmio.*/@d" \ + -e '\@/\.git/@d' \ + -e '\@/\.tags/@d' \ -e '\@applications/bin/@d' \ + -e '\@wmake/utilbin/@d' \ -e '\@/t/@d' \ -e '\@/Make[.A-Za-z]*/[^/]*/@d'\ -e '\@/platforms/@d' \ + -e '\@libccmio.*/@d' \ > $tmpFile + +# provide some feedback +wc $tmpFile | awk '{print "Packing",$1,"files - this could take some time ..."}' + tar czpf $packFile --files-from $tmpFile -if [ $? = 0 ] +if [ $? -eq 0 ] then - echo "Finished packing and compressing $packDir into file $packFile" + echo "Finished packing and compressing $packDir into file $packFile" else - echo "Error: failure packing $packDir into file $packFile" - rm -f $packFile 2>/dev/null + echo "Error: failure packing $packDir into file $packFile" + rm -f $packFile 2>/dev/null fi #------------------------------------------------------------------------------ diff --git a/bin/foamPackThirdPartyBin b/bin/foamPackThirdPartyBin index 1e128db1da..b9363f6874 100755 --- a/bin/foamPackThirdPartyBin +++ b/bin/foamPackThirdPartyBin @@ -31,36 +31,43 @@ # #------------------------------------------------------------------------------ -if [ $# = 0 ] +if [ $# -eq 0 ] then - echo "Error: archOptions type expected, exiting" - echo - echo "Usage : ${0##*/} [outputDir]" - echo - exit 1 + echo "Error: archOptions type expected, exiting" + echo + echo "Usage : ${0##*/} [outputDir]" + echo + exit 1 fi archOptions=$1 arch=${archOptions%%G*} # TODO: works for Gcc only -arch3264=$(echo "$arch" | sed 's@64@-64@') +arch3264=$(echo "$arch" | sed -e 's@64@-64@') echo "archOptions=$archOptions" echo "arch=$arch" echo "arch3264=$arch3264" timeStamp=$(date +%Y-%m-%d) -packDir=ThirdParty +packDir=${WM_THIRD_PARTY_DIR:-ThirdParty} +packDir=${packDir##*/} packFile=${packDir}.${archOptions}_${timeStamp}.gtgz +if [ ! -d $packDir ] +then + echo "Error: directory $packDir does not exist" + exit 1 +fi + # add optional output directory if [ -d "$2" ] then - packFile="$2/$packFile" + packFile="$2/$packFile" fi if [ -f $packFile ] then - echo "Error: $packFile already exists" - exit 1 + echo "Error: $packFile already exists" + exit 1 fi # get list of directories @@ -71,12 +78,12 @@ echo tar czpf $packFile $dirList -if [ $? = 0 ] +if [ $? -eq 0 ] then - echo "Finished packing and compressing file $packFile" + echo "Finished packing and compressing file $packFile" else - echo "Error: failure packing $packFile" - rm -f $packFile 2>/dev/null + echo "Error: failure packing $packFile" + rm -f $packFile 2>/dev/null fi #------------------------------------------------------------------------------ diff --git a/bin/foamPackThirdPartyGeneral b/bin/foamPackThirdPartyGeneral index 845b2bfa47..a690f7f448 100755 --- a/bin/foamPackThirdPartyGeneral +++ b/bin/foamPackThirdPartyGeneral @@ -32,25 +32,26 @@ #------------------------------------------------------------------------------ timeStamp=$(date +%Y-%m-%d) -packDir=ThirdParty +packDir=${WM_THIRD_PARTY_DIR:-ThirdParty} +packDir=${packDir##*/} packFile=${packDir}.General_${timeStamp}.gtgz if [ ! -d $packDir ] then - echo "Error: directory $packDir does not exist" - exit 1 + echo "Error: directory $packDir does not exist" + exit 1 fi # add optional output directory if [ -d "$1" ] then - packFile="$1/$packFile" + packFile="$1/$packFile" fi if [ -f $packFile ] then - echo "Error: $packFile already exists" - exit 1 + echo "Error: $packFile already exists" + exit 1 fi # Create time stamp file @@ -62,7 +63,7 @@ echo $timeStamp 2>/dev/null > $packDir/.timeStamp # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ echo -echo "Packing $packDir into $packFile" +echo "Packing $packDir source files into $packFile" echo foamPackSource $packDir $packFile diff --git a/src/thermophysicalModels/basic/rhoThermo/.directory b/src/thermophysicalModels/basic/rhoThermo/.directory deleted file mode 100644 index 72608b79a0..0000000000 --- a/src/thermophysicalModels/basic/rhoThermo/.directory +++ /dev/null @@ -1,5 +0,0 @@ -[Dolphin] -AdditionalInfo=3 -SortOrder=0 -Timestamp=2009,6,10,15,58,20 -ViewMode=1 diff --git a/src/turbulenceModels/compressible/LES/LESModel/LESModel.H b/src/turbulenceModels/compressible/LES/LESModel/LESModel.H index ca87dd64ed..3012b4124a 100644 --- a/src/turbulenceModels/compressible/LES/LESModel/LESModel.H +++ b/src/turbulenceModels/compressible/LES/LESModel/LESModel.H @@ -33,13 +33,13 @@ Class Foam::compressible::LESModel Description - Class for all compressible flow LES SGS models. + Base class for all compressible flow LES SGS models. - This class defines the basic interface for a compressible flow SGS model, - and encapsulates data of value to all possible models. In particular - this includes references to all the dependent fields (rho, U, phi), - the physical viscosity mu, and the LESProperties dictionary, - which contains the model selection and model coefficients. + This class defines the basic interface for a compressible flow SGS + model, and encapsulates data of value to all possible models. + In particular this includes references to all the dependent fields + (rho, U, phi), the physical viscosity mu, and the LESProperties + dictionary, which contains the model selection and model coefficients. SourceFiles LESModel.C diff --git a/src/turbulenceModels/compressible/RAS/derivedFvPatchFields/wallFunctions/kQRWallFunctions/kQRWallFunction/kQRWallFunctionFvPatchField.C b/src/turbulenceModels/compressible/RAS/derivedFvPatchFields/wallFunctions/kQRWallFunctions/kQRWallFunction/kQRWallFunctionFvPatchField.C index d0d1d1ef35..8286c1b149 100644 --- a/src/turbulenceModels/compressible/RAS/derivedFvPatchFields/wallFunctions/kQRWallFunctions/kQRWallFunction/kQRWallFunctionFvPatchField.C +++ b/src/turbulenceModels/compressible/RAS/derivedFvPatchFields/wallFunctions/kQRWallFunctions/kQRWallFunction/kQRWallFunctionFvPatchField.C @@ -51,8 +51,8 @@ void kQRWallFunctionFvPatchField::checkType() << "Invalid wall function specification" << nl << " Patch type for patch " << this->patch().name() << " must be wall" << nl - << " Current patch type is " << this->patch().type() - << nl << endl << abort(FatalError); + << " Current patch type is " << this->patch().type() << nl << endl + << abort(FatalError); } } diff --git a/src/turbulenceModels/compressible/RAS/laminar/laminar.H b/src/turbulenceModels/compressible/RAS/laminar/laminar.H index cfd5e57352..af1f5e2bb2 100644 --- a/src/turbulenceModels/compressible/RAS/laminar/laminar.H +++ b/src/turbulenceModels/compressible/RAS/laminar/laminar.H @@ -30,12 +30,11 @@ Description SourceFiles laminar.C - laminarCorrect.C \*---------------------------------------------------------------------------*/ -#ifndef compressibleLaminar_H -#define compressibleLaminar_H +#ifndef compressibleRasLaminar_H +#define compressibleRasLaminar_H #include "RASModel.H" @@ -82,42 +81,42 @@ public: // Member Functions //- Return the turbulence viscosity, i.e. 0 for laminar flow - tmp mut() const; + virtual tmp mut() const; //- Return the effective viscosity, i.e. the laminar viscosity - tmp muEff() const + virtual tmp muEff() const { return tmp(new volScalarField("muEff", mu())); } //- Return the effective turbulent thermal diffusivity, // i.e. the laminar thermal diffusivity - tmp alphaEff() const + virtual tmp alphaEff() const { return tmp(new volScalarField("alphaEff", alpha())); } //- Return the turbulence kinetic energy, i.e. 0 for laminar flow - tmp k() const; + virtual tmp k() const; //- Return the turbulence kinetic energy dissipation rate, // i.e. 0 for laminar flow - tmp epsilon() const; + virtual tmp epsilon() const; //- Return the Reynolds stress tensor, i.e. 0 for laminar flow - tmp R() const; + virtual tmp R() const; //- Return the effective stress tensor, i.e. the laminar stress - tmp devRhoReff() const; + virtual tmp devRhoReff() const; //- Return the source term for the momentum equation - tmp divDevRhoReff(volVectorField& U) const; + virtual tmp divDevRhoReff(volVectorField& U) const; //- Correct the laminar viscosity - void correct(); + virtual void correct(); //- Read RASProperties dictionary - bool read(); + virtual bool read(); }; diff --git a/src/turbulenceModels/compressible/turbulenceModel/Make/options b/src/turbulenceModels/compressible/turbulenceModel/Make/options index 65d3ed1e01..075a03796e 100644 --- a/src/turbulenceModels/compressible/turbulenceModel/Make/options +++ b/src/turbulenceModels/compressible/turbulenceModel/Make/options @@ -1,5 +1,6 @@ EXE_INC = \ -I$(LIB_SRC)/finiteVolume/lnInclude \ + -I$(LIB_SRC)/turbulenceModels \ -I$(LIB_SRC)/thermophysicalModels/basic/lnInclude LIB_LIBS = \ diff --git a/src/turbulenceModels/compressible/turbulenceModel/laminar/laminar.C b/src/turbulenceModels/compressible/turbulenceModel/laminar/laminar.C index c4213fdd8a..4a391c3db5 100644 --- a/src/turbulenceModels/compressible/turbulenceModel/laminar/laminar.C +++ b/src/turbulenceModels/compressible/turbulenceModel/laminar/laminar.C @@ -52,10 +52,10 @@ laminar::laminar const volScalarField& rho, const volVectorField& U, const surfaceScalarField& phi, - const basicThermo& thermoPhysicalModel + const basicThermo& thermophysicalModel ) : - turbulenceModel(rho, U, phi, thermoPhysicalModel) + turbulenceModel(rho, U, phi, thermophysicalModel) {} @@ -66,10 +66,10 @@ autoPtr laminar::New const volScalarField& rho, const volVectorField& U, const surfaceScalarField& phi, - const basicThermo& thermoPhysicalModel + const basicThermo& thermophysicalModel ) { - return autoPtr(new laminar(rho, U, phi, thermoPhysicalModel)); + return autoPtr(new laminar(rho, U, phi, thermophysicalModel)); } @@ -96,18 +96,6 @@ tmp laminar::mut() const } -tmp laminar::muEff() const -{ - return tmp(new volScalarField("muEff", mu())); -} - - -tmp laminar::alphaEff() const -{ - return tmp(new volScalarField("alphaEff", alpha())); -} - - tmp laminar::k() const { return tmp diff --git a/src/turbulenceModels/compressible/turbulenceModel/laminar/laminar.H b/src/turbulenceModels/compressible/turbulenceModel/laminar/laminar.H index 7931e45bee..d4379bfb2e 100644 --- a/src/turbulenceModels/compressible/turbulenceModel/laminar/laminar.H +++ b/src/turbulenceModels/compressible/turbulenceModel/laminar/laminar.H @@ -33,8 +33,8 @@ SourceFiles \*---------------------------------------------------------------------------*/ -#ifndef laminar_H -#define laminar_H +#ifndef compressibleLaminar_H +#define compressibleLaminar_H #include "turbulenceModel.H" @@ -67,7 +67,7 @@ public: const volScalarField& rho, const volVectorField& U, const surfaceScalarField& phi, - const basicThermo& thermoPhysicalModel + const basicThermo& thermophysicalModel ); @@ -79,7 +79,7 @@ public: const volScalarField& rho, const volVectorField& U, const surfaceScalarField& phi, - const basicThermo& thermoPhysicalModel + const basicThermo& thermophysicalModel ); @@ -94,10 +94,17 @@ public: virtual tmp mut() const; //- Return the effective viscosity, i.e. the laminar viscosity - virtual tmp muEff() const; + virtual tmp muEff() const + { + return tmp(new volScalarField("muEff", mu())); + } - //- Return the effective turbulent thermal diffusivity - virtual tmp alphaEff() const; + //- Return the effective turbulent thermal diffusivity, + // i.e. the laminar thermal diffusivity + virtual tmp alphaEff() const + { + return tmp(new volScalarField("alphaEff", alpha())); + } //- Return the turbulence kinetic energy, i.e. 0 for laminar flow virtual tmp k() const; @@ -109,7 +116,7 @@ public: //- Return the Reynolds stress tensor, i.e. 0 for laminar flow virtual tmp R() const; - //- Return the effective stress tensor including the laminar stress + //- Return the effective stress tensor, i.e. the laminar stress virtual tmp devRhoReff() const; //- Return the source term for the momentum equation diff --git a/src/turbulenceModels/compressible/turbulenceModel/turbulenceModel.C b/src/turbulenceModels/compressible/turbulenceModel/turbulenceModel.C index 18f61ea286..15cce81cc1 100644 --- a/src/turbulenceModels/compressible/turbulenceModel/turbulenceModel.C +++ b/src/turbulenceModels/compressible/turbulenceModel/turbulenceModel.C @@ -117,12 +117,6 @@ autoPtr turbulenceModel::New } -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -turbulenceModel::~turbulenceModel() -{} - - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // void turbulenceModel::correct() diff --git a/src/turbulenceModels/compressible/turbulenceModel/turbulenceModel.H b/src/turbulenceModels/compressible/turbulenceModel/turbulenceModel.H index a3cce25b51..97638e5e49 100644 --- a/src/turbulenceModels/compressible/turbulenceModel/turbulenceModel.H +++ b/src/turbulenceModels/compressible/turbulenceModel/turbulenceModel.H @@ -65,7 +65,7 @@ namespace compressible { /*---------------------------------------------------------------------------*\ - Class turbulenceModel Declaration + Class turbulenceModel Declaration \*---------------------------------------------------------------------------*/ class turbulenceModel @@ -144,7 +144,8 @@ public: //- Destructor - virtual ~turbulenceModel(); + virtual ~turbulenceModel() + {} // Member Functions diff --git a/src/turbulenceModels/incompressible/LES/LESModel/LESModel.C b/src/turbulenceModels/incompressible/LES/LESModel/LESModel.C index a845089e33..3e3c952ffc 100644 --- a/src/turbulenceModels/incompressible/LES/LESModel/LESModel.C +++ b/src/turbulenceModels/incompressible/LES/LESModel/LESModel.C @@ -124,8 +124,8 @@ autoPtr LESModel::New { FatalErrorIn ( - "LESModel::select(const volVectorField&, const " - "surfaceScalarField&, transportModel&)" + "LESModel::New(const volVectorField& U, const " + "surfaceScalarField& phi, transportModel&)" ) << "Unknown LESModel type " << modelName << endl << endl << "Valid LESModel types are :" << endl @@ -137,12 +137,6 @@ autoPtr LESModel::New } -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -LESModel::~LESModel() -{} - - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // void LESModel::correct(const tmp&) diff --git a/src/turbulenceModels/incompressible/LES/LESModel/LESModel.H b/src/turbulenceModels/incompressible/LES/LESModel/LESModel.H index e784535b73..49fe52c454 100644 --- a/src/turbulenceModels/incompressible/LES/LESModel/LESModel.H +++ b/src/turbulenceModels/incompressible/LES/LESModel/LESModel.H @@ -35,10 +35,10 @@ Description Base class for all incompressible flow LES SGS models. This class defines the basic interface for an incompressible flow SGS - model, and encapsulates data of value to all possible models. In - particular this includes references to all the dependent fields (U, - phi), the physical viscosity nu, and the LESProperties - dictionary which contains the model selection and model coefficients. + model, and encapsulates data of value to all possible models. + In particular this includes references to all the dependent fields + (U, phi), the physical viscosity nu, and the LESProperties + dictionary, which contains the model selection and model coefficients. SourceFiles LESModel.C @@ -151,7 +151,8 @@ public: //- Destructor - virtual ~LESModel(); + virtual ~LESModel() + {} // Member Functions @@ -240,14 +241,14 @@ public: } - //- Correct Eddy-Viscosity and related properties - virtual void correct(const tmp& gradU); - //- Correct Eddy-Viscosity and related properties. // This calls correct(const tmp& gradU) by supplying // gradU calculated locally. void correct(); + //- Correct Eddy-Viscosity and related properties + virtual void correct(const tmp& gradU); + //- Read LESProperties dictionary virtual bool read() = 0; }; diff --git a/src/turbulenceModels/incompressible/LES/dynOneEqEddy/dynOneEqEddy.C b/src/turbulenceModels/incompressible/LES/dynOneEqEddy/dynOneEqEddy.C index 4342712d80..4aadf02bf2 100644 --- a/src/turbulenceModels/incompressible/LES/dynOneEqEddy/dynOneEqEddy.C +++ b/src/turbulenceModels/incompressible/LES/dynOneEqEddy/dynOneEqEddy.C @@ -133,12 +133,6 @@ dynOneEqEddy::dynOneEqEddy } -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -dynOneEqEddy::~dynOneEqEddy() -{} - - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // void dynOneEqEddy::correct(const tmp& gradU) diff --git a/src/turbulenceModels/incompressible/LES/dynOneEqEddy/dynOneEqEddy.H b/src/turbulenceModels/incompressible/LES/dynOneEqEddy/dynOneEqEddy.H index 15f0ac56d1..9b1a4064d6 100644 --- a/src/turbulenceModels/incompressible/LES/dynOneEqEddy/dynOneEqEddy.H +++ b/src/turbulenceModels/incompressible/LES/dynOneEqEddy/dynOneEqEddy.H @@ -116,7 +116,8 @@ public: //- Destructor - virtual ~dynOneEqEddy(); + virtual ~dynOneEqEddy() + {} // Member Functions diff --git a/src/turbulenceModels/incompressible/LES/dynSmagorinsky/dynSmagorinsky.C b/src/turbulenceModels/incompressible/LES/dynSmagorinsky/dynSmagorinsky.C index e260a6d16d..fedd18ee7d 100644 --- a/src/turbulenceModels/incompressible/LES/dynSmagorinsky/dynSmagorinsky.C +++ b/src/turbulenceModels/incompressible/LES/dynSmagorinsky/dynSmagorinsky.C @@ -124,12 +124,6 @@ dynSmagorinsky::dynSmagorinsky } -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -dynSmagorinsky::~dynSmagorinsky() -{} - - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // void dynSmagorinsky::correct(const tmp& gradU) diff --git a/src/turbulenceModels/incompressible/LES/dynSmagorinsky/dynSmagorinsky.H b/src/turbulenceModels/incompressible/LES/dynSmagorinsky/dynSmagorinsky.H index 93e85a808b..b0bd7868f0 100644 --- a/src/turbulenceModels/incompressible/LES/dynSmagorinsky/dynSmagorinsky.H +++ b/src/turbulenceModels/incompressible/LES/dynSmagorinsky/dynSmagorinsky.H @@ -125,7 +125,8 @@ public: //- Destructor - virtual ~dynSmagorinsky(); + virtual ~dynSmagorinsky() + {} // Member Functions diff --git a/src/turbulenceModels/incompressible/LES/laminar/laminar.H b/src/turbulenceModels/incompressible/LES/laminar/laminar.H index 45500d6172..b428f102ab 100644 --- a/src/turbulenceModels/incompressible/LES/laminar/laminar.H +++ b/src/turbulenceModels/incompressible/LES/laminar/laminar.H @@ -34,8 +34,8 @@ SourceFiles \*---------------------------------------------------------------------------*/ -#ifndef laminar_H -#define laminar_H +#ifndef lesLaminar_H +#define lesLaminar_H #include "LESModel.H" #include "volFields.H" diff --git a/src/turbulenceModels/incompressible/LES/locDynOneEqEddy/locDynOneEqEddy.C b/src/turbulenceModels/incompressible/LES/locDynOneEqEddy/locDynOneEqEddy.C index 7d34bbb981..f463e3f208 100644 --- a/src/turbulenceModels/incompressible/LES/locDynOneEqEddy/locDynOneEqEddy.C +++ b/src/turbulenceModels/incompressible/LES/locDynOneEqEddy/locDynOneEqEddy.C @@ -126,12 +126,6 @@ locDynOneEqEddy::locDynOneEqEddy } -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -locDynOneEqEddy::~locDynOneEqEddy() -{} - - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // void locDynOneEqEddy::correct(const tmp& gradU) diff --git a/src/turbulenceModels/incompressible/LES/locDynOneEqEddy/locDynOneEqEddy.H b/src/turbulenceModels/incompressible/LES/locDynOneEqEddy/locDynOneEqEddy.H index 1ff8fc07dd..ef6a9edcff 100644 --- a/src/turbulenceModels/incompressible/LES/locDynOneEqEddy/locDynOneEqEddy.H +++ b/src/turbulenceModels/incompressible/LES/locDynOneEqEddy/locDynOneEqEddy.H @@ -138,7 +138,8 @@ public: //- Destructor - virtual ~locDynOneEqEddy(); + virtual ~locDynOneEqEddy() + {} // Member Functions diff --git a/src/turbulenceModels/incompressible/LES/scaleSimilarity/scaleSimilarity.C b/src/turbulenceModels/incompressible/LES/scaleSimilarity/scaleSimilarity.C index 0499ffca68..226054bf14 100644 --- a/src/turbulenceModels/incompressible/LES/scaleSimilarity/scaleSimilarity.C +++ b/src/turbulenceModels/incompressible/LES/scaleSimilarity/scaleSimilarity.C @@ -56,12 +56,6 @@ scaleSimilarity::scaleSimilarity } -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -scaleSimilarity::~scaleSimilarity() -{} - - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // tmp scaleSimilarity::k() const diff --git a/src/turbulenceModels/incompressible/LES/scaleSimilarity/scaleSimilarity.H b/src/turbulenceModels/incompressible/LES/scaleSimilarity/scaleSimilarity.H index 3f4f55535f..69d06a892c 100644 --- a/src/turbulenceModels/incompressible/LES/scaleSimilarity/scaleSimilarity.H +++ b/src/turbulenceModels/incompressible/LES/scaleSimilarity/scaleSimilarity.H @@ -90,7 +90,8 @@ public: //- Destructor - virtual ~scaleSimilarity(); + virtual ~scaleSimilarity() + {} // Member Functions diff --git a/src/turbulenceModels/incompressible/RAS/RASModel/RASModel.C b/src/turbulenceModels/incompressible/RAS/RASModel/RASModel.C index 272d0f60fe..620a3fe2af 100644 --- a/src/turbulenceModels/incompressible/RAS/RASModel/RASModel.C +++ b/src/turbulenceModels/incompressible/RAS/RASModel/RASModel.C @@ -174,14 +174,9 @@ autoPtr RASModel::New } -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -RASModel::~RASModel() -{} - - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // + scalar RASModel::yPlusLam(const scalar kappa, const scalar E) const { scalar ypl = 11.0; diff --git a/src/turbulenceModels/incompressible/RAS/RASModel/RASModel.H b/src/turbulenceModels/incompressible/RAS/RASModel/RASModel.H index c934488bb3..fdc2b2e3b7 100644 --- a/src/turbulenceModels/incompressible/RAS/RASModel/RASModel.H +++ b/src/turbulenceModels/incompressible/RAS/RASModel/RASModel.H @@ -182,7 +182,8 @@ public: //- Destructor - virtual ~RASModel(); + virtual ~RASModel() + {} // Member Functions @@ -310,9 +311,6 @@ public: ); } - //- Return yPlus for the given patch - virtual tmp yPlus(const label patchI) const; - //- Return the turbulence kinetic energy virtual tmp k() const = 0; @@ -328,6 +326,9 @@ public: //- Return the source term for the momentum equation virtual tmp divDevReff(volVectorField& U) const = 0; + //- Return yPlus for the given patch + virtual tmp yPlus(const label patchI) const; + //- Solve the turbulence equations and correct the turbulence viscosity virtual void correct() = 0; diff --git a/src/turbulenceModels/incompressible/RAS/laminar/laminar.C b/src/turbulenceModels/incompressible/RAS/laminar/laminar.C index a88b319268..6f400a1c9a 100644 --- a/src/turbulenceModels/incompressible/RAS/laminar/laminar.C +++ b/src/turbulenceModels/incompressible/RAS/laminar/laminar.C @@ -77,12 +77,6 @@ tmp laminar::nut() const } -tmp laminar::nuEff() const -{ - return tmp(new volScalarField("nuEff", nu())); -} - - tmp laminar::k() const { return tmp diff --git a/src/turbulenceModels/incompressible/RAS/laminar/laminar.H b/src/turbulenceModels/incompressible/RAS/laminar/laminar.H index b139f0fad3..8b328addf0 100644 --- a/src/turbulenceModels/incompressible/RAS/laminar/laminar.H +++ b/src/turbulenceModels/incompressible/RAS/laminar/laminar.H @@ -33,8 +33,8 @@ SourceFiles \*---------------------------------------------------------------------------*/ -#ifndef laminar_H -#define laminar_H +#ifndef rasLaminar_H +#define rasLaminar_H #include "RASModel.H" @@ -83,7 +83,10 @@ public: virtual tmp nut() const; //- Return the effective viscosity, i.e. the laminar viscosity - virtual tmp nuEff() const; + virtual tmp nuEff() const + { + return tmp(new volScalarField("nuEff", nu())); + } //- Return the turbulence kinetic energy, i.e. 0 for laminar flow virtual tmp k() const; @@ -95,7 +98,7 @@ public: //- Return the Reynolds stress tensor, i.e. 0 for laminar flow virtual tmp R() const; - //- Return the effective stress tensor including the laminar stress + //- Return the effective stress tensor, i.e. the laminar stress virtual tmp devReff() const; //- Return the source term for the momentum equation diff --git a/src/turbulenceModels/incompressible/turbulenceModel/Make/options b/src/turbulenceModels/incompressible/turbulenceModel/Make/options index 6ade117347..2af4fa4baf 100644 --- a/src/turbulenceModels/incompressible/turbulenceModel/Make/options +++ b/src/turbulenceModels/incompressible/turbulenceModel/Make/options @@ -1,5 +1,6 @@ EXE_INC = \ -I$(LIB_SRC)/finiteVolume/lnInclude \ + -I$(LIB_SRC)/turbulenceModels \ -I$(LIB_SRC)/transportModels LIB_LIBS = \ diff --git a/src/turbulenceModels/incompressible/turbulenceModel/laminar/laminar.H b/src/turbulenceModels/incompressible/turbulenceModel/laminar/laminar.H index a64884da91..51eef7c436 100644 --- a/src/turbulenceModels/incompressible/turbulenceModel/laminar/laminar.H +++ b/src/turbulenceModels/incompressible/turbulenceModel/laminar/laminar.H @@ -104,7 +104,7 @@ public: //- Return the Reynolds stress tensor, i.e. 0 for laminar flow virtual tmp R() const; - //- Return the effective stress tensor including the laminar stress + //- Return the effective stress tensor, i.e. the laminar stress virtual tmp devReff() const; //- Return the source term for the momentum equation diff --git a/src/turbulenceModels/incompressible/turbulenceModel/turbulenceModel.C b/src/turbulenceModels/incompressible/turbulenceModel/turbulenceModel.C index da4c39dcaa..cdbb61fa70 100644 --- a/src/turbulenceModels/incompressible/turbulenceModel/turbulenceModel.C +++ b/src/turbulenceModels/incompressible/turbulenceModel/turbulenceModel.C @@ -110,12 +110,6 @@ autoPtr turbulenceModel::New } -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -turbulenceModel::~turbulenceModel() -{} - - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // void turbulenceModel::correct() diff --git a/src/turbulenceModels/incompressible/turbulenceModel/turbulenceModel.H b/src/turbulenceModels/incompressible/turbulenceModel/turbulenceModel.H index 4399e85120..1474e5dfa3 100644 --- a/src/turbulenceModels/incompressible/turbulenceModel/turbulenceModel.H +++ b/src/turbulenceModels/incompressible/turbulenceModel/turbulenceModel.H @@ -139,7 +139,8 @@ public: //- Destructor - virtual ~turbulenceModel(); + virtual ~turbulenceModel() + {} // Member Functions diff --git a/tutorials/combustion/XiFoam/les/pitzDaily/constant/LESProperties b/tutorials/combustion/XiFoam/les/pitzDaily/constant/LESProperties index faa025c8e2..9beb4b8687 100644 --- a/tutorials/combustion/XiFoam/les/pitzDaily/constant/LESProperties +++ b/tutorials/combustion/XiFoam/les/pitzDaily/constant/LESProperties @@ -19,6 +19,8 @@ LESModel oneEqEddy; delta cubeRootVol; +turbulence on; + printCoeffs on; laminarCoeffs diff --git a/tutorials/combustion/XiFoam/les/pitzDaily3D/constant/LESProperties b/tutorials/combustion/XiFoam/les/pitzDaily3D/constant/LESProperties index faa025c8e2..9beb4b8687 100644 --- a/tutorials/combustion/XiFoam/les/pitzDaily3D/constant/LESProperties +++ b/tutorials/combustion/XiFoam/les/pitzDaily3D/constant/LESProperties @@ -19,6 +19,8 @@ LESModel oneEqEddy; delta cubeRootVol; +turbulence on; + printCoeffs on; laminarCoeffs diff --git a/tutorials/compressible/rhoPisoFoam/les/pitzDaily/constant/LESProperties b/tutorials/compressible/rhoPisoFoam/les/pitzDaily/constant/LESProperties index 25be4174a3..251fe1ae80 100644 --- a/tutorials/compressible/rhoPisoFoam/les/pitzDaily/constant/LESProperties +++ b/tutorials/compressible/rhoPisoFoam/les/pitzDaily/constant/LESProperties @@ -17,6 +17,8 @@ FoamFile LESModel oneEqEddy; +turbulence on; + printCoeffs on; delta cubeRootVol; diff --git a/wmake/rules/solarisGcc/mplibPVM b/wmake/rules/solarisGcc/mplibPVM deleted file mode 100644 index 9652e427d8..0000000000 --- a/wmake/rules/solarisGcc/mplibPVM +++ /dev/null @@ -1,3 +0,0 @@ -PFLAGS = -PINC = -I$(PVM_ROOT)/include -PLIBS = -L$(PVM_ROOT)/lib/$(PVM_ARCH) -lgpvm3 -lpvm3s