From adb7d5fb499857cd5431c1b813440026b2f2cdfd Mon Sep 17 00:00:00 2001 From: henry Date: Thu, 19 Jun 2008 10:42:35 +0100 Subject: [PATCH 1/2] Bug fix: http://openfoam.cfd-online.com/cgi-bin/forum/show.cgi?126/8089 --- .../Schaeffer/SchaefferFrictionalStress.C | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/applications/solvers/multiphase/twoPhaseEulerFoam/kineticTheoryModels/frictionalStressModel/Schaeffer/SchaefferFrictionalStress.C b/applications/solvers/multiphase/twoPhaseEulerFoam/kineticTheoryModels/frictionalStressModel/Schaeffer/SchaefferFrictionalStress.C index b3ddd44ff2..1e0ec17021 100644 --- a/applications/solvers/multiphase/twoPhaseEulerFoam/kineticTheoryModels/frictionalStressModel/Schaeffer/SchaefferFrictionalStress.C +++ b/applications/solvers/multiphase/twoPhaseEulerFoam/kineticTheoryModels/frictionalStressModel/Schaeffer/SchaefferFrictionalStress.C @@ -123,13 +123,13 @@ Foam::tmp Foam::SchaefferFrictionalStress::muf ) ); - volScalarField& muf_ = tmuf(); + volScalarField& muff = tmuf(); forAll (D, celli) { if (alpha[celli] > alphaMax.value()-5e-2) { - muf_[celli] = + muff[celli] = 0.5*pf[celli]*sin(phi.value()) /( sqrt(1.0/6.0*(sqr(D[celli].xx() - D[celli].yy()) @@ -141,7 +141,7 @@ Foam::tmp Foam::SchaefferFrictionalStress::muf } } - return muf_; + return tmuf; } From 4160491f683a9125796cf713a3369a20146e2a70 Mon Sep 17 00:00:00 2001 From: henry Date: Thu, 19 Jun 2008 12:44:23 +0100 Subject: [PATCH 2/2] Added better clipping and removed x-permissions. --- .../HerschelBulkley/HerschelBulkley.C | 0 .../HerschelBulkley/HerschelBulkley.H | 0 .../viscosityModels/powerLaw/powerLaw.C | 28 ++++++++++++++----- .../viscosityModels/powerLaw/powerLaw.H | 4 +-- 4 files changed, 23 insertions(+), 9 deletions(-) mode change 100755 => 100644 src/transportModels/incompressible/viscosityModels/HerschelBulkley/HerschelBulkley.C mode change 100755 => 100644 src/transportModels/incompressible/viscosityModels/HerschelBulkley/HerschelBulkley.H mode change 100755 => 100644 src/transportModels/incompressible/viscosityModels/powerLaw/powerLaw.C mode change 100755 => 100644 src/transportModels/incompressible/viscosityModels/powerLaw/powerLaw.H diff --git a/src/transportModels/incompressible/viscosityModels/HerschelBulkley/HerschelBulkley.C b/src/transportModels/incompressible/viscosityModels/HerschelBulkley/HerschelBulkley.C old mode 100755 new mode 100644 diff --git a/src/transportModels/incompressible/viscosityModels/HerschelBulkley/HerschelBulkley.H b/src/transportModels/incompressible/viscosityModels/HerschelBulkley/HerschelBulkley.H old mode 100755 new mode 100644 diff --git a/src/transportModels/incompressible/viscosityModels/powerLaw/powerLaw.C b/src/transportModels/incompressible/viscosityModels/powerLaw/powerLaw.C old mode 100755 new mode 100644 index 0155aaca31..a735465a93 --- a/src/transportModels/incompressible/viscosityModels/powerLaw/powerLaw.C +++ b/src/transportModels/incompressible/viscosityModels/powerLaw/powerLaw.C @@ -51,9 +51,23 @@ namespace viscosityModels Foam::tmp Foam::viscosityModels::powerLaw::calcNu() const { - dimensionedScalar tone("tone", dimTime, 1.0); - return (max(numin_, min(numax_, k_ - * pow(tone * strainRate(), n_.value()- scalar(1.0))))); + return max + ( + nuMin_, + min + ( + nuMax_, + k_*pow + ( + max + ( + dimensionedScalar("one", dimTime, 1.0)*strainRate(), + dimensionedScalar("VSMALL", dimless, VSMALL) + ), + n_.value() - scalar(1.0) + ) + ) + ); } @@ -71,8 +85,8 @@ Foam::viscosityModels::powerLaw::powerLaw powerLawCoeffs_(viscosityProperties.subDict(typeName + "Coeffs")), k_(powerLawCoeffs_.lookup("k")), n_(powerLawCoeffs_.lookup("n")), - numin_(powerLawCoeffs_.lookup("numin")), - numax_(powerLawCoeffs_.lookup("numax")), + nuMin_(powerLawCoeffs_.lookup("nuMin")), + nuMax_(powerLawCoeffs_.lookup("nuMax")), nu_ ( IOobject @@ -101,8 +115,8 @@ bool Foam::viscosityModels::powerLaw::read powerLawCoeffs_.lookup("k") >> k_; powerLawCoeffs_.lookup("n") >> n_; - powerLawCoeffs_.lookup("numin") >> numin_; - powerLawCoeffs_.lookup("numax") >> numax_; + powerLawCoeffs_.lookup("nuMin") >> nuMin_; + powerLawCoeffs_.lookup("nuMax") >> nuMax_; return true; } diff --git a/src/transportModels/incompressible/viscosityModels/powerLaw/powerLaw.H b/src/transportModels/incompressible/viscosityModels/powerLaw/powerLaw.H old mode 100755 new mode 100644 index 10a49fc8c4..f32fb749be --- a/src/transportModels/incompressible/viscosityModels/powerLaw/powerLaw.H +++ b/src/transportModels/incompressible/viscosityModels/powerLaw/powerLaw.H @@ -61,8 +61,8 @@ class powerLaw dimensionedScalar k_; dimensionedScalar n_; - dimensionedScalar numin_; - dimensionedScalar numax_; + dimensionedScalar nuMin_; + dimensionedScalar nuMax_; volScalarField nu_;