diff --git a/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointOutletPressure/adjointOutletPressureFvPatchScalarField.C b/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointOutletPressure/adjointOutletPressureFvPatchScalarField.C index 5614578429..0d94768b23 100644 --- a/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointOutletPressure/adjointOutletPressureFvPatchScalarField.C +++ b/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointOutletPressure/adjointOutletPressureFvPatchScalarField.C @@ -121,7 +121,7 @@ void Foam::adjointOutletPressureFvPatchScalarField::write(Ostream& os) const namespace Foam { - makePatchTypeField + makeNonTemplatedPatchTypeField ( fvPatchScalarField, adjointOutletPressureFvPatchScalarField diff --git a/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointOutletVelocity/adjointOutletVelocityFvPatchVectorField.C b/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointOutletVelocity/adjointOutletVelocityFvPatchVectorField.C index 0a00076eaf..dbde31a88a 100644 --- a/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointOutletVelocity/adjointOutletVelocityFvPatchVectorField.C +++ b/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointOutletVelocity/adjointOutletVelocityFvPatchVectorField.C @@ -96,10 +96,10 @@ void Foam::adjointOutletVelocityFvPatchVectorField::updateCoeffs() const fvPatchField& Up = patch().lookupPatchField("U"); - scalarField Un = mag(patch().nf() & Up); - vectorField UtHat = (Up - patch().nf()*Un)/(Un + SMALL); + scalarField Un(mag(patch().nf() & Up)); + vectorField UtHat((Up - patch().nf()*Un)/(Un + SMALL)); - vectorField Uan = patch().nf()*(patch().nf() & patchInternalField()); + vectorField Uan(patch().nf()*(patch().nf() & patchInternalField())); vectorField::operator=(phiap*patch().Sf()/sqr(patch().magSf()) + UtHat); //vectorField::operator=(Uan + UtHat); @@ -119,7 +119,7 @@ void Foam::adjointOutletVelocityFvPatchVectorField::write(Ostream& os) const namespace Foam { - makePatchTypeField + makeNonTemplatedPatchTypeField ( fvPatchVectorField, adjointOutletVelocityFvPatchVectorField diff --git a/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointShapeOptimizationFoam.C b/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointShapeOptimizationFoam.C index a18298f826..de7a9276ae 100644 --- a/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointShapeOptimizationFoam.C +++ b/applications/solvers/incompressible/adjointShapeOptimizationFoam/adjointShapeOptimizationFoam.C @@ -114,7 +114,7 @@ int main(int argc, char *argv[]) solve(UEqn() == -fvc::grad(p)); p.boundaryField().updateCoeffs(); - volScalarField rAU = 1.0/UEqn().A(); + volScalarField rAU(1.0/UEqn().A()); U = rAU*UEqn().H(); UEqn.clear(); phi = fvc::interpolate(U) & mesh.Sf(); @@ -153,10 +153,13 @@ int main(int argc, char *argv[]) { // Adjoint Momentum predictor - volVectorField adjointTransposeConvection = (fvc::grad(Ua) & U); - //volVectorField adjointTransposeConvection = fvc::reconstruct + volVectorField adjointTransposeConvection((fvc::grad(Ua) & U)); + //volVectorField adjointTransposeConvection //( - // mesh.magSf()*(fvc::snGrad(Ua) & fvc::interpolate(U)) + // fvc::reconstruct + // ( + // mesh.magSf()*(fvc::snGrad(Ua) & fvc::interpolate(U)) + // ) //); zeroCells(adjointTransposeConvection, inletCells); @@ -174,7 +177,7 @@ int main(int argc, char *argv[]) solve(UaEqn() == -fvc::grad(pa)); pa.boundaryField().updateCoeffs(); - volScalarField rAUa = 1.0/UaEqn().A(); + volScalarField rAUa(1.0/UaEqn().A()); Ua = rAUa*UaEqn().H(); UaEqn.clear(); phia = fvc::interpolate(Ua) & mesh.Sf(); diff --git a/applications/solvers/incompressible/boundaryFoam/boundaryFoam.C b/applications/solvers/incompressible/boundaryFoam/boundaryFoam.C index af2798cc32..4bfdd66f46 100644 --- a/applications/solvers/incompressible/boundaryFoam/boundaryFoam.C +++ b/applications/solvers/incompressible/boundaryFoam/boundaryFoam.C @@ -60,7 +60,7 @@ int main(int argc, char *argv[]) { Info<< "Time = " << runTime.timeName() << nl << endl; - fvVectorMatrix divR = turbulence->divDevReff(U); + fvVectorMatrix divR(turbulence->divDevReff(U)); divR.source() = flowMask & divR.source(); fvVectorMatrix UEqn diff --git a/applications/solvers/incompressible/boundaryFoam/interrogateWallPatches.H b/applications/solvers/incompressible/boundaryFoam/interrogateWallPatches.H index 6fa3a0892c..7fd01f0e9e 100644 --- a/applications/solvers/incompressible/boundaryFoam/interrogateWallPatches.H +++ b/applications/solvers/incompressible/boundaryFoam/interrogateWallPatches.H @@ -13,7 +13,7 @@ forAll(patches, patchi) if (isA(currPatch)) { - const vectorField nf = currPatch.nf(); + const vectorField nf(currPatch.nf()); forAll(nf, facei) { @@ -67,8 +67,10 @@ else label cellId = patches[patchId].faceCells()[faceId]; // create position array for graph generation -scalarField y = +scalarField y +( wallNormal - & (mesh.C().internalField() - mesh.C().boundaryField()[patchId][faceId]); + & (mesh.C().internalField() - mesh.C().boundaryField()[patchId][faceId]) +); Info<< " Height to first cell centre y0 = " << y[cellId] << endl; diff --git a/applications/solvers/incompressible/channelFoam/channelFoam.C b/applications/solvers/incompressible/channelFoam/channelFoam.C index 8918a4d8eb..6f19b96168 100644 --- a/applications/solvers/incompressible/channelFoam/channelFoam.C +++ b/applications/solvers/incompressible/channelFoam/channelFoam.C @@ -77,7 +77,7 @@ int main(int argc, char *argv[]) // --- PISO loop - volScalarField rAU = 1.0/UEqn.A(); + volScalarField rAU(1.0/UEqn.A()); for (int corr=0; corr UEqn UEqn().relax(); -volScalarField rAU = 1.0/UEqn().A(); +volScalarField rAU(1.0/UEqn().A()); if (momentumPredictor) { diff --git a/applications/solvers/incompressible/pisoFoam/pisoFoam.C b/applications/solvers/incompressible/pisoFoam/pisoFoam.C index 47414bf173..59c76c9e93 100644 --- a/applications/solvers/incompressible/pisoFoam/pisoFoam.C +++ b/applications/solvers/incompressible/pisoFoam/pisoFoam.C @@ -79,7 +79,7 @@ int main(int argc, char *argv[]) for (int corr=0; corr